depot_tools

You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

History

Stephen Martinis ea50265aef Revert "Reland "bot_update: Patch on gclient by default."" This reverts commit `8f20428bf4`. Reason for revert: Probably broke bot update on catapult bots: https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/11225 Original change's description: > Reland "bot_update: Patch on gclient by default." > > This is a reland of `e38cf570fc` > > The issue with win CQ bots was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1036309 > It was due to misconfigured git user.{name,email} > > Original change's description: > > bot_update: Patch on gclient by default. > > > > See [4] for the design doc for this change. > > > > We're moving the patching logic from bot_update to gclient. > > This way we can test patches of dependencies that modify their DEPS > > files as well, for example when ANGLE uploads a patch that modifies > > DEPS files to be tested by a Chromium trybot. > > > > Chromium Linux CQ and Angle trybots are already running this way > > (see [1] and [2]) and a PSA has already been sent [3] > > > > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214 > > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105 > > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I > > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165# > > > > Bug: 643346 > > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3 > > Recipe-Nontrivial-Roll: skia > > Recipe-Nontrivial-Roll: infra > > Recipe-Nontrivial-Roll: build_limited_scripts_slave > > Recipe-Nontrivial-Roll: skiabuildbot > > Recipe-Nontrivial-Roll: build > > Recipe-Nontrivial-Roll: release_scripts > > Reviewed-on: https://chromium-review.googlesource.com/1014356 > > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> > > Reviewed-by: Aaron Gable <agable@chromium.org> > > Bug: 643346 > Change-Id: I4f4edd8e815cb12a4cbc3ab690eaf588bc2accc1 > Reviewed-on: https://chromium-review.googlesource.com/1039966 > Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org> TBR=agable@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org Change-Id: Ia8a5779cde3c31812121cffdd806476d4536f35e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 643346 Reviewed-on: https://chromium-review.googlesource.com/1043167 Reviewed-by: Stephen Martinis <martiniss@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org>	8 years ago
..
full.expected	Revert "Reland "bot_update: Patch on gclient by default.""	8 years ago
full.py	Revert "Reland "bot_update: Patch on gclient by default.""	8 years ago

Stephen Martinis ea50265aef Revert "Reland "bot_update: Patch on gclient by default.""

This reverts commit 8f20428bf4.

Reason for revert: Probably broke bot update on catapult bots: https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/11225

Original change's description:
> Reland "bot_update: Patch on gclient by default."
> 
> This is a reland of e38cf570fc
> 
> The issue with win CQ bots was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1036309
> It was due to misconfigured git user.{name,email}
> 
> Original change's description:
> > bot_update: Patch on gclient by default.
> >
> > See [4] for the design doc for this change.
> >
> > We're moving the patching logic from bot_update to gclient.
> > This way we can test patches of dependencies that modify their DEPS
> > files as well, for example when ANGLE uploads a patch that modifies
> > DEPS files to be tested by a Chromium trybot.
> >
> > Chromium Linux CQ and Angle trybots are already running this way
> > (see [1] and [2]) and a PSA has already been sent [3]
> >
> > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214
> > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105
> > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I
> > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165#
> >
> > Bug: 643346
> > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3
> > Recipe-Nontrivial-Roll: skia
> > Recipe-Nontrivial-Roll: infra
> > Recipe-Nontrivial-Roll: build_limited_scripts_slave
> > Recipe-Nontrivial-Roll: skiabuildbot
> > Recipe-Nontrivial-Roll: build
> > Recipe-Nontrivial-Roll: release_scripts
> > Reviewed-on: https://chromium-review.googlesource.com/1014356
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Aaron Gable <agable@chromium.org>
> 
> Bug: 643346
> Change-Id: I4f4edd8e815cb12a4cbc3ab690eaf588bc2accc1
> Reviewed-on: https://chromium-review.googlesource.com/1039966
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=agable@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: Ia8a5779cde3c31812121cffdd806476d4536f35e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 643346
Reviewed-on: https://chromium-review.googlesource.com/1043167
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

full.expected Revert "Reland "bot_update: Patch on gclient by default."" 8 years ago

full.py Revert "Reland "bot_update: Patch on gclient by default."" 8 years ago