aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'ea50265aef'
${ noResults }
depot_tools/recipes/recipe_modules/bot_update/examples/full.expected
History
Stephen Martinis ea50265aef Revert "Reland "bot_update: Patch on gclient by default."" 
This reverts commit 8f20428bf4.

Reason for revert: Probably broke bot update on catapult bots: https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Linux%20Tryserver/builds/11225

Original change's description:
> Reland "bot_update: Patch on gclient by default."
> 
> This is a reland of e38cf570fc
> 
> The issue with win CQ bots was fixed in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1036309
> It was due to misconfigured git user.{name,email}
> 
> Original change's description:
> > bot_update: Patch on gclient by default.
> >
> > See [4] for the design doc for this change.
> >
> > We're moving the patching logic from bot_update to gclient.
> > This way we can test patches of dependencies that modify their DEPS
> > files as well, for example when ANGLE uploads a patch that modifies
> > DEPS files to be tested by a Chromium trybot.
> >
> > Chromium Linux CQ and Angle trybots are already running this way
> > (see [1] and [2]) and a PSA has already been sent [3]
> >
> > [1] https://chromium.googlesource.com/chromium/src/+/master/infra/config/global/cr-buildbucket.cfg#214
> > [2] https://chromium.googlesource.com/angle/angle/+/infra/config/cr-buildbucket.cfg#105
> > [3] https://groups.google.com/a/google.com/forum/#!topic/chrome-infra/FVHN2kdUX4I
> > [4] https://docs.google.com/document/d/1GSTw4ysm5AYjNR6vMA7NJUxLK2VN9IpOEp_v0u-wyOE/edit?ts=5ad78165#
> >
> > Bug: 643346
> > Change-Id: Ic9a9dcfae86aca730d35fbb26c26b21135e05bf3
> > Recipe-Nontrivial-Roll: skia
> > Recipe-Nontrivial-Roll: infra
> > Recipe-Nontrivial-Roll: build_limited_scripts_slave
> > Recipe-Nontrivial-Roll: skiabuildbot
> > Recipe-Nontrivial-Roll: build
> > Recipe-Nontrivial-Roll: release_scripts
> > Reviewed-on: https://chromium-review.googlesource.com/1014356
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Reviewed-by: Aaron Gable <agable@chromium.org>
> 
> Bug: 643346
> Change-Id: I4f4edd8e815cb12a4cbc3ab690eaf588bc2accc1
> Reviewed-on: https://chromium-review.googlesource.com/1039966
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=agable@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: Ia8a5779cde3c31812121cffdd806476d4536f35e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 643346
Reviewed-on: https://chromium-review.googlesource.com/1043167
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
 		8 years ago
..
apply_gerrit_ref.json [bot_update] Prefix PATH, cleanup. 8 years ago
apply_gerrit_ref_custom.json bot_update recipe: parameterize step name in apply_gerrit_ref 8 years ago
apply_patch_on_gclient.json Revert "Reland "bot_update: Patch on gclient by default."" 8 years ago
basic.json Revert "bot_update: Patch on gclient by default." 8 years ago
basic_luci.json Revert "bot_update: Patch on gclient by default." 8 years ago
basic_with_branch_heads.json Revert "bot_update: Patch on gclient by default." 8 years ago
buildbot.json Revert "bot_update: Patch on gclient by default." 8 years ago
clobber.json Revert "bot_update: Patch on gclient by default." 8 years ago
deprecated_got_revision_mapping.json Revert "bot_update: Patch on gclient by default." 8 years ago
gerrit_no_rebase_patch_ref.json Revert "bot_update: Patch on gclient by default." 8 years ago
gerrit_no_reset.json Revert "bot_update: Patch on gclient by default." 8 years ago
no_shallow.json Revert "bot_update: Patch on gclient by default." 8 years ago
reset_root_solution_revision.json Revert "bot_update: Patch on gclient by default." 8 years ago
trychange.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_empty_revision.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_fail.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_fail_patch.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_fail_patch_download.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_gerrit_angle.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_gerrit_angle_deprecated.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_gerrit_feature_branch.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_gerrit_v8.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_gerrit_v8_feature_branch.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_gerrit_webrtc.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_v8.json Revert "bot_update: Patch on gclient by default." 8 years ago
tryjob_v8_head_by_default.json Revert "bot_update: Patch on gclient by default." 8 years ago
with_manifest_name.json Revert "bot_update: Patch on gclient by default." 8 years ago
with_manifest_name_no_patch.json Revert "bot_update: Patch on gclient by default." 8 years ago
with_tags.json Revert "bot_update: Patch on gclient by default." 8 years ago