You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Bruce Dawson e65444f91d Fix Python3 bugs in package_from_installed.py
The package_from_installed.py script didn't run under Python 3. This
change fixes that and this script now _requires_ Python 3. Requiring
Python 3 was simpler than supporting both, and there is no need to
maintain Python 2.7 support. This script is only ever invoked manually
and all machines it is run on should have Python 3.

Changes included using universal_newlines=True so that
subprocess.check_output returns a string instead of bytes, and
by explicitly converting dict.items() to a list.

Similarly, open(name, 'wb') was changed to open(name,'wt', newline='')
to avoid byte/str problems while still avoiding CR/LF translations.

This also changes the default Windows 10 SDK version to something more
recent - the current version that we build with.

To test:

  python3 package_from_installed.py -d 2019

The use of '-d' makes the script run in test mode which is much faster.

Change-Id: I2e3fc4d464f2914ba5ae36f0a78570ea7e5d4f03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2224506
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
5 years ago
bootstrap [cipd] Take cipd.ps1 out of %PATH%. 5 years ago
fetch_configs Add fetch configs for devtools-frontend 6 years ago
git-templates Explicitly exec hooks inside a shell. 12 years ago
infra Roll recipe dependencies (trivial). 5 years ago
man [man] Followup: Fix order of depot_tools in PATH in html docs 5 years ago
python-bin depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
recipes Roll recipe dependencies (trivial). 5 years ago
testing_support Run spellchecker on depot_tools 5 years ago
tests Reland "Use OS level locking in git_cache.py" 5 years ago
third_party Revert "Improve git cl split" 5 years ago
win_toolchain Fix Python3 bugs in package_from_installed.py 5 years ago
zsh-goodies Remove unmaintained "gclient export" command, 14 years ago
.cipd_impl.ps1 [cipd] Take cipd.ps1 out of %PATH%. 5 years ago
.gitattributes git-cl: Run using vpython 6 years ago
.gitignore depot_tools: Don't add a python3 shim to depot_tools on bootstrap. 6 years ago
.style.yapf Update "git cl format --python" to default to PEP-8 5 years ago
.vpython depot_tools: Use mock from vpython (or unittest.mock) instead of third_party/mock 5 years ago
.vpython3 Reland "gerrit_util: Refactor ReadHttpResponse and add more tests." 6 years ago
CROS_OWNERS CROS_OWNERS: update 6 years ago
GOMA_OWNERS Add tikuta, <user>@chromium.org to GOMA_OWNERS 5 years ago
LICENSE Create the Next Generation of depot_tools. Eh. 16 years ago
LUCI_OWNERS Make vadimsh@ an owner of cipd*. 5 years ago
OWNERS Add sokcevic@google.com to owners 5 years ago
PRESUBMIT.py Fix Windows unit tests for roll-dep and use py3 5 years ago
README.gclient.md docs: Removing references to SVN 9 years ago
README.git-cl.md README.git-cl.md: Remove reference to Rietveld 6 years ago
README.md add clarification for Python 3 5 years ago
WATCHLISTS WATCHLISTS: CC chops-source-team@ on all depot_tools changes. 5 years ago
auth.py auth: Fix has_luci_context_local_auth. 6 years ago
autoninja Fix a python invocation that wasn't replaced with vpython. 5 years ago
autoninja.bat Run autoninja scripts using vpython. 5 years ago
autoninja.py Run spellchecker on depot_tools 5 years ago
bb do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
bb.bat [bb] Deploy bb 6 years ago
bootstrap_python3 Add quotes around paths in bash scripts. 5 years ago
breakpad.py Finally get rid of depot_tools' breakpad. 9 years ago
cbuildbot simplify the chromite wrappers 6 years ago
chrome_set_ver simplify the chromite wrappers 6 years ago
cipd do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
cipd.bat [cipd] Take cipd.ps1 out of %PATH%. 5 years ago
cipd_bin_setup.bat Revert "put goma client in depot_tools" 6 years ago
cipd_bin_setup.sh Revert "put goma client in depot_tools" 6 years ago
cipd_client_version [cipd] Update client v2.3.4 => v2.3.5. 5 years ago
cipd_client_version.digests [cipd] Update client v2.3.4 => v2.3.5. 5 years ago
cipd_manifest.txt [lucicfg] Update to 1.14.5. 5 years ago
cipd_manifest.versions [lucicfg] Update to 1.14.5. 5 years ago
cit Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
cit.bat Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
cit.py Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
clang-format Depot tools: use the clang-format binaries that are now included 11 years ago
clang-format.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format.py Convert print statements to Python 3 style 6 years ago
clang_format_merge_driver Introduce git merge driver for the blink reformatting 9 years ago
clang_format_merge_driver.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
clang_format_merge_driver.py Convert except statements to be Python 3 compatible 6 years ago
codereview.settings Make depot_tools upload reviews to Gerrit by default 9 years ago
compile_single_file Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.bat Add a script to make it easier to build a single source file with ninja 8 years ago
compile_single_file.py Make it clear that compile_single_file.py doesn't support Jumbo builds 6 years ago
cpplint.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
cpplint.py Allow a space after __except 5 years ago
cpplint_chromium.py Add lint check against "Foo *bar" and "Foo &bar" declarations. 14 years ago
cros Reland "cros: switch CrOS programs to python3" 5 years ago
cros_sdk simplify the chromite wrappers 6 years ago
crosjobs Add crosjobs shim script 6 years ago
detect_host_arch.py depot_tools: Add tests for detect_host_arch. 5 years ago
download_from_google_storage Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
download_from_google_storage.bat Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
download_from_google_storage.py Print the SHA of files downloaded from GS 5 years ago
ensure_bootstrap Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
fetch Make Python 3 default on Windows 5 years ago
fetch.bat Abort fetch, gclient, gsutil.py when update_depot_tools fails on Windows 5 years ago
fetch.py Make fetch compatible with py 3.5 5 years ago
fix_encoding.py Run spellchecker on depot_tools 5 years ago
gclient Make Python 3 default on Windows 5 years ago
gclient-new-workdir.py Revert "depot_tools: Run Python scripts using vpython (Part 2)" 6 years ago
gclient.bat Abort fetch, gclient, gsutil.py when update_depot_tools fails on Windows 5 years ago
gclient.py Remove agable from depot_tools OWNERS and TODOs 5 years ago
gclient_completion.sh Added basic completion (the commands) for gclient. 11 years ago
gclient_eval.py Run spellchecker on depot_tools 5 years ago
gclient_paths.py depot_tools: Add tests for gclient_paths 5 years ago
gclient_scm.py Remove rev-parse --verify FETCH_HEAD 5 years ago
gclient_utils.py Remove agable from depot_tools OWNERS and TODOs 5 years ago
gerrit_client.py Add gerrit_client unit tests 5 years ago
gerrit_util.py ReadHttpResponse: Handle 429s with retries and adjust retry count 5 years ago
git-cache Add quotes around paths in bash scripts 5 years ago
git-cl Add quotes around paths in bash scripts. 5 years ago
git-crrev-parse Fix git-crrev-parse on Mac. 8 years ago
git-drover Add quotes around paths in bash scripts 5 years ago
git-find-releases Add quotes around paths in bash scripts 5 years ago
git-footers Add quotes around paths in bash scripts 5 years ago
git-freeze Add quotes around paths in bash scripts 5 years ago
git-gs Add *.proto to git-gs 8 years ago
git-hyper-blame Add quotes around paths in bash scripts 5 years ago
git-map Add quotes around paths in bash scripts 5 years ago
git-map-branches Add quotes around paths in bash scripts 5 years ago
git-mark-merge-base Add quotes around paths in bash scripts 5 years ago
git-nav-downstream Add quotes around paths in bash scripts 5 years ago
git-nav-upstream Make git-nav-upstream use the upstream branch name 6 years ago
git-new-branch Add quotes around paths in bash scripts 5 years ago
git-number Add quotes around paths in bash scripts 5 years ago
git-rebase-update Add quotes around paths in bash scripts 5 years ago
git-rename-branch Add quotes around paths in bash scripts 5 years ago
git-reparent-branch Add quotes around paths in bash scripts 5 years ago
git-retry Add quotes around paths in bash scripts 5 years ago
git-runhooks Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git-squash-branch Add quotes around paths in bash scripts 5 years ago
git-thaw Add quotes around paths in bash scripts 5 years ago
git-upstream-diff Add quotes around paths in bash scripts 5 years ago
git_cache.py git-cache: delete support for internal repos. 5 years ago
git_cl.py Remove agable from depot_tools OWNERS and TODOs 5 years ago
git_cl_completion.sh Add git completion helper to cl upload 5 years ago
git_common.py Fix gclient-new-workdir when source repo is shallow clone 5 years ago
git_dates.py Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git_drover.py git-drover: Don't attempt to decode output of check_call. 5 years ago
git_find_releases.py Add unit tests for git_find_releases 5 years ago
git_footers.py Run spellchecker on depot_tools 5 years ago
git_freezer.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_hyper_blame.py Add support for git_hyper_blame for Windows 5 years ago
git_map.py git-map: Refactor and add simple tests 5 years ago
git_map_branches.py git cl: use short URLs in `git cl status`. 5 years ago
git_mark_merge_base.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_nav_downstream.py depot_tools: Use gclient_utils.AskForData instead of raw_input. 5 years ago
git_new_branch.py git-cl: Fix invocation of git new-branch 5 years ago
git_number.py Run spellchecker on depot_tools 5 years ago
git_rebase_update.py Revert "Fix printing error on git-rebase failure" 5 years ago
git_rename_branch.py git-rebase-update: Make tests run on Python 3. 6 years ago
git_reparent_branch.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_retry.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_squash_branch.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
git_upstream_diff.py Revert "depot_tools: Run Python scripts using vpython (Part 1)" 6 years ago
gn Add executable and line ending properties for GN. 12 years ago
gn.bat [.bat] Remove "depot_tools" override. (#2) 8 years ago
gn.py Convert print statements to Python 3 style 6 years ago
goma_auth Reland "put goma client in depot_tools" 6 years ago
goma_auth.bat Fix goma_auth.bat to use nul instead of null. 5 years ago
goma_ctl [goma_ctl] Use vpython to call goma_ctl.py. 5 years ago
goma_ctl.bat Fixed goma_ctl.bat to pipe to nul instead of creating a file called null. 5 years ago
gsutil.py depot_tools: Make gsutil compatible with python3. 5 years ago
gsutil.py.bat gsutil.py.bat: Skip updating depot_tools if DEPOT_TOOLS_UPDATE=0. 5 years ago
gsutil.vpython gsutil.vpython: Set vpython_version: 2.7 5 years ago
led do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
led.bat [bootstraps] Sync at gclient, suppress output (#2) 8 years ago
lockfile.py Reland "Use OS level locking in git_cache.py" 5 years ago
luci-auth do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
luci-auth.bat [luci-auth] Add statically-linked luci-auth CLI tool. 7 years ago
lucicfg do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
lucicfg.bat [cipd] Add lucicfg tool. 6 years ago
mac_toolchain do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
metrics.README.md metrics: Update documentation 5 years ago
metrics.py Reland "metrics: Use vpython3 instead of sys.executable" 5 years ago
metrics_utils.py depot_tools: Make some changes to make metrics collection compatible with Python 3. 6 years ago
my_activity.py Document the parameter {heading} avilable to --output-format-heading. 5 years ago
ninja properly detect msys_nt as windows in the ninja script 5 years ago
ninja-linux32 Update ninja to v1.8.2 8 years ago
ninja-linux64 Update ninja to v1.8.2 8 years ago
ninja-mac Update ninja to v1.8.2 8 years ago
ninja.exe Update ninja to v1.8.2 8 years ago
ninjalog.README.md [ninjalog] add ninjalog.README.md 6 years ago
ninjalog_uploader.py Run autoninja scripts using vpython. 5 years ago
ninjalog_uploader_wrapper.py Run autoninja scripts using vpython. 5 years ago
owners.py Fix slash direction sensitivity in git cl owners 5 years ago
owners_finder.py Print clarifying message when no new owners needed 5 years ago
post_build_ninja_summary.py More detailed build-step type summary for android 5 years ago
presubmit_canned_checks.py Remove agable from depot_tools OWNERS and TODOs 5 years ago
presubmit_support.py Remove agable from depot_tools OWNERS and TODOs 5 years ago
profile.xml Create the Next Generation of depot_tools. Eh. 16 years ago
prpc do not hardcode the path to bash by using the #!/usr/bin/env bash shebang 6 years ago
prpc.bat [prpc] Add pRPC CLI tool to depot_tools. 7 years ago
pylint pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint-1.5 pylint: make pylint-quotes available 5 years ago
pylint-1.6 pylint: make pylint-quotes available 5 years ago
pylint-1.7 pylint: make pylint-quotes available 5 years ago
pylint-1.8 pylint: make pylint-quotes available 5 years ago
pylint-1.9 pylint: make pylint-quotes available 5 years ago
pylint.bat pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylint_main.py pylint: rework wrapper to use vpython for multiple versions 6 years ago
pylintrc pylint: make pylint-quotes available 5 years ago
python_runner.sh Make Python 3 default on Windows 5 years ago
rdb [resultdb] Add rdb and rdb.bat 5 years ago
rdb.bat [resultdb] Add rdb and rdb.bat 5 years ago
repo repo: update to 2.8 launcher 5 years ago
roll-dep Make Python 3 default on Windows 5 years ago
roll-dep.bat Make Python 3 default on Windows 5 years ago
roll_dep.py Fix Python3 integer division issue in roll-dep. 5 years ago
scm.py Run spellchecker on depot_tools 5 years ago
setup_color.py setup_color: Don't output an error if GetConsoleMode fails 6 years ago
split_cl.py git-cl: Fix git-cl split. 5 years ago
subcommand.py Run spellchecker on depot_tools 5 years ago
subprocess2.py Remove rev-parse --verify FETCH_HEAD 5 years ago
update_depot_tools Add quotes around paths in bash scripts 5 years ago
update_depot_tools.bat Fix command prompt title after update_depot_tools 5 years ago
update_depot_tools_toggle.py [auto_update] Add control script, allow disable. 8 years ago
upload_metrics.py Revert "Reland "depot_tools: Move six to depot_tools' .vpython"" 6 years ago
upload_to_google_storage.py gsutil: Decode output from subprocess. 6 years ago
vpython depot_tools: Use system's python for vpython. 5 years ago
vpython.bat Reland "vpython: Specify interpreter to run." 5 years ago
vpython3 depot_tools: Simplify MinGW check. 5 years ago
vpython3.bat Fix git-* commands when using python3 on Win 5 years ago
watchlists.py depot_tools: Run watchlists tests on Python 3 6 years ago
weekly Convert print statements to Python 3 style 6 years ago
win32imports.py Reland "Use OS level locking in git_cache.py" 5 years ago
wtf Convert print statements to Python 3 style 6 years ago
yapf update yapf to 0.27.0 5 years ago
yapf.bat Fix git cl format --python on windows 7 years ago

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.