Abort fetch, gclient, gsutil.py when update_depot_tools fails on Windows

We should fail when we fail to update depot_tools instead of continuing
the execution silently. Otherwise, developers might get stuck on a bad
depot_tools revision without knowing.

Change-Id: I0431a24a28a77aca8c66352939a0252c458b3e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208616
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
changes/16/2208616/6
Edward Lesmes 5 years ago committed by LUCI CQ
parent 5a7be3da21
commit 002f97b35a

@ -6,6 +6,10 @@ setlocal
:: Synchronize the root directory before deferring control back to gclient.py.
call "%~dp0\update_depot_tools.bat"
:: Abort the script if we failed to update depot_tools.
IF %errorlevel% NEQ 0 (
goto :EOF
)
:: Ensure that "depot_tools" is somewhere in PATH so this tool can be used
:: standalone, but allow other PATH manipulations to take priority.

@ -9,6 +9,10 @@ IF "%DEPOT_TOOLS_UPDATE%" == "0" GOTO :CALL_GCLIENT
:: Synchronize the root directory before deferring control back to gclient.py.
call "%~dp0update_depot_tools.bat" %*
:: Abort the script if we failed to update depot_tools.
IF %errorlevel% NEQ 0 (
goto :EOF
)
:CALL_GCLIENT
:: Ensure that "depot_tools" is somewhere in PATH so this tool can be used

@ -6,6 +6,10 @@ setlocal
:: Synchronize the root directory before deferring control back to gsutil.py.
call "%~dp0update_depot_tools.bat" %*
:: Abort the script if we failed to update depot_tools.
IF %errorlevel% NEQ 0 (
goto :EOF
)
:: Ensure that "depot_tools" is somewhere in PATH so this tool can be used
:: standalone, but allow other PATH manipulations to take priority.

Loading…
Cancel
Save