One of the mistakes one can make when running ninja is having goma enabled (use_goma=true in args.gn) but not having goma running. This can lead to ~1,000 failed compile steps, which is messy. This change teaches autoninja.py to check whether goma is running. If not then it tells autoninja to just print a warning message. The check costs roughly 30 ms which seems reasonable. In fact, because this change also switches away from vpython (necessary to use python3 to use subprocess.run) it actually runs about 600 ms _faster_ than before this change. If build acceleration is requested through use_rbe then no checking for whether the service is running is done. That could be added in the future. autoninja.py could auto-start goma but that is error prone and has limited additional value. This was tested on Linux, OSX, and Windows. Bug: 868590, b/174673874 Change-Id: Ie773e574878471e5136b9b82d52f86af3d848318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2627014 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com> |
4 years ago | |
---|---|---|
bootstrap | 5 years ago | |
fetch_configs | 6 years ago | |
git-templates | ||
infra | 4 years ago | |
man | 4 years ago | |
python-bin | 6 years ago | |
python2-bin | 5 years ago | |
recipes | 4 years ago | |
testing_support | 5 years ago | |
tests | 4 years ago | |
third_party | 5 years ago | |
win_toolchain | 5 years ago | |
zsh-goodies | ||
.cipd_impl.ps1 | 5 years ago | |
.gitattributes | 5 years ago | |
.gitignore | 6 years ago | |
.style.yapf | 5 years ago | |
.vpython | 5 years ago | |
.vpython3 | 5 years ago | |
CROS_OWNERS | 5 years ago | |
DIR_METADATA | 4 years ago | |
GOMA_OWNERS | 5 years ago | |
LICENSE | ||
LUCI_OWNERS | 5 years ago | |
OWNERS | 4 years ago | |
PRESUBMIT.py | 5 years ago | |
README.gclient.md | ||
README.git-cl.md | 5 years ago | |
README.md | 5 years ago | |
WATCHLISTS | 5 years ago | |
auth.py | 6 years ago | |
autoninja | 4 years ago | |
autoninja.bat | 4 years ago | |
autoninja.py | 4 years ago | |
bb | ||
bb.bat | ||
bootstrap_python3 | 5 years ago | |
breakpad.py | ||
cbuildbot | 6 years ago | |
chrome_set_ver | 6 years ago | |
cipd | 5 years ago | |
cipd.bat | 5 years ago | |
cipd_bin_setup.bat | 6 years ago | |
cipd_bin_setup.sh | 6 years ago | |
cipd_client_version | 4 years ago | |
cipd_client_version.digests | 4 years ago | |
cipd_manifest.txt | 4 years ago | |
cipd_manifest.versions | 4 years ago | |
cit | ||
cit.bat | ||
cit.py | 4 years ago | |
clang-format | ||
clang-format.bat | ||
clang_format.py | ||
clang_format_merge_driver | ||
clang_format_merge_driver.bat | ||
clang_format_merge_driver.py | ||
codereview.settings | 4 years ago | |
compile_single_file | ||
compile_single_file.bat | ||
compile_single_file.py | 5 years ago | |
cpplint.bat | ||
cpplint.py | 5 years ago | |
cpplint_chromium.py | ||
cros | 5 years ago | |
cros_sdk | 6 years ago | |
crosjobs | ||
detect_host_arch.py | 6 years ago | |
dirmd | 5 years ago | |
dirmd.bat | 5 years ago | |
download_from_google_storage | ||
download_from_google_storage.bat | ||
download_from_google_storage.py | 5 years ago | |
ensure_bootstrap | ||
fetch | 5 years ago | |
fetch.bat | 5 years ago | |
fetch.py | 5 years ago | |
fix_encoding.py | 5 years ago | |
gclient | 5 years ago | |
gclient-new-workdir.py | ||
gclient.bat | 5 years ago | |
gclient.py | 4 years ago | |
gclient_completion.sh | ||
gclient_eval.py | 5 years ago | |
gclient_paths.py | 5 years ago | |
gclient_scm.py | 5 years ago | |
gclient_utils.py | 5 years ago | |
gerrit_client.py | 5 years ago | |
gerrit_util.py | 4 years ago | |
git-cache | 5 years ago | |
git-cl | 5 years ago | |
git-crrev-parse | ||
git-drover | 5 years ago | |
git-find-releases | 5 years ago | |
git-footers | 5 years ago | |
git-freeze | 5 years ago | |
git-gs | ||
git-hyper-blame | 5 years ago | |
git-map | 5 years ago | |
git-map-branches | 5 years ago | |
git-mark-merge-base | 5 years ago | |
git-migrate-default-branch | 5 years ago | |
git-nav-downstream | 5 years ago | |
git-nav-upstream | ||
git-new-branch | 5 years ago | |
git-number | 5 years ago | |
git-rebase-update | 5 years ago | |
git-rename-branch | 5 years ago | |
git-reparent-branch | 5 years ago | |
git-retry | 5 years ago | |
git-runhooks | ||
git-squash-branch | 5 years ago | |
git-thaw | 5 years ago | |
git-upstream-diff | 5 years ago | |
git_cache.py | 4 years ago | |
git_cl.py | 4 years ago | |
git_cl_completion.sh | 5 years ago | |
git_common.py | 4 years ago | |
git_dates.py | ||
git_drover.py | 5 years ago | |
git_find_releases.py | 5 years ago | |
git_footers.py | 5 years ago | |
git_freezer.py | ||
git_hyper_blame.py | 5 years ago | |
git_map.py | 5 years ago | |
git_map_branches.py | 5 years ago | |
git_mark_merge_base.py | ||
git_migrate_default_branch.py | 5 years ago | |
git_nav_downstream.py | 5 years ago | |
git_new_branch.py | 5 years ago | |
git_number.py | 5 years ago | |
git_rebase_update.py | 5 years ago | |
git_rename_branch.py | 6 years ago | |
git_reparent_branch.py | ||
git_retry.py | 5 years ago | |
git_squash_branch.py | ||
git_upstream_diff.py | ||
gn | ||
gn.bat | ||
gn.py | ||
goma_auth | 6 years ago | |
goma_auth.bat | 5 years ago | |
goma_ctl | 6 years ago | |
goma_ctl.bat | 5 years ago | |
gsutil.py | 6 years ago | |
gsutil.py.bat | 5 years ago | |
gsutil.vpython | 5 years ago | |
led | ||
led.bat | ||
lockfile.py | 5 years ago | |
luci-auth | ||
luci-auth.bat | ||
lucicfg | ||
lucicfg.bat | ||
mac_toolchain | ||
metrics.README.md | 5 years ago | |
metrics.py | 5 years ago | |
metrics_utils.py | ||
my_activity.py | 5 years ago | |
ninja | 6 years ago | |
ninja-linux32 | ||
ninja-linux64 | ||
ninja-mac | 5 years ago | |
ninja.exe | ||
ninjalog.README.md | ||
ninjalog_uploader.py | 4 years ago | |
ninjalog_uploader_wrapper.py | 4 years ago | |
owners.py | 4 years ago | |
owners_client.py | 4 years ago | |
owners_finder.py | 5 years ago | |
post_build_ninja_summary.py | 5 years ago | |
presubmit_canned_checks.py | 4 years ago | |
presubmit_support.py | 4 years ago | |
profile.xml | ||
prpc | ||
prpc.bat | ||
pylint | ||
pylint-1.5 | 6 years ago | |
pylint-1.6 | 6 years ago | |
pylint-1.7 | 6 years ago | |
pylint-1.8 | 6 years ago | |
pylint-1.9 | 6 years ago | |
pylint-2.6 | 5 years ago | |
pylint.bat | ||
pylint_main.py | ||
pylintrc | 5 years ago | |
python_runner.sh | 5 years ago | |
rdb | 5 years ago | |
rdb.bat | 5 years ago | |
rdb_wrapper.py | 5 years ago | |
repo | 5 years ago | |
repo_launcher | 4 years ago | |
roll-dep | 5 years ago | |
roll-dep.bat | 5 years ago | |
roll_dep.py | 4 years ago | |
scm.py | 4 years ago | |
setup_color.py | 5 years ago | |
split_cl.py | 5 years ago | |
subcommand.py | 5 years ago | |
subprocess2.py | 4 years ago | |
update_depot_tools | 5 years ago | |
update_depot_tools.bat | 5 years ago | |
update_depot_tools_toggle.py | ||
upload_metrics.py | ||
upload_to_google_storage.py | 6 years ago | |
vpython | 6 years ago | |
vpython.bat | 5 years ago | |
vpython3 | 5 years ago | |
vpython3.bat | 5 years ago | |
watchlists.py | 4 years ago | |
weekly | 5 years ago | |
win32imports.py | 5 years ago | |
wtf | ||
yapf | 5 years ago | |
yapf.bat |
README.md
depot_tools
Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.
Tools
The most important tools are:
fetch
: Agclient
wrapper to checkout a project. Usefetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Usegit cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools
updates itself automatically when running gclient
tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
.
To update package manually, run update_depot_tools.bat
on Windows,
or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py
was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py
in depot_tools
, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.