You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Fumitoshi Ukai a7571b1596 Reland "Reland "Use bundled python to run gn""
This reverts commit 6678906cf8.

Reason for revert:
run gn.py instead of gn on PATH in presubmit check.

Bug: 414312048
Original change's description:
> Revert "Reland "Use bundled python to run gn""
>
> This reverts commit 49fcbee29e.
>
> Reason for revert: This broke a presubmit check in devtools-frontend https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715987965894722097/overview
>
> Bug: 414312048
> Original change's description:
> > Reland "Use bundled python to run gn"
> >
> > This reverts commit a3cdfed6c4.
> >
> > Reason for revert:
> > https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed
> >
> > Original change's description:
> > > Revert "Use bundled python to run gn"
> > >
> > > This reverts commit fa8fc854e1.
> > >
> > > Reason for revert: Most likely culprit for consistent failure
> > > to generate orderfiles (see crbug.com/414312048).
> > >
> > > Bug: 414312048
> > >
> > > Original change's description:
> > > > Use bundled python to run gn
> > > >
> > > > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > > > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > >
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> > > Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> > > Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> >
> > Bug: 414312048
> > Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Reviewed-by: Junji Watanabe <jwata@google.com>
>
> Bug: 414312048
> Change-Id: Iadb3bd20af737c1e7404bf8e95c333f1dbd62942
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508888
> Commit-Queue: Garrett Beaty <gbeaty@google.com>
> Reviewed-by: Garrett Beaty <gbeaty@google.com>
> Owners-Override: Garrett Beaty <gbeaty@google.com>
> Auto-Submit: Liviu Rau <liviurau@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: 414312048
Change-Id: I86d611b234bd5b2e91b184c7610c18cfe79f9816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6515221
Reviewed-by: Junji Watanabe <jwata@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
6 months ago
bootstrap [win-bootstrap] Update the comments in update_depot_tools.bat 9 months ago
fetch_configs Add fetch config for web-tests 6 months ago
hooks pre-commit: do not ignore submodule when running diff-index 2 years ago
infra Roll recipe dependencies (trivial). 6 months ago
infra_lib/telemetry Add telemetry initialization and opt out utility 1 year ago
man [doc] Add some cred helper info 7 months ago
metadata metadata: Fix metadata validator error reporting 9 months ago
python-bin better error message from python3 when not initialized 6 months ago
python2-bin
recipes Roll recipe dependencies (trivial). 6 months ago
testing_support Add CheckNewDEPSHooksHasRequiredReviewers canned check 9 months ago
tests Improve ensure_gsutil reliability 6 months ago
third_party updating license id for colorama 9 months ago
win_toolchain DEPOT_TOOLS_WIN_TOOLCHAIN=0 does not work with remote execution 6 months ago
zsh-goodies
.cipd_impl.ps1 [cipd] support proxy for .cipd_impl.ps1 11 months ago
.flake8 Add a config file for the flake8 linter. 2 years ago
.git-blame-ignore-revs Reuse GIT_BLAME_IGNORE_REV_FILE variable 1 year ago
.gitattributes Establish a directory for chrome infra telemetry 1 year ago
.gitignore autoninja: check RBE project, not account 1 year ago
.isort.cfg
.style.yapf switch to 4 space indent 2 years ago
.vpython3 Add hjson wheel for web-tests presubmit support 6 months ago
BUILD_OWNERS add siso wrapper 3 years ago
CROS_OWNERS
DIR_METADATA
LICENSE
LUCI_OWNERS add peep-software-deploy team to luci owners 2 years ago
OWNERS android: Add wnwen to OWNERS 6 months ago
PRESUBMIT.py Revert "Add AffectedFile.Extension() in presubmit_support" 9 months ago
README.gclient.md
README.git-cl.md
README.google_cloud_storage.md Document the current state of LUCI GCS integration 8 months ago
README.md explain build tools and depot_tools installations 6 months ago
RECLIENT_OWNERS Add convenience wrapper for reclientreport for autoninja users 3 years ago
WATCHLISTS Update WATCHLISTS for ninja, siso and reclient changes 2 years ago
android_build_server_helper.py android: Allow anonymous pipes for benchmarking 6 months ago
auth.py [auth] Delete unused _run_luci_auth_login method 8 months ago
autoninja autoninja: Use bundled Python to invoke autoninja.py 8 months ago
autoninja.bat autoninja: check RBE project, not account 1 year ago
autoninja.py autoninja.py: Make use_android_build_server enabled by default 7 months ago
bazel [ChromiumOS] Add a launcher for Bazel 2 years ago
bazel.py switch to 4 space indent 2 years ago
bb provide a way to override cipd root for *nix systems. 1 year ago
bb.bat
black
bootstrap_python3 Use relative path for cipd 3 years ago
breakpad.py switch to 4 space indent 2 years ago
build_telemetry autoninja: Implement build_telemetry utils 1 year ago
build_telemetry.bat autoninja: Implement build_telemetry utils 1 year ago
build_telemetry.py build_telemetry: Do not print warning message for cipd auth-info error 1 year ago
cbuildbot
cipd cipd: allow overriding the location of where cipd binary is installed 1 year ago
cipd.bat [cipd] Run cipd_impl.ps1 in constrained language mode 3 years ago
cipd_bin_setup.bat
cipd_bin_setup.sh provide a way to override cipd root for *nix systems. 1 year ago
cipd_client_version [depot_tools] Roll CIPD. 1 year ago
cipd_client_version.digests [depot_tools] Roll CIPD. 1 year ago
cipd_manifest.txt [cipd] Update lucicfg to v1.45.0. 6 months ago
cipd_manifest.versions [cipd] Update lucicfg to v1.45.0. 6 months ago
cipd_manifest_cros_python2.txt remove goma CIPD package 2 years ago
cipd_manifest_cros_python2.versions
clang-format
clang-format.bat
clang_format.py [clang_format] Update clang path 1 year ago
codereview.settings
compile_single_file Make 'compile_single_file' use vpython3 2 years ago
compile_single_file.bat Make 'compile_single_file' use vpython3 2 years ago
compile_single_file.py Make 'compile_single_file' use vpython3 2 years ago
cpplint.bat
cpplint.py [cpplint] add nolint region support 7 months ago
cpplint_chromium.py switch to 4 space indent 2 years ago
cros cros: start pushing people to 3.11 10 months ago
cros_python2.vpython
cros_sdk
detect_host_arch.py enable fetch and gclient to run on z/OS part 1 2 years ago
dirmd provide a way to override cipd root for *nix systems. 1 year ago
dirmd.bat
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py [auth-unify] deprecate no_auth options in download_for_google_storage 7 months ago
ensure_bootstrap ensure_bootstrap: basic argument processing 10 months ago
fetch [py2] Drop envvar to run scripts with py2 3 years ago
fetch.bat [py2] Drop envvar to run scripts with py2 3 years ago
fetch.py fail if fetch command is called in Cog 1 year ago
gclient [py2] Drop envvar to run scripts with py2 3 years ago
gclient-new-workdir.py fail gracefully if gclient-new-workdir.py is called in non-git env 1 year ago
gclient.bat [py2] Drop envvar to run scripts with py2 3 years ago
gclient.py Add --ignore-dep-type option to gclient sync 7 months ago
gclient_completion.sh
gclient_eval.py gclient_eval.py: Add "new_usages_require_review" to DEPS file schema 1 year ago
gclient_paths.py Set rootRepo custom-keyed-value push option on upload 6 months ago
gclient_scm.py set verbose=False for mirror.populate in _UpdateMirrorIfNotContains() 7 months ago
gclient_utils.py Improve ensure_gsutil reliability 6 months ago
gerrit
gerrit_client.py gerrit: addmessage: support attention set control 10 months ago
gerrit_util.py git cl cherry-pick: Use base parameter to fix identical tree errors 7 months ago
git-cache
git-cl
git-credential-luci [git-credential-luci] Redirect to batch file on Windows 7 months ago
git-credential-luci.bat [cipd] Add git-credential-luci (reland) 1 year ago
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs Enable searching starlark files with git gs. 2 years ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream print slightly better message if git nav-upstream is not called in git repo 2 years ago
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-squash-branch-tree Add git squash-branch-tree 1 year ago
git-thaw
git-upstream-diff
git_auth.py [git_auth] Check and fix auth on GCE 7 months ago
git_cache.py Reland "git-cache: contains_revision returns False if sentient file exists" 6 months ago
git_cl.py git_cl: Add type annotations to CMDformat and related functions 6 months ago
git_cl_completion.sh
git_common.py git_common: raise CalledProcessError with the given cwd, if set 7 months ago
git_completion.sh Bash autocompletion for 'git new-branch' and 'git reparent-branch' 2 years ago
git_dates.py Fix multiline comment formatting 2 years ago
git_find_releases.py fail gracefully if git find-releases is called in cog 2 years ago
git_footers.py [git_footers] add support for multiline footers 11 months ago
git_freezer.py fail gracefully if git freeze or git thaw are called in cog 2 years ago
git_hyper_blame.py Reuse GIT_BLAME_IGNORE_REV_FILE variable 1 year ago
git_map.py fail gracefully if git map is called in cog 2 years ago
git_map_branches.py [git-map-branches] Fix coloring of root branch 8 months ago
git_mark_merge_base.py fail gracefully if git mark-merge-base is called in cog 2 years ago
git_nav_downstream.py fail gracefully if git nav-downstream is called in cog 2 years ago
git_new_branch.py Track origin/lkgr when using --lkgr flag in new-branch 1 year ago
git_number.py Revert "[git-number] Remove unused git-number script." 1 year ago
git_rebase_update.py Colorize branch names for rebase-update 9 months ago
git_rename_branch.py fail gracefully if git rename-branch is called in cog 2 years ago
git_reparent_branch.py fail gracefully if git reparent-branch is called in cog 2 years ago
git_retry.py Fix multiline comment formatting 2 years ago
git_squash_branch.py Modify git squash-branch to perform reparenting 9 months ago
git_squash_branch_tree.py Modify git squash-branch to perform reparenting 9 months ago
git_upstream_diff.py fail gracefully if git upstream-diff is called in cog 2 years ago
gn Reland "Reland "Use bundled python to run gn"" 6 months ago
gn.bat Reland "Reland "Use bundled python to run gn"" 6 months ago
gn.py Reland "[depot_tools] Support both gn paths in gn.py" 2 years ago
gn_helper.py gn_helper: add missing sys import 9 months ago
google-java-format [depot_tools] add google_java_format.py 2 years ago
google-java-format.bat [depot_tools] add google_java_format.py 2 years ago
google_java_format.py Fix google-java-format/cipd exists check. 1 year ago
gsutil.py Improve ensure_gsutil reliability 6 months ago
gsutil.py.bat
gsutil.vpython3
isort switch to 4 space indent 2 years ago
led provide a way to override cipd root for *nix systems. 1 year ago
led.bat
lockfile.py lockfile: release the lock before closing the file handler 6 months ago
luci-auth provide a way to override cipd root for *nix systems. 1 year ago
luci-auth.bat
lucicfg provide a way to override cipd root for *nix systems. 1 year ago
lucicfg.bat
mac_toolchain provide a way to override cipd root for *nix systems. 1 year ago
metrics-xml-format add metrics_xml_formatter 11 months ago
metrics.README.md [metrics] Add new auth metric 1 year ago
metrics.py [metrics] Add new auth metric 1 year ago
metrics_utils.py [metrics] Add new auth metric 1 year ago
metrics_xml_format.py metrics_xml_format: check the XML path against realpath 9 months ago
my_activity.py my_activity.py: Handle JSON parse errors 11 months ago
newauth.py [newauth] Enable by default (reland) (include bots) 7 months ago
ninja
ninja.bat
ninja.py ninja: Improve depot_tools directory detection 9 months ago
ninjalog_uploader.py ninjalog_uploader: Send is_cloudtop=false explicitly 1 year ago
owners_client.py Select a minimal number of owners for a set of files 8 months ago
owners_finder.py Remove __future__ imports 2 years ago
pinpoint provide a way to override cipd root for *nix systems. 1 year ago
pinpoint.bat
post_build_ninja_summary.py post_build_ninja_summary: run siso.py instead of siso command 9 months ago
presubmit_canned_checks.py Reland "Reland "Use bundled python to run gn"" 6 months ago
presubmit_diff.py presubmit_diff: add support for -U 10 months ago
presubmit_support.py presubmit: add location data to presubmit result 7 months ago
prpc provide a way to override cipd root for *nix systems. 1 year ago
prpc.bat
pylint-2.6 switch to 4 space indent 2 years ago
pylint-2.6.bat
pylint-2.7 switch to 4 space indent 2 years ago
pylint-2.7.bat
pylint-2.17 pylint: Add pylint 2.17 2 years ago
pylint-2.17.bat pylint: Add pylint 2.17 2 years ago
pylint-3.2 pylint: add v3.2 support 10 months ago
pylint-3.2.bat pylint: add v3.2 support 10 months ago
pylint_main.py pylint: support versioned pylintrc files 10 months ago
pylintrc-2.6 pylintrc: version all of them 10 months ago
pylintrc-2.7 pylintrc: version all of them 10 months ago
pylintrc-2.17 pylintrc: version all of them 10 months ago
pylintrc-3.2 pylint: add v3.2 support 10 months ago
python_runner.sh [py2] Drop envvar to run scripts with py2 3 years ago
rdb provide a way to override cipd root for *nix systems. 1 year ago
rdb.bat
rdb_wrapper.py Fix multiline comment formatting 2 years ago
reclient_helper.py Revert "reclient_helper: tuning local execution parameter" 12 months ago
reclientreport Add convenience wrapper for reclientreport for autoninja users 3 years ago
reclientreport.bat Remove unnesisary quotes from propagated args in reclientreport.bat 2 years ago
reclientreport.py [reclient] Keep previous 5 builds worth of logs 2 years ago
repo error if repo command is called in Cog environment 1 year ago
repo_launcher repo: Update from upstream 7 months ago
roll-dep [py2] Drop envvar to run scripts with py2 3 years ago
roll-dep.bat [py2] Drop envvar to run scripts with py2 3 years ago
roll_dep.py roll_dep: Update README.chromium when rolling submodules 7 months ago
roll_downstream_gcs_deps.py Update roll_downstream_gcs_deps to take a list of source and destination packages. 1 year ago
rustfmt.py switch to 4 space indent 2 years ago
scm.py [scm] Handle empty .gitmodules file 1 year ago
setup_color.py Fix multiline comment formatting 2 years ago
siso siso: Use bundled python to run siso 8 months ago
siso.bat siso: Use bundled python to run siso 8 months ago
siso.py [siso]Adding import 7 months ago
split_cl.py fix doc-string in GetFilesSplitByOwners 7 months ago
subcommand.py subcommand: Add type annotations 6 months ago
subprocess2.py Fix multiline comment formatting 2 years ago
swift-format
swift_format.py switch to 4 space indent 2 years ago
update_depot_tools Remove check for canonical depot_tools URL 9 months ago
update_depot_tools.bat [win-bootstrap] Update the comments in update_depot_tools.bat 9 months ago
update_depot_tools_toggle.py switch to 4 space indent 2 years ago
upload_metrics.py switch to 4 space indent 2 years ago
upload_to_google_storage.py upload_to_google_storage.py: set x-goog-meta-executable during upload instead of using setmeta 1 year ago
upload_to_google_storage_first_class.py [GCS] Add prefix option to upload_to_gs_f_c 1 year ago
utils.py Use $HOME/.config/depot_tools on linux for .cfg files 1 year ago
vpython3 Don't write pyc files if running from Cog 1 year ago
vpython3.bat
watchlists.py Fix multiline comment formatting 2 years ago
whitespace.txt
win32imports.py switch to 4 space indent 2 years ago
yapf Always run yapf with vpython3. 2 years ago
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Also, includes shell script/batch file for tools required to build chromium, e.g.

  • gn: a meta-build system that generates build files for Ninja
  • autoninja: a wrapper for siso and ninja.
  • siso: a build tool that aims to significantly speed up Chromium's build.
  • ninja: a small build system with a focus on speed. deprecated by Siso.

These shell script/batch file runs python script with python-bin/python3 that find binaries in chromium checkout, and run with proper setup/check. To use these wrappers, you need to initialize/bootstrap depot_tools (using gclient, update_depot_tools or ensure_bootstrap).

Installing

See set-up documentation.

depot_tools is also available in

These depot_tools would not be initialized/bootstrapped (i.e. no python-bin/python3 binary available), so the build tool wrapper won't work, unless it is explicitly initialized by ensure_bootstrap. Or, directly call the python script instead of using the shell script/batch file.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

Running gclient will install python3 binary.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.