You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Jordan Brown 9fbf88b06f Presubmit error for bad delimiters
This change introduces a new error for license fields that use any of
the following `["/", ";", " and ", " or "]`.

I chose to include the offending character/s in the error message
because I find it easier to parse error messages that tell me exactly
which character is the bad one. Similarly I've included conditions in
the reason to handle the plural cases correctly, generating either:

`License contains a bad delimiter character ...`, or
`License contains bad delimiter characters ...`

I realise this means that any downstream rules looking to detect this
error will need to check for a common subset, e.g 'bad delimiter
character', however I think it's worth it for the improved user
experience of receiving the error.

I've also anticipated that most of these errors will be due to
situations where multiple licenses are offered, and included additional
text explaining that only the most permissive of the choices should be
included.

This will affect 9 dependencies and they need to choose between multiple licenses anyway so it's okay to generate an error and have partybug file bugs.

Bug: http://b/374850412
Change-Id: I6eb53a8a3bd541a1801dff133884b719dcdfe04d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6181848
Reviewed-by: Jiewei Qian <qjw@chromium.org>
Reviewed-by: Rachael Newitt <renewitt@google.com>
Commit-Queue: Jordan Brown <rop@google.com>
10 months ago
bootstrap [win-bootstrap] Never add docs to Git 10 months ago
fetch_configs Add webpagereplay fetch_config 1 year ago
hooks
infra Roll recipe dependencies (trivial). 10 months ago
infra_lib/telemetry Add telemetry initialization and opt out utility 1 year ago
man Remove "attempt to squash" behavior from `git rebase-update` 11 months ago
metadata Presubmit error for bad delimiters 10 months ago
python-bin
python2-bin
recipes Roll recipe dependencies (trivial). 10 months ago
testing_support Update CMDgitmodules to set `gclient-recursedeps` in .gitmodules file. 1 year ago
tests presubmit_diff: add support for -U 10 months ago
third_party [depot_tools] annotate third_party/colorama as non security critical 1 year ago
win_toolchain Add timeout to git call in windows toolchain update script 1 year ago
zsh-goodies
.cipd_impl.ps1 [cipd] support proxy for .cipd_impl.ps1 11 months ago
.flake8
.git-blame-ignore-revs Reuse GIT_BLAME_IGNORE_REV_FILE variable 1 year ago
.gitattributes Establish a directory for chrome infra telemetry 1 year ago
.gitignore autoninja: check RBE project, not account 1 year ago
.isort.cfg
.style.yapf
.vpython3 autoninja: check RBE project, not account 1 year ago
BUILD_OWNERS
CROS_OWNERS
DIR_METADATA
LICENSE
LUCI_OWNERS
OWNERS Add myself as a depot_tools owner. 10 months ago
PRESUBMIT.py presubmit: Check freeze on commit only 1 year ago
README.gclient.md
README.git-cl.md
README.md Switch to using issues.chromium.org bug links 2 years ago
RECLIENT_OWNERS
WATCHLISTS
android_build_server_helper.py Integrate autoninja.py with fast_local_dev_server.py 11 months ago
auth.py gerrit_util: Use git-credential-luci instead of luci-auth 12 months ago
autoninja autoninja: check RBE project, not account 1 year ago
autoninja.bat autoninja: check RBE project, not account 1 year ago
autoninja.py autoninja: run ninjalog_uploader in new session 10 months ago
bazel
bazel.py
bb provide a way to override cipd root for *nix systems. 1 year ago
bb.bat
black
bootstrap_python3
breakpad.py
build_telemetry autoninja: Implement build_telemetry utils 1 year ago
build_telemetry.bat autoninja: Implement build_telemetry utils 1 year ago
build_telemetry.py build_telemetry: Do not print warning message for cipd auth-info error 1 year ago
cbuildbot
cipd cipd: allow overriding the location of where cipd binary is installed 1 year ago
cipd.bat
cipd_bin_setup.bat
cipd_bin_setup.sh provide a way to override cipd root for *nix systems. 1 year ago
cipd_client_version [depot_tools] Roll CIPD. 1 year ago
cipd_client_version.digests [depot_tools] Roll CIPD. 1 year ago
cipd_manifest.txt Roll vpython3 to include python 3.11.9.chromium.36. 10 months ago
cipd_manifest.versions Roll vpython3 to include python 3.11.9.chromium.36. 10 months ago
cipd_manifest_cros_python2.txt remove goma CIPD package 2 years ago
cipd_manifest_cros_python2.versions
clang-format
clang-format.bat
clang_format.py [clang_format] Update clang path 1 year ago
codereview.settings
compile_single_file Make 'compile_single_file' use vpython3 2 years ago
compile_single_file.bat Make 'compile_single_file' use vpython3 2 years ago
compile_single_file.py Make 'compile_single_file' use vpython3 2 years ago
cpplint.bat
cpplint.py [cpplint] add stdin support in stdin 1 year ago
cpplint_chromium.py
cros cros: start pushing people to 3.11 10 months ago
cros_python2.vpython
cros_sdk
detect_host_arch.py enable fetch and gclient to run on z/OS part 1 2 years ago
dirmd provide a way to override cipd root for *nix systems. 1 year ago
dirmd.bat
download_from_google_storage
download_from_google_storage.bat
download_from_google_storage.py Add gsutil.py config hint to 401 GCS error message 12 months ago
ensure_bootstrap ensure_bootstrap: basic argument processing 10 months ago
fetch
fetch.bat
fetch.py fail if fetch command is called in Cog 1 year ago
gclient
gclient-new-workdir.py fail gracefully if gclient-new-workdir.py is called in non-git env 1 year ago
gclient.bat
gclient.py Skip writing gclient_args.gni if contents are unchanged to avoid causing rebuild 10 months ago
gclient_completion.sh
gclient_eval.py gclient_eval.py: Add "new_usages_require_review" to DEPS file schema 1 year ago
gclient_paths.py gclient: resolve symlink in gclient_entries before checking with current path 1 year ago
gclient_scm.py [gclient] Handle auth setup for cached repos 10 months ago
gclient_utils.py Explicitly propagate terminal size to gclient hooks. 10 months ago
gerrit
gerrit_client.py gerrit: addmessage: support attention set control 10 months ago
gerrit_util.py gerrit: addmessage: support attention set control 10 months ago
git-cache
git-cl
git-credential-luci provide a way to override cipd root for *nix systems. 1 year ago
git-credential-luci.bat [cipd] Add git-credential-luci (reland) 1 year ago
git-crrev-parse
git-drover
git-find-releases
git-footers
git-freeze
git-gs Enable searching starlark files with git gs. 2 years ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream print slightly better message if git nav-upstream is not called in git repo 2 years ago
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks
git-squash-branch
git-squash-branch-tree Add git squash-branch-tree 1 year ago
git-thaw
git-upstream-diff
git_auth.py gerrit_util: Use git-credential-luci instead of luci-auth 12 months ago
git_cache.py error if git cache commands are called in cog env. 2 years ago
git_cl.py Remove unnecessary RunHook call for squash mode. 10 months ago
git_cl_completion.sh
git_common.py Prefer direct git installation for Windows 1 year ago
git_completion.sh
git_dates.py Fix multiline comment formatting 2 years ago
git_find_releases.py fail gracefully if git find-releases is called in cog 2 years ago
git_footers.py [git_footers] add support for multiline footers 12 months ago
git_freezer.py fail gracefully if git freeze or git thaw are called in cog 2 years ago
git_hyper_blame.py Reuse GIT_BLAME_IGNORE_REV_FILE variable 1 year ago
git_map.py fail gracefully if git map is called in cog 2 years ago
git_map_branches.py fail gracefully if git map-branches is called in cog 2 years ago
git_mark_merge_base.py fail gracefully if git mark-merge-base is called in cog 2 years ago
git_nav_downstream.py fail gracefully if git nav-downstream is called in cog 2 years ago
git_new_branch.py Track origin/lkgr when using --lkgr flag in new-branch 1 year ago
git_number.py Revert "[git-number] Remove unused git-number script." 1 year ago
git_rebase_update.py Remove "attempt to squash" behavior from `git rebase-update` 11 months ago
git_rename_branch.py fail gracefully if git rename-branch is called in cog 2 years ago
git_reparent_branch.py fail gracefully if git reparent-branch is called in cog 2 years ago
git_retry.py Fix multiline comment formatting 2 years ago
git_squash_branch.py fail gracefully if git squash-branch is called in cog 2 years ago
git_squash_branch_tree.py Add git squash-branch-tree 1 year ago
git_upstream_diff.py fail gracefully if git upstream-diff is called in cog 2 years ago
gn
gn.bat
gn.py Reland "[depot_tools] Support both gn paths in gn.py" 2 years ago
gn_helper.py gn_helper: find correct directory for // 12 months ago
google-java-format [depot_tools] add google_java_format.py 2 years ago
google-java-format.bat [depot_tools] add google_java_format.py 2 years ago
google_java_format.py Fix google-java-format/cipd exists check. 1 year ago
gsutil.py [gsutil] Fix race when downloading gsutil 2 years ago
gsutil.py.bat
gsutil.vpython3
isort
led provide a way to override cipd root for *nix systems. 1 year ago
led.bat
lockfile.py [gsutil] Fix race when downloading gsutil 2 years ago
luci-auth provide a way to override cipd root for *nix systems. 1 year ago
luci-auth.bat
lucicfg provide a way to override cipd root for *nix systems. 1 year ago
lucicfg.bat
mac_toolchain provide a way to override cipd root for *nix systems. 1 year ago
metrics-xml-format add metrics_xml_formatter 11 months ago
metrics.README.md [metrics] Add new auth metric 1 year ago
metrics.py [metrics] Add new auth metric 1 year ago
metrics_utils.py [metrics] Add new auth metric 1 year ago
metrics_xml_format.py Reland "Support formatting metrics xml(s) in the subfolders." 11 months ago
my_activity.py my_activity.py: Handle JSON parse errors 12 months ago
newauth.py [git_cl] Let creds-check revert new auth config changes 1 year ago
ninja
ninja.bat
ninja.py ninja: error if trying to build for use_remoteexec=true 1 year ago
ninjalog_uploader.py ninjalog_uploader: Send is_cloudtop=false explicitly 1 year ago
owners_client.py [owners] Limit number of concurrent Gerrit connections 2 years ago
owners_finder.py
pinpoint provide a way to override cipd root for *nix systems. 1 year ago
pinpoint.bat
post_build_ninja_summary.py allow v6 ninja log format 1 year ago
presubmit_canned_checks.py Add `is_open_source_project` to metadata validation 10 months ago
presubmit_diff.py presubmit_diff: add support for -U 10 months ago
presubmit_support.py Use ProvidedDiffChange if diff is empty string 1 year ago
prpc provide a way to override cipd root for *nix systems. 1 year ago
prpc.bat
pylint-2.6
pylint-2.6.bat
pylint-2.7
pylint-2.7.bat
pylint-2.17
pylint-2.17.bat
pylint-3.2 pylint: add v3.2 support 10 months ago
pylint-3.2.bat pylint: add v3.2 support 10 months ago
pylint_main.py pylint: support versioned pylintrc files 11 months ago
pylintrc-2.6 pylintrc: version all of them 11 months ago
pylintrc-2.7 pylintrc: version all of them 11 months ago
pylintrc-2.17 pylintrc: version all of them 11 months ago
pylintrc-3.2 pylint: add v3.2 support 10 months ago
python_runner.sh
rdb provide a way to override cipd root for *nix systems. 1 year ago
rdb.bat
rdb_wrapper.py Fix multiline comment formatting 2 years ago
reclient_helper.py Revert "reclient_helper: tuning local execution parameter" 1 year ago
reclientreport
reclientreport.bat
reclientreport.py
repo error if repo command is called in Cog environment 1 year ago
repo_launcher [repo] Update repo launcher to v2.50 10 months ago
roll-dep
roll-dep.bat
roll_dep.py error if roll-dep command is called in Cog environment 1 year ago
roll_downstream_gcs_deps.py Update roll_downstream_gcs_deps to take a list of source and destination packages. 1 year ago
rustfmt.py
scm.py [scm] Handle empty .gitmodules file 1 year ago
setup_color.py Fix multiline comment formatting 2 years ago
siso
siso.bat
siso.py Integrate autoninja.py with fast_local_dev_server.py 11 months ago
split_cl.py Fix argument mismatch in split_cl.py 10 months ago
subcommand.py Fix multiline comment formatting 2 years ago
subprocess2.py Fix multiline comment formatting 2 years ago
swift-format
swift_format.py
update_depot_tools Make update_depot_tools tell you if it's skipping an update. 1 year ago
update_depot_tools.bat remove goma CIPD package 2 years ago
update_depot_tools_toggle.py
upload_metrics.py
upload_to_google_storage.py upload_to_google_storage.py: set x-goog-meta-executable during upload instead of using setmeta 1 year ago
upload_to_google_storage_first_class.py [GCS] Add prefix option to upload_to_gs_f_c 1 year ago
utils.py Use $HOME/.config/depot_tools on linux for .cfg files 1 year ago
vpython3 Don't write pyc files if running from Cog 1 year ago
vpython3.bat
watchlists.py Fix multiline comment formatting 2 years ago
whitespace.txt
win32imports.py
yapf Always run yapf with vpython3. 2 years ago
yapf.bat

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.