aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '6b1e3ee9e3'
${ noResults }
depot_tools/tests
History
dpranke@chromium.org 6b1e3ee9e3 Change the OWNERS check to print files, not directories 
Currently, when we run the OWNERS check, we print the list of directories
that contain the relevant OWNERS files for any modified files in a change
still needing approval. 

This has two problems:

1) if we bubble all the way up to the top level OWNERS, we print "" instead of
"src/" or something more useful (bug 157191)

2) for OWNERS files that contain per-file set-noparent entries (like changes to IPC messages), this can be really confusing because an owner of other stuff in the directory might've approved things already.

This change will now print the list of files in the CL that are still unapproved.
This might be a lot more verbose (since you get N lines rather than 1 for N files in a given directory), but hopefully it'll be clearer in the two cases above.

Also, this change takes care of some lingering clean-up in the code to rename some methods to be clearer.

R=maruel@chromium.org
BUG=157191




Review URL: https://chromiumcodereview.appspot.com/12314044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@184219 0039d316-1c4b-4281-b951-d872f2087c98
 		12 years ago
..
subversion_config Move commit-queue/checkout into depot_tools so it can be reused by the try server. 14 years ago
abandon.sh Add test for git-svn with submodule/merge layout. 13 years ago
basic.sh Add test for git-svn with submodule/merge layout. 13 years ago
breakpad_unittest.py Make sure that direct call to SendStack() doesn't send a stack trace for non googler 14 years ago
checkout_test.py Make apply_issue.py much more verbose about what it's doing. 13 years ago
fix_encoding_test.py Standardize the sys.path fix up and fix a few pylint warnings. 14 years ago
gcl_unittest.py Fix parameters for git_cl and gcl. 12 years ago
gclient_scm_test.py Make safesync w/ git hash work when lkgr is ahead of clone. 12 years ago
gclient_smoketest.py Remove more unversioned directories. 13 years ago
gclient_test.py Add gclient grep for git repos 13 years ago
gclient_utils_test.py Make gclient sync use cpu count for default jobs 13 years ago
git_cl_test.py Don't call settings.GetIsGerrit() before parser.parse_args() 13 years ago
hooks.sh Add test for git-svn with submodule/merge layout. 13 years ago
owners.sh Add test for git-svn with submodule/merge layout. 13 years ago
owners_unittest.py Change the OWNERS check to print files, not directories 12 years ago
patch.sh Add test for git-svn with submodule/merge layout. 13 years ago
patch_test.py Fix applying svn:executable on Windows. 13 years ago
post-dcommit-hook-test.sh Add test for git-svn with submodule/merge layout. 13 years ago
presubmit_unittest.py Change the OWNERS check to print files, not directories 12 years ago
push-basic.sh Add test for git-svn with submodule/merge layout. 13 years ago
push-from-logs.sh options.from_logs is not used anywhere since it's the default. 13 years ago
rename.sh Add test for git-svn with submodule/merge layout. 13 years ago
rietveld_test.py Create CachingRietveld to automatically cache results for presubmit checks. 13 years ago
sample_pre_commit_hook Move commit-queue/checkout into depot_tools so it can be reused by the try server. 14 years ago
save-description-on-failure.sh Add test for git-svn with submodule/merge layout. 13 years ago
scm_unittest.py Restore previous behavior of GetSha1ForSvnRev, so unit tests pass. 13 years ago
submit-from-new-dir.sh Add test for git-svn with submodule/merge layout. 13 years ago
submodule-merge-test.sh Add test for git-svn with submodule/merge layout. 13 years ago
subprocess2_test.py Fix variable aliasing. Fixes pylint W0623. 14 years ago
test-lib.sh Add test for git-svn with submodule/merge layout. 13 years ago
trychange_unittest.py Make git try warn on a dirty index. 13 years ago
upload-local-tracking-branch.sh Add test for git-svn with submodule/merge layout. 13 years ago
upload-stale.sh Add test for git-svn with submodule/merge layout. 13 years ago
upstream.sh Add test for git-svn with submodule/merge layout. 13 years ago
watchlists_unittest.py Create a new testing_support module to move utility modules there 14 years ago