aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
1,682 Commits
6 Branches
0 Tags
184 MiB
Python 96.9%
Shell 1.2%
Roff 1.2%
Batchfile 0.7%
 
 
 
 
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '6b1e3ee9e3'
${ noResults }
Go to file
dpranke@chromium.org 6b1e3ee9e3 Change the OWNERS check to print files, not directories 
Currently, when we run the OWNERS check, we print the list of directories
that contain the relevant OWNERS files for any modified files in a change
still needing approval. 

This has two problems:

1) if we bubble all the way up to the top level OWNERS, we print "" instead of
"src/" or something more useful (bug 157191)

2) for OWNERS files that contain per-file set-noparent entries (like changes to IPC messages), this can be really confusing because an owner of other stuff in the directory might've approved things already.

This change will now print the list of files in the CL that are still unapproved.
This might be a lot more verbose (since you get N lines rather than 1 for N files in a given directory), but hopefully it'll be clearer in the two cases above.

Also, this change takes care of some lingering clean-up in the code to rename some methods to be clearer.

R=maruel@chromium.org
BUG=157191




Review URL: https://chromiumcodereview.appspot.com/12314044

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@184219 0039d316-1c4b-4281-b951-d872f2087c98
 		12 years ago
bootstrap Force a new download/install of git-1.8.0 to pick up: 13 years ago
git-templates git template files for chromium checkouts. 12 years ago
git_utils Rename git-utils to git_utils so it can be imported with python. 13 years ago
support chromite_wrapper: Add support for gclient checkouts. 12 years ago
testing_support Fix small error in SimpleMock. 12 years ago
tests Change the OWNERS check to print files, not directories 12 years ago
third_party Update upload.py at @ 41332266d718. 13 years ago
zsh-goodies Remove unmaintained "gclient export" command, 14 years ago
.gitignore Add stuff that are generated from tests. 13 years ago
LICENSE Create the Next Generation of depot_tools. Eh. 16 years ago
OWNERS I own you, depot_tools. 12 years ago
PRESUBMIT.py Add disabled_warnings arg to RunPylint() and use the default pylintrc file by default. 13 years ago
README Fix git depot_tools update flow. 13 years ago
README.codereview Move git_cl back into depot_tools. 14 years ago
README.gclient Fix EOL issues. 14 years ago
README.git-cl Move git_cl back into depot_tools. 14 years ago
README.testing Move git_cl back into depot_tools. 14 years ago
WATCHLISTS Use cmp-cc for watchlists. 12 years ago
apply_issue Mark the apply_issue and apply_issue.bat files as executable. BUG=149941 13 years ago
apply_issue.bat Mark the apply_issue and apply_issue.bat files as executable. BUG=149941 13 years ago
apply_issue.py Use --nohooks when gclient sync in apply_issue. 13 years ago
breakpad.py Only call SendProfile() on slow commands 13 years ago
cbuildbot Cleanup chromite_wrapper. 13 years ago
checkout.py Add workaround where SVN.Revert() deletes the checkout. 13 years ago
chrome-update-create-task.bat Fix EOL issues. 14 years ago
chrome-update.bat Fix EOL issues. 14 years ago
chrome-update.py Add a warning if the current version of python is not 2.5 14 years ago
chrome_set_ver Cleanup chromite_wrapper. 13 years ago
codereview.settings Add codereview.settings to depot_tools. 15 years ago
commit_queue.py Silence pylint on Mac OSX 10.6 14 years ago
cpplint.bat Fix EOL issues. 14 years ago
cpplint.py Change the python hashbang in cppint.py 13 years ago
cpplint_chromium.py Add lint check against "Foo *bar" and "Foo &bar" declarations. 14 years ago
create-chromium-git-src Change shebangs to allow the tools to be used out of the box without modification 15 years ago
create-ntfs-junction.c Utility to create an NTFS junction point. Previously reviewed at: 13 years ago
create-ntfs-junction.exe Utility to create an NTFS junction point. Previously reviewed at: 13 years ago
cros Add cros wrapper to depot_tools. 13 years ago
cros_sdk Cleanup chromite_wrapper. 13 years ago
crup-runner.sh Fix git-crup errors when CDPATH is set. 12 years ago
drover Enable PYTHONDONTWRITEBYTECODE=1 as much as possible. 14 years ago
drover.bat Enable PYTHONDONTWRITEBYTECODE=1 as much as possible. 14 years ago
drover.py Fix presubmit check failure caused by r179457. 12 years ago
fix_encoding.py Fix case where wc_info is not present. 14 years ago
gcl Enable PYTHONDONTWRITEBYTECODE=1 as much as possible. 14 years ago
gcl.bat Enable PYTHONDONTWRITEBYTECODE=1 as much as possible. 14 years ago
gcl.py Fix parameters for git_cl and gcl. 12 years ago
gclient Fix gclient "skip update on certain commands", again 13 years ago
gclient.bat Attempting to fix a C:\cygwin\bin\python.exe stack trace 13 years ago
gclient.py handle bad python install 12 years ago
gclient_scm.py Make safesync w/ git hash work when lkgr is ahead of clone. 12 years ago
gclient_utils.py Add gclient grep for git repos 13 years ago
git-cl Fix dirname logic for msys and not-msys. 13 years ago
git-cl-upload-hook Enforce inserting the depot_tools path as the first path in sys.path. 14 years ago
git-crsync Add --sync option, to only sync submodules. 12 years ago
git-crup Add --sync option, to only sync submodules. 12 years ago
git-gs git-gs: Search in java files too. 12 years ago
git-lkgr Add --closest option to git-lkgr. 12 years ago
git-runhooks Set executable bit 13 years ago
git-try Update dirname logic. 13 years ago
git-wktry Add a git command for running ToT WebKit patches against the trybots. 12 years ago
git_cl.py tyop: 'patchsets' seems to be the correct key, not 'patchset'. 12 years ago
git_try.py Enforce cwd for GIT functions 14 years ago
git_wktry.py Fix lint error in git_wktry. 12 years ago
hammer Updating hammer script based on review suggestions. 16 years ago
hammer.bat Fix EOL issues. 14 years ago
my_activity.py my_activity.py: Add a shorturl for cromium-os. 12 years ago
my_reviews.py Add median latency to my_reviews.py. Do more calculation on the fly. 13 years ago
ninja ninja: Add a friendlier error message if no prebuilt binary is found. 13 years ago
ninja-linux32 Update ninja to v1.1.0 on Mac, Linux32, Linux64, Windows. 12 years ago
ninja-linux64 Update ninja to v1.1.0 on Mac, Linux32, Linux64, Windows. 12 years ago
ninja-mac Update ninja to v1.1.0 on Mac, Linux32, Linux64, Windows. 12 years ago
ninja.exe Update ninja to v1.1.0 on Mac, Linux32, Linux64, Windows. 12 years ago
owners.py Change the OWNERS check to print files, not directories 12 years ago
patch.py Make apply_issue.py much more verbose about what it's doing. 13 years ago
presubmit_canned_checks.py Change the OWNERS check to print files, not directories 12 years ago
presubmit_support.py Create CachingRietveld to automatically cache results for presubmit checks. 13 years ago
profile.xml Create the Next Generation of depot_tools. Eh. 16 years ago
pylint Pass arguments to pylint child process via a pipe. 13 years ago
pylint.py Pass arguments to pylint child process via a pipe. 13 years ago
pylintrc Add multiprocessing.managers.SyncManager to pylintrc generated-members 13 years ago
repo Pull in repo v1.18 script for matching repo v1.11.1 update. 13 years ago
rietveld.py Cut the comment short in Rietveld.add_comment(). [follow up of r177704] 12 years ago
scm.py Restore previous behavior of GetSha1ForSvnRev, so unit tests pass. 13 years ago
subprocess2.py Correct invalid use of 'is' when '==' should have been used. 13 years ago
trychange.py Fix toplevel_root parsing in trychange.py 13 years ago
update_depot_tools Point to newer git-1.8.0_bin directory. 12 years ago
update_depot_tools.bat Add prompt for updating remote URL to git-on-borg. 12 years ago
watchlists.py Add a warning if the current version of python is not 2.5 14 years ago
weekly Adding weekly tool to help with weekly snippets 15 years ago
wtf fix wtf crash when deps entry is at None 13 years ago

README 

This package contains tools for working with Chromium development.

The "gclient" wrapper knows how to keep this repository updated to
the latest versions of these tools as found at:

    http://src.chromium.org/svn/trunk/tools/depot_tools

This package contains:

  chrome-update-create-task.bat
    Creates a scheduled task to do an automatic local chromium build every day.

  cpplint.py
    A copy of our linting tool which enforces Google style. Fetched from
    http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py

  gcl
    A tool for uploading and managing code reviews on the Chromium
    project, using the Rietveld code review tool.  More info at:
    http://code.google.com/p/rietveld/

  gclient
    A script for managing a workspace with modular dependencies that
    are each checked out independently from different repositories.
    More info at:
    http://code.google.com/p/gclient/

  hammer
    A wrapper script for building Chromium with the SCons software
    construction tool.  More info at:
    http://www.scons.org/

Note: svn and python will be installed automatically if not accessible (on
Windows only).

To update this distribution manually, run .\update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.

To disable automatic updating, set the environment variable DEPOT_TOOLS_UPDATE=0