You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Josip Sokcevic 4da8a3d59d Fix bot_update hanging on exception
This change starts observers as soon as possible, and wraps the entire
block that can cause an exception in try..finally. This ensures that we
stop threads are stopped.

If we notice the same behavior, it could be worth to put a cap on number
of executions per observer, and shut the thread down once reached.

R=apolito@google.com

Bug: 1255228
Change-Id: I1f165267460da02b3bbba39022c262e6c29fe86b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3213451
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
bootstrap cpython3 3.8.10.chromium.21 to depot_tools bleeding_edge. 4 years ago
fetch_configs Add fetch recipe for the Flutter Engine repository. 4 years ago
git-templates
infra Roll recipe dependencies (nontrivial). 4 years ago
man Use main ref in git-footers documentation 4 years ago
python-bin Add python batch wrappers 4 years ago
python2-bin Add python batch wrappers 4 years ago
recipes Fix bot_update hanging on exception 4 years ago
testing_support Use py3 for remaining tools in depot_tools path 4 years ago
tests Fix bot_update hanging on exception 4 years ago
third_party Remove third_party/httplib2 4 years ago
win_toolchain Fix python2/3 compatibility in DownloadUsingHttp function 4 years ago
zsh-goodies
.cipd_impl.ps1 Try removing windows-386 from cipd_manifest.txt 4 years ago
.gitattributes chrome_set_ver: punt old script 4 years ago
.gitignore Ignore VsChromium config file 4 years ago
.style.yapf Update "git cl format --python" to default to PEP-8 5 years ago
.vpython Add explicit vpython verification tags which include mac-arm64. 4 years ago
.vpython3 Require certifi package and python3 in my_activity 4 years ago
CROS_OWNERS CROS_OWNERS: add more build peeps 4 years ago
DIR_METADATA [depot_tools] Migrate metadata to DIR_METADATA. 4 years ago
GOMA_OWNERS Update GOMA_OWNERS 4 years ago
LICENSE
LUCI_OWNERS tandrii: switch OWNERS to @google.com account. 5 years ago
OWNERS Remove ehmaldonado from OWNERS 4 years ago
PRESUBMIT.py Require certifi package and python3 in my_activity 4 years ago
README.gclient.md
README.git-cl.md Replace non-inclusive terms 5 years ago
README.md add clarification for Python 3 5 years ago
WATCHLISTS [docs] update links to developer guide 4 years ago
auth.py [auth] log errors from luci-auth token invocation. 4 years ago
autoninja Fix "expr: syntax error" on macOS 4 years ago
autoninja.bat Have autoninja.bat run depot_tools python3 4 years ago
autoninja.py Respect GOMA_DIR in autoninja instead of always assuming .cipd_bin. 4 years ago
bb Add revert instructions 4 years ago
bb.bat Add revert instructions 4 years ago
bootstrap_python3 [mac/arm] pull python3 binary in cipd bootstrap now that it exists 4 years ago
breakpad.py
cbuildbot simplify the chromite wrappers 6 years ago
cipd Default to arm64 cipd packages on arm macs 4 years ago
cipd.bat [cipd] Take cipd.ps1 out of %PATH%. 5 years ago
cipd_bin_setup.bat Revert "put goma client in depot_tools" 6 years ago
cipd_bin_setup.sh Revert "put goma client in depot_tools" 6 years ago
cipd_client_version [cipd] Update cipd client to v2.6.2. 4 years ago
cipd_client_version.digests [cipd] Update cipd client to v2.6.2. 4 years ago
cipd_manifest.txt Roll out new goma client binary VERSION=233 4 years ago
cipd_manifest.versions Roll out new goma client binary VERSION=233 4 years ago
cit Use py3 for remaining tools in depot_tools path 4 years ago
cit.bat Use py3 for remaining tools in depot_tools path 4 years ago
cit.py Update "cit" tool to use vpython instead of run.py. 4 years ago
clang-format Use py3 for remaining tools in depot_tools path 4 years ago
clang-format.bat Use py3 for remaining tools in depot_tools path 4 years ago
clang_format.py Use py3 for remaining tools in depot_tools path 4 years ago
clang_format_merge_driver Use py3 for remaining tools in depot_tools path 4 years ago
clang_format_merge_driver.bat Use py3 for remaining tools in depot_tools path 4 years ago
clang_format_merge_driver.py Use py3 for remaining tools in depot_tools path 4 years ago
codereview.settings update stale codereview.chromium.org links 4 years ago
compile_single_file Use py3 for remaining tools in depot_tools path 4 years ago
compile_single_file.bat Use py3 for remaining tools in depot_tools path 4 years ago
compile_single_file.py Use py3 for remaining tools in depot_tools path 4 years ago
cpplint.bat
cpplint.py CodeInclusion: Rename whitelist/blacklist -> allowlist/blocklist 5 years ago
cpplint_chromium.py
cros cros: raise python version requirement to 3.6 5 years ago
cros_sdk simplify the chromite wrappers 6 years ago
crosjobs Add revert instructions 4 years ago
detect_host_arch.py gclient: Correctly set host_cpu to arm64 on arm macs 4 years ago
dirmd Add revert instructions 4 years ago
dirmd.bat Add revert instructions 4 years ago
download_from_google_storage Switch download_from_google_storage to py3 4 years ago
download_from_google_storage.bat Revert "Switch download_from_google_storage scripts to invoke python3." 4 years ago
download_from_google_storage.py Refactor gsutil and fix concurrecny issue on MacOS 4 years ago
ensure_bootstrap Reland "depot_tools: Bootstrap Python 3 on Linux/Mac" 6 years ago
fetch Make Python 3 default on Windows 5 years ago
fetch.bat Abort fetch, gclient, gsutil.py when update_depot_tools fails on Windows 5 years ago
fetch.py Make fetch compatible with py 3.5 5 years ago
fix_encoding.py Revert "Modify fix_encodng to make it use fix_win_sys_argv for python2 only and" 4 years ago
gclient Make Python 3 default on Windows 5 years ago
gclient-new-workdir.py
gclient.bat Abort fetch, gclient, gsutil.py when update_depot_tools fails on Windows 5 years ago
gclient.py gclient: Report hook metrics 4 years ago
gclient_completion.sh
gclient_eval.py Revert "Remove use_relative_hooks now that all deprecated uses are removed." 5 years ago
gclient_paths.py Change FindGclientRoot to Use os.path.abspath instead of os.path.realpath 4 years ago
gclient_scm.py Fetch remote when applying patches in gclient 4 years ago
gclient_utils.py Support UTF-8 messages in git cl upload 🪟 4 years ago
gerrit_client.py Fix gerrit_client py3 incompatibility 4 years ago
gerrit_util.py Add new subcommand for 'Changes Submitted Together'. 4 years ago
git-cache Add quotes around paths in bash scripts 5 years ago
git-cl Add quotes around paths in bash scripts. 5 years ago
git-crrev-parse
git-drover Add quotes around paths in bash scripts 5 years ago
git-find-releases Add quotes around paths in bash scripts 5 years ago
git-footers Add quotes around paths in bash scripts 5 years ago
git-freeze Add quotes around paths in bash scripts 5 years ago
git-gs
git-hyper-blame Add quotes around paths in bash scripts 5 years ago
git-map Add quotes around paths in bash scripts 5 years ago
git-map-branches Add quotes around paths in bash scripts 5 years ago
git-mark-merge-base Add quotes around paths in bash scripts 5 years ago
git-migrate-default-branch Add git-migrate-default-branch 5 years ago
git-nav-downstream Add quotes around paths in bash scripts 5 years ago
git-nav-upstream
git-new-branch Add quotes around paths in bash scripts 5 years ago
git-number Add quotes around paths in bash scripts 5 years ago
git-rebase-update Add quotes around paths in bash scripts 5 years ago
git-rename-branch Add quotes around paths in bash scripts 5 years ago
git-reparent-branch Add quotes around paths in bash scripts 5 years ago
git-retry Add quotes around paths in bash scripts 5 years ago
git-runhooks Use py3 for remaining tools in depot_tools path 4 years ago
git-squash-branch Add quotes around paths in bash scripts 5 years ago
git-thaw Add quotes around paths in bash scripts 5 years ago
git-upstream-diff Add quotes around paths in bash scripts 5 years ago
git_cache.py Make git_cache compatible with git <2.28 4 years ago
git_cl.py [rust] [depot_tools] Minimal `rustfmt` support for `git cl format`. 4 years ago
git_cl_completion.sh Add git completion helper to cl upload 5 years ago
git_common.py Revert "[depot_tools] Add --fork-point when computing merge-base" 4 years ago
git_dates.py
git_drover.py git_drover: Replace with instructions on how to cherry-pick. 4 years ago
git_find_releases.py Add unit tests for git_find_releases 5 years ago
git_footers.py Replace non-inclusive terms 5 years ago
git_freezer.py
git_hyper_blame.py Add support for git_hyper_blame for Windows 5 years ago
git_map.py git-map: Refactor and add simple tests 5 years ago
git_map_branches.py Replace non-inclusive terms 5 years ago
git_mark_merge_base.py
git_migrate_default_branch.py Update origin HEAD when running git migration 4 years ago
git_nav_downstream.py depot_tools: Use gclient_utils.AskForData instead of raw_input. 5 years ago
git_new_branch.py Replace non-inclusive terms 5 years ago
git_number.py Run spellchecker on depot_tools 5 years ago
git_rebase_update.py Revert "Error out of rebase-update if there are uncommitted changes" 4 years ago
git_rename_branch.py git-rebase-update: Make tests run on Python 3. 6 years ago
git_reparent_branch.py add metric for reparent_branch 4 years ago
git_retry.py Replace non-inclusive terms 5 years ago
git_squash_branch.py
git_upstream_diff.py
gn gn: Call gn.bat in msysgit on Windows. 4 years ago
gn.bat Revert "Call python3.bat explicitly from gn.bat on Windows." 4 years ago
gn.py Switch gn wrapper scripts to invoke python3. 4 years ago
goma_auth Reland "Reland "use python3 for goma related scripts"" 4 years ago
goma_auth.bat Reland "Reland "use python3 for goma related scripts"" 4 years ago
goma_ctl Reland "Reland "use python3 for goma related scripts"" 4 years ago
goma_ctl.bat Reland "Reland "use python3 for goma related scripts"" 4 years ago
gsutil.py Set cache-control when uploading to google storage 4 years ago
gsutil.py.bat gsutil.py.bat: Skip updating depot_tools if DEPOT_TOOLS_UPDATE=0. 5 years ago
gsutil.vpython Use fixed cffi wheel verison. 4 years ago
led Add revert instructions 4 years ago
led.bat Add revert instructions 4 years ago
lockfile.py Reland "Use OS level locking in git_cache.py" 5 years ago
luci-auth Add revert instructions 4 years ago
luci-auth.bat Add revert instructions 4 years ago
lucicfg Add revert instructions 4 years ago
lucicfg.bat Add revert instructions 4 years ago
mac_toolchain
metrics.README.md Replace non-inclusive terms 5 years ago
metrics.py metrics: Wait until upload is complete on bots. 4 years ago
metrics_utils.py metrics: Don't collect metrics on DEPOT_TOOLS_METRICS=0 4 years ago
my_activity.py Require certifi package and python3 in my_activity 4 years ago
ninja properly detect msys_nt as windows in the ninja script 6 years ago
ninja-linux32
ninja-linux64
ninja-mac mac-arm64: Provide an arm64-native ninja-mac for builds in ¼ of the time 5 years ago
ninja.exe
ninjalog.README.md
ninjalog_uploader.py ninjalog_uploader: ignore http.client.RemoteDisconnected 4 years ago
ninjalog_uploader_wrapper.py ninjalog_uploader_wrapper: do not use binary read/write for json 4 years ago
owners.py Change to slash separator to fix a bug on Windows in owners.py 4 years ago
owners_client.py Reland "presubmit: Skip owners checks if code-owners plugin is enabled." 4 years ago
owners_finder.py owners_finder: Use code-owners plugin if available. 4 years ago
pinpoint Add revert instructions 4 years ago
pinpoint.bat Add revert instructions 4 years ago
post_build_ninja_summary.py autoninja: use pure python3 to get build id and for post_build_ninja_summary.py 4 years ago
presubmit_canned_checks.py Add pylint-2.7 4 years ago
presubmit_canned_checks_test.py Warn user in case they use commit messages with "Bug=" instead of "Bug:" 4 years ago
presubmit_canned_checks_test_mocks.py Warn user in case they use commit messages with "Bug=" instead of "Bug:" 4 years ago
presubmit_support.py Remove unused function GetPreferredTryMasters 4 years ago
profile.xml
prpc Add revert instructions 4 years ago
prpc.bat Add revert instructions 4 years ago
pylint
pylint-1.5 pylint: roll six to 1.15.0. 4 years ago
pylint-1.5.bat Add an option to specify pylint version 4 years ago
pylint-1.6 pylint: roll six to 1.15.0. 4 years ago
pylint-1.7 pylint: roll six to 1.15.0. 4 years ago
pylint-1.8 pylint: roll six to 1.15.0. 4 years ago
pylint-1.9 pylint: roll six to 1.15.0. 4 years ago
pylint-2.6 Explicitly set python version for pylint 2.6 4 years ago
pylint-2.6.bat Get pylint-2.6 to work under vpython3 on Windows. 4 years ago
pylint-2.7 Add pylint-2.7 4 years ago
pylint-2.7.bat Add pylint-2.7 4 years ago
pylint.bat
pylint_main.py Don't make depot_tools pylintrc override local pylint configs. 4 years ago
pylintrc CodeInclusion: Rename whitelist/blacklist -> allowlist/blocklist 5 years ago
python_runner.sh Make Python 3 default on Windows 5 years ago
rdb Add revert instructions 4 years ago
rdb.bat Add revert instructions 4 years ago
rdb_wrapper.py [resultdb] use requests.Session in rdb_wrapper 5 years ago
repo repo: restore fstrings for Python 3.6 4 years ago
repo_launcher repo: update launcher 4 years ago
roll-dep Make Python 3 default on Windows 5 years ago
roll-dep.bat Make Python 3 default on Windows 5 years ago
roll_dep.py Support main branch as default branch in roll-dep 4 years ago
rustfmt.py [rust] [depot_tools] Minimal `rustfmt` support for `git cl format`. 4 years ago
scm.py Refresh remote HEAD if matches legacy default 4 years ago
setup_color.py setup_color: Disable colorama on pre-Windows-10 5 years ago
split_cl.py Update format of `git cl split` 4 years ago
subcommand.py Run spellchecker on depot_tools 5 years ago
subprocess2.py [subprocess2] Replace VOID with DEVNULL 5 years ago
update_depot_tools Fetch all refs/heads/* on depot_tools update 4 years ago
update_depot_tools.bat Fetch all refs/heads/* on depot_tools update 4 years ago
update_depot_tools_toggle.py
upload_metrics.py metrics: Report bot metrics if DEPOT_TOOLS_REPORT_BUILD is set 4 years ago
upload_to_google_storage.py Set cache-control when uploading to google storage 4 years ago
vpython Add revert instructions 4 years ago
vpython.bat Add revert instructions 4 years ago
vpython3 depot_tools: Simplify MinGW check. 5 years ago
vpython3.bat Fix git-* commands when using python3 on Win 5 years ago
watchlists.py update stale codereview.chromium.org links 4 years ago
weekly Replace non-inclusive terms 5 years ago
whitespace.txt Change whitespace.txt 4 years ago
win32imports.py Reland "Use OS level locking in git_cache.py" 5 years ago
wtf
yapf Run yapf with vpython3 4 years ago
yapf.bat Run yapf with vpython3 4 years ago

README.md

depot_tools

Tools for working with Chromium development. It requires python 2.7 or 3.8 for python 3 support.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.