aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '278a25d2f1'
${ noResults }
depot_tools/tests
History
tandrii@chromium.org 278a25d2f1 Reland of git cl: Rework Changelist class for Rietveld/Gerrit use. (patchset #1 id:1 of https://codereview.chromium.org/1840833002/ ) 
Reason for revert:
with a fix.

Original issue's description:
> Revert of git cl: Rework Changelist class for Rietveld/Gerrit use. (patchset #3 id:40001 of https://codereview.chromium.org/1830973003/ )
> 
> Reason for revert:
> Speculative revert, see crbug.com/598428.
> 
> Original issue's description:
> > git cl: Rework Changelist class for Rietveld/Gerrit use.
> > 
> > This adds pluggable codereview-specific implementations into
> > Changelist class. The specific implementation is chosen at
> > Changelist automatically, with Rietveld being default for
> > backwards compatibility.
> > 
> > Gerrit implementation for Gerrit is incomplete, and will be
> > added in later CLs. However, it is sufficient to ensure
> > current functionality of this tool is not diminished.
> > 
> > Sadly, the base class isn't completely free from Rietveld
> > assumptions because of presubmit_support. Apparently, PRESUBMIT
> > scripts can make use of Rietveld instance for RPCs directly.
> > This use doesn't make sense for Gerrit, which substitutes
> > rietveld instance with a dummy object, which raises exception
> > on any attribute access with a diagnostic message.
> > 
> > This also includes refactoring of some related code which
> > (ab)used ChangeList. Overall, this CL adds a few extra call to
> > git config in order to determine which codereview to use, but
> > but it shouldn't have any performance impact.
> > 
> > 
> > 
> > These is a reland of these 4 CLs + a fix.
> > patch from issue 1827523003 at patchset 20001 (http://crrev.com/1827523003#ps20001)
> > patch from issue 1830703004 at patchset 1 (http://crrev.com/1830703004#ps1)
> > patch from issue 1830923002 at patchset 60001 (http://crrev.com/1830923002#ps60001)
> > patch from issue 1805193002 at patchset 380001 (http://crrev.com/1805193002#ps380001)
> > 
> > 
> > 
> > R=machenbach@chromium.org,sergiyb@chromium.org,andybons@chromium.org
> > BUG=579160,597638
> > 
> > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299506
> 
> TBR=andybons@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,tandrii@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=579160,597638
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299515

TBR=andybons@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,dnj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579160,597638

Review URL: https://codereview.chromium.org/1844523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299528 0039d316-1c4b-4281-b951-d872f2087c98
 		9 years ago
..
gstools Scripts to download files from google storage based on sha1 sums 12 years ago
subversion_config Move commit-queue/checkout into depot_tools so it can be reused by the try server. 14 years ago
abandon.sh Enable OAuth2 by default. 10 years ago
basic.sh Make 'git cl status' report the current branch even if there's no active CL. 10 years ago
checkout_test.py Remove most svn related testing. 10 years ago
download_from_google_storage_unittests.py Reland 0c7d94eb9d9fa388bda0d74405c0928dceea22ff: Add support for tar.gz archive files to download from download_from_google_storage 10 years ago
fix_encoding_test.py Standardize the sys.path fix up and fix a few pylint warnings. 14 years ago
gclient_scm_test.py Remove most svn related testing. 10 years ago
gclient_smoketest.py Revert of git_cl/gclient: use python2 (patchset #3 id:40001 of https://codereview.chromium.org/1437773002/ ) 10 years ago
gclient_test.py The original assertions trigger pylint unreachable warnings, and they are replaced by fail() calls. 10 years ago
gclient_utils_test.py Make it possible to refer to github-style URLs. 11 years ago
git_cache_test.py Allow 'git cache fetch' to re-bootstrap. 10 years ago
git_cl_test.py Reland of git cl: Rework Changelist class for Rietveld/Gerrit use. (patchset #1 id:1 of https://codereview.chromium.org/1840833002/ ) 9 years ago
git_common_test.py git hyper-blame: Added approx. line number translation. 9 years ago
git_dates_test.py Added git hyper-blame, a tool that skips unwanted commits in git blame. 9 years ago
git_drover_test.py Support merging with conflicts with git-drover. 10 years ago
git_footers_test.py Gerrit git cl: fix change-id appending. 9 years ago
git_hyper_blame_test.py git hyper-blame: Added automatically ignoring revs from a file. 9 years ago
git_number_test.py Disable tests that break because of git 2.4 10 years ago
git_rebase_update_test.py Add better error messages to git_reparent_branch. 10 years ago
gsutil_test.py gsutil: Parallel-safe, specify target, add clean. 10 years ago
hooks.sh Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. 11 years ago
owners.sh Enable OAuth2 by default. 10 years ago
owners_finder_test.py An interactive tool to help find owners covering current change list. 12 years ago
owners_unittest.py Implement support for file: includes in OWNERS files. 10 years ago
patch.sh Enable OAuth2 by default. 10 years ago
patch_test.py Fix applying svn:executable on Windows. 13 years ago
post-dcommit-hook-test.sh Enable OAuth2 by default. 10 years ago
presubmit_unittest.py Remove build/c++11 from the set of linter rules ever used. 9 years ago
push-basic.sh Make 'git cl status' report the current branch even if there's no active CL. 10 years ago
push-from-logs.sh Enable OAuth2 by default. 10 years ago
recipes_test.py Manual roll of engine, removing coverage threshold! 10 years ago
rename.sh Enable OAuth2 by default. 10 years ago
rietveld_test.py Raise exceptions properly on HTTP errors from OAuthRpcServer (which is only used on bots) 9 years ago
sample_pre_commit_hook Move commit-queue/checkout into depot_tools so it can be reused by the try server. 14 years ago
save-description-on-failure.sh Enable OAuth2 by default. 10 years ago
scm_unittest.py Remove most svn related testing. 10 years ago
submit-from-new-dir.sh Enable OAuth2 by default. 10 years ago
submodule-merge-test.sh Enable OAuth2 by default. 10 years ago
subprocess2_test.py Fix many (but not all[1]) depot_tools tests on Windows. 12 years ago
test-lib.sh Fix test failures on Ubuntu/Trusty. 11 years ago
trychange_unittest.py Finally get rid of depot_tools' breakpad. 9 years ago
upload-local-tracking-branch.sh Enable OAuth2 by default. 10 years ago
upload-stale.sh Enable OAuth2 by default. 10 years ago
upload_to_google_storage_unittests.py Reland 0c7d94eb9d9fa388bda0d74405c0928dceea22ff: Add support for tar.gz archive files to download from download_from_google_storage 10 years ago
upstream.sh Invoke the bash shell via /usr/bin/env so that these scripts run on operating systems without /bin/bash too. 11 years ago
watchlists_unittest.py Create a new testing_support module to move utility modules there 14 years ago