You cannot select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
278a25d2f1
Reason for revert: with a fix. Original issue's description: > Revert of git cl: Rework Changelist class for Rietveld/Gerrit use. (patchset #3 id:40001 of https://codereview.chromium.org/1830973003/ ) > > Reason for revert: > Speculative revert, see crbug.com/598428. > > Original issue's description: > > git cl: Rework Changelist class for Rietveld/Gerrit use. > > > > This adds pluggable codereview-specific implementations into > > Changelist class. The specific implementation is chosen at > > Changelist automatically, with Rietveld being default for > > backwards compatibility. > > > > Gerrit implementation for Gerrit is incomplete, and will be > > added in later CLs. However, it is sufficient to ensure > > current functionality of this tool is not diminished. > > > > Sadly, the base class isn't completely free from Rietveld > > assumptions because of presubmit_support. Apparently, PRESUBMIT > > scripts can make use of Rietveld instance for RPCs directly. > > This use doesn't make sense for Gerrit, which substitutes > > rietveld instance with a dummy object, which raises exception > > on any attribute access with a diagnostic message. > > > > This also includes refactoring of some related code which > > (ab)used ChangeList. Overall, this CL adds a few extra call to > > git config in order to determine which codereview to use, but > > but it shouldn't have any performance impact. > > > > > > > > These is a reland of these 4 CLs + a fix. > > patch from issue 1827523003 at patchset 20001 (http://crrev.com/1827523003#ps20001) > > patch from issue 1830703004 at patchset 1 (http://crrev.com/1830703004#ps1) > > patch from issue 1830923002 at patchset 60001 (http://crrev.com/1830923002#ps60001) > > patch from issue 1805193002 at patchset 380001 (http://crrev.com/1805193002#ps380001) > > > > > > > > R=machenbach@chromium.org,sergiyb@chromium.org,andybons@chromium.org > > BUG=579160,597638 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299506 > > TBR=andybons@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,tandrii@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=579160,597638 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299515 TBR=andybons@chromium.org,machenbach@chromium.org,sergiyb@chromium.org,dnj@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=579160,597638 Review URL: https://codereview.chromium.org/1844523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299528 0039d316-1c4b-4281-b951-d872f2087c98 |
9 years ago | |
|---|---|---|
| bootstrap | 9 years ago | |
| fetch_configs | ||
| git-templates | ||
| git_utils | ||
| infra | 9 years ago | |
| luci_hacks | ||
| man | ||
| recipe_modules | 9 years ago | |
| support | ||
| testing_support | 9 years ago | |
| tests | 9 years ago | |
| third_party | ||
| win_toolchain | 9 years ago | |
| zsh-goodies | ||
| .gitignore | 9 years ago | |
| .style.yapf | ||
| LICENSE | ||
| OWNERS | ||
| PRESUBMIT.py | ||
| README | ||
| README.codereview | ||
| README.gclient | ||
| README.git-cl | ||
| README.testing | ||
| WATCHLISTS | ||
| annotated_gclient.py | ||
| apply_issue | ||
| apply_issue.bat | ||
| apply_issue.py | ||
| auth.py | ||
| breakpad.py | ||
| buildbucket.py | ||
| cbuildbot | ||
| checkout.py | ||
| chrome-update-create-task.bat | ||
| chrome-update.bat | ||
| chrome-update.py | ||
| chrome_set_ver | ||
| cit | ||
| cit.bat | ||
| cit.py | ||
| clang-format | ||
| clang-format.bat | ||
| clang_format.py | ||
| codereview.settings | 9 years ago | |
| commit_queue | ||
| commit_queue.bat | ||
| commit_queue.py | ||
| cpplint.bat | ||
| cpplint.py | ||
| cpplint_chromium.py | ||
| create-chromium-git-src | ||
| create-ntfs-junction.c | ||
| create-ntfs-junction.exe | ||
| cros | ||
| cros_sdk | ||
| dart_format.py | ||
| depot-tools-auth | ||
| depot-tools-auth.bat | ||
| depot-tools-auth.py | ||
| download_from_google_storage | ||
| download_from_google_storage.bat | ||
| download_from_google_storage.py | 9 years ago | |
| drover | ||
| drover.bat | ||
| drover.py | ||
| fetch | ||
| fetch.bat | ||
| fetch.py | ||
| fix_encoding.py | ||
| gcl | ||
| gcl.bat | ||
| gcl.py | ||
| gclient | ||
| gclient-new-workdir.py | ||
| gclient.bat | ||
| gclient.py | 9 years ago | |
| gclient_completion.sh | ||
| gclient_scm.py | ||
| gclient_utils.py | ||
| gerrit_util.py | 9 years ago | |
| git-auto-svn | ||
| git-bash | ||
| git-cache | ||
| git-cherry-pick-upload | ||
| git-cl | ||
| git-crrev-parse | ||
| git-crsync | ||
| git-drover | ||
| git-find-releases | ||
| git-footers | 10 years ago | |
| git-freeze | ||
| git-gs | ||
| git-hyper-blame | ||
| git-lkgr | ||
| git-map | ||
| git-map-branches | ||
| git-mark-merge-base | ||
| git-nav-downstream | ||
| git-nav-upstream | ||
| git-new-branch | ||
| git-number | ||
| git-rebase-update | ||
| git-rename-branch | ||
| git-reparent-branch | ||
| git-retry | ||
| git-runhooks | ||
| git-squash-branch | ||
| git-thaw | ||
| git-try | ||
| git-upstream-diff | ||
| git_auto_svn.py | ||
| git_cache.py | 9 years ago | |
| git_cherry_pick_upload.py | ||
| git_cl.py | 9 years ago | |
| git_common.py | ||
| git_dates.py | ||
| git_drover.py | ||
| git_find_releases.py | ||
| git_footers.py | 9 years ago | |
| git_freezer.py | ||
| git_hyper_blame.py | ||
| git_map.py | ||
| git_map_branches.py | 9 years ago | |
| git_mark_merge_base.py | ||
| git_nav_downstream.py | ||
| git_new_branch.py | ||
| git_number.py | ||
| git_rebase_update.py | ||
| git_rename_branch.py | ||
| git_reparent_branch.py | ||
| git_retry.py | ||
| git_squash_branch.py | ||
| git_try.py | ||
| git_upstream_diff.py | ||
| gn | ||
| gn.bat | ||
| gn.py | ||
| gsutil.py | ||
| hammer | ||
| hammer.bat | ||
| my_activity.py | ||
| my_reviews.py | ||
| ninja | ||
| ninja-linux32 | ||
| ninja-linux64 | ||
| ninja-mac | ||
| ninja.exe | ||
| owners.py | ||
| owners_finder.py | ||
| patch.py | ||
| presubmit_canned_checks.py | ||
| presubmit_support.py | 9 years ago | |
| profile.xml | ||
| pylint | ||
| pylint.py | ||
| pylintrc | ||
| python_runner.sh | ||
| recipes.py | ||
| repo | ||
| rietveld.py | ||
| roll-dep | ||
| roll-dep-svn | ||
| roll-dep-svn.bat | ||
| roll-dep.bat | ||
| roll_dep.py | ||
| roll_dep_svn.py | ||
| scm.py | ||
| subcommand.py | ||
| subprocess2.py | ||
| trychange.py | ||
| update_depot_tools | ||
| update_depot_tools.bat | ||
| upload_to_google_storage.py | 9 years ago | |
| watchlists.py | ||
| weekly | ||
| wtf | ||
README
This package contains tools for working with Chromium development.
The "gclient" wrapper knows how to keep this repository updated to
the latest versions of these tools as found at:
http://src.chromium.org/svn/trunk/tools/depot_tools
This package contains:
chrome-update-create-task.bat
Creates a scheduled task to do an automatic local chromium build every day.
cpplint.py
A copy of our linting tool which enforces Google style. Fetched from
http://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py
gcl
A tool for uploading and managing code reviews on the Chromium
project, using the Rietveld code review tool. More info at:
http://code.google.com/p/rietveld/
gclient
A script for managing a workspace with modular dependencies that
are each checked out independently from different repositories.
More info at:
http://code.google.com/p/gclient/
hammer
A wrapper script for building Chromium with the SCons software
construction tool. More info at:
http://www.scons.org/
Note: svn and python will be installed automatically if not accessible (on
Windows only).
To update this distribution manually, run .\update_depot_tools.bat on Windows,
or ./update_depot_tools on Linux or Mac.
To disable automatic updating, set the environment variable DEPOT_TOOLS_UPDATE=0