You cannot select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
 
 
 
 
Go to file
Bruce Dawson 09c232e7c0 Resolve git.bat to git.exe without using shell=True
In order for git to be run on Windows and ultimately run git.exe it is
normally necessary to pass shell=True to Popen or else invoke git.bat,
or both. However this means invoking cmd.exe every time we want to
invoke git.exe, which can end up being over 1,500 invocations of cmd.exe
when running the "update" stage of gclient sync. This makes the "update"
stage take about 1.45x as long to run - it's a significant overhead.
Even with optimizations to the update stage of gclient sync in the NOP
case this repeated invocation of cmd.exe still costs about 0.8 s of a
4.9 s "update" stage.

This change teaches git_common how to find git.exe instead of just
git.bat by parsing the .exe name out of the .bat file.

Bug: 332982922
Change-Id: I4e052444276d55c0496144b9816fe365a95a56d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5462405
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
1 year ago
bootstrap New cpython3 and vpython3 packages to depot_tools. 1 year ago
fetch_configs remove references to goma client repository 1 year ago
hooks pre-commit: do not ignore submodule when running diff-index 2 years ago
infra Roll recipe dependencies (trivial). 1 year ago
man Switch to using issues.chromium.org bug links 1 year ago
metadata metadata: treats CPEPrefix "unknown" as None 1 year ago
python-bin cipd/python: optimize cat usage 2 years ago
python2-bin cipd/python: optimize cat usage 2 years ago
recipes Roll recipe dependencies (trivial). 1 year ago
testing_support [git_cl.py] Remove all usage and messages around netrc. 1 year ago
tests [git_cl.py] Remove all usage and messages around netrc. 1 year ago
third_party schema: pull LICENSE whitespace trim from upstream 2 years ago
win_toolchain Revert "Reland "Add support for GCS deps"" 1 year ago
zsh-goodies
.cipd_impl.ps1 Import Get-FileHash from PowerShell's version specific path 2 years ago
.flake8 Add a config file for the flake8 linter. 2 years ago
.gitattributes Define main metadata validation functions 2 years ago
.gitignore autoninja: cache negative result of gcloud account check 2 years ago
.isort.cfg isort: make available to users 3 years ago
.style.yapf switch to 4 space indent 2 years ago
.vpython3 Update the CheckInfraFreeze canned check to use datetime & zoneinfo. 1 year ago
BUILD_OWNERS add siso wrapper 2 years ago
CROS_OWNERS CROS_OWNERS: switch to our common shared lists 3 years ago
DIR_METADATA
LICENSE
LUCI_OWNERS add peep-software-deploy team to luci owners 2 years ago
OWNERS remove goma CIPD package 1 year ago
PRESUBMIT.py [PRESUBMIT] Increase unit test timeout 2 years ago
README.gclient.md
README.git-cl.md
README.md Switch to using issues.chromium.org bug links 1 year ago
RECLIENT_OWNERS Add convenience wrapper for reclientreport for autoninja users 2 years ago
WATCHLISTS Update WATCHLISTS for ninja, siso and reclient changes 2 years ago
auth.py Fix multiline comment formatting 2 years ago
autoninja Revert^2 "autoninja.py: disallow external account from corp machine" 2 years ago
autoninja.bat Remove obsolete autoninja.bat comment 1 year ago
autoninja.py autoninja: fix behavior when passed args after '--' 1 year ago
autosiso Deprecate autosiso.bat and autosiso. 2 years ago
autosiso.bat Deprecate autosiso.bat and autosiso. 2 years ago
autosiso.py Revert "[siso] Limit remote jobs on Windows to 1000" 1 year ago
bazel [ChromiumOS] Add a launcher for Bazel 2 years ago
bazel.py switch to 4 space indent 2 years ago
bb Add revert instructions 4 years ago
bb.bat Add revert instructions 4 years ago
black black: add helper for formatting Python 3 years ago
bootstrap_python3 Use relative path for cipd 2 years ago
breakpad.py switch to 4 space indent 2 years ago
cbuildbot
cipd enable fetch and gclient to run on z/OS part 1 1 year ago
cipd.bat [cipd] Run cipd_impl.ps1 in constrained language mode 2 years ago
cipd_bin_setup.bat Revert "Retry switching to use CIPD ninja v1.8.2" 3 years ago
cipd_bin_setup.sh cipd_bin_setup: load cipd script instead of running it 2 years ago
cipd_client_version Update to 2.6.16 2 years ago
cipd_client_version.digests Update to 2.6.16 2 years ago
cipd_manifest.txt New vpython3 to depot_tools. 1 year ago
cipd_manifest.versions New vpython3 to depot_tools. 1 year ago
cipd_manifest_cros_python2.txt remove goma CIPD package 1 year ago
cipd_manifest_cros_python2.versions Redirect cros calls to py2.7 scripts to the vpython2.7 package. 3 years ago
clang-format Use py3 for remaining tools in depot_tools path 4 years ago
clang-format.bat Use py3 for remaining tools in depot_tools path 4 years ago
clang_format.py [depot_tools] Update clang_format.py with new path 1 year ago
codereview.settings
compile_single_file Make 'compile_single_file' use vpython3 1 year ago
compile_single_file.bat Make 'compile_single_file' use vpython3 1 year ago
compile_single_file.py Make 'compile_single_file' use vpython3 1 year ago
cpplint.bat Use python3 for cpplint and get_toolchain on Win 3 years ago
cpplint.py [cpplint] Update for c++20 1 year ago
cpplint_chromium.py switch to 4 space indent 2 years ago
cros cros: expand to cover more roots 2 years ago
cros_python2.vpython Redirect cros calls to py2.7 scripts to the vpython2.7 package. 3 years ago
cros_sdk
crosjobs Add revert instructions 4 years ago
detect_host_arch.py enable fetch and gclient to run on z/OS part 1 1 year ago
dirmd Add revert instructions 4 years ago
dirmd.bat Add revert instructions 4 years ago
download_from_google_storage Switch download_from_google_storage to py3 4 years ago
download_from_google_storage.bat use python3 for download_from_google_storage.bat 3 years ago
download_from_google_storage.py [depot_tools] Update GCS dotfile naming 1 year ago
ensure_bootstrap setup & share path to depot_tools checkout 2 years ago
fetch [py2] Drop envvar to run scripts with py2 2 years ago
fetch.bat [py2] Drop envvar to run scripts with py2 2 years ago
fetch.py Use shlex instead of pipes 1 year ago
gclient [py2] Drop envvar to run scripts with py2 2 years ago
gclient-new-workdir.py switch to 4 space indent 2 years ago
gclient.bat [py2] Drop envvar to run scripts with py2 2 years ago
gclient.py gclient: error if fetch command is called in non-git env 1 year ago
gclient_completion.sh
gclient_eval.py [gclient] remove output_file from gcs object setdep 1 year ago
gclient_paths.py Cache values in gclient_paths.py 2 years ago
gclient_scm.py Use git_common to call git 1 year ago
gclient_utils.py [gclient] Use lowercase and when merging conditions 1 year ago
gerrit Symlink gerrit CLI into depot_tools 2 years ago
gerrit_client.py [fix_encoding] Remove fix_encoding 1 year ago
gerrit_util.py [git_cl.py] Remove all usage and messages around netrc. 1 year ago
git-cache
git-cl
git-crrev-parse Fix git-crrev-parse to work with both master & main branches 4 years ago
git-drover
git-find-releases
git-footers
git-freeze
git-gs Enable searching starlark files with git gs. 2 years ago
git-hyper-blame
git-map
git-map-branches
git-mark-merge-base
git-nav-downstream
git-nav-upstream print slightly better message if git nav-upstream is not called in git repo 1 year ago
git-new-branch
git-number
git-rebase-update
git-rename-branch
git-reparent-branch
git-retry
git-runhooks Revert "Remove unused functionality in bot_update.py" 3 years ago
git-squash-branch
git-thaw
git-upstream-diff
git_cache.py error if git cache commands are called in cog env. 1 year ago
git_cl.py [git_cl.py] Remove all usage and messages around netrc. 1 year ago
git_cl_completion.sh
git_common.py Resolve git.bat to git.exe without using shell=True 1 year ago
git_completion.sh Bash autocompletion for 'git new-branch' and 'git reparent-branch' 2 years ago
git_dates.py Fix multiline comment formatting 2 years ago
git_find_releases.py fail gracefully if git find-releases is called in cog 1 year ago
git_footers.py fail gracefully if git footers is called in cog 1 year ago
git_freezer.py fail gracefully if git freeze or git thaw are called in cog 1 year ago
git_hyper_blame.py fail gracefully if git hyper-blame are called in cog 1 year ago
git_map.py fail gracefully if git map is called in cog 1 year ago
git_map_branches.py fail gracefully if git map-branches is called in cog 1 year ago
git_mark_merge_base.py fail gracefully if git mark-merge-base is called in cog 1 year ago
git_nav_downstream.py fail gracefully if git nav-downstream is called in cog 1 year ago
git_new_branch.py fail gracefully if git new-branch is called in cog 1 year ago
git_number.py Fix multiline comment formatting 2 years ago
git_rebase_update.py fail gracefully if git rebase-update is called in cog 1 year ago
git_rename_branch.py fail gracefully if git rename-branch is called in cog 1 year ago
git_reparent_branch.py fail gracefully if git reparent-branch is called in cog 1 year ago
git_retry.py Fix multiline comment formatting 2 years ago
git_squash_branch.py fail gracefully if git squash-branch is called in cog 1 year ago
git_upstream_diff.py fail gracefully if git upstream-diff is called in cog 1 year ago
gn gn: Call gn.bat in msysgit on Windows. 4 years ago
gn.bat Revert "Call python3.bat explicitly from gn.bat on Windows." 4 years ago
gn.py Reland "[depot_tools] Support both gn paths in gn.py" 1 year ago
google-java-format [depot_tools] add google_java_format.py 1 year ago
google-java-format.bat [depot_tools] add google_java_format.py 1 year ago
google_java_format.py [depot_tools] add google_java_format.py 1 year ago
gsutil.py [gsutil] Fix race when downloading gsutil 1 year ago
gsutil.py.bat Reland "Make depot_tools scripts return exit codes properly on all platforms." 3 years ago
gsutil.vpython3 Reland "Update gsutil to use gsutil version 4.68" 3 years ago
isort switch to 4 space indent 2 years ago
led Add revert instructions 4 years ago
led.bat Add revert instructions 4 years ago
lockfile.py [gsutil] Fix race when downloading gsutil 1 year ago
luci-auth Add revert instructions 4 years ago
luci-auth.bat Add revert instructions 4 years ago
lucicfg Add revert instructions 4 years ago
lucicfg.bat Add revert instructions 4 years ago
mac_toolchain
metrics.README.md
metrics.py Clean up stacked-changes dogfood 1 year ago
metrics_utils.py remove references to goma client repository 1 year ago
my_activity.py [fix_encoding] Remove fix_encoding 1 year ago
ninja Revert "Use depot_tools python3 to call ninja.py" 3 years ago
ninja.bat Add single file compile support for Windows in ninja wrappers 3 years ago
ninja.py Add "ninja -t targets" to the command allowlist 1 year ago
ninja_reclient.py apply black and `git cl format` for ninja related python files 2 years ago
ninjalog.README.md remove references to goma 1 year ago
ninjalog_uploader.py remove references to goma 1 year ago
ninjalog_uploader_wrapper.py apply black and `git cl format` for ninja related python files 2 years ago
owners_client.py [owners] Limit number of concurrent Gerrit connections 2 years ago
owners_finder.py Remove __future__ imports 2 years ago
pinpoint Add revert instructions 4 years ago
pinpoint.bat Add revert instructions 4 years ago
post_build_ninja_summary.py check `siso summary` 2 years ago
presubmit_canned_checks.py [presubmit] Add check for recursedeps entries 1 year ago
presubmit_diff.py Handle diff without chunk header 1 year ago
presubmit_support.py Provide useful submodule info for all Change classes 1 year ago
profile.xml
prpc Add revert instructions 4 years ago
prpc.bat Add revert instructions 4 years ago
pylint-2.6 switch to 4 space indent 2 years ago
pylint-2.6.bat Get pylint-2.6 to work under vpython3 on Windows. 4 years ago
pylint-2.7 switch to 4 space indent 2 years ago
pylint-2.7.bat Add pylint-2.7 4 years ago
pylint-2.17 pylint: Add pylint 2.17 2 years ago
pylint-2.17.bat pylint: Add pylint 2.17 2 years ago
pylint_main.py Remove __future__ imports 2 years ago
pylintrc
pylintrc-2.17 pylint: Add pylint 2.17 2 years ago
python_runner.sh [py2] Drop envvar to run scripts with py2 2 years ago
rdb Add revert instructions 4 years ago
rdb.bat Add revert instructions 4 years ago
rdb_wrapper.py Fix multiline comment formatting 2 years ago
reclient_helper.py Remove a space between a value and its unit 1 year ago
reclient_metrics Add reclient_metrics command 2 years ago
reclient_metrics.README.md [reclient] Update reclient_metrics.README.md to reflect that we collect googler hostnames 2 years ago
reclient_metrics.bat Add reclient_metrics command 2 years ago
reclient_metrics.py Fix multiline comment formatting 2 years ago
reclientreport Add convenience wrapper for reclientreport for autoninja users 2 years ago
reclientreport.bat Remove unnesisary quotes from propagated args in reclientreport.bat 2 years ago
reclientreport.py [reclient] Keep previous 5 builds worth of logs 2 years ago
repo repo: stop using our repo fork 1 year ago
repo_launcher [repo_launcher] Update repo_launcher to v2.45 1 year ago
roll-dep [py2] Drop envvar to run scripts with py2 2 years ago
roll-dep.bat [py2] Drop envvar to run scripts with py2 2 years ago
roll_dep.py Hide git log by default if rolling from a non-public host 1 year ago
rustfmt.py switch to 4 space indent 2 years ago
scm.py Use git_common to call git 1 year ago
setup_color.py Fix multiline comment formatting 2 years ago
siso add siso wrapper 2 years ago
siso.bat add siso wrapper 2 years ago
siso.py Reland "siso.py check ninja marker" 1 year ago
split_cl.py split_cl: do not prepend '/' in $directory 1 year ago
subcommand.py Fix multiline comment formatting 2 years ago
subprocess2.py Fix multiline comment formatting 2 years ago
swift-format Support git cl formatting for swift files 3 years ago
swift_format.py switch to 4 space indent 2 years ago
update_depot_tools remove goma CIPD package 1 year ago
update_depot_tools.bat remove goma CIPD package 1 year ago
update_depot_tools_toggle.py switch to 4 space indent 2 years ago
upload_metrics.py switch to 4 space indent 2 years ago
upload_to_google_storage.py Revert "Reland "Add support for GCS deps"" 1 year ago
upload_to_google_storage_first_class.py Remove <> from upload_to_google_storage_first_class output 1 year ago
utils.py switch to 4 space indent 2 years ago
vpython3 vpython: clear DEPOT_TOOLS_DIR before running scripts 2 years ago
vpython3.bat Use the bundled interpreter instead of passing -vpython-interpreter. 3 years ago
watchlists.py Fix multiline comment formatting 2 years ago
weekly Remove __future__ imports 2 years ago
whitespace.txt Change whitespace.txt 4 years ago
win32imports.py switch to 4 space indent 2 years ago
wtf Remove __future__ imports 2 years ago
yapf Always run yapf with vpython3. 1 year ago
yapf.bat Run yapf with vpython3 4 years ago

README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.