In order for git to be run on Windows and ultimately run git.exe it is normally necessary to pass shell=True to Popen or else invoke git.bat, or both. However this means invoking cmd.exe every time we want to invoke git.exe, which can end up being over 1,500 invocations of cmd.exe when running the "update" stage of gclient sync. This makes the "update" stage take about 1.45x as long to run - it's a significant overhead. Even with optimizations to the update stage of gclient sync in the NOP case this repeated invocation of cmd.exe still costs about 0.8 s of a 4.9 s "update" stage. This change teaches git_common how to find git.exe instead of just git.bat by parsing the .exe name out of the .bat file. Bug: 332982922 Change-Id: I4e052444276d55c0496144b9816fe365a95a56d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5462405 Reviewed-by: Josip Sokcevic <sokcevic@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> |
1 year ago | |
---|---|---|
bootstrap | 1 year ago | |
fetch_configs | 1 year ago | |
hooks | 2 years ago | |
infra | 1 year ago | |
man | 1 year ago | |
metadata | 1 year ago | |
python-bin | 2 years ago | |
python2-bin | 2 years ago | |
recipes | 1 year ago | |
testing_support | 1 year ago | |
tests | 1 year ago | |
third_party | 2 years ago | |
win_toolchain | 1 year ago | |
zsh-goodies | ||
.cipd_impl.ps1 | 2 years ago | |
.flake8 | 2 years ago | |
.gitattributes | 2 years ago | |
.gitignore | 2 years ago | |
.isort.cfg | 3 years ago | |
.style.yapf | 2 years ago | |
.vpython3 | 1 year ago | |
BUILD_OWNERS | 2 years ago | |
CROS_OWNERS | 3 years ago | |
DIR_METADATA | ||
LICENSE | ||
LUCI_OWNERS | 2 years ago | |
OWNERS | 1 year ago | |
PRESUBMIT.py | 2 years ago | |
README.gclient.md | ||
README.git-cl.md | ||
README.md | 1 year ago | |
RECLIENT_OWNERS | 2 years ago | |
WATCHLISTS | 2 years ago | |
auth.py | 2 years ago | |
autoninja | 2 years ago | |
autoninja.bat | 1 year ago | |
autoninja.py | 1 year ago | |
autosiso | 2 years ago | |
autosiso.bat | 2 years ago | |
autosiso.py | 1 year ago | |
bazel | 2 years ago | |
bazel.py | 2 years ago | |
bb | 4 years ago | |
bb.bat | 4 years ago | |
black | 3 years ago | |
bootstrap_python3 | 2 years ago | |
breakpad.py | 2 years ago | |
cbuildbot | ||
cipd | 1 year ago | |
cipd.bat | 2 years ago | |
cipd_bin_setup.bat | 3 years ago | |
cipd_bin_setup.sh | 2 years ago | |
cipd_client_version | 2 years ago | |
cipd_client_version.digests | 2 years ago | |
cipd_manifest.txt | 1 year ago | |
cipd_manifest.versions | 1 year ago | |
cipd_manifest_cros_python2.txt | 1 year ago | |
cipd_manifest_cros_python2.versions | 3 years ago | |
clang-format | 4 years ago | |
clang-format.bat | 4 years ago | |
clang_format.py | 1 year ago | |
codereview.settings | ||
compile_single_file | 1 year ago | |
compile_single_file.bat | 1 year ago | |
compile_single_file.py | 1 year ago | |
cpplint.bat | 3 years ago | |
cpplint.py | 1 year ago | |
cpplint_chromium.py | 2 years ago | |
cros | 2 years ago | |
cros_python2.vpython | 3 years ago | |
cros_sdk | ||
crosjobs | 4 years ago | |
detect_host_arch.py | 1 year ago | |
dirmd | 4 years ago | |
dirmd.bat | 4 years ago | |
download_from_google_storage | 4 years ago | |
download_from_google_storage.bat | 3 years ago | |
download_from_google_storage.py | 1 year ago | |
ensure_bootstrap | 2 years ago | |
fetch | 2 years ago | |
fetch.bat | 2 years ago | |
fetch.py | 1 year ago | |
gclient | 2 years ago | |
gclient-new-workdir.py | 2 years ago | |
gclient.bat | 2 years ago | |
gclient.py | 1 year ago | |
gclient_completion.sh | ||
gclient_eval.py | 1 year ago | |
gclient_paths.py | 2 years ago | |
gclient_scm.py | 1 year ago | |
gclient_utils.py | 1 year ago | |
gerrit | 2 years ago | |
gerrit_client.py | 1 year ago | |
gerrit_util.py | 1 year ago | |
git-cache | ||
git-cl | ||
git-crrev-parse | 4 years ago | |
git-drover | ||
git-find-releases | ||
git-footers | ||
git-freeze | ||
git-gs | 2 years ago | |
git-hyper-blame | ||
git-map | ||
git-map-branches | ||
git-mark-merge-base | ||
git-nav-downstream | ||
git-nav-upstream | 1 year ago | |
git-new-branch | ||
git-number | ||
git-rebase-update | ||
git-rename-branch | ||
git-reparent-branch | ||
git-retry | ||
git-runhooks | 3 years ago | |
git-squash-branch | ||
git-thaw | ||
git-upstream-diff | ||
git_cache.py | 1 year ago | |
git_cl.py | 1 year ago | |
git_cl_completion.sh | ||
git_common.py | 1 year ago | |
git_completion.sh | 2 years ago | |
git_dates.py | 2 years ago | |
git_find_releases.py | 1 year ago | |
git_footers.py | 1 year ago | |
git_freezer.py | 1 year ago | |
git_hyper_blame.py | 1 year ago | |
git_map.py | 1 year ago | |
git_map_branches.py | 1 year ago | |
git_mark_merge_base.py | 1 year ago | |
git_nav_downstream.py | 1 year ago | |
git_new_branch.py | 1 year ago | |
git_number.py | 2 years ago | |
git_rebase_update.py | 1 year ago | |
git_rename_branch.py | 1 year ago | |
git_reparent_branch.py | 1 year ago | |
git_retry.py | 2 years ago | |
git_squash_branch.py | 1 year ago | |
git_upstream_diff.py | 1 year ago | |
gn | 4 years ago | |
gn.bat | 4 years ago | |
gn.py | 1 year ago | |
google-java-format | 1 year ago | |
google-java-format.bat | 1 year ago | |
google_java_format.py | 1 year ago | |
gsutil.py | 1 year ago | |
gsutil.py.bat | 3 years ago | |
gsutil.vpython3 | 3 years ago | |
isort | 2 years ago | |
led | 4 years ago | |
led.bat | 4 years ago | |
lockfile.py | 1 year ago | |
luci-auth | 4 years ago | |
luci-auth.bat | 4 years ago | |
lucicfg | 4 years ago | |
lucicfg.bat | 4 years ago | |
mac_toolchain | ||
metrics.README.md | ||
metrics.py | 1 year ago | |
metrics_utils.py | 1 year ago | |
my_activity.py | 1 year ago | |
ninja | 3 years ago | |
ninja.bat | 3 years ago | |
ninja.py | 1 year ago | |
ninja_reclient.py | 2 years ago | |
ninjalog.README.md | 1 year ago | |
ninjalog_uploader.py | 1 year ago | |
ninjalog_uploader_wrapper.py | 2 years ago | |
owners_client.py | 2 years ago | |
owners_finder.py | 2 years ago | |
pinpoint | 4 years ago | |
pinpoint.bat | 4 years ago | |
post_build_ninja_summary.py | 2 years ago | |
presubmit_canned_checks.py | 1 year ago | |
presubmit_diff.py | 1 year ago | |
presubmit_support.py | 1 year ago | |
profile.xml | ||
prpc | 4 years ago | |
prpc.bat | 4 years ago | |
pylint-2.6 | 2 years ago | |
pylint-2.6.bat | 4 years ago | |
pylint-2.7 | 2 years ago | |
pylint-2.7.bat | 4 years ago | |
pylint-2.17 | 2 years ago | |
pylint-2.17.bat | 2 years ago | |
pylint_main.py | 2 years ago | |
pylintrc | ||
pylintrc-2.17 | 2 years ago | |
python_runner.sh | 2 years ago | |
rdb | 4 years ago | |
rdb.bat | 4 years ago | |
rdb_wrapper.py | 2 years ago | |
reclient_helper.py | 1 year ago | |
reclient_metrics | 2 years ago | |
reclient_metrics.README.md | 2 years ago | |
reclient_metrics.bat | 2 years ago | |
reclient_metrics.py | 2 years ago | |
reclientreport | 2 years ago | |
reclientreport.bat | 2 years ago | |
reclientreport.py | 2 years ago | |
repo | 1 year ago | |
repo_launcher | 1 year ago | |
roll-dep | 2 years ago | |
roll-dep.bat | 2 years ago | |
roll_dep.py | 1 year ago | |
rustfmt.py | 2 years ago | |
scm.py | 1 year ago | |
setup_color.py | 2 years ago | |
siso | 2 years ago | |
siso.bat | 2 years ago | |
siso.py | 1 year ago | |
split_cl.py | 1 year ago | |
subcommand.py | 2 years ago | |
subprocess2.py | 2 years ago | |
swift-format | 3 years ago | |
swift_format.py | 2 years ago | |
update_depot_tools | 1 year ago | |
update_depot_tools.bat | 1 year ago | |
update_depot_tools_toggle.py | 2 years ago | |
upload_metrics.py | 2 years ago | |
upload_to_google_storage.py | 1 year ago | |
upload_to_google_storage_first_class.py | 1 year ago | |
utils.py | 2 years ago | |
vpython3 | 2 years ago | |
vpython3.bat | 3 years ago | |
watchlists.py | 2 years ago | |
weekly | 2 years ago | |
whitespace.txt | 4 years ago | |
win32imports.py | 2 years ago | |
wtf | 2 years ago | |
yapf | 1 year ago | |
yapf.bat | 4 years ago |
README.md
depot_tools
Tools for working with Chromium development. It requires python 3.8.
Tools
The most important tools are:
fetch
: Agclient
wrapper to checkout a project. Usefetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Usegit cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools
updates itself automatically when running gclient
tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
or
run ./update_depot_tools_toggle.py --disable
.
To update package manually, run update_depot_tools.bat
on Windows,
or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py
was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py
in depot_tools
, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.