Previously EnsureCanUploadPatchset only had a working implementation for the CookiesAuthenticator, relying on being able to parse the user name out of the .gitcookies file. Additionally, the previous implementation assumed that you would always authenticate as your primary Gerrit account OR you had a matching `user.email` gitconfig entry, even though neither of these is a strict requirement for the upload to work. The new implementation still short-circuits if issue_owner matches the configured user.email, but other than this it just asks Gerrit what the full list of linked emails is for the currently authenticated account. The new approach is not only correct, but will now work for all auth schemes in exactly the same way. When the accounts do mismatch, you will now see output like: ``` WARNING: Change 5590262 is owned by iannucci@chromium.org, but Gerrit knows you as: * user@example.org * other.user@example.com * primary@real.example.com (preferred) Uploading may fail due to lack of permissions. ``` R=ayatane@chromium.org, yiwzhang@google.com Bug: 336351842 Change-Id: I89c1b121c9110e00d1348884aaf025fc783542d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5590262 Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Reviewed-by: Yiwei Zhang <yiwzhang@google.com> Auto-Submit: Robbie Iannucci <iannucci@chromium.org> |
10 months ago | |
---|---|---|
bootstrap | 1 year ago | |
fetch_configs | 12 months ago | |
hooks | 2 years ago | |
infra | 10 months ago | |
man | 10 months ago | |
metadata | 1 year ago | |
python-bin | 2 years ago | |
python2-bin | 2 years ago | |
recipes | 10 months ago | |
testing_support | 11 months ago | |
tests | 10 months ago | |
third_party | 2 years ago | |
win_toolchain | 1 year ago | |
zsh-goodies | ||
.cipd_impl.ps1 | 2 years ago | |
.flake8 | 2 years ago | |
.gitattributes | 11 months ago | |
.gitignore | 11 months ago | |
.isort.cfg | 3 years ago | |
.style.yapf | 2 years ago | |
.vpython3 | 1 year ago | |
BUILD_OWNERS | 2 years ago | |
CROS_OWNERS | 3 years ago | |
DIR_METADATA | 4 years ago | |
LICENSE | ||
LUCI_OWNERS | 2 years ago | |
OWNERS | 1 year ago | |
PRESUBMIT.py | 1 year ago | |
README.gclient.md | ||
README.git-cl.md | 4 years ago | |
README.md | 1 year ago | |
RECLIENT_OWNERS | 2 years ago | |
WATCHLISTS | 2 years ago | |
auth.py | 11 months ago | |
autoninja | 1 year ago | |
autoninja.bat | 1 year ago | |
autoninja.py | 11 months ago | |
bazel | 2 years ago | |
bazel.py | 2 years ago | |
bb | 4 years ago | |
bb.bat | 4 years ago | |
black | 3 years ago | |
bootstrap_python3 | 2 years ago | |
breakpad.py | 2 years ago | |
cbuildbot | 6 years ago | |
cipd | 1 year ago | |
cipd.bat | 2 years ago | |
cipd_bin_setup.bat | 3 years ago | |
cipd_bin_setup.sh | 2 years ago | |
cipd_client_version | 1 year ago | |
cipd_client_version.digests | 1 year ago | |
cipd_manifest.txt | 11 months ago | |
cipd_manifest.versions | 11 months ago | |
cipd_manifest_cros_python2.txt | 1 year ago | |
cipd_manifest_cros_python2.versions | 2 years ago | |
clang-format | 4 years ago | |
clang-format.bat | 4 years ago | |
clang_format.py | 11 months ago | |
codereview.settings | 4 years ago | |
compile_single_file | 1 year ago | |
compile_single_file.bat | 1 year ago | |
compile_single_file.py | 1 year ago | |
cpplint.bat | 3 years ago | |
cpplint.py | 1 year ago | |
cpplint_chromium.py | 2 years ago | |
cros | 1 year ago | |
cros_python2.vpython | 2 years ago | |
cros_sdk | 6 years ago | |
detect_host_arch.py | 1 year ago | |
dirmd | 4 years ago | |
dirmd.bat | 4 years ago | |
download_from_google_storage | 4 years ago | |
download_from_google_storage.bat | 3 years ago | |
download_from_google_storage.py | 1 year ago | |
ensure_bootstrap | 2 years ago | |
fetch | 2 years ago | |
fetch.bat | 2 years ago | |
fetch.py | 11 months ago | |
gclient | 2 years ago | |
gclient-new-workdir.py | 11 months ago | |
gclient.bat | 2 years ago | |
gclient.py | 11 months ago | |
gclient_completion.sh | ||
gclient_eval.py | 12 months ago | |
gclient_paths.py | 2 years ago | |
gclient_scm.py | 11 months ago | |
gclient_utils.py | 11 months ago | |
gerrit | 2 years ago | |
gerrit_client.py | 1 year ago | |
gerrit_util.py | 10 months ago | |
git-cache | 5 years ago | |
git-cl | 5 years ago | |
git-credential-luci | 11 months ago | |
git-credential-luci.bat | 11 months ago | |
git-crrev-parse | 4 years ago | |
git-drover | 5 years ago | |
git-find-releases | 5 years ago | |
git-footers | 5 years ago | |
git-freeze | 5 years ago | |
git-gs | 1 year ago | |
git-hyper-blame | 5 years ago | |
git-map | 5 years ago | |
git-map-branches | 5 years ago | |
git-mark-merge-base | 5 years ago | |
git-nav-downstream | 5 years ago | |
git-nav-upstream | 12 months ago | |
git-new-branch | 5 years ago | |
git-number | 5 years ago | |
git-rebase-update | 5 years ago | |
git-rename-branch | 5 years ago | |
git-reparent-branch | 5 years ago | |
git-retry | 5 years ago | |
git-runhooks | 3 years ago | |
git-squash-branch | 5 years ago | |
git-thaw | 5 years ago | |
git-upstream-diff | 5 years ago | |
git_cache.py | 12 months ago | |
git_cl.py | 10 months ago | |
git_cl_completion.sh | 5 years ago | |
git_common.py | 10 months ago | |
git_completion.sh | 2 years ago | |
git_dates.py | 1 year ago | |
git_find_releases.py | 12 months ago | |
git_footers.py | 12 months ago | |
git_freezer.py | 12 months ago | |
git_hyper_blame.py | 12 months ago | |
git_map.py | 12 months ago | |
git_map_branches.py | 12 months ago | |
git_mark_merge_base.py | 12 months ago | |
git_nav_downstream.py | 12 months ago | |
git_new_branch.py | 12 months ago | |
git_number.py | 1 year ago | |
git_rebase_update.py | 12 months ago | |
git_rename_branch.py | 12 months ago | |
git_reparent_branch.py | 12 months ago | |
git_retry.py | 1 year ago | |
git_squash_branch.py | 12 months ago | |
git_upstream_diff.py | 12 months ago | |
gn | 4 years ago | |
gn.bat | 4 years ago | |
gn.py | 1 year ago | |
google-java-format | 12 months ago | |
google-java-format.bat | 12 months ago | |
google_java_format.py | 11 months ago | |
gsutil.py | 1 year ago | |
gsutil.py.bat | 3 years ago | |
gsutil.vpython3 | 3 years ago | |
isort | 2 years ago | |
led | 4 years ago | |
led.bat | 4 years ago | |
lockfile.py | 1 year ago | |
luci-auth | 4 years ago | |
luci-auth.bat | 4 years ago | |
lucicfg | 4 years ago | |
lucicfg.bat | 4 years ago | |
mac_toolchain | ||
metrics.README.md | 4 years ago | |
metrics.py | 11 months ago | |
metrics_utils.py | 12 months ago | |
my_activity.py | 1 year ago | |
newauth.py | 10 months ago | |
ninja | 2 years ago | |
ninja.bat | 2 years ago | |
ninja.py | 12 months ago | |
ninja_reclient.py | 1 year ago | |
ninjalog.README.md | 11 months ago | |
ninjalog_uploader.py | 11 months ago | |
ninjalog_uploader_wrapper.py | 11 months ago | |
owners_client.py | 1 year ago | |
owners_finder.py | 2 years ago | |
pinpoint | 4 years ago | |
pinpoint.bat | 4 years ago | |
post_build_ninja_summary.py | 11 months ago | |
presubmit_canned_checks.py | 10 months ago | |
presubmit_diff.py | 1 year ago | |
presubmit_support.py | 10 months ago | |
prpc | 4 years ago | |
prpc.bat | 4 years ago | |
pylint-2.6 | 2 years ago | |
pylint-2.6.bat | 4 years ago | |
pylint-2.7 | 2 years ago | |
pylint-2.7.bat | 4 years ago | |
pylint-2.17 | 1 year ago | |
pylint-2.17.bat | 1 year ago | |
pylint_main.py | 2 years ago | |
pylintrc | 5 years ago | |
pylintrc-2.17 | 1 year ago | |
python_runner.sh | 2 years ago | |
rdb | 4 years ago | |
rdb.bat | 4 years ago | |
rdb_wrapper.py | 1 year ago | |
reclient_helper.py | 12 months ago | |
reclient_metrics | 2 years ago | |
reclient_metrics.README.md | 2 years ago | |
reclient_metrics.bat | 2 years ago | |
reclient_metrics.py | 11 months ago | |
reclientreport | 2 years ago | |
reclientreport.bat | 2 years ago | |
reclientreport.py | 2 years ago | |
repo | 11 months ago | |
repo_launcher | 1 year ago | |
roll-dep | 2 years ago | |
roll-dep.bat | 2 years ago | |
roll_dep.py | 11 months ago | |
rustfmt.py | 2 years ago | |
scm.py | 10 months ago | |
setup_color.py | 1 year ago | |
siso | 2 years ago | |
siso.bat | 2 years ago | |
siso.py | 11 months ago | |
split_cl.py | 12 months ago | |
subcommand.py | 1 year ago | |
subprocess2.py | 1 year ago | |
swift-format | 3 years ago | |
swift_format.py | 2 years ago | |
update_depot_tools | 1 year ago | |
update_depot_tools.bat | 1 year ago | |
update_depot_tools_toggle.py | 2 years ago | |
upload_metrics.py | 2 years ago | |
upload_to_google_storage.py | 1 year ago | |
upload_to_google_storage_first_class.py | 11 months ago | |
utils.py | 11 months ago | |
vpython3 | 2 years ago | |
vpython3.bat | 3 years ago | |
watchlists.py | 1 year ago | |
whitespace.txt | 4 years ago | |
win32imports.py | 2 years ago | |
yapf | 1 year ago | |
yapf.bat | 4 years ago |
README.md
depot_tools
Tools for working with Chromium development. It requires python 3.8.
Tools
The most important tools are:
fetch
: Agclient
wrapper to checkout a project. Usefetch --help
for more details.gclient
: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Usegclient help
for more details and README.gclient.md.git cl
: A code review tool to interact with Rietveld or Gerrit. Usegit cl help
for more details and README.git-cl.md.roll-dep
: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.
There are a lot of git utilities included.
Updating
depot_tools
updates itself automatically when running gclient
tool. To
disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0
or
run ./update_depot_tools_toggle.py --disable
.
To update package manually, run update_depot_tools.bat
on Windows,
or ./update_depot_tools
on Linux or Mac.
On Windows only, running gclient
will install git
and python
.
Contributing
To contribute change for review:
git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>
# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail
# Edit change description if needed.
git cl desc
# If change is approved, flag it to be committed.
git cl set-commit
# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"
See also open bugs, open reviews, forum or report problems.
cpplint.py
Until 2018, our cpplint.py
was a copy of the upstream version at
https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that
repository is not maintained any more.
If you want to update cpplint.py
in depot_tools
, just upload a patch to do
so. We will figure out a long-term strategy via issue https://crbug.com/916550.
Note that the cpplint.py
here is also used by the Tricium
analyzer,
so if the cpplint.py here changes, we should also update the copy used there.