Commit Graph

10600 Commits (f318db0055b10ab5c4f6f9566d826c7adaf005e9)
 

Author SHA1 Message Date
Josip Sokcevic f318db0055 [GCS] Allow upload of the entire directory to GS
Allow users to upload the entire directory by providing . or ./ as the
path.

R=jojwang@google.com

Bug: 343199633
Change-Id: Idf2a6b27577bb9ef153e096f00367084daab9239
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5578674
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
11 months ago
Robert Iannucci a85dcffff4 [git_cl] Refactor away a use of isinstance.
Previously when composing a debugging trace, it would use an
isinstance check to special-case inclusion of a gitcookies file.

This CL refactors this to be part of the Authenticator API, instead,
which means that we will always get some sort of authenticator log
file in a trace, even if it's empty.

This also provides an affordance to add debugging information for
the other authenticator types later.

R=ddoman@chromium.org, gavinmak@google.com

Bug: 336351842
Change-Id: Idd6f45ea60b089f9b2391b5527c5281f67421043
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5571497
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
11 months ago
danakj 97246c4f73 Revert "[gclient] Delete GCS output_dir on download"
This reverts commit 7d95eb2eb0.

Reason for revert: Causing bot_update failures: https://issues.chromium.org/issues/342945505



Original change's description:
> [gclient] Delete GCS output_dir on download
>
> GCS output_directory needs to be cleaned up prior to extracting new
> content. At the same time, it can't be cleaned up by individual GCS
> fetcher as there can be multiple objects in the same output_dir.
>
> This change adds a top level support to delete old GCS output_dir. If
> any of objects need to be downloaded, the output_dir will be completely
> deleted and all objects will be redownloaded.
>
> R=jojwang@google.com
>
> Bug: 342522902, 338612245
> Change-Id: Icbe4f1238cac54d7390bbb9b6fc5f17c538cca62
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5570466
> Reviewed-by: Joanna Wang <jojwang@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

Bug: 342522902, 338612245, 342945505
Change-Id: I93ed99d7311f15a7a24a03ccba8c310cc7e4c4d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5570280
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Yann Dago <ydago@google.com>
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Auto-Submit: danakj <danakj@chromium.org>
Owners-Override: danakj <danakj@chromium.org>
11 months ago
Junji Watanabe 8a11c2d152 autoninja: Support Siso builtin RBE client mode
This CL allows autoninja to use Siso's builtin RBE client instead of using Reclient.
Developers have to specify `use_remoteexec=true use_reclient=false` GN arg to use this mode.

This should be no-op for all developers unless `use_reclient=false` is set.

Bug: 342038479
Change-Id: I8a67f114c056be6ddb0cd26cccf0157e0b184c5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5567811
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
11 months ago
Junji Watanabe 450c36420d autoninja: Remove autosiso
autosiso has been deprecated. Nobody should be using it now.

Bug: 342038479
Change-Id: I3b22b9fc6db5b4693e954818c5aed58a3e4b4a0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5567813
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
11 months ago
Josip Sokcevic 7d95eb2eb0 [gclient] Delete GCS output_dir on download
GCS output_directory needs to be cleaned up prior to extracting new
content. At the same time, it can't be cleaned up by individual GCS
fetcher as there can be multiple objects in the same output_dir.

This change adds a top level support to delete old GCS output_dir. If
any of objects need to be downloaded, the output_dir will be completely
deleted and all objects will be redownloaded.

R=jojwang@google.com

Bug: 342522902, 338612245
Change-Id: Icbe4f1238cac54d7390bbb9b6fc5f17c538cca62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5570466
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
11 months ago
Bruce Dawson 09c232e7c0 Resolve git.bat to git.exe without using shell=True
In order for git to be run on Windows and ultimately run git.exe it is
normally necessary to pass shell=True to Popen or else invoke git.bat,
or both. However this means invoking cmd.exe every time we want to
invoke git.exe, which can end up being over 1,500 invocations of cmd.exe
when running the "update" stage of gclient sync. This makes the "update"
stage take about 1.45x as long to run - it's a significant overhead.
Even with optimizations to the update stage of gclient sync in the NOP
case this repeated invocation of cmd.exe still costs about 0.8 s of a
4.9 s "update" stage.

This change teaches git_common how to find git.exe instead of just
git.bat by parsing the .exe name out of the .bat file.

Bug: 332982922
Change-Id: I4e052444276d55c0496144b9816fe365a95a56d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5462405
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
11 months ago
Robert Iannucci 3ea849f363 [git_cl.py] Remove all usage and messages around netrc.
netrc was already legacy in 2017:
fe30f18fc5

The removed gerrit-init.sh script was written in 2013 and no longer
works.

R=yiwzhang@google.com

Bug: 336351842
Change-Id: Ia8e845899973eb5ead66aee2f54078c09d80ef28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5564197
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
11 months ago
Robert Iannucci 2f779d3061 [git_cl] Minor type annotation and initialization cleanup.
Noticed that the comments around lazily initialization on settings
mentioned that it does logging or something like this, but in fact
the __init__ method is purely vanilla.

R=gavinmak@google.com

Bug: 336351842
Change-Id: I9d8120001690b2bbd52ac2172d346ce95e2dddd3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5565083
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
11 months ago
recipe-roller cd6d85be9c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747123848594790817

recipe_engine:
ece005ce6b
  ece005c (gbeaty@chromium.org)
      Support Paths as arguments to Path.joinpath.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I48acc5f87627f37bb9bee0fec87d4512459613b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5564878
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
11 months ago
Bruce Dawson 062ecac69f Use git_common to call git
In preparation for some Windows optimizations to how git_common calls
git it is important to use git_common more widely, specifically from
scm.py and gclient_scm.py. This change updates scm.py and gclient_scm.py
and updates the associated tests:

Test command lines used when updating the tests include:
vpython3 tests/gclient_scm_test.py ManagedGitWrapperTestCaseMock.testUpdateConflict

vpython3 tests/gclient_scm_test.py GerritChangesTest.testRecoversAfterPatchFailure

vpython3 tests/gerrit_util_test.py CookiesAuthenticatorTest.testGetGitcookiesPath

Bug: 332982922
Change-Id: I7aacb110b2888c164259815385cd77e26942adc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5478509
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
11 months ago
Chenlin Fan 4071d0d728 New vpython3 to depot_tools.
b8fc6011e50cc017b6773ec4be99f7de6b468b0f cipkg: fix race condition when two packages waiting the execlusive lock simultaneously
89692b880afac19a3cd83922500bd3f474e9cb79 Add --no-periodic-update flag for virtualenv.
e986e645f627a0e9044002f81d1307c66084d8cf [packages] build for GOOS=openbsd GOARCH=ppc64,riscv64
3e19cd7bb78031ef91dc239ca5e570a32305d103 vpython: use realpath when invoking virtualenv
7f1070fd28b718864a306e95cad0b7a757eb0eca Revert "vpython: use realpath when invoking virtualenv"
988aaae74e27c6f8d191b31fcfa77340bfc64d0b vpython: use realpath when invoking virtualenv
f03b35a50ae5912b9031e4ac0dbd3924f92b5bff cipkg: rename root_step_name to step_name
097ceb2f05696dd96f465fa4df800ce008954765 cipkg: better handle execution error
47b5ad06e33f96931416639890ec16fe6db2e045 cipkg: add RootStepName and PackageExecutor
8c0507b3a1d4e4604d1e48d0adb3ace4ac18caf9 cipkg: fix mode override for embed fs
67ea392d049d6e4c238019a4fd8835a66253068f Include relevant build/packages/ changes in the vpython changelog.
a3fa998caff7d6e235febb4e262edfce9b5861e1 [vpython] Update version of virtualenv for python3.11
5055ac4c2310863a7f05584e971ec1abaec8b126 [vpython] Factor out pins for virtualenv package.

Bug: 335552303
Change-Id: I673665e0ef235af2687f1d9727bd337956e336e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5556721
Auto-Submit: Chenlin Fan <fancl@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
11 months ago
recipe-roller 3699e0df54 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747201864459170225

recipe_engine:
c7dbdce807
  c7dbdce (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 5d0d03b48537 to 4967d21f2b92

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I04686fef2be385b77ce10de88d94d8ad2fcf438a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5560182
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
11 months ago
Josip Sokcevic 525b18d46b [gclient] Use lowercase and when merging conditions
python doesn't understand AND.

R=jojwang@google.com

Change-Id: Icd0a8a4440bea2e272b2e9760bcd88a65d559848
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5555884
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
11 months ago
recipe-roller 6b4aef5d85 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747216962194218561

recipe_engine:
500f30575f
  500f305 (mohrr@google.com)
      OWNERS: Remove yuanjunh@

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0ab2dafbf8e7b7bfc570acfed2428a92e4c50d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5559225
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
11 months ago
recipe-roller 0c557985c7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747264777920524369

recipe_engine:
e7b7f04f2c
  e7b7f04 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 17b46bce7733 to d8c41eecc02c

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If005c6609ea0fa71df8c448493fab0ab8330fcc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5556573
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
nqmtuan e23121d423 [Depot tools] Roll rdb to 6dc7eeb1a5db99a04b6ee701fa3b369813528c20
Include https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5555500 via 6dc7eeb1a5

Regenerate cipd_manifest.versions using `cipd ensure-file-resolve -ensure-file ./cipd_manifest.txt`


Bug:b/341607007
Change-Id: I05a5f38db85b2ae00f64d5ae94e940e74be458aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5556722
Commit-Queue: Tuan Nguyen <nqmtuan@google.com>
Reviewed-by: Chenlin Fan <fancl@chromium.org>
12 months ago
recipe-roller f89a20ef0e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747272956496165601

recipe_engine:
61b570eafa
  61b570e (mohrr@google.com)
      [post_process] Update docstrings

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8b5703f3c23e3e862d56a6137517f665268bbceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5555657
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
recipe-roller ce7ceeb5ad Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747290564998337857

recipe_engine:
2639a9be27
  2639a9b (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 54d5e5423ec4 to 6dd0c6cf2b42

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If113674104c8ed12053b702f03df7fcc9a79848a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5556246
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
recipe-roller da2c0d70d3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747291831115132033

recipe_engine:
ad79a5f376
  ad79a5f (bpastene@chromium.org)
      Allow ancestor_ids to be set in buildbucket's recipe test helpers

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ice6411f4dbbf97d38d7c37f23e095d3feaf13b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5556243
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
Rob Mohr bed44e68b7 recipes: Support multiple changes in gerrit tests
Add get_multiple_changes_response_data() to Gerrit's test_api.

Bug: 40275665
Change-Id: I2a3b986ec0a5481cd16b887601661d26b8f0589c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5553034
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Rob Mohr <mohrr@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
12 months ago
recipe-roller 22d7982fb2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747313852642603137

recipe_engine:
6847560c6f
  6847560 (sshrimp@google.com)
      utr: add an unwrap function to resultdb

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2be465b0883d4fb85209fd4f394bfb8082b8b120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5553036
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
Fei Shao b4fbce4794 gerrit_util: Expand user path from http.cookiefile config
This fixes an issue where "~" in user http.cookiefile config doesn't get
expanded and causes failures when "git cl" commands tries to read the
credentials.

Expand the path returned by scm.GIT.GetConfig() but not just the default
value.

Bug: b/341619336
Change-Id: Ib89d5b86710a0a6bb6ca669639eeec6adc75689d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5547345
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Fei Shao <fshao@chromium.org>
12 months ago
recipe-roller 7d046b15fc Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747372986399630161

recipe_engine:
8d37f2ed94
  8d37f2e (iannucci@chromium.org)
      [file] Fix bug in read_proto.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6560b7a034673cf41bf2fe23eb9644fba3f0b622
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5552251
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
Josip Sokcevic 0dd5028133 [presubmit] Add check for recursedeps entries
All DEPS entries in recursedeps array should be defined in deps map. If
not, raise presubmit error.

R=gavinmak@google.com

Fixed: b/340948588
Change-Id: I13c3741577cf26e116493834f4825468fe74569a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5547691
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
recipe-roller 1b70611e2a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747397526733174065

recipe_engine:
adb648a936
  adb648a (olivernewman@google.com)
      [step] Propagate canceled statuses to parent steps

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If2c33810cbe62e3478ddbb7e3a4d105a5bc35291
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5549464
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
Takuto Ikuta d32e1cb571 remove references to goma
We don't use goma anymore.

Bug: 41489832
Change-Id: Ia816ed49f55740090665f308da82781f60f64d23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5545484
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
12 months ago
Takuto Ikuta b433697f22 ninjalog_uploader.py: sort ALLOWLISTED_CONFIGS
Change-Id: I5de4ddc5efc71f1c96f4bc792bd521d76127e940
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5546604
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
12 months ago
recipe-roller 6708d95ec6 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747655477826289089

recipe_engine:
af183010da
  af18301 (mohrr@google.com)
      [path] Add warning for tests using "api.path[...]"

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ica349fa4ea3460b615666de85050c6907b17a719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5545085
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
recipe-roller 589bc9e678 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747656107304074017

recipe_engine:
d746ebee9c
  d746ebe (mohrr@google.com)
      [warning] Add test_api

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7c6c584d841ae6a8ca9c298f8eb4f64978aa67e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5545084
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
Josip Sokcevic ab914fad1e Improve cloudtop error message on git cl failure
R=gavinmak@google.com

Fixed: 280621923
Change-Id: I856dc1eb4f3fcd65906196b66f358b1dd413012e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5547690
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
Garrett Beaty 4750254802 Remove json and presentation attributes from bot_update.Result.
All downstream uses have been updated, so the backward compatibility is
no longer necessary.

Bug: 339472834
Change-Id: Ie8434168e7d1255561e5f5434ea811f753f88835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5534148
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
12 months ago
Yiwei Zhang ede176e919 delete infra_to_superproject scripts
I assume it's safe to delete after infra superproject migration is done

Change-Id: I6c8d826ea6e8cfbcf4ca11d90e6b0c9da7a7ac95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5478508
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
12 months ago
recipe-roller ef488b29a8 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747674353054615601

recipe_engine:
832042556b
  8320425 (mohrr@google.com)
      [path] Remove __getitem__() and get() methods

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3a29f62ba586883c8a3db9c3b5909d189f4d9de7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5547681
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
Takuto Ikuta f97b5e2424 remove references to goma client repository
We don't maintain goma client anymore.

Bug: 41489832
Change-Id: Ib171f1d51b65c2c456dc3580d4e360a380ab6abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5546605
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
12 months ago
recipe-roller 9a8c80ca55 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747740413159054977

recipe_engine:
1929d57324
  1929d57 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 00de1ab59bf2 to a60c80172417

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id76c0c7ad5fb55b2794d32fb5abc4e1f7c0286c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5544452
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
Yiwei Zhang e0038c0721 print slightly better message if git nav-upstream is not called in git repo
Currently, the command will print following message twice when not called
in git repo.

```
fatal: not a git repository (or any parent up to mount point /google)
Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).
```

Bug: 339231299
Change-Id: Iab05e037a81b7e15dcc011d78480cd9ace7c7e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5544438
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
Yiwei Zhang 2321f138a8 delete git migrate-default-branch command
I believe this is needed for master->main migration and should no
longer needed.

Change-Id: I75ef8d5bfcf76a862c95c227d6bc9616176c1df1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540888
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
12 months ago
recipe-roller 274689c4a5 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747812763934065153

recipe_engine:
69ec2061db~..b75be3ed6eb0776b100b18c9f5bd32a11322c355
  69ec206 (nqmtuan@google.com)
      [Reproduction] Support instructions in update_invocation
  b75be3e (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from d44275688895 to 0ff3a23429ed

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4d8e42a425f7fe37a2f9db7fcd4c02ac7dda4b90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5543621
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
12 months ago
Yiwei Zhang 7f95b88c66 fail gracefully if git rename-branch is called in cog
Bug: 339231299
Change-Id: If88eaa54c579b418516058b1285ce2eb5af6e474
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540435
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
Yiwei Zhang 6eed8faff0 fail gracefully if git hyper-blame are called in cog
Bug: 339231299
Change-Id: I99a1bf033bfe7d09213484ca22536aee047373df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539651
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
12 months ago
Yiwei Zhang 718d2c81de fail gracefully if git map is called in cog
Bug: 339231299
Change-Id: Iba5519f7d9e9c18abfbae47866f6b91d821c54e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539652
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
Yiwei Zhang 04535d7af3 fail gracefully if git footers is called in cog
Bug: 339231299
Change-Id: Ibfe871ec37db42f2ad75b3effc142f5854d878be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539335
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
12 months ago
Yiwei Zhang 56edc1d23d fail gracefully if git squash-branch is called in cog
Bug: 339231299
Change-Id: If343481d12cd3763897b8fc695d3607cc4d7f64f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540931
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
Yiwei Zhang 2ea2ccaa3d fail gracefully if git freeze or git thaw are called in cog
Bug: 339231299
Change-Id: I331f2d3da13536b396e89f773dde7af843ea2b33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539994
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
Yiwei Zhang 0c999fd71a fail gracefully if git reparent-branch is called in cog
Bug: 339231299
Change-Id: I395095bbdf4d097ff1ab236eb07cf308cef04799
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540929
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
12 months ago
Yiwei Zhang 2ae9ede018 fail gracefully if git rebase-update is called in cog
Bug: 339231299
Change-Id: I2becec27c0b3f8d7b5e70c1eb7fe861c67f33e42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539474
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
Yiwei Zhang da2ef92c9f fail gracefully if git map-branches is called in cog
Bug: 339231299
Change-Id: I65c96463be51bb7da32b44c280d75622842612c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540669
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
Yiwei Zhang 25120f4278 fail gracefully if git mark-merge-base is called in cog
Bug: 339231299
Change-Id: I882365cd75e5945ecbf01bdca5a2b67735eb58da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540670
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
12 months ago
Yiwei Zhang 60997ea745 fail gracefully if git nav-downstream is called in cog
Bug: 339231299
Change-Id: If4d5dcc0ee0606acd8b539d19b29106f5152bba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540889
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
12 months ago