aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,553 Commits
6 Branches
0 Tags
185 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'da2ef92c9f'
${ noResults }
Commit Graph

10553 Commits (da2ef92c9f15b97a75bf50ad5928e537b1651997)
 

Author SHA1 Message Date
Yiwei Zhang da2ef92c9f fail gracefully if git map-branches is called in cog 
Bug: 339231299
Change-Id: I65c96463be51bb7da32b44c280d75622842612c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540669
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Yiwei Zhang 25120f4278 fail gracefully if git mark-merge-base is called in cog 
Bug: 339231299
Change-Id: I882365cd75e5945ecbf01bdca5a2b67735eb58da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540670
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Yiwei Zhang 60997ea745 fail gracefully if git nav-downstream is called in cog 
Bug: 339231299
Change-Id: If4d5dcc0ee0606acd8b539d19b29106f5152bba3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540889
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Yiwei Zhang 5773197a10 fail gracefully if git upstream-diff is called in cog 
Bug: 339231299
Change-Id: Iaf3f6f8904fc2d0af0eeb5c22fa08bd6af3418be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540932
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Yiwei Zhang da41d62982 fail gracefully if git new-branch is called in cog 
Bug: 339231299
Change-Id: I21084c12815c82f7c0a90b5755de4d5551b6d94d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540434
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
recipe-roller 99cfa7555b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747851770452721793

recipe_engine:
52adf31997
  52adf31 (nqmtuan@google.com)
      Update recipe proto

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iad56e1d5de5bba7dae5d65cbebce059dcddaf4b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5542343
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Takuto Ikuta d44bc14aa6 split_cl: do not prepend '/' in $directory 
I think it is readable if '/' is not prepended for the CL title like

```
$directory: apply some change
```

e.g. https://crrev.com/c/5541194/1..3//COMMIT_MSG#b7

Change-Id: If4cbb4966ebf62f99a7078028e4cb104de4b7197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540834
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 12 months ago
Yiwei Zhang f37d3b325f fail gracefully if git find-releases is called in cog 
Bug: 339231299
Change-Id: I70e02cf053bae635d3db007fc9ef3aa534e6c749
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539650
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
recipe-roller 2b6524b208 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747911539686261105

recipe_engine:
999aaa2b14
  999aaa2 (meiring@google.com)
      [recipes] Mark scheduled builds that are not included export ro...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie7040df76488f6f894671ef88444404b780604f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539338
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
recipe-roller 6421eb2eda Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747915941982853105

recipe_engine:
dfb875054a
  dfb8750 (chanli@chromium.org)
      [recipe_modules/led] fix test data

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7f9147ffdceac6aef9c0be06cf7e768cb8597a75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5540224
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
recipe-roller 5a86d1cc39 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747926010524309761

recipe_engine:
1f78bf9431
  1f78bf9 (chanli@chromium.org)
      [recipe_modules/buildbucket] Add builder_url

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3f58441cfa9c8132d40e728fd0c951dcaef398f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539336
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Yiwei Zhang d431e7606b requires files for git cl lint if called in cog 
Reason: In cog, there's currently no way to get the file diff.

Bug: 339231299
Change-Id: Ibe1cf771fbc84a1710ce7f72d13250877d4d21a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539168
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 12 months ago
Yiwei Zhang dc87892549 git cl commands fail gracefully when called in Cog 
Bug: 339231299
Change-Id: Ia2713ac64cb52d1857ac4ae0cd9db22f73167150
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539171
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
 12 months ago
recipe-roller 2dfcb607f6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747927268614352129

recipe_engine:
01ba86a23a
  01ba86a (bpastene@chromium.org)
      Properly propagate CV recipe_mod props to custom child builds

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia6ce72d4b60f0bbcfca6edcbce69783767a1ba5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539332
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Yiwei Zhang bacc5f189b gclient: error if fetch command is called in non-git env 
Bug: 339231299
Change-Id: I090b634afbea978270bb6d1f859cd0a6eeca2489
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5534146
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Josip Sokcevic adfd994f98 [gclient] remove output_file from gcs object setdep 
We now ask users to preserve the order of objects since there are now
two fields that don't need to updated (output_file and condition).

R=kimstephanie@google.com

Change-Id: Ic2e8c0b350060247458e733f14466145c2af435f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539331
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Stephanie Kim <kimstephanie@google.com>
 12 months ago
Josip Sokcevic e6a370ee1d [gclient] Fix setdep when GCS object condition is set 
If an object has condition set, gclient setdep fails with a KeyError
exception. This change allowlists properties that can change during
the setdep operation.

R=kimstephanie@google.com

Change-Id: Icde3a1c0ff3d9e7c5a4560147e8baddad397ccd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5532302
Reviewed-by: Stephanie Kim <kimstephanie@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Yiwei Zhang 6a7597cf9a error if git cache commands are called in cog env. 
Bug: 339231299
Change-Id: I0baa6ba9836b0026fb5b5c27b17a72c6e4d7ecde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5536289
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Stephanie Kim 52ed6cd7eb Replace forward slashes with underscores for GCS output_files 
We need to preserve the words before the slashes for instances like
`Linux_x64/rust-toolchain-31e6e8c6c5b6ce62656c922c7384d3376018c980-2-llvmorg-19-init-9433-g76ea5feb.tar.xz`
and `Mac/rust-toolchain-31e6e8c6c5b6ce62656c922c7384d3376018c980-2-llvmorg-19-init-9433-g76ea5feb.tar.xz`

Bug: 328065301
Change-Id: I0d745ee8be7751149c292f2bd2f79df2af593bdd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5536288
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Josip Sokcevic e36a78e3fe [gclient] Fix GCS object condition merge 
Bug: b/328065301
Change-Id: I9d37f5c502d618d68aa77ce7773c2537b10d0432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5536291
Reviewed-by: Stephanie Kim <kimstephanie@google.com>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Garrett Beaty 1a8da2d914 Remove the src_root attribute from gclient config. 
The src_root attribute of the gclient config is not used.

Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: chrome_release
Change-Id: I9889e944a4a849e8dc0f4de78698e32b2440843b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5536335
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 12 months ago
recipe-roller 848cdc3e53 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747946142864097409

recipe_engine:
faa0710ec6
  faa0710 (meiring@google.com)
      [recipes] Roll recipe protos.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8c5575ae1745a563ea8dc786b5b46d1ea90ad5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5539328
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
recipe-roller 5282ffc6e1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8747948030397513249

recipe_engine:
5754d5d1d5~..b1f40860d141405dfc8ded7147ce2bf1fd672dfe
  5754d5d (iannucci@chromium.org)
      Reland: Remove a bit of sys.path hackery.
  b1f4086 (iannucci@chromium.org)
      Revert "Reland: Remove a bit of sys.path hackery."

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3b79ab3e9a8cdf2ccacfc9fe32a6e1b2079a2080
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5537547
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Junji Watanabe 8479869311 Revert "[siso] Limit remote jobs on Windows to 1000" 
This reverts commit 7ababdfe02.

Reason for revert: Max limit 1000 is set inside Siso command now.

Original change's description:
> [siso] Limit remote jobs on Windows to 1000
>
> Until we fix slow Window builds on developer machine,
> It would probably be better to limit remote jobs to 1000.
>
> Bug: b/335525655, b/336481263
> Change-Id: I065e19480a27203da2b32ceb19050d0846fbc554
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5482550
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> Commit-Queue: Junji Watanabe <jwata@google.com>
> Auto-Submit: Junji Watanabe <jwata@google.com>
> Reviewed-by: Fumitoshi Ukai <ukai@google.com>

Bug: b/335525655, b/336481263
Change-Id: I911376d3ef3c7482fad4231db06c0dd1a0f1ab28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5534440
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 12 months ago
recipe-roller af58dae320 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8748011574509143681

recipe_engine:
f7da739e03
  f7da739 (mohrr@google.com)
      [recipe.warnings] Spread out June deadlines

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8eafe50dd3152a8f91a9f971f609b10119da1539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5536338
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Yiwei Zhang fc27cf2298 gclient: fix a typo 
Change-Id: Iec309efec041150cb84faf556fd13a014d19183d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5532716
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Yiwei Zhang feec2fd149 remove git cache unlock command 
It's never been called since 2023 according to the metric

Bug: 339231299
Change-Id: I6de76058f8daa00eb1115eabf04f915c332ef79f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5533622
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
recipe-roller 28ece72a5d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8748028561365180129

recipe_engine:
b667a7fdd7
  b667a7f (mohrr@google.com)
      [misc] Add path-migration scripts

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7dc527d19064465a3769a9426f4683ba73ca2c51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5533619
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Yiwei Zhang d625750652 gclient: error if grep command is called in cog env 
Bug: 339231299
Change-Id: I8b1d0e76342b180a4ec100f22ce8be85b9a35664
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5533260
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
 12 months ago
Yiwei Zhang 4040383e2d gclient: error if gitmodules command is called in cog env 
Bug: 339231299
Change-Id: Ia313592194cade3a512b67d98c8889d71888ad6c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5533259
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Yiwei Zhang fa85abfd7c gclient: error if revert command is called in cog env 
Bug: 339231299
Change-Id: I1b8741b3de4827edcfac61872626c901ffdecbfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5534147
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Yiwei Zhang c5e2ceabe3 gclient: error if status command is called in cog env 
Bug: 339231299
Change-Id: Id27a8e8954ec7da813d6076559953d4f6d5d212c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5535828
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Andrew Grieve e1385296c4 Add "ninja -t targets" to the command allowlist 
It's used here: https://source.chromium.org/chromium/chromium/src/+/main:build/android/list_java_targets.py;drc=911128ac37a470797e6e24251598e4d0f3d3c21c;l=82

Change-Id: I31c687d36393a36b3b7d75b4668720214011aa1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5527347
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 12 months ago
Yiwei Zhang a9b9284faf use ls-file to calculate all submodules instead of git submodule status 
reason: git submodule status command could be slower and output may
not be deterministic depending on the init status and current status

Change-Id: I3c9b8128e6fb230d51eb456234396a557b61c86f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5528758
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Scott Lee a76c50e296 [depot_tools] add google_java_format.py 
google_java_format.py is a simple wrapper script that finds and
executes the google-java-format binary from Chromium tree.

This CL moves the corresponding function from git_cl.py so that
the logic can be executed without git_cl.py. This is the same strcture
used in git_cl.py for running other language formatters.
- clang_format.py
- swift_format.py
- rustfmt.py
- gn.py

With this patch, google-java-format can be used to run to formatter
a java file in a chromium tree that is located in a non git checkout.

Change-Id: I5f1b845040b28c0a8f15dd2e7c48c83ce2d9df97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5525851
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 12 months ago
Garrett Beaty fd81abb19d Return a custom result type from bot_update.ensure_checkout. 
In order to facilitate removing uses of api.path.checkout_dir from
downstream repos, this change adds a custom return type for
bot_update.ensure_checkout. Now instead of a standard step result, an
object of Result will be returned. Result records the relevant paths
(directory where the checkout was performed, the repo that was checked
out and the repo that was patched, if any). This provides the caller
the ability to work in any of these directories without using
api.path.checkout_dir and without requiring boilerplate to construct
the paths. It also includes some attributes that provide details from
within the json output to abstract that out.

Bug: 329113288, 339472834
Change-Id: I2ec6db635c5b799bdb65d4e9364e7d99aae4159e
Recipe-Manual-Change: build
Recipe-Manual-Change: build_limited
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5523194
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
 12 months ago
Yiwei Zhang e5cacc3a8a return error if gclient setdep is called for git dep in Cog 
Bug: 339231299
Change-Id: I2ec445412d2d5796cccedac9a548de1a45072a07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5529884
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
recipe-roller 6e32e926e9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8748362007438841889

recipe_engine:
61d032078b
  61d0320 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 1e5bc7b60694 to 0353d07d5ede

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifd0000fbde0bdc9bcf1010d06e66d4ff792ad699
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5531023
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Josip Sokcevic 96dfd2e757 [gclient] Support per-object GCS condition 
llvm-build GCS dependency needs to place one GCS object based on
platform. We can't have multiple top-level GCS llvm-build dependencies
as the pathname is used as a key.

This extends object property of GCS dependency to have `condition`.
The `condition` field will be AND with the top level condition.

R=jojwang@google.com, kimstephanie@google.com

Change-Id: I06a6281140a8057d598a6eac2b07c7577f0ea86c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5527474
Reviewed-by: Stephanie Kim <kimstephanie@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
Yiwei Zhang 314e46cf2c move is_env_cog to a dedicated helper function in gclient_util module 
So that it can be shared with code other than scm.

Bug: 339231299
Change-Id: Iba68cc7ebba78c8933598d073861290bb0157c40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5529883
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
recipe-roller 584da4aa9e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8748457637959396129

recipe_engine:
9baac7f170
  9baac7f (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from a6b38afb07dc to 5661e9538682

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I89a9c92f8d8619202e1b9d57fc165444cf45e88c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5528258
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Scott Lee 1619815af4 [depot_tools] add file parameter support in git cl lint 
Currently, git cl lint runs git commands to retrieve a list of
the affected files and runs the lint tool against the files.

This CL updates the command line argument interface such that,
if file paths are given in positional arguments, git cl will
just run the lint tool against the given files w/o executing any
git commands.

The intent of this CL is to make git cl lint runnable out of Git
checkouts.

Bug: 324595694
Change-Id: I0a68e33931f84c2441da53bf880a2d18a5526ae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5454166
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago
recipe-roller 2f5dd07a00 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8748477142795886065

recipe_engine:
a7d70e5145
  a7d70e5 (gbeaty@chromium.org)
      Update path comparisons to use common conventions.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6cd84d3b9e8b77e89467f90034ca34d176c08561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5525844
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
recipe-roller b988fdcb18 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8748492241035306433

recipe_engine:
9bf82361f2
  9bf8236 (mohrr@google.com)
      [post_process] Add PropertyMatcher checkers

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5db5c17600d051b5d182509064bf56b2d573149b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5525841
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
recipe-roller 97e6194d42 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8748497275280475569

recipe_engine:
bf91fe22e7
  bf91fe2 (mohrr@google.com)
      [post_process] Add property-related tests

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5a8a11c0a25b5cf89c672a5dcbd097ea7d12d29d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5525838
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
recipe-roller 2ca8efcec8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8748529357856737697

recipe_engine:
8fc1a49196
  8fc1a49 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 37687beeaeb7 to 91ca2f5af39c

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I45a1c5c47ea5b40f7ece3f1002c352db0b20d679
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5523198
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 12 months ago
Fumitoshi Ukai df437783c2 Reland "ninja.py check siso_marker" 
This reverts ninja.py in commit 6ed0d7b86c

Allow `-t list`, `-t commands` and `-t inputs` even in siso out dir.

Bug: b/338414465, b/339320220
Change-Id: Ia8cdaf53680207625b485e6e326fbe4db8297b96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5524253
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 12 months ago
Fumitoshi Ukai 08d5eb6d68 Reland "siso.py check ninja marker" 
This reverts siso.py in commit 6ed0d7b86c
siso.py doesn't affect `ninja -t commands`

If out dir was built by Ninja, don't build by Siso.
(still allow `siso query` etc)

Bug: b/338414465
Change-Id: I3b317ca40153cee3987390d8b62ac070b6f85243
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5524213
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
 12 months ago
Garrett Beaty 7cc2678a05 Simplify overriding test data for bot_update. 
Currently overriding test data for bot_update requires specifying the
json output and in some cases the corresponding retcode. It's easy to
set the json output to values that wouldn't match the build inputs. This
change adds module test data for bot_update to have the bot_update fail
to checkout or fail the patch without having to manually specify the
json output as well. It also adds module test data for controlling
whether there are commit positions in the output properties.

The fail_patch property of the bot_update module was removed since it
was only used by tests to force the patch failure codepath and now the
fail_patch module test data can be used instead.

Change-Id: I03f61c2ff95c2561b746efbaae8e35b520027a2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5518044
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 12 months ago
Andrew Grieve 6ed0d7b86c Revert "Reland "siso.py: check ninja marker"" 
This reverts commit c9fb389f4b.

Reason for revert: Breaks ability to do "ninja -t commands"

Original change's description:
> Reland "siso.py: check ninja marker"
>
> This reverts commit b1c6497e19.
>
> Reason for revert: Fix var name
>
> ```
> ukai@ukai ...src/chromium/src % ~/src/depot_tools/depot_tools/siso ninja -C out/ninja
> depot_tools/siso.py: Using Siso binary from SISO_PATH: /usr/local/google/home/ukai/go/bin/siso.
> depot_tools/siso.py: out/ninja contains Ninja state file.
> Use `autoninja` to use reclient,
> or run `gn clean out/ninja` to switch from ninja to siso
>
> ukai@ukai ...src/chromium/src % ~/src/depot_tools/depot_tools/siso ninja -C out/siso base
> depot_tools/siso.py: Using Siso binary from SISO_PATH: /usr/local/google/home/ukai/go/bin/siso.
>  4.63s init credentials
> reapi instance: projects/rbe-chrome-untrusted/instances/default_instance
>  1.63s loading fs state
>  3.42s load build.ninja
> 15.32s Regenerating ninja files
>  3.64s reloading
> build finished
> local:3 remote:0 cache:0 fallback:0 skip:3026
> reapi: ops: 17(err:1) / r:0(err:0) 0B / w:0(err:0) 0B
> fs: ops: 12092(err:192) / r:350(err:0) 189.04MiB / w:1(err:0) 13.96KiB
> 27.29s Build Succeeded: 3 steps - 0.11/s
>
> ```
>
> Original change's description:
> > Revert "siso.py: check ninja marker"
> >
> > This reverts commit 41bbfb8b90.
> >
> > Reason for revert:
> > ukai@ukai ...src/chromium/src % siso ninja -C out/siso
> > depot_tools/siso.py: Using Siso binary from SISO_PATH: /usr/local/google/home/ukai/go/bin/siso.
> > Traceback (most recent call last):
> >   File "/usr/local/google/home/ukai/depot_tools/siso.py", line 115, in <module>
> >     sys.exit(main(sys.argv))
> >              ^^^^^^^^^^^^^^
> >   File "/usr/local/google/home/ukai/depot_tools/siso.py", line 104, in main
> >     checkOutdir(args[1:])
> >   File "/usr/local/google/home/ukai/depot_tools/siso.py", line 21, in checkOutdir
> >     for i, arg in enumerate(ninja_args):
> >                             ^^^^^^^^^^
> > NameError: name 'ninja_args' is not defined. Did you mean: 'ninja_marker'?
> >
> >
> > Original change's description:
> > > siso.py: check ninja marker
> > >
> > > If out dir was built by Ninja, don't build by Siso.
> > >
> > > (still allow `siso query` etc)
> > >
> > > Bug: b/338414465
> > > Change-Id: I48f8fbb5e83714fd3d27ff3a2bfffe929e4ef121
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5518396
> > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > Commit-Queue: Junji Watanabe <jwata@google.com>
> > > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> >
> > Bug: b/338414465
> > Change-Id: Ie69ca1b6c1d3dc47475d9356beab29a917356479
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5514902
> > Reviewed-by: Philipp Wollermann <philwo@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
>
> Bug: b/338414465
> Change-Id: Idb18ad9191a062f83b538c1e2a76ee77200c4df0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5518397
> Reviewed-by: Philipp Wollermann <philwo@chromium.org>
> Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> Commit-Queue: Fumitoshi Ukai <ukai@google.com>

Bug: b/338414465
Change-Id: I0a24db3675762b92e96ab37b629fa12b4af89240
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5522633
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 12 months ago