Daniel Bratell
d6bf517dd4
Improved comments for the recent optimization in owners.py
...
The final improvement of the patch, better comments, was never
included in the CL that got checked in. Here they are.
Bug: 920591
Change-Id: I2a5f7f67d4bbc5b40fdb0e7021795cd204d6f0c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1583772
Auto-Submit: Daniel Bratell <bratell@opera.com>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
6 years ago
recipe-roller
5716400ae2
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/a890ea91304d39295cbbf0ebc2ead97037ca9167 Escape newlines when writing enviroment values to execution logs. (gbeaty@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I529a0c805dfdf195d369877824c71e6f8931fae8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1621548
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
df352ab58a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/86003d0c34d194b08701a0cca237b5d33fff4a26 Add "pipe" helpers for multiprocess communication. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I64d298867c82684e6559c8f129ec284c8f52dee3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1621517
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
6014b9c87a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/4579203e4d12ba6ea65ecaf040ac4cf2e4e5f632 Add coverage pattern information directly to RecipeDeps. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9eb13e97b63347b1f8c59f59265fe7c647dba663
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1620823
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
fcdb428dee
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM+CQ.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/eeac8fccee349f073b6244a1032d083555b803ec Redact line numbers for traceback frames which originate outside the (iannucci@chromium.org )
R=recipe-roller@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iadda2159e026ed5e9e411dc4ecec2ff9cd36da32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1620813
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
Andrii Shyshkalov
ad39f9d8f8
[lucicfg] Release v1.7.5
...
luci-go @ b8f8bf3582b0bed4cde222f538b4ff04c0b0cfc0.
Backwards compatible.
Includes experimental CQ cancelation feature
and a bugfix for CQ groups w/o any builders.
R=vadimsh
note: roll will be trivial, footer below just for autoroller to let this CL in.
Recipe-Nontrivial-Roll: skia
Change-Id: Ief596c260276fc461d3dc473a7b89e20e863b965
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1620806
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
6 years ago
recipe-roller
ee7beb2bb2
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/b4bd5cf2dfd1133713f6087c046ce02d5b78c20a Fix up readme. (iannucci@chromium.org )
https://crrev.com/5619081599b072acce6072da76aab28097a07686 Fix error in doc/user_guide.md (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib32e4f33bb85c3ea763abfa81b536816fac834b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1620849
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
f160aa8e2d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/012a6f73a5a8d98ad4e6a0872240b38b1ff5d8d7 Compute a PYTHON(site-packages) root based off of a site package. (gbeaty@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id751b54fcacca467cae2c2ddc2924effd01614da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1620568
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
2ce88ed3d8
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM+CQ.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/74e8a4d9e6fad23d85f241a457067647c66d0d73 Small tweaks to recipe_deps for upcoming test runner change (iannucci@chromium.org )
R=recipe-roller@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id2f4cd3cdeb471f35edf7eec84a34d265b03eae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1620305
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
recipe-roller
7639f1999a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/e28cc028144722cc0bfab514f9ada312b245ece3 Make test_result.proto an internal protocol. (iannucci@chromium.org )
https://crrev.com/7f33bc0f23af3bb83d27b8cc31f5f35d189a1127 Add proto for new test runner. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ica7e5fb8d3ec0282df4b4f86706dd7a224b838c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1619558
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
6 years ago
Daniel Cheng
cf6269b441
[git-cl] Handle non-HTTPS repositories gracefully in EnsureAuthenticated
...
There are some Google-internal repos that use a custom scheme. Having
any remotes pointing to these URLs breaks git cl archive.
Change-Id: Ibd686c5cd11e090f0821ff2b412540138252dfce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1614946
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Auto-Submit: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
6 years ago
recipe-roller
a7a23c078a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/8cb0faab5f1b6e30e56d13324954dd6c1f623c4e Fix current test runner when tests crash. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib1524f1f055abb35a2a112975f7183743ce4b9e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1617989
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
a86225ee24
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/2c7dbb91cfb38dc64a85ac581fab056c0cd8b584 Add pylint comment to help some downstream repos cope with this. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4093944a0c145129379f2537bc7758a5b427b9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1617987
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
25331bfed5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/9f95903cb308192351026428275ba8dc4f6e4378 Set non-buffered mode for recipes.py and catch Ctrl-C. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0fb5538d09a01f07d42b45604fa0c3812a742dc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1618086
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
1ca7ce3f76
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/0d245ab9614f86baeaf26dfe69f5cbe9feb4e8af Refactor test/__init__ a bit. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib655f5b8519c93936d364198e76396a82d1b995a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1617963
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
a1f0fb0027
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/304d10cdcc0c37bd2f5add7114a21d27cb3298fd Factor out filesystem_safe() into its own module. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I39aa94a08a50f756768b6ec5c627820d56e8e1a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1617944
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
d7e41546c0
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/c31f06ae447e388b551ae1fefb08557279b1c36a Fix properties recipe to sort properties dict for determinism. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If20ed68d4f807ad8db9891a9976ba49a397365f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1617943
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
0e405d1ac6
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/e7498a59f81c8fad2caf7e3d7c8ca072ec0e2494 Stringify recipe_name when executing test case. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic8792a722ae9a077dbda8012b11234ee4369ee9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1617430
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
caa04a2751
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/a5456c47f654f8cab699314f687a1f40aa99a3d2 Fix flaky test. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4ee9723b1fbacb87c3831f981bb1a918c980b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1617426
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Edward Lemur
5737f025b5
git-cl: Only display a detailed message when git-cl fails.
...
git-cl will print the path to the collected traces and git info,
but will only display the detailed message when git-cl fails.
Bug: 961663, 955206
Change-Id: I0a4d470aba24d696bdd5e02e069833f47cf56c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1615665
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
6 years ago
Edward Lemur
99fe071354
Reland "bot_update: Pass target-ref to gclient."
...
This is a reland of f61af56950
crrev.com/c/1592577 should fix the issues with the original change.
Original change's description:
> bot_update: Pass target-ref to gclient.
>
> Bug: 956807
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: skia
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Recipe-Nontrivial-Roll: build
> Change-Id: I4d786d989446b8c1e3f39ef78c3c99cfe70808c0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1588502
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Bug: 956807
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: skia
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: build
Change-Id: I16c22cb6aeb8e9dc1f55d77b1f12987720da3480
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1613341
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
6 years ago
recipe-roller
abe8aefc62
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/9d31f1727653888912994380e7b9c35ad9ea8380 buildbucket: Add critical to BB fieldmask (seanabraham@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icb8e862574f95b225f3d37adafc38ef93779101a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1613928
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
1f5e810a97
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/76f4351baff3376ef9920ba1a270bb502918d365 Extract diff and list subcommands from main test implementation. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia3aafef84c062142518aba6bf5b8f15ad0b2d8aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1613669
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
John Budorick
a16f28fc23
Roll mac_toolchain to pick up -verbose.
...
Bug: 962920
Change-Id: Ib52b4fb571381352b63a83ac4c4392ba20677892
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612291
Auto-Submit: John Budorick <jbudorick@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
6 years ago
Joey Scarr
2d3b9260f3
Delete the mojo config from the gclient recipe module.
...
The repo it references is obsolete and I've been requested to delete it.
Bug: 963195
Change-Id: I4e765465950f85d4bdcb604804959ff29a00f062
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611591
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
6 years ago
recipe-roller
b77f2db9b1
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/f4424b87ca831dbc1fb2b72af3dc94ed2666861b Change test simulation substituter to work with oddball python distributions. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia55886d9cd8ef8beefadcc42bb7bd61667eac912
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612283
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Edward Lemur
75391d46d0
git-cl: Reword the message when surfacing traces to the user.
...
In crbug.com/955206 they pointed out that:
- It's not clear when to upload the issue
- It's not clear where to report it, or where to look for existing issues.
- It's not made clear that the traces can contain information the user might not want to share.
I've reworded the message to address those concerns
Bug: 955206
Change-Id: Ia1426007d389328eac52babeee1ec3782c2b104e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1606608
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
6 years ago
recipe-roller
74ca692079
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/cc6f5c718d9336bc98b85a820d04bdefd6dfe2b8 Improve cmd0 resolution to account for absolute base paths. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I74679ada4d06a2493c58b8c1adba5f98a8073d96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612434
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
2d37ec48e9
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/c262e24ab6137157a6c834fc38a127a886ba959a Extract debug command from the test subcommand. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9f2db0793179ec7ed6430ea03aa2272d3a39c800
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612080
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
e684a5050f
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/55fabf49b398f40fe4561f37ca5bac0eb9352e7e Move simulator stream engine to its own file. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e11a1869ceb3a782720a14f6b4675df094fb309
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612079
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
3d86f06bc7
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/41c54934d664b4034e5a42655a42e866f6ba8485 swarming: fix aliasing in dimensions, env_vars and env_prefixes (maruel@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I660ea4885e3f0cd20de18f9cb0d1b449bdab2a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1612078
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
1988507cfc
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/b2103d4eb1f8a9380ec37299db6d0898bd014d12 Remove subprocess42 everywhere except the actual recipe step runner. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I609a73495e71a9eef7d6d1b08a3abb8ab4521d19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611092
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
9f1377b765
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/2e9624d2c517e450eb2d896171d9a058d9829989 [swarming] Start exposing new containment flags (maruel@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I514e386dddb8087c9ad97c03922915dbf2e3d998
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611089
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
468d0cc4a2
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/107d545f22f4f6923e46655032afb050c1945bd6 Roll swarming client (maruel@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie1e0b8463e79c650215e6fcd552835fe4397bc14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611087
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Raul Tambre
25eb8e4680
Update colorama to 0.4.1
...
Fixes colorama unintentionally overriding multiple sys.stdout wrappers of our own.
And provides a fix for a SyntaxWarning on Python 3.8:
C:\Google\depot_tools\third_party\colorama\ansitowin32.py:43: SyntaxWarning: invalid escape sequence \[
ANSI_RE = re.compile('\033\[((?:\d|;)*)([a-zA-Z])')
Tests are updated to account for the annotation wrapper no longer being overriden.
A fix by agable for the annotation wrapper working with carriage returns is also included (https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1592612 ).
Bug: 958138, 958321
Change-Id: I2fe1def85c66cfe5229a1c25c2f677e498593eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1591513
Reviewed-by: Aaron Gable <agable@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
6 years ago
recipe-roller
8a96493270
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/0aae08882d042675016c1f44da43457958fe8054 Treat any cmd0 containing path sep as relative. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id7fe88eec793e24dbf8ae296bc1a73732291b117
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1611213
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
6 years ago
Raul Tambre
09e64b49ee
Make presubmit scripts not inherit the executor script's context
...
This caused compatibility issues, because the executor script (presubmit_support.py) asks the parser for Python 3-style print functions and inherits this to the presubmit scripts it runs, of which some still use the old style statements.
Bug: 961783
Change-Id: I545d778991a53f484bce6c7e29089e0484dc19ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605917
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
6 years ago
Raul Tambre
6a9b00e433
scm: Replace invalid UTF-8 in Git output
...
This may occur when git diff is ran with binary changes in the diff.
Example: https://chromium-review.googlesource.com/c/chromium/src/+/1606595
Bug: 942522
Change-Id: I44caef559de44076ef394caa5abc3967db2bb0b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1607840
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
6 years ago
recipe-roller
06f5b22624
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/13fa883dbdc89e258d7ef300035e4bba67bffc9f Replace paths in simulations sorted by -len. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id4b6307c79dc50c9ad52bbb72f444bae5cb0fe62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1610871
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
recipe-roller
702766069b
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM+CQ.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/125d102e429465dc3468b4b235f9e3a5df4b252c Reland: Refactor recipe engine step execution. (iannucci@chromium.org )
R=recipe-roller@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7736e6b20f8a7ec9d5cf9eeb21456a1d0b37f189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609964
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
recipe-roller
66eeedc2ba
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM+CQ.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/9b3ed1d5e912b8e9195060c3401da9b5370f2fce Revert "Refactor recipe engine step execution." (iannucci@chromium.org )
R=recipe-roller@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I628d01d7a259024f677ca8fb5de7317ae9aa591f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609960
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
recipe-roller
417f2332fc
Roll recipe dependencies (nontrivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
Please review the expectation changes, and LGTM+CQ.
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/440a45cae6b329192f60313e41714bd78e886c8d Refactor recipe engine step execution. (iannucci@chromium.org )
R=recipe-roller@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6e85bbfdf2eb61a433a505f81db6b805b9231402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1610858
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
recipe-roller
7a3d1fb756
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/f34152acbe36ba6b4dc513885271cfca8838a634 Fix invalid Python file encoding "utf8" (raul@tambre.ee )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idb7c5a135e66bb134da01d4924b94364e8fafaae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609860
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Raul Tambre
a04028c2e6
Fix invalid Python file encoding "utf8"
...
Since Python 3 it must be "utf-8", which is the official name.
This is backwards compatible with Python 2.
Bug: 962277
Change-Id: I21115a322944532f1870862c8c048f8455c1109f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1608562
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
recipe-roller
42db0b42ab
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/20932a9267873300fb27651bd9572bfbb284930c [buildbucket] Do not crash on empty input (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb0015245bd156829ec58198ef92ef8ae2cf3397
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1609041
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago
Raul Tambre
cd862e37ea
gclient_scm: Decode Git output centrally for better Python 3 support
...
This avoids the need to do the decoding everywhere separately.
Also a small fix for filter() no longer returning a list on Py3.
The scripts still work with Python 2.
There are no intended behaviour changes.
Bug: 942522
Change-Id: Id0f5153011b2ef1b64394359087864cd9434e45e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1595685
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
6 years ago
Robert Nagy
059f26bcb4
do not hardcode the path to bash by using the #!/usr/bin/env bash shebang
...
on non-linux systems bash is not the default shell (by default) and
lives in a completely different path
Change-Id: I6580c776dda1b60b3d5c5f5f1ce4d6694ac45fe9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605902
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
6 years ago
Takuto Ikuta
980d615e7e
[bootstrap/win] Upgrade Python to 2.7.13.
...
This is followup of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/571171/
Bug: 741001
TEST: > gclient version # to update python
TEST: > .\python.bat # start python 2.7.13 correctly
Change-Id: I07e596d3006104ccb1c5fe0fde097a3c29f8a5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1605541
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
6 years ago
Andrii Shyshkalov
006b29556d
[lucicfg] Bump lucicfg version v1.7.2 -> v1.7.4.
...
Knows about CQ allow_owner_if_submittable.
No API changes.
R=vadimsh
Bug: 959098
Change-Id: Icfb3e201df4916b2e8d8923d87c474af1ae85b9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1604465
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Andrii Shyshkalov <tandrii@chromium.org>
6 years ago
recipe-roller
4145bd87de
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/842aee7058c3e87013ef8d59aef4c39fcceef507 Fix masked ImportErrors for config.py and test_api.py. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7e5584b6024a4e765d3f044ff9c2ae4613ed08ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1604124
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
6 years ago