This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
bbbf2ecbd0
bbbf2ec (olivernewman@google.com)
[tricium] Fix pylint analyzer executable name
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4f9b1505d0dfce4289bed1d327ff996dc3281745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2827152
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
7c1ba3120b
7c1ba31 (weiweilin@google.com)
[recipe] support configuring test presentation in MiloApi.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22f39bf7f8d263fc3704c55e1a864dd339fc5308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2824176
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Windows builders have issues fetching from chromium/src, and increasing
timeout may help - recommended by git team.
Bug: 1198581
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: build
Change-Id: Ic650dea2a175e9642a6d3d5b8f1c54fa9979e12a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2823020
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
In crbug.com/1196159, a build got stuck at "gerrit changes" step for 3
hours. It would be good to add a timeout so that it fails early.
Also adjust the timeout for get_changes to 60s, from 600s
Bug: 1196159
Change-Id: Id2327ab40dd2fd8d95aaad6bb724f7ed06e6c244
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2811899
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
This picks up a change to make 'debug sleep' work on luciexe jobs.
R=yiwzhang
Bug: 1197300
Change-Id: Iea7a061e84f7011b6a7f1cc64cca34b0267b6ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2818885
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
91f81ea469
91f81ea (olivernewman@google.com)
[tricium] Add `run_legacy` option to skip emitting comments
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2c0827476d48af10bdc44c707dce996215262af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2812318
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
mass-abandon allows users to mass abandon CLs based on search query.
Owner is always specified (either "me" or user defined via -p).
R=gavinmak@google.com, thakis@chromium.org
Change-Id: I789a3a1f3af22867ebbbc50c35b60486206ff403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2811005
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Also adds a new canned_presubmit_checks_test.py and supporting mocks,
based on the PRESUBMIT_*.py under chromium/src.
If this is OK, there are subsequent CLs for removing the original code
from chromuim/src and infra/infra, and having their PRESUBMIT scripts
just reference this canned check instead.
Change-Id: I67dfb7ac0b4cdc36bd62ec2dc062ca5c78c2244e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2805268
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
With this, `gclient` completes bootstrap after running
echo "mac-arm64" > .cipd_client_platform
as long as you also run
export VPYTHON_BYPASS="manually managed python not supported by chrome operations"
Things work enough that you can `fetch chromium`. You can then build
all of chrome (if you want to build all tests, you also need to
`echo "mac-arm64" > third_party/depot_tools/.cipd_client_platform`
in your chromium checkout).
Parts of depot_tools that actually need the env managed by vpython,
such as `git cl`, don't work. So you can't `git cl upload` for now.
Bug: 1184768,1103326,1184766,1184765,1103236
Change-Id: Ib559c35e9665b826db9841dd8a4fe0dea16f37ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2807956
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
This change includes the following commits from the infra/infra
repository:
97ee9cecaa Pinpoint: introduce fakelegacy-based smoke test. (chowski@google.com)
7f5c67efcb pinpoint: Translate ExperimentCommit properly (dberris@google.com)
6c32245733 Pinpoint cli: add actionable error when GCS credentials fail. (chowski@google.com)
5ed9722479 pinpoint fakelegacy: support /api/new endpoint. (chowski@google.com)
9d26e75b86 pinpoint: add copyright heading to files which are missing it. (chowski@google.com)
2c07962627 Pinpoint server: use the new ShouldBeStatusError assertion more. (chowski@google.com)
830e31f6b1 Pinpoint server: add unit test for ScheduleJob. (chowski@google.com)
c27f979330 Pinpoint cli: infer some flag defaults from `git cl issue`. (chowski@google.com)
ed69e2428f Pinpoint fakelegacy: support ListJobs. (chowski@google.com)
5f0e1e9a35 Pinpoint: first stab at a fake Legacy Pinpoint implementation. (chowski@google.com)
3aae5c2e6b pinpoint: Support wait+download for experiments (dberris@google.com)
6a634f7926 Replace 'master' with 'main' in test data. (chowski@chromium.org)
81ccbd091d Pinpoint server: support ListJobs' filter argument. (chowski@chromium.org)
575bd02e5a pinpoint: Update docs, support non-chromium/src (dberris@google.com)
e53451b2ca pinpoint server: support Cancel RPC. (chowski@chromium.org)
cb65ecf501 pinpoint: Reduce duplication in server_test (chowski@chromium.org)
e91e4e899d pinpoint: Support optional patchset for CLs (dberris@google.com)
R=dpranke@google.com
Bug: chromium:1175615
Change-Id: I4ac6407d822bf1905cbba02d29649ac4e400aecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2807336
Auto-Submit: Dean Berris <dberris@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
9e296d9de0
9e296d9 (yiwzhang@google.com)
Set step end_time to start_time if it is earlier than the start...
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iba11781abb42db07f3a43f8020daa10181edf713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2803201
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This check has been disabled basically everywhere since about 2013. It
should be safe to remove this; there will be warnings when trying to
skip it, but it shouldn't fail any builds.
Recipe-Nontrivial-Roll: build
Bug: 1194216
Change-Id: I84878f9e46543ae71f7e4e057b99d15a034e0d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2794799
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Add calls to support creating changes, as well as editing and publishing
them in gerrit_client and gerrit_util.
Bug=b:182613582
Change-Id: I0514cf08dce63ab29d99d4485d96fa124006326a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2800811
Auto-Submit: LaMont Jones <lamontjones@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: LaMont Jones <lamontjones@chromium.org>
When uploading a large-scale change, many users are automatically CC'ed
on a change. This adds a warning if this is the case and links to a more
appropriate approval for a large-scale change.
Bug: 1194514
Change-Id: Icd336ebdffbccbc9f30a89a33e244a788a768cfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2798963
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
If origin/HEAD resolves to `master`, depot_tools can check if
origin/main exists. If so, it's very likely that origin/HEAD should be
updated to point to origin/main.
In the worst case, this will result in extra git remote call while not
changing local state (i.e origin/HEAD remained unchanged).
R=gavinmak@google.com
Bug: 1190702
Change-Id: I51e69d7a95d3534e1820099b4b6983d38b5e2763
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2795075
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
We have a python2 binary available on all platforms already, so use
that instead of relying on the system copy. This provides consistent
behavior across all platforms and avoids the impending doom when host
distros stop providing python2 packages.
Change-Id: Id48fe343291ba70981a1a65526ba80d1f7ae7d73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2785114
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Change-Id: I370f023c7c4a5e5b1d1c1322bc443c7c375e1089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2792341
Commit-Queue: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
3e3066d09b
3e3066d (iannucci@chromium.org)
Do not open $debug until the engine is committed to running the...
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I089e6ac0444c465987c43103dc1634fd61d8f5b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2785349
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
e9c8ffe3e5
e9c8ffe (yiwzhang@google.com)
cq: Expose method for setting reuse
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie0ef956e3f06cab41744df16a51998e8f4f43a2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2782115
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
Please review the expectation changes, and LGTM+CQ.
recipe_engine:
3faa1bab09
3faa1ba (yiwzhang@google.com)
cq: Use proto Output properties in cq recipe_module
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=dpranke@google.com
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5cb2fc5927de1cecad74f2c7a25be875983556a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2781195
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
This will allow us to target Big Sur for Mac ARM64 builds.
Bug: 1124119
Change-Id: I0aa17c744e13d45699e79eb17336ebcafb9ea719
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2777472
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Jeff Yoon <jeffyoon@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
3c382e042b
3c382e0 (yiwzhang@google.com)
engine: Support set proto output properties
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iab3f85b66bfff4df0b87b26056a2c3c41d077822
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2779774
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
platform.machine() is 'arm64' on arm macs, and the `.startswith('arm')`
branch converted that to 'arm' before this CL.
Bug: 1103236,1190880
Change-Id: Idd75a724f059ecd2dd873737e4998fe9bc937e04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2779414
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
recipe-roller
Mirko Bonadei
Owen Rodley
Josip Sokcevic
Fumitoshi Ukai
Haiyang Pan
Robert Iannucci
Chan Li
Michael Achenbach
Mike Frysinger
Nico Weber
seanmccullough
Dean Michael Berris
Stephen Martinis
LaMont Jones
Gavin Mak
Solomon Kinard
Ryan Harrison
Edward Lesmes
Yiwei Zhang
Nodir Turakulov
Brian Ryner
Vadim Shtayura
Edward Lesmes