ad9cc11121
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/6acef55ce230375622724fc75c023fae38065664 buildbucket recipe_module: make each step an infra step. (tandrii@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I999cb1c7f4e85988c34f4d8b606f0320fe83fe63
Reviewed-on: https://chromium-review.googlesource.com/812995
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
7 years ago
7d47eb5495
[PRESUBMIT] Add cipd package checks for all known manifests.
...
This also improves the cipd manifest canned check to produce unique
names in order to debug PRESUBMIT's more easily.
Adds onto
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/708354
R=maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org
Bug:
Change-Id: I9f086996998608092a4d23f5c98fbac34117a9e4
Reviewed-on: https://chromium-review.googlesource.com/811445
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
7 years ago
0afcd10430
Revert "[led] Update led to the latest version"
...
This reverts commit 9c02a833e2https://chromium-review.googlesource.com/809947
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
TBR=iannucci@chromium.org,nodir@chromium.org
Change-Id: Idbed632448a986f714579c63c4da8b49068757ce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/810164
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
7 years ago
9c02a833e2
[led] Update led to the latest version
...
infra.git relevant Changelog:
8bc0df738 [kitchen] Remove some unnecessary flags.
54472fa9f led: improvements in led get-build subcommand.
6707984c0 [led] Add ability to set buildbucket tags on get-builder command.
R=nodir@chromium.org
Bug:
Change-Id: If1e664f402fdac73fe16ae351d9a5d819f426909
Reviewed-on: https://chromium-review.googlesource.com/809947
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
7 years ago
873be6fd45
Update depot_tools bleeding-edge win git to 2.15.1.2
...
R=iannucci
Bug: 749709
Change-Id: Id254c60b9fba981824b267ccaaf4dc7f35428a8a
Reviewed-on: https://chromium-review.googlesource.com/806974
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
7 years ago
b278ddd939
[presubmit] Remove line
...
Bug:
Change-Id: Ife9b3eaec3031de1fa4324e345f8e30012ed618a
Reviewed-on: https://chromium-review.googlesource.com/806241
Commit-Queue: Mun Yong Jang <myjang@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
7 years ago
ad64abd69a
git-cl: Fix 'git cl issue --reverse'
...
While ripping SVN support out of git-cl, the Changelist() constructor
changed to require that the branch name start with "refs/heads/",
but the CMDissue --reverse code was never updated to feed it the
fully-qualified refname.
R=thestig
Bug: 791176
Change-Id: Ia7fee0f77fec080d91f34ad43bfd9f7c6a4bf64b
Reviewed-on: https://chromium-review.googlesource.com/806239
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
7 years ago
17995a9f12
[depot_tools] Remove deprecated config check in canned checks
...
Bug: 785114
Change-Id: Ic98995d670b22ba17ef6139ed086cb1b31c7d39c
Reviewed-on: https://chromium-review.googlesource.com/804736
Commit-Queue: Mun Yong Jang <myjang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago
6c5a1c4c3c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/0f093b369402a86363de15a3fae0c98eab4c8e00 Remove references to phajdan.jr (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I899048a12034fc054e7e2c8e6f971b1fd94fff4d
Reviewed-on: https://chromium-review.googlesource.com/803796
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
f6b946d71d
Also print key in commit message.
...
BUG=
TEST=manual
Change-Id: Ic0335ecae5809e1cf328e130a29d2e42acc463ce
Reviewed-on: https://chromium-review.googlesource.com/798591
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Eric Boren <borenet@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
8 years ago
009150b7af
bot_update: be explicit when checking out branches.
...
$ git checkout <name>
may be interpreted by git as checking out a file named <name>
if <name> has slashes. Thus,
$ git checkout infra/config
ends up checking out infra/config directory of the (typically)
master branch that was checked out before. To avoid confusion,
we have to add '--' separator between branch name and file names:
$ git checkout <name> --
This in turns allows to run CQ-based presubmit on infra/config branches.
R=nodir@chromium.org
Bug: 790738
Change-Id: I6ce31a8f0fbd66fd59ac7c2ea9cccd3ff97d1f0e
Reviewed-on: https://chromium-review.googlesource.com/802136
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago
8076c2854d
Give git-cl-presubmit an --all option
...
This will let developers run PRESUBMIT against all files in the
repo, rather than just those their CL touches. This will be
particularly helpful when modifying PRESUBMIT.py itself.
R=maruel@chromium.org
Bug: 519046
Change-Id: I5775eef8aecefe0cd358537c9218afc7480a7619
Reviewed-on: https://chromium-review.googlesource.com/798056
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
bd95f41abd
Fix fetch --dry-run to not invoke git
...
This was broken by 209a681f9chttps://chromium-review.googlesource.com/797611
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
9e51906ffb
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/6d6af8922b3707d7b02c8ed31f5a839a9be7eb80 Add truncate() to file api (kjharland@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I55fc4af937e2570b12bf355f1582d2e1ace0f584
Reviewed-on: https://chromium-review.googlesource.com/794044
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
1b30125fbc
bot_update: don't remove git cache's .lock files.
...
bot_update and gclient invokes git cache with --ignore-locks.
This should also reduce noisiness of bot_update stdout.
R=iannucci@chromium.org
Bug:
Change-Id: I6baf9e5665d244d08aab58a7d3327e6c3204b2b5
Reviewed-on: https://chromium-review.googlesource.com/791536
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
24650b6c5a
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/16114fcab34af737bd1488b163a5af97efdd4aab [autoroll] Skip backwards rolls instead of terminating. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9d52be2d5888088bdb76b16fc73ea972b45f2204
Reviewed-on: https://chromium-review.googlesource.com/792431
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
77ce4bdc7d
gclient on bots: don't cleanup lock files.
...
bot_update & gclient on bots instruct git cache locks
to be ignored, so there is no need to clean them up.
R=hinoka@chromium.org
Change-Id: I81c52cfcd44a42d13b641847439ac92053a7bc98
Reviewed-on: https://chromium-review.googlesource.com/791652
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
1728f5f3e6
[depot_tools] Fix timestamp issues related to local auth
...
Bug: 509672
Change-Id: I5abb813d5f78291b4bf2d8e856c6fd71fcad5b68
Reviewed-on: https://chromium-review.googlesource.com/791472
Commit-Queue: Mun Yong Jang <myjang@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago
ad3e639bae
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/6c2cb40870d113be8dddefc69ea6a4177d5fc884 [vpython] Assume vpython in $PATH for bootstrap. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I88f5b9ee7c66b79425692fdd21f87283f66704bd
Reviewed-on: https://chromium-review.googlesource.com/791153
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
46a672bafa
gclient: don't update cache if needed revision is already there.
...
Tested end-to-end, for example
https://ci.chromium.org/swarming/task/3a0147207378b910
which contains:
src/media/cdm/api (Elapsed: 0:00:01)
----------------------------------------
[0:00:00] Started.
_____ src\media\cdm\api at ea5df8e78fbd0a4c24cc3a1f3faefefcd1b45237
[0:00:00] running "git cat-file -e ea5df8e78fbd0a4c24cc3a1f3faefefcd1b45237" in "e:\b\s\w\ir\cache\git\chromium.googlesource.com-chromium-cdm"
skipping mirror update, it has rev=ea5df8e78fbd0a4c24cc3a1f3faefefcd1b45237 already
thereby saving on needless git fetch (~40s in glcient sync on win trybots),
and reducing the rate of .pack file accumulation inside cache directories.
Risks: silently broken recipes which run gclient sync (or worse, bot_update)
as a means of fetching latest commits in all repos of a solution. I think
the benefit of faster bot_update in chromium CQ is worth the potential risk.
PSA: https://groups.google.com/a/chromium.org/d/msg/infra-dev/UYLdBwAXm1Y/OV9QB6JnBQAJ
Bug: 749709
Change-Id: I7a9e8ab82a5e2b848e450f19a798ac18a0b5e201
Reviewed-on: https://chromium-review.googlesource.com/787331
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
8 years ago
568f473e4b
bot_update: add mooooooore chars in logs.
...
Before, bot_update would print after command:
Succeeded (Failed) in 0.1 mins
but figuring out which command takes a lot of scrolling/searching
for previous
Running <cmd with args>
This CL fixes that:
Succeeded (Failed) in 0.1 mins <cmd with args>
R=machenbach@chromium.org, maruel@chromium.org
TEST=end-to-end with led tool, but only on LUCI stack.
Bug: 749709
Change-Id: Id3031a12b9013ab136ea03cdf6d325930722e50f
Reviewed-on: https://chromium-review.googlesource.com/787175
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
d51ed57edb
git_cache: lower max num of .pack files before re-bootstrap on Win.
...
It used to be 50, I think ~9 gives best results for Chromium on Win:
on golo VM, it takes <4 minutes to re-boostrap + git fetch small
delta, assuming zipped git checkout for bootstrap is fresh (~1day).
For other repos, which are significantly smaller, this change should
have minor effect if at all.
Test: I tested this using `led` tool on Win7 machines running LUCI
stack extensively. For example,
* https://ci.chromium.org/swarming/task/3a0102e8c8657410
shows case with few .pack files, hence just 1 fetch
* https://ci.chromium.org/swarming/task/3a010282f9fd8010
shows case with 39 .pack files and so bootstrapping + fetch.
If you look at prior tasks on the same VM, you'd find this:
https://ci.chromium.org/swarming/task/39ffe843d01ed010
which spent 8 minutes doing 1 incremental fetch with 39 .pack
files.
**Troopers/Sheriffs**: This change is safe to revert.
However, beware that you should also at the same time revert the recipe
roll of this CL to the repo, in which the failed builder's recipe is
located, typically `chromium/tools/build`.
Bug: 749709
Change-Id: I18e2b63283100d466e9fb981a9094862463f6909
Reviewed-on: https://chromium-review.googlesource.com/787174
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
8 years ago
0083130c97
Whitespace change inside recipes to kick recipe autoroller.
...
TBR=iannucci@chromium.org
Bug: 749709
Change-Id: I8aa02f780c5f2a3c2f8c0c408f83b061ba11c672
Reviewed-on: https://chromium-review.googlesource.com/788244
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
4f56f234f9
git_cache: add more diagnostic logging wrt bootstrapping.
...
This is short of sending this metrics to ts_mon, but is still useful
for diagnose and then claim improvements in git cache performance on
bots.
This change has been tested for realz with led, particularly on windows
https://ci.chromium.org/swarming/task/3a01358af14a7d10
Bug: 749709
Change-Id: I2b3589079d2caa7f70007f90fcbce85a0205d24b
Reviewed-on: https://chromium-review.googlesource.com/787173
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
05ecc0e484
Roll mac_toolchain to 2b69be620
...
Relevant commit:
2b69be620 mac_toolchain: update file permissions post-install
894cac284 mac_toolchain: add "package" command
09ed0cfc0 mac_toolchain: include symlinks
BUG=475693
TBR=iannucci@chromium.org
Change-Id: I65d146fd99ab8dd378b04714b8e3b88e0cf51907
Reviewed-on: https://chromium-review.googlesource.com/775667
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
d36fce4408
Fix silly bug in presubmit_support implementation of AppendCC.
...
The executor needs to accumnulate more_cc, not overwrite them.
Bug: 786386
Change-Id: Iadfe836ae9623f1b66d2db8209d347b5e61ccae8
Reviewed-on: https://chromium-review.googlesource.com/784553
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
8 years ago
82d8dcd6e5
git_cache: remove redundant code.
...
R=iannucci@chromium.org, nodir@chromium.org
Change-Id: If7d48775b01a55e884a4c1fd6c26b1ff65992f4e
Reviewed-on: https://chromium-review.googlesource.com/786823
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
25b1da95b3
Revert "Show GIT_TRACE for git command in bot_update.py"
...
This reverts commit 6e215cefe2https://ci.chromium.org/swarming/task/39ff1814b3bb5b10?server=chromium-swarm.appspot.com
Original change's description:
> Show GIT_TRACE for git command in bot_update.py
>
> GIT_TRACE=true tells us which internal git command is slow.
> https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables
>
> I got following results in my local repository.
> Let me confirm the bots show similar behavior.
>
> C:\src\chromium\src>set GIT_TRACE=true
>
> C:\src\chromium\src>git rebase-update
> 21:32:36.519698 git.c:576 trace: exec: 'git-rebase-update'
> 21:32:36.519698 run-command.c:626 trace: run_command: 'git-rebase-update'
> 21:32:38.889848 git.c:344 trace: built-in: git 'fetch' '--multiple' 'origin'
> 21:32:38.893846 run-command.c:626 trace: run_command: 'fetch' '--append' 'origin'
> Fetching origin
> 21:32:38.911858 git.c:344 trace: built-in: git 'fetch' '--append' 'origin'
> 21:32:38.983909 run-command.c:626 trace: run_command: 'remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
> 21:32:39.002923 git.c:576 trace: exec: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
> 21:32:39.003923 run-command.c:626 trace: run_command: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
> 21:32:43.782266 run-command.c:626 trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> 21:32:43.827301 run-command.c:626 trace: run_command: 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/ '
> remote: Counting objects: 74400, done
> remote: Finding sources: 100% (19/19)
> 21:35:49.348951 run-command.c:626 trace: run_command: 'unpack-objects' '--pack_header=2,19'
> 21:35:49.368985 git.c:344 trace: built-in: git 'unpack-objects' '--pack_header=2,19'
> remote: Total 19 (delta 1), reused 18 (delta 1)
> Unpacking objects: 100% (19/19), done.
> 21:35:49.597328 run-command.c:626 trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> 21:35:49.612375 git.c:344 trace: built-in: git 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> From https://chromium.googlesource.com/chromium/src
> e8994685157b..fd56d3ad0528 master -> origin/master
> 21:35:50.281845 run-command.c:1452 run_processes_parallel: preparing to run up to 1 tasks
> 21:35:50.287848 run-command.c:1484 run_processes_parallel: done
> 21:35:50.309865 run-command.c:626 trace: run_command: 'gc' '--auto'
> 21:35:50.328880 git.c:344 trace: built-in: git 'gc' '--auto'
> 21:35:50.453967 run-command.c:1452 run_processes_parallel: preparing to run up to 1 tasks
> 21:35:50.460971 run-command.c:1484 run_processes_parallel: done
> 21:35:50.460971 run-command.c:626 trace: run_command: 'gc' '--auto'
> 21:35:50.480985 git.c:344 trace: built-in: git 'gc' '--auto'
> Rebasing: direct_goma
> Rebasing: python_pool
>
> C:\src\chromium\src>git fetch
> 21:36:23.409703 git.c:344 trace: built-in: git 'fetch'
> 21:36:23.486758 run-command.c:626 trace: run_command: 'remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
> 21:36:23.506772 git.c:576 trace: exec: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
> 21:36:23.506772 run-command.c:626 trace: run_command: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
> 21:36:28.542596 run-command.c:626 trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> 21:36:28.578620 run-command.c:626 trace: run_command: 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/ '
> 21:36:28.601635 git.c:344 trace: built-in: git 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/ '
> remote: Counting objects: 67598, done
> remote: Finding sources: 100% (28/28)
> 21:39:29.787441 run-command.c:626 trace: run_command: 'unpack-objects' '--pack_header=2,28'
> 21:39:29.812462 git.c:344 trace: built-in: git 'unpack-objects' '--pack_header=2,28'
> remote: Total 28 (delta 2), reused 20 (delta 2)
> Unpacking objects: 100% (28/28), done.
> 21:39:30.083690 run-command.c:626 trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> 21:39:30.108704 git.c:344 trace: built-in: git 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
> From https://chromium.googlesource.com/chromium/src
> fd56d3ad0528..fbcc09282dc8 master -> origin/master
> 21:39:30.788186 run-command.c:1452 run_processes_parallel: preparing to run up to 1 tasks
> 21:39:30.795191 run-command.c:1484 run_processes_parallel: done
> 21:39:30.813200 run-command.c:626 trace: run_command: 'gc' '--auto'
> 21:39:30.836212 git.c:344 trace: built-in: git 'gc' '--auto'
>
>
> Bug:749709
> Change-Id: I5b94549c42271885365c2354dc3f58399d6aebe0
> Reviewed-on: https://chromium-review.googlesource.com/786691
> Reviewed-by: Ryan Tseng <hinoka@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@google.com>
TBR=hinoka@chromium.org,agable@chromium.org,tandrii@chromium.org,tikuta@google.com
Change-Id: I970ddac1fd21e904c69dc18e48169d49293b1800
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 749709
Reviewed-on: https://chromium-review.googlesource.com/786413
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
6e215cefe2
Show GIT_TRACE for git command in bot_update.py
...
GIT_TRACE=true tells us which internal git command is slow.
https://git-scm.com/book/en/v2/Git-Internals-Environment-Variables
I got following results in my local repository.
Let me confirm the bots show similar behavior.
C:\src\chromium\src>set GIT_TRACE=true
C:\src\chromium\src>git rebase-update
21:32:36.519698 git.c:576 trace: exec: 'git-rebase-update'
21:32:36.519698 run-command.c:626 trace: run_command: 'git-rebase-update'
21:32:38.889848 git.c:344 trace: built-in: git 'fetch' '--multiple' 'origin'
21:32:38.893846 run-command.c:626 trace: run_command: 'fetch' '--append' 'origin'
Fetching origin
21:32:38.911858 git.c:344 trace: built-in: git 'fetch' '--append' 'origin'
21:32:38.983909 run-command.c:626 trace: run_command: 'remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
21:32:39.002923 git.c:576 trace: exec: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
21:32:39.003923 run-command.c:626 trace: run_command: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
21:32:43.782266 run-command.c:626 trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
21:32:43.827301 run-command.c:626 trace: run_command: 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/ '
remote: Counting objects: 74400, done
remote: Finding sources: 100% (19/19)
21:35:49.348951 run-command.c:626 trace: run_command: 'unpack-objects' '--pack_header=2,19'
21:35:49.368985 git.c:344 trace: built-in: git 'unpack-objects' '--pack_header=2,19'
remote: Total 19 (delta 1), reused 18 (delta 1)
Unpacking objects: 100% (19/19), done.
21:35:49.597328 run-command.c:626 trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
21:35:49.612375 git.c:344 trace: built-in: git 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
From https://chromium.googlesource.com/chromium/src
e8994685157b..fd56d3ad0528 master -> origin/master
21:35:50.281845 run-command.c:1452 run_processes_parallel: preparing to run up to 1 tasks
21:35:50.287848 run-command.c:1484 run_processes_parallel: done
21:35:50.309865 run-command.c:626 trace: run_command: 'gc' '--auto'
21:35:50.328880 git.c:344 trace: built-in: git 'gc' '--auto'
21:35:50.453967 run-command.c:1452 run_processes_parallel: preparing to run up to 1 tasks
21:35:50.460971 run-command.c:1484 run_processes_parallel: done
21:35:50.460971 run-command.c:626 trace: run_command: 'gc' '--auto'
21:35:50.480985 git.c:344 trace: built-in: git 'gc' '--auto'
Rebasing: direct_goma
Rebasing: python_pool
C:\src\chromium\src>git fetch
21:36:23.409703 git.c:344 trace: built-in: git 'fetch'
21:36:23.486758 run-command.c:626 trace: run_command: 'remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
21:36:23.506772 git.c:576 trace: exec: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
21:36:23.506772 run-command.c:626 trace: run_command: 'git-remote-https' 'origin' 'https://chromium.googlesource.com/chromium/src.git '
21:36:28.542596 run-command.c:626 trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
21:36:28.578620 run-command.c:626 trace: run_command: 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/ '
21:36:28.601635 git.c:344 trace: built-in: git 'fetch-pack' '--stateless-rpc' '--stdin' '--lock-pack' '--include-tag' '--thin' 'https://chromium.googlesource.com/chromium/src.git/ '
remote: Counting objects: 67598, done
remote: Finding sources: 100% (28/28)
21:39:29.787441 run-command.c:626 trace: run_command: 'unpack-objects' '--pack_header=2,28'
21:39:29.812462 git.c:344 trace: built-in: git 'unpack-objects' '--pack_header=2,28'
remote: Total 28 (delta 2), reused 20 (delta 2)
Unpacking objects: 100% (28/28), done.
21:39:30.083690 run-command.c:626 trace: run_command: 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
21:39:30.108704 git.c:344 trace: built-in: git 'rev-list' '--objects' '--stdin' '--not' '--all' '--quiet'
From https://chromium.googlesource.com/chromium/src
fd56d3ad0528..fbcc09282dc8 master -> origin/master
21:39:30.788186 run-command.c:1452 run_processes_parallel: preparing to run up to 1 tasks
21:39:30.795191 run-command.c:1484 run_processes_parallel: done
21:39:30.813200 run-command.c:626 trace: run_command: 'gc' '--auto'
21:39:30.836212 git.c:344 trace: built-in: git 'gc' '--auto'
Bug:749709
Change-Id: I5b94549c42271885365c2354dc3f58399d6aebe0
Reviewed-on: https://chromium-review.googlesource.com/786691
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>
8 years ago
00fc72856b
[presubmit] Rename to CheckChangedLUCIConfigs
...
Bug: 785114
Change-Id: I53c3b4e54f39f4bacf8fb0bda1de4e4b0e1b280b
Reviewed-on: https://chromium-review.googlesource.com/771592
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Mun Yong Jang <myjang@google.com>
8 years ago
acc8e3ebaa
[presubmit] Extend depot tools auth to use luci context
...
Bug: 509672
Change-Id: Ie3cb2fa1a2276f1fe658cdf7b9ffb657d03556e8
Reviewed-on: https://chromium-review.googlesource.com/754340
Commit-Queue: Mun Yong Jang <myjang@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago
7d9d9233cb
[depot_tools] Add mock lib
...
Bug:
Change-Id: I1c02188625a42af974744d0c27905f879963b0d2
Reviewed-on: https://chromium-review.googlesource.com/783878
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Mun Yong Jang <myjang@google.com>
8 years ago
049f076ab6
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/6d6c1515cda8fb88bfa135743d8fdac359c832b0 buildbucket.put: improvements in tag handling. (tandrii@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id627040f707ab5c057eb01c6c5437a42a710f3c7
Reviewed-on: https://chromium-review.googlesource.com/783991
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
faf3708960
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/8b52d1ce749a21542c5a4a4f836251a577db4700 Refactor buildbucket module. (tandrii@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ide8ccea77f1920912803325ef04df46721361fa0
Reviewed-on: https://chromium-review.googlesource.com/781059
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
641b3b8345
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/f272cac20a48ee92ee3310aa32e9060cdd485eb9 buildbucket recipe_module: propagate is_experimental flag. (tandrii@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8208b9e56e867c869c7fcbcc3a5c5a7ef4c7cae9
Reviewed-on: https://chromium-review.googlesource.com/780863
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
7227d2175a
Add OutputApi.AppendCC to allow presubmit checks to add CCs
...
Bug: 786386
Change-Id: If29acf287355d150e0f89f45b2f7aa87a08dcc57
Reviewed-on: https://chromium-review.googlesource.com/776645
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
8 years ago
ddfead3483
bot_update: mooore refactor around _git_checkout.
...
Bug:
Change-Id: I7141022348cdfd4dafbd2fa00b5981faa0ba79e0
Reviewed-on: https://chromium-review.googlesource.com/771930
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
8 years ago
75c0b4b715
bot_update: don't crash badly if there no json outpot.
...
To illustrate, with this CL it's clear what is broken:
https://ci.chromium.org/swarming/task/39e5676c13f00710?server=chromium-swarm.appspot.com
while before you get a red herring:
ncaught Exception: AttributeError("'NoneType' object has no attribute
'get'",)...
https://ci.chromium.org/swarming/task/39e55d46c0774610?server=chromium-swarm.appspot.com
R=iannucci@chromium.org
Bug: 786486
Change-Id: I9ed2cdb7261c2e22a5a68116b81f841ece06c5d2
Reviewed-on: https://chromium-review.googlesource.com/777556
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
8762632eb7
Reland "bot_update: make --output_json required in script invocation."
...
This is a reland of 331a276b54R=iannucci@chromium.org
>
> Bug:
> Change-Id: I1e1129b9748d6647e45eb26892c8e892019fe088
> Reviewed-on: https://chromium-review.googlesource.com/769164
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Change-Id: I165da9650df6b5e8d382aafc30914eff9a524c56
Reviewed-on: https://chromium-review.googlesource.com/777820
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
276e0454b7
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/ee90ad121c9e96935792ee2276fecc5139ddccc0 Create file/api.symlink. (dgarrett@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8c7f4fb3566af6d7142a809f6173e482614af239
Reviewed-on: https://chromium-review.googlesource.com/777689
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
0844d0e444
Revert "bot_update: make --output_json required in script invocation."
...
This reverts commit 331a276b54https://build.chromium.org/p/chromium/buildstatus?builder=Win&number=60914
Original change's description:
> bot_update: make --output_json required in script invocation.
>
> It's already set by recipe, so this should have 0 difference in prod.
>
> R=iannucci@chromium.org
>
> Bug:
> Change-Id: I1e1129b9748d6647e45eb26892c8e892019fe088
> Reviewed-on: https://chromium-review.googlesource.com/769164
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
TBR=iannucci@chromium.org,tandrii@chromium.org
Change-Id: Ifc40a5f89c9c770f6c0fc02aed024a6ba5f693cb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/777659
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
8 years ago
fe36710a72
Revert "bot_update: make --output_json required in script invocation."
...
This reverts commit 331a276b54https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium%2FWin%2F60913%2F%2B%2Frecipes%2Fsteps%2Fbot_update%2F0%2Fstdout
Original change's description:
> bot_update: make --output_json required in script invocation.
>
> It's already set by recipe, so this should have 0 difference in prod.
>
> R=iannucci@chromium.org
>
> Bug:
> Change-Id: I1e1129b9748d6647e45eb26892c8e892019fe088
> Reviewed-on: https://chromium-review.googlesource.com/769164
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
TBR=iannucci@chromium.org,tandrii@chromium.org
Change-Id: I65d7665e45dde539f6436ffe8932319e03f96f25
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/777619
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
f151da9fac
bot_update: refactor _git_checkout moving invariants out of the loop.
...
Bug:
Change-Id: Ie8781f73236e13c0afedf18dacf770d14563ab9f
Reviewed-on: https://chromium-review.googlesource.com/771857
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
331a276b54
bot_update: make --output_json required in script invocation.
...
It's already set by recipe, so this should have 0 difference in prod.
R=iannucci@chromium.org
Bug:
Change-Id: I1e1129b9748d6647e45eb26892c8e892019fe088
Reviewed-on: https://chromium-review.googlesource.com/769164
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
23b8214cec
[git-cl] refactor hash tags support
...
Addressing comments in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/764974
that were sent after the CL landed.
Bug:
Change-Id: I6e0a583999e1c22f86d0f6b905aa5fae62b194d5
Reviewed-on: https://chromium-review.googlesource.com/775453
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
8 years ago
d0e2cd280c
[git-cl] add support for hashtags
...
If a commit subject contains [hashtags], include them in Gerrit CL.
Replace consecutive non-alphanums with dash.
Also add --hashtag flag for explicit hashtagging.
Bug:
Change-Id: I25aed286013043263f959ff340a5b5478faa0f27
Reviewed-on: https://chromium-review.googlesource.com/764974
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
8 years ago
f78690b687
bot_update: refactor hiding ugly revision details into lower layers.
...
Bug:
Change-Id: Ie1caef2d58dce12bafbbec29fa4a5cc65076626c
Reviewed-on: https://chromium-review.googlesource.com/771856
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
8 years ago
f062cf21e4
bot_update: refactoring improving variable names.
...
Change-Id: I36c64bb46b967af00adcf69f2e867fd03204d7c2
Reviewed-on: https://chromium-review.googlesource.com/771910
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
8 years ago
1f620f0550
bot_update: refactor giant git_checkout into two.
...
Change-Id: I2c023a538bfe62955238b39034ed7460286789e5
Reviewed-on: https://chromium-review.googlesource.com/771454
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
3d50d9c5b3
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/53ae04bd603b423c9715c6dc04b3821fecd168d1 runtime recipe_module: is_experimental should default to False. (tandrii@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I16c8211c5d52e02f6af33cd604a1ef12faae5b21
Reviewed-on: https://chromium-review.googlesource.com/773799
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
recipe-roller
Robert Iannucci
Marc-Antoine Ruel
Aaron Gable
Mun Yong Jang
Achuith Bhandarkar
Andrii Shyshkalov
Sergey Berezin
Daniel Cheng
Takuto Ikuta
Michael Achenbach
Robert Flack
Nodir Turakulov