aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,235 Commits
6 Branches
0 Tags
190 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'cf31045b34'
${ noResults }
Commit Graph

9235 Commits (cf31045b347e24e6619f2564fdb0c2490f661745)
 

Author SHA1 Message Date
Stephen Martinis cf31045b34 Remove martiniss from OWNERS 
I'm leaving Chrome

Change-Id: I6dad3a55a83de4a2609d316f23e82c8f2dc729a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4117567
Auto-Submit: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2 years ago
recipe-roller d2752f24f5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8794253776620768001

recipe_engine:
aed2176f4d
  aed2176 (yiwzhang@google.com)
      add USE_PYTHON3 = True to PRESUBMIT.py

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe96885eb3c57e4881db175655ecf92c47a6d96a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4118094
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Mike Frysinger 5decb17543 cros: start warning for python 3.6/3.7 usage 
In preparation for updating chromite requirements to Python 3.8,
start warning when people run with older versions.

Bug: b:187794810
Change-Id: I7b5430384c0818bca05df5642d8583fd16204105
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4062907
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
 2 years ago
recipe-roller 41a2d0f1a0 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8794741992090716209

recipe_engine:
dc46b6c283
  dc46b6c (weiweilin@google.com)
      [resultdb] support configuring -inv-properties(-file) via resul...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: If0c5413458ff55703df34def785170a4af6ef954
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4110208
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Weiwei Lin 9ace9b4dc4 [depot_tools] roll rdb 
To pick up
https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4105423

R=meiring@google.com, mwarton@google.com, gavinmak@google.com

Bug: 1373762
Change-Id: Ic6c1b8626dd1080a8598da7cf45f818aac114559
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4109528
Reviewed-by: Patrick Meiring <meiring@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Weiwei Lin <weiweilin@google.com>
 2 years ago
Yuanjun Huang 18359bb9a1 [depot_tools] roll lucicfg 
Roll lucicfg to the same version as in c41cf36253/configs/cr-buildbucket/settings.cfg (88)

Change-Id: I595dcffb3b11cbf2008e577611a74e1addd3b328
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4108369
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
 2 years ago
recipe-roller e1c8efebe0 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8794944578143109873

recipe_engine:
a4e5d51c43
  a4e5d51 (bryner@google.com)
      Convert output to a string before calling replacer.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5555ec76d0f4d257639764a7f27738b5e08f8c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4099246
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Yuanjun Huang d291058e47 [depot_tools] roll bb 
Roll bb tool to the same version in c781c121d8/configs/cr-buildbucket/settings.cfg (96), which has already
been verified in Prod

Change-Id: Id30486841d65b598012210de7f6a1d1ea552d919
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4094461
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
 2 years ago
Primiano Tucci a964ca1296 clang-format: lookup for binary under third_party/clang-format 
This change looks for clang-format (and its script) *also*
inside third_party/clang-format (on top of buildtools/$plat).
This is to bring consistency to the recent changes [1] to
gn and ninja wrappers, which now look only in third_party
and not in buildtools/.
This is to make it so that a project can use depot_tools
without requiring both buildtools/ and third_party/
directories.

[1] See https://crrev.com/c/3925341

Bug: b/261398524
Bug: 1340825
Change-Id: I895d244592eed259ab8efa050cc87372d891246c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4079069
Commit-Queue: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
 3 years ago
Nico Weber c768fd8fc9 Revert "Use depot_tools python3 to call ninja.py" 
This reverts commit 8e77bba1ae.

Reason for revert: Very likely caused https://crbug.com/1399811

Original change's description:
> Use depot_tools python3 to call ninja.py
>
> This guarantees the python version used to call ninja.py.
>
> Bug: 1398687
> Change-Id: Ife58b285bb621dddb20b947010bc19818cd41395
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4091206
> Commit-Queue: Junji Watanabe <jwata@google.com>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Auto-Submit: Junji Watanabe <jwata@google.com>
> Commit-Queue: Nico Weber <thakis@chromium.org>

Bug: 1398687
Change-Id: I9bf469cf19134f58b3bbb44d4efa1959fe37b93f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4092694
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 3 years ago
Junji Watanabe 8e77bba1ae Use depot_tools python3 to call ninja.py 
This guarantees the python version used to call ninja.py.

Bug: 1398687
Change-Id: Ife58b285bb621dddb20b947010bc19818cd41395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4091206
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
 3 years ago
Junji Watanabe 22bbba13ce Do not show python stack trace in ninja.py when KeyboardInterrupt happens 
Before
```
❯ ninja -C out/Default
ninja: Entering directory `out/Default'
Traceback (most recent call last):
  File "/Users/jwata/depot_tools/ninja.py", line 85, in <module>
    sys.exit(main(sys.argv))
  File "/Users/jwata/depot_tools/ninja.py", line 79, in main
    return subprocess.call([ninja_path] + args[1:])
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/subprocess.py", line 351, in call
    return p.wait(timeout=timeout)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/subprocess.py", line 1189, in wait
    return self._wait(timeout=timeout)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/subprocess.py", line 1917, in _wait
    (pid, sts) = self._try_wait(0)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/subprocess.py", line 1875, in _try_wait
    (pid, sts) = os.waitpid(self.pid, wait_flags)
KeyboardInterrupt
```

After
```
❯ ninja -C out/Default
ninja: Entering directory `out/Default'
interrupted
```

Fixed: 1398687
Change-Id: I7cbc80f2214d46b492c6e9ade7b0d78766a8a6f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4085366
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 3 years ago
Chan Li d259b31644 [depot_tools] roll led 
To release 42f95c25b2

Change-Id: I0af5281e8c88da9b3fccf86cb11bf39e3582d5a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4086338
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
 3 years ago
Joanna Wang 5175d18f8a Remove branch option from git cache update-bootstrap. 
in update_bootstrap, it's only used for `git number`.
without it git number defaults to `HEAD`
and
nothing seems to actually set the `branch` option
https://source.chromium.org/search?q=%22update-bootstrap%22

Should fix the following failure: http://shortn/_nLLz2nJAGS

Change-Id: I5f3eb8497133c1e5d2f964af969ca61ab6256330
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4080542
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 3 years ago
Christian Flach a2658217d2 git-map-branches: Fix --show-subject for branches that are gone 
Without this change, the script would try to query the subject of
branches that no longer exist (these are shown as
`{branch-name:GONE}` in the output of the command).

Bug: None
Change-Id: Ia8dafe428654a1ab995dcd0be794e6fd9e25bc7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4078970
Commit-Queue: Christian Flach <cmfcmf@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 3 years ago
recipe-roller 107142ac38 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8795480609579254433

recipe_engine:
5174439768
  5174439 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 085d8f0f4a49 to bac571b53995

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5866e7ee3e5c8663e0967d3d39b9a67e2e8d95dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4083492
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Aleksey Khoroshilov 6e33ba049f Use rustfmt from third_party/rust-toolchain/bin directory. 
Chromium now has rust toolchain in a well-established directory, which is properly gated with `use_rust` gclient variable. External projects can setup this directory using their own toolchains and have rustfmt work properly in presubmit format checks.

Bug: 1395070
Change-Id: I3d1de8278b9da0db1cdb75673cb7d637ce0273ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4070004
Auto-Submit: Aleksey Khoroshilov <akhoroshilov@brave.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: danakj <danakj@chromium.org>
 3 years ago
Chan Li b5b80d27b5 [depot_tools] roll led 
To release https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4081567

Change-Id: I54cbe18f3c27e61a318195b229dd6d7882a71e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4080515
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
 3 years ago
Gavin Mak 591ebafe68 Fix external changes patching when issue number ends with <= 09 
A change ref's format is: refs/changes/X/Y/Z where X is last two digits of the CL number, Y is the entire number, and Z is the patchset number.

In cases where Y ends in XXXX09, for example, we incorrectly fetch
refs/9/XXXX09 instead of refs/09/XXXX09.

Bug: 1382528
Change-Id: Icc0b08e9ee451a75c07039913418a6802b2b62fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4080591
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Gavin Mak <gavinmak@google.com>
 3 years ago
Bruce Dawson 25334bb18e Handle goma_ctl/autoninja /? 
With nested batch files it is very common for /? arguments to end up
being interpreted as a request for help on the batch file "call"
command. That is, if a user invokes "goma_ctl /?" then this turns into
something like this:
  @call ...\python3.bat %~dp0\.cipd_bin\goma_ctl.py %*
The name of the script to be invoked is ignored and this is treated
like:
  @call /?

This is particularly problematic for commands like goma_ctl and
autoninja which don't print help if no arguments are passed, thus
making finding the correct help incantation slightly challenging.

This special-cases /? in these two batch files. Some other common batch
files were tested and found to be not affected, so while this is not a
complete fix it does hit some of the most important places.

Change-Id: Ic9b0455c2f8b085666862bc4495d9bad445dfeaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4080991
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 3 years ago
Riley Wong 8d16d4a754 Updating Lucicfg vs to 1.35.2 Fixes Nil Issue 
Bug:b/261078137
Change-Id: Icb87ded407ade1bcd1713a36b94bad8f2387b9dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4079324
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 3 years ago
Dirk Pranke ec1882fbc2 Add dpranke@ back as an OWNER. 
Change-Id: I774348ae01769a0ea8e2032d66728e10dbb428fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4074124
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
recipe-roller c4044d4e06 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8795931707510102881

recipe_engine:
928ef44068
  928ef44 (chanli@chromium.org)
      [recipes-py] led get builder accept builder in the format of "p...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1aec64ee23d3f8272294722a18086c038f3e806f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4073904
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Riley Wong 0922aaade1 Revert "Updating Lucicfg V 1.35.0 to 1.35.1" 
This reverts commit fa0a108281.

Reason for revert: Creating a null pointer issue

Original change's description:
> Updating Lucicfg V 1.35.0 to 1.35.1
>
> Version updates a bug where lucicfg fmt was erroring out on sentinel when it should safely continue
>
> Change-Id: Ic62d82176b4c9b8ded139338c7742a2b0cbe56a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072884
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Riley Wong <rgw@google.com>

Change-Id: I47c56e110f0b3acc2011fa0c169d979297856a3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072086
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 3 years ago
Chan Li 8f9920ba6f [depot_tools] roll led 
to release https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4072425

Change-Id: Ifdfc00d5aa7b092ecfeee35776bb8fdba94563fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072031
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 3 years ago
recipe-roller 0909a5aa38 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8795946175345122097

recipe_engine:
c66df993a7
  c66df99 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6f2c3501d383 to 4814885a05fd

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icbfb7dbb38c23488f7ee1cd193830efd2abc99ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072026
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Riley Wong fa0a108281 Updating Lucicfg V 1.35.0 to 1.35.1 
Version updates a bug where lucicfg fmt was erroring out on sentinel when it should safely continue

Change-Id: Ic62d82176b4c9b8ded139338c7742a2b0cbe56a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072884
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 3 years ago
Robbie Iannucci de9b59989f Revert "[lucicfg] Update v1.34.1 -> v1.35.0" 
This reverts commit 391cc612d0.

Reason for revert: This broke `lucicfg fmt`.

Original change's description:
> [lucicfg] Update v1.34.1 -> v1.35.0
>
> This is to pick up 91566b068c
>
> Change-Id: I1a644f362dbd16cc53825a619faf83d9b2c70ac1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4067805
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

Change-Id: I7a6e10eaa66fb068fbeb78e5638af9cb4a51590e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4067398
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Anushruth Sasivehalli <anushruth@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 3 years ago
Riley Wong 391cc612d0 [lucicfg] Update v1.34.1 -> v1.35.0 
This is to pick up 91566b068c

Change-Id: I1a644f362dbd16cc53825a619faf83d9b2c70ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4067805
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 3 years ago
Junji Watanabe ad452a7204 Fix autoninja to call ninja.py 
ninja.exe will be removed from depot_tools soon.
Calling ninja.py finds the ninja installed by DEPS or one in PATH.

Bug: 1340825
Change-Id: I32ed6d8e5b0498347042490eedeca19972d35233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4061247
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
 3 years ago
Chan Li 141be0c7fe [depot_tools] roll led 
Bug: 1393265
Change-Id: I57e5ae59ea6e35755c50f9cdaa7e44fe81ea1f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4064699
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
 3 years ago
recipe-roller 67828ff1bb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8796177701879779825

recipe_engine:
67bac822e5
  67bac82 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 7d56fc0f58a4 to 7a04ca7c0fd3

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7c95ef2ba5daba8f6380702a0c745edb10210e6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4063573
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Junji Watanabe fc04ff1628 Call ninja.py from compile_single_file.py 
ninja.exe will be removed from depot_tools soon.
depot_tools/ninja.py finds the ninja installed by DEPS (or fallback to ninja in PATH).

Bug: 1340825
Change-Id: I0fefe7a3fdb254ca0025d9d8d4490675ac718184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4061246
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 3 years ago
Victor Vianna 9a6aa08468 Suggest --no-fetch flag after git rebase-update conflict 
This spares an unnecessary git fetch.

Change-Id: I552148bdfadc3482bda0d71d75aaf9d9ed61d75d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4062088
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
Mike Frysinger 84edf22d0e repo: update to 2.30 launcher 
Change-Id: I66a830a22488a9b8b7d8cc00857efa144e153648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4054940
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 3 years ago
Travis Lane 738b48a0bf Avoid full fetches with gclient sync --no-history 
This reworks the behavior of gclient sync --no-history to avoid fetching
the full repository history. This is accomplished by initializing a bare
repository and fetching the ref we are interested in.

Bug: 1305189
Change-Id: Ifea2a061308c354be15abd4e945141599ec20c9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3883766
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Travis Lane <travislane@google.com>
 3 years ago
Gavin Mak d83509c0c3 Move presubmit_canned_checks tests under tests/ and fix 
Only tests under tests/ are run on presubmit, so
presubmit_canned_checks_test.py is not run. Move these there and fix
them.

Bug: 1385693
Change-Id: Ib01a816b0a81919722ea49e5551010251c0e3287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4038514
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
 3 years ago
Bruce Dawson 0115386a26 Switch from VS 2017/2019 support to VS 2019/2022 
This drops support for packaging toolchains based on VS 2017 and adds
support for VS 2022. This will allow us to package a toolchain for
building Chrome using the latest tools.

Bug: 1273169
Change-Id: I1981c935d1a9f3f4ae25e4643b9956fbdd705be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4054349
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 3 years ago
recipe-roller 73a26246e5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8796660886911891793

recipe_engine:
ff5ce51cea
  ff5ce51 (sshrimp@google.com)
      Revert "Check created_by to ensure cq tags were copied on retry...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4748ec97c46ebb28bdfd12b48aeafd3d736fcff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4054460
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 6fde0fbe92 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8796734484111755233

recipe_engine:
189a0bb4a1
  189a0bb (akashmukherjee@google.com)
      [bcid] Uprev provenance broker tool.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8a4dc43b8384e422d439ae8896efb7124b227501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4050460
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Allen Xie 60af816019 depot_tools: Roll rdb and result sink 
Include crrev.com/c/4037071 via
337392bc26

Regenerate cipd_manifest.versions using `cipd ensure-file-resolve -ensure-file ./cipd_manifest.txt`

rdb rollout example: crrev.com/c/3627691

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=1385957
TEST=No test

Change-Id: I311bede115afa0bcb3b5e0530d3381c46ceb37ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4050062
Commit-Queue: Zhihui Xie <zhihuixie@google.com>
Auto-Submit: Zhihui Xie <zhihuixie@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
 3 years ago
recipe-roller 2fc7e1ffd5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8796757773764910801

recipe_engine:
6fefccf8bd
  6fefccf (bpastene@chromium.org)
      Allow chrome branch projects to call cq recipe_mod's owner_is_g...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I561d40bec1d53c797d82e78dae9b332695a140ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4049625
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Fumitoshi Ukai 30e3ce8b1c Roll out goma client VERSION=255 
Bug: b/256548869, crbug.com/1386100
Change-Id: If9367944461e8b4d1b775a087abd8fcc1a224b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4045102
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 3 years ago
recipe-roller d06e475934 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797135889494218401

recipe_engine:
b63398006f
  b633980 (kuanhuang@chromium.org)
      LUCI Analysis: roll the proto.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id10141d7f13cd13bbb412a9a885be44466a3cea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4037596
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Brian Osman a0cf432171 Tweak ninja fallback logic 
In Skia (for example), GetPrimarySolutionPath works, but FindGclientRoot
does not (users tend not to use gclient to sync DEPS, etc).

Without this change, we'd get to the loop. If a user had pulled ninja to
third_party/ninja/ninja, then it would work just fine. If they hadn't,
python would throw an exception on the os.path.join line, because we'd
be passing a NoneType as the first argument.

Bug: chromium:1340825
Change-Id: Iab86450c5b6f00bc9c2716b9504debc9a56d9bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4034942
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
 3 years ago
Bruce Dawson 31ca877242 Fix CheckLicense tests 
A last minute change to the CheckLicense tests in crrev.com/c/4032366
used the _GetLicenseText function in the wrong place, thus neutering one
test and duplicating code in another. This fixes the tests so that they
minimize duplication and actually test the CSS/C style comments.

Change-Id: Ibbe880dec8d1e85416ed1b7ce94922c6f2c2a543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4037103
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 3 years ago
Junji Watanabe 1f67d5573f Add ninja wrappers to trigger DEPS ninja 
This is the first step to deprecate ninja binaries in depot_tools.

depot_tools/{ninja, ninja.bat} will call ninja.py, which finds CIPD ninja under src/third_party in the current gclient source tree. https://crrev.com/c/3869740

If it fails to find, it does fallback to an existing ninja binary in depot_tools, until removing the references to the legacy ninja binaries.

# For those who see the deprecation message,
You need to install ninja using DEPS at your project. (https://crrev.com/c/3869740 is an example.)

If your project doesn't have DEPS, you need to install ninja and include it in PATH manually. e.g. sudo apt install ninja-build

Test:
Linux builder: https://ci.chromium.org/swarming/task/5e9cfc917aa3f110?server=chromium-swarm.appspot.com
Windows builder: https://ci.chromium.org/swarming/task/5e9d48885c460b10?server=chromium-swarm.appspot.com

Bug: 1340825
Change-Id: I70d1863d72ddfa65b87a62c9bde8ff63f7641d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3925341
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 3 years ago
recipe-roller aad574d446 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797220197766658801

recipe_engine:
cd88b2f65f
  cd88b2f (yuanjunh@google.com)
      [file] handle non-encodable string in listdir cmd

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9b46affdb5017b1f3e634278b696b9faf8fb2b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4035067
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Gavin Mak f35a9ebe8a Don't prompt unsignificant external changes 
Description changes shouldn't prompt. Changes like these that don't
change code or the merge base won't get overriden anyway.

Bug: 1382528
Change-Id: Ie1947a28ea97a8383a791e76738a2ad20c349878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4033329
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 3 years ago
recipe-roller be242dbeac Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797228374896861665

recipe_engine:
a2528d57f4
  a2528d5 (sshrimp@google.com)
      Check created_by to ensure cq tags were copied on retry builds

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibae12c0e282e078c53c459270ae723212f51203b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4034374
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago