aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,007 Commits
6 Branches
0 Tags
190 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'ce4aac950f'
${ noResults }
Commit Graph

10007 Commits (ce4aac950f17cd460c4c8bbb15b0e5011810aa0c)
 

Author SHA1 Message Date
recipe-roller ce4aac950f Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8766760104840571473

recipe_engine:
58fefbd25c
  58fefbd (chanli@chromium.org)
      [buildbucket]recipe_module:allow schedule shadow child builds i...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54b4c0c57cf2a58246598c020960957bc604eefa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4957523
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 767a521586 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8766787795919569697

recipe_engine:
909800ddc2
  909800d (ayatane@google.com)
      [bcid_reporter] Uprev provenance_broker

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic01172b2b1f594315a9a9824ec784036ee06ba51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4954951
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Daniel Cheng 8f761f5795 Mention updating inclusive language excluded directories for 3p code. 
In an ideal world, exclusions to this check would never be needed, but
for third-party code, fixing this can often be non-trivial (e.g. it
might involve renaming git branches and fixing CI infrastructure).

Change-Id: I7e27f5a65fce0d8356765b58474c23321d1cf361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4944933
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
 2 years ago
Fumitoshi Ukai 406be8281e autoninja: don't allow use_siso=true and use_goma=true 
Bug: b/306048338
Change-Id: Ib34eb5abe3c419d4afefb7a9cd083441ef755110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4951553
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
 2 years ago
recipe-roller a3ae284553 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8766941306795794337

recipe_engine:
748f6ffd0e
  748f6ff (mohrr@google.com)
      [buildbucket] Add test_data arg to search()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic2c4ad66883f34917ea3430b2ea20596aeff78b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4950815
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Andrew Grieve 491aa5d18a Do not fail "git cl format" when google-java-format.jar is missing 
The file is conditionally downloaded in chrome, and we do not want to
have "git cl format" fail when editing a .java file on non-linux /
non-android checkouts.

Bug: 1462204
Change-Id: I5fc3b74484e1d9304089118449678acb506d5831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4943676
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
recipe-roller 3d0d2793cf Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8767047632773177233

recipe_engine:
5699c27a54
  5699c27 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 143c67d734d9 to 924cfd2323a9

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I195bdb48b2178ced3acbd15e94e458506653e27b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4943382
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 73b69b0167 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8767315649605498593

recipe_engine:
a0b2af1af3
  a0b2af1 (yuanjunh@google.com)
      [recipe-py] Add config_service protos into recipe_proto

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iec7a4129b88d31a3b1c407637f025dfc52b2d24a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4939343
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Yiwei Zhang f2f500022d git_cl: add a long option for git cl patch -b 
R=sokcevic

Fixed: 1492418
Change-Id: I09b7b05c8eb4968f079303406c474f90c34b66a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4937884
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Junji Watanabe c51829968b [autoninja] Update Siso .ninja_log comments 
Siso is going to generate non-empty .ninja_log for the analysis tools.
https://crrev.com/c/4907677

This CL fixes the comment about empty ninja_log.

It's not compatible with Ninja's .ninja_log. So `gn clean` will still
be required.

Bug: b/298594790
Change-Id: Ib4c60f3ed22f516d6f7e2847aaf57e228121eccf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4937692
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 2 years ago
Alexei Svitkine a51863b2f8 Fix missing \n in an error message. 
Change-Id: Icd567773f56b977afd7725f9ecfff51311ef381f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4937211
Auto-Submit: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 2 years ago
Philipp Wollermann 0b943400a4 Execute Ninja / Siso directly from autoninja.py. 
Instead of printing a command-line, we just directly call into the respective main functions from Python. This saves spawning another interpreter and prevents things that can go wrong from having to quote, unquote, split and tunnel arguments through shells.

Part of my bigger auto{ninja,siso} refactoring.

Tested:
- Handling of the ^^ suffix on Windows still works correctly.
- Handling of error codes - i.e.; making sure
  "autoninja base_unittests && base_unittests.exe" behaves properly
  in the success/failure case.
- Make sure the command prompt title is reliably reset on exit.

I tested autoninja with all combinations of these:
- Host platform: Linux, macOS, Windows
- Remote GN args: <none>, use_goma=true, use_remoteexec=true
- Siso GN args: <none>, use_siso=true
- Targets: base, ../../base/types/expected_macros_unittest.cc^ (on Linux) and ../../base/types/expected_macros_unittest.cc^^ (on Windows)

R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org

Bug: b/293657720
Change-Id: I275a775fdc5abb6555f79d4beab76cd0914d4bd6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924185
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
 2 years ago
Andrew Grieve 69e597f8e5 Do not fail formatting when google-java-formatter is not found 
A missing google-java-format should not break older chromium branches
and non-chromium projects. This causes the formatting step to skip .java
files when google-java-format is not available, and introduces an
environment variable GOOGLE_JAVA_FORMAT_PATH to set a custom path.

Bug: 1491627
Change-Id: I5e3155553630ddc59c1a8d197e96079f6a372454
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4930437
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Philipp Wollermann aabd869daf autoninja.py: Add unit test for gn_lines with 100% coverage 
Part of my bigger auto{ninja,siso} refactoring.

R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org

Bug: b/293657720
Change-Id: I5c228ecf9910b0a8ce18afc816f213f08b941299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924715
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Philipp Wollermann <philwo@chromium.org>
 2 years ago
Jeff Yoon 4566632822 [dirmd] Roll dirmd in depot_tools 
Changes include:
* crrev/c/4925716
* crrev/c/4909980

Bug:1488997, 1491512
Change-Id: I46ad310f32fe747ee9f3607ddeb0f37c2a660976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4928010
Reviewed-by: Arthur Wang <wuwang@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@google.com>
 2 years ago
Philipp Wollermann 2ef0787c49 Add a config file for the flake8 linter. 
Part of my bigger auto{ninja,siso} refactoring.

R=brucedawson@chromium.org, jwata@google.com, tikuta@chromium.org

Bug: b/293657720
Change-Id: I2a7783b8675ecc7dac16a490a290b2edf4b9d64d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4924716
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Auto-Submit: Philipp Wollermann <philwo@chromium.org>
 2 years ago
Ben Segall 4d6298fabb Revert "Enable racing for ninja+reclient developer builds" 
This reverts commit bb67064617.

Reason for revert: Racing has been enabled explicitly in developer cfg files

Original change's description:
> Enable racing for ninja+reclient developer builds
>
> Bug: b/288564971
> Change-Id: Ibae8f86b7c79b9fa218e0f04c75fe99414c4f48b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4844059
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Commit-Queue: Ben Segall <bentekkie@google.com>

Bug: b/288564971
Change-Id: I480be53a9c19a6c9f89321cb52a5adde9baa28b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4889572
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Ben Segall <bentekkie@google.com>
 2 years ago
Arthur Eubanks 92d8c4e0cf [git-cl] Ignore moved/copied/deleted files for formatting purposes 
Bug: 737568
Change-Id: I9888d1b2c392503a1d98579445cda8eee97bd07f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4904205
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Arthur Eubanks <aeubanks@google.com>
Reviewed-by: Hans Wennborg <hans@chromium.org>
 2 years ago
recipe-roller 2ea383731c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8767696910391068833

recipe_engine:
a490ce84e4
  a490ce8 (iannucci@chromium.org)
      [recipe_modules/file] Switch fileutil.py to python 3.11

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5e6689ce8ddaa60d13b4683cbdfd8de38580c1ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4922634
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Mike Frysinger ffd07cc90d cros: handle CitC checkouts 
Change-Id: Ie1183f1e6daca9cda9fb685c18b244a2defe99f3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4922171
Commit-Queue: George Engelbrecht <engeg@google.com>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: George Engelbrecht <engeg@google.com>
 2 years ago
Joanna Wang 6aed4f5a0c Clarify that gclient gitmodules' changes need to be committed. 
Bug: 1483198
Change-Id: I1dfae06bfc273b01d168b507861984327ad0d629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4892468
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2 years ago
Ben Segall 0471c76c58 [reclient] Use python impl for reclientreport for all platorms temporarily 
Bug: b/301574845
Change-Id: I96f67b4cf791707a0bc2c8e0459bb4002b64a228
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4887767
Commit-Queue: Michael Savigny <msavigny@google.com>
Reviewed-by: Michael Savigny <msavigny@google.com>
Auto-Submit: Ben Segall <bentekkie@google.com>
 2 years ago
Josip Sokcevic df30961664 Trigger recipe roll 
This is to pick up https://crrev.com/c/4914238

R=jojwang@google.com

Bug: 1486677
Change-Id: I024a7a0dd6b6613987e6ded88b62db37aef16409
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4916209
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Fabian Sommer <fabiansommer@chromium.org>
Reviewed-by: Fabian Sommer <fabiansommer@chromium.org>
 2 years ago
Joanna Wang 60adf7b6d9 sync: Ensure child dependencies are always removed first. 
Fixed: chromium:1454643, chromium:1486677
Change-Id: I3f8f5f9a2e2419830e94fa1419292717820830c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4914238
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Joanna Wang c2e0061723 Use diff.ignoreSubmodules=all when committing patches. 
Bug:1486973
Recipe-Nontrivial-Roll: build
Change-Id: Ifde97d61d55e7f78068bc2f745ec0816bbb5d694
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4909801
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Thiago Perrotta 32e7363c50 git: tweak fsmonitor warning message to mention the git version fix 
R=avi@chromium.org, sokcevic@chromium.org

Bug: 1475405
Change-Id: Iaa29a2993871837352eb9d02d368102a212edf49
Follow-up-of: https://crrev.com/c/4892305
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4911838
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Thiago Perrotta <tperrotta@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Takuto Ikuta 1553f03225 remove unnecessary file writes from tests 
Change-Id: Ic6da86d05ac29d13c727a1fbe1229e45a846cb14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4905171
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 2 years ago
Yuanjun Huang 5dffbd43c4 [config] change to use luci-config v2 in presubmit 
In `CheckChangedLUCIConfigs`, it will call luci-config to list all
config sets. Change that call to v2.

Change-Id: I7a00d157fa631174b2124f0920026fa6b1fea04c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4900076
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2 years ago
Andrew Grieve 6e8c18239d Cache values in gclient_paths.py 
Several clients of this module call its methods repeatedly. Cache them
to speed them up.

E.g. "autosiso" calls FindGclientRoot() 5 times before building
E.g. "git cl format" calls it 5 times in one of my CLs.

Bug: None
Change-Id: I70995c2def9689d46a89896640cc748d9629df3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4904697
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Yiwei Zhang e5c422c9cc roll lucicfg to v1.39.20 
Notable change: https://crrev.com/c/4902082

R=yuanjunh

Bug: 1449933
Change-Id: Ic9dd98400a0e8efa53787c6171f99c5e07d6ebba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4902887
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
 2 years ago
Andrew Grieve 3008d7ec82 git cl format: Enable google-java-format by default. 
Removes --google-java-format and adds --no-java.

Does not provide a way to fallback to clang-format, since there is no
established way for projects to declare which formatters they prefer to
use.

Bug: 1462204
Change-Id: Ie116e73ccad0fbd55c968248ae2ebeca130a3f80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4905866
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
 2 years ago
Chenlin Fan 422ba5b9a5 New vpython to depot_tools. 
Update bundled 3.11 to 3.11.5.chromium.30

Change-Id: I48912ab4b4bd86566dd89ee587d9cfe19ec626a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4905158
Commit-Queue: Chenlin Fan <fancl@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
 2 years ago
recipe-roller f90b3b035c Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8768304036109154497

recipe_engine:
ba4a2a613d
  ba4a2a6 (gregorynisbet@google.com)
      [recipes] Add validation for sub_build API

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iea2c8a217577c5c160d60353748a15a1f7b53cf0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4908375
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 90a30a5b53 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8768579601945155153

recipe_engine:
d6b82b7cd8
  d6b82b7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2c2d4e4ba852 to 4d1a67cc1301

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9d4f88e1ab2ba48dad2af1d53bf3495f5d81ece3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4906088
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Yuanjun Huang 4c1d6d90bc [auth] Be able to generate id_token 
Make auth be able to generate id_token. Some services on Cloud Run will
need it (e.g. luci-config v2).

Bug: 1487020
Change-Id: Icfe95002f93ee552b99ab2694c7b777e2322484b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4899437
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
 2 years ago
recipe-roller 68318472db Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8768692847281921857

recipe_engine:
0a42b2afe8
  0a42b2a (iannucci@chromium.org)
      Remove all patchups from importer.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie813a82b30dbac3244a377452914ef695cfd9fa7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4901882
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Maggie Chen 34e0ecf20e Change from PresubmitError to PresubmitWarning for bad license 
We cannot distinguish if this is a moved third-party file. So just
do warnings for a license header from a third-party company.

Bug: 1462922
Change-Id: I78394dcccb9028bce6c535dfce625364dd29157b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4895337
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
 2 years ago
Thiago Perrotta 853b29f65d depot_tools: add an `--auto-submit` alias to `--enable-auto-submit` 
It is easier to remember.

Bug: none
Change-Id: Ic011c2b0bbbde364b69e5db91566748e72946264
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4892967
Commit-Queue: Thiago Perrotta <tperrotta@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2 years ago
Junji Watanabe 3359097e9e Update goma version to 262 
Bug: b/301042082
Change-Id: I9cc5dd4291392c7ac561ce98d86e2e6379a1f703
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4895964
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 2 years ago
recipe-roller 0846064bc2 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8768843214116191249

recipe_engine:
4c3d41bcf2
  4c3d41b (renewitt@google.com)
      Clarify some of the SBOM report fields

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I27f671ccb4c759296f73ea7ddf92d4feb06bbe2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4894616
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Eli Trexler 8609345923 Revert "Clear existing Change-Ids from description if issue is 0" 
This reverts commit 36d937d16d.

Reason for revert: Not sure the best way to notify you about this, but suspect this is the root cause of https://chat.google.com/room/AAAAXGgrwSo/hZDeSAsoQ4k

Verified via rolling back depot_tools

Original change's description:
> Clear existing Change-Ids from description if issue is 0
>
> git cl upload may not create a new change even if issue is 0 because
> of a leftover Change-Id footer in the commit message.
>
> Bug: 1484251
> Change-Id: Ibee0542e0f5a2cbf930b1882892fbb7640054b69
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4880971
> Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
> Commit-Queue: Gavin Mak <gavinmak@google.com>

Bug: 1484251
Change-Id: Ic3230fd7432f57bf9f3d0266b2e2c0df6a7e9bae
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4893199
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2 years ago
Gavin Mak 36d937d16d Clear existing Change-Ids from description if issue is 0 
git cl upload may not create a new change even if issue is 0 because
of a leftover Change-Id footer in the commit message.

Bug: 1484251
Change-Id: Ibee0542e0f5a2cbf930b1882892fbb7640054b69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4880971
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
Ben Segall 1077fbe08a [reclient] Only show shutdown msg if ctrl-C end the build 
Bug: b/300284667
Change-Id: I28151a974cd20cb5ec7a789cf7f7cd0c926b4486
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4864734
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Ben Segall <bentekkie@google.com>
Auto-Submit: Ben Segall <bentekkie@google.com>
 2 years ago
Josip Sokcevic d95084e851 Adjust fsmonitor alert for Mac 
Version 2.43 contains a fix for fsmonitor. Google managed git already
contains the fix.

R=aravindvasudev

Fixed: 1475405
Change-Id: I388b1e14e070595b8b0c6bca046dd3af2248a0ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4892305
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
 2 years ago
recipe-roller 0827dd28f1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8768944507024259233

recipe_engine:
583202c4f3
  583202c (atyfto@google.com)
      [cipd] Hash the version in cipd.ensure_tool()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3248dcc8eba505778213b2c99a4b29333c83a588
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4892304
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Yiwei Zhang 6ededf8bea roll lucicfg to v1.39.19 
To pickup: https://crrev.com/c/4888890
and a fix: https://crrev.com/c/4889787

R=yuanjunh

Change-Id: I124a79f88b91a35f0c65ddb20502b273478c2279
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4892324
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
 2 years ago
recipe-roller 7f07a2679b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8768950797819272241

recipe_engine:
1eecf8fa10
  1eecf8f (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from aba49158ee65 to 2cc30870896f

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia097455979cb33a48443603206878bace8ac724c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4884746
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Gavin Mak f936d540e1 Remove __future__ imports 
All __future__ imports (unicode_literals, print_function) are already
mandatory in py3. Also remove an outdated py2 comment in
presubmit_canned_checks.py

Bug: 1475402
Change-Id: I27cf6a8268f6dd1081f22af782c4c29a975376ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4867135
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
Junji Watanabe c5505889cf [gn] Fallback GN in PATH 
This allows us to call GN outside of gclient checkout.
e.g PATH=$PATH:~/chromium/src/buildtools/linux64 gn

Change-Id: Ib4b6d09fbd4d3a12ea1407fcea0eb5494c808fb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4886535
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
 2 years ago
Joanna Wang 4af2818c5b Fix path's current and new url comparison. 
Steps to reproduce:
https://bugs.chromium.org/p/chromium/issues/detail?id=1484613#c2

Bug: 1484613
Change-Id: Id42e8e8019334444d6b2423550f04f3869e43bbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4875677
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2 years ago