aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
10,160 Commits
6 Branches
0 Tags
188 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'cd076ba1b0'
${ noResults }
Commit Graph

10160 Commits (cd076ba1b0be061d4446e47f68b3ec53122ce95c)
 

Author SHA1 Message Date
Scott Lee a3f3465f48 [depot_tools] add optional param `depth` in git checkout 
It can be used to reduce the size of payloads to download in git fetch
operations.

Change-Id: I631af18bee01eaa829d3d4755a57935690a99a85
Bug: 1508826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5091760
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 1 year ago
recipe-roller 60f6c8a860 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762411459081330273

recipe_engine:
bb81400a29
  bb81400 (iannucci@chromium.org)
      [path] Remove dependency of path module on the platform module.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4c0fe7ce1c9a2e022a48703365a6b03e51b83029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5095960
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 916dda0a0b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762530363196749409

recipe_engine:
66b4d49410
  66b4d49 (iannucci@chromium.org)
      Remove platform_ext from Path.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib2e3017aa4e706578de2bde6e944bebb000aba21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5085724
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 963000950b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762590764419191425

recipe_engine:
a2efad720f
  a2efad7 (iannucci@chromium.org)
      [step] Clarify how steps without cmd should be used.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaf3b506ea7158ea42a5a7c033c7f4ecebc740faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5086211
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Aravind Vasudevan 259774c3ac [gclient_scm] Update _CheckClean() to use `git status` 
This change updates the `_CheckClean()` fn to use `git status` instead
of `git update-index` and `git diff-index`. The `_CheckClean()` fn is
run during every update and this change reduces the subprocess calls
made by it by half.

Change-Id: Ie9a23b0bce748bec4cac88df09655569e88e4841
Bug: 1501984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5076224
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 1 year ago
recipe-roller 29672fbb92 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762595163202012961

recipe_engine:
1359680708~..d0e40ef56fa57e2dd3c0fae03f7bec723a56916a
  1359680 (olivernewman@google.com)
      [engine] Improve error for missing test deps
  d0e40ef (chanli@chromium.org)
      [recipes-py] Roll LUCI proto

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7843c2b9dc889446993aeb74c82e1f3a3407da43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5086208
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller 34256ef66a Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762596427481436401

recipe_engine:
b16c348b02
  b16c348 (bryner@google.com)
      Run archive module scripts under python 3.11.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I596527cf4c5c9fbc100ad90a060b2fd94a8a1dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5086207
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Ryan Macnak 1fd8a6fa56 Roll packages to make linux-riscv64 available. 
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1138584
Bug: https://github.com/dart-lang/sdk/issues/48545
Change-Id: Ibcd10ce402abc8d3d4b3e6e2c045be9c97fb5c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5076225
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 1 year ago
Chan Li 68a9928f42 [depot_tools] release led 
Change-Id: I1c80cf822751b48791b88a848aa1dde4a1631eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5084558
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 1 year ago
Dirk Pranke 081bca8cb3 git_cl: Attempt again to fix xml format on Win 
It turns out that we need forward slashes in one place and back
slashes in two other places, so neither path by itself will work.

This CL changes things to do the slash substitution as needed.

Bug: 1502689
Change-Id: I05681ca5aff9f02a1c4ecc14c3c4e877312118ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5074657
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 1 year ago
Michael Savigny 8d97b6d89b Add mac-specific reclient tweak. 
Set cas_concurrency for mac builds to 100.  It doesn't affect
performance on high-speed networks, but has shown an improvement on
networks prone to congestion.

Note that these adjustments have been checked out for builds on macs, and the cas_concurrency value being a default of 100 for mac doesn't mean it should be the default for other oses.

Bug: b/304616237
Change-Id: I9431fdb35737f9f2b236296625af2f2a31e52754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5075857
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Michael Savigny <msavigny@google.com>
 1 year ago
Takuto Ikuta cccca95d8f Revert^2 "autoninja.py: disallow external account from corp machine" 
This reverts commit ed596dadf9.

Reason for revert:
Ignore exception when getting account for application default
credentials.

Original change's description:
> Revert "autoninja.py: disallow external account from corp machine"
>
> This reverts commit 0d0f28a4fc.
>
> Reason for revert:
> http://b/309720176#comment7
>
> Original change's description:
> > autoninja.py: disallow external account from corp machine
> >
> > This disallows Googler to use non-google account with reclient and
> > siso from corp machine.
> >
> > Bug: b/309720176
> > Change-Id: I8077eff8bbf47f579462e1fefa3609a5d492a013
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035266
> > Reviewed-by: Philipp Wollermann <philwo@chromium.org>
> > Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
>
> Bug: b/309720176
> Change-Id: I62b4891b1e2e2554d088d162057982b95c8adcd7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065849
> Reviewed-by: Philipp Wollermann <philwo@chromium.org>
> Owners-Override: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: b/309720176
Change-Id: Ib9aef1b7fa8e3c9bb20ac8d6b461c6bcff72dc83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065052
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 1 year ago
Aravind Vasudevan 8197d724a6 [detect_host_arch] Cache HostArch() function 
From my recent go/gclient-sync-no-ops analysis, I noticed that
HostArch() is repeated called within get_builtin_vars() fn. The
`platform.architecture()` call made in arm-based systems and some x64 is
expensive and adds to gclient sync's runtime when repeatedly called.

When caching HostArch(), I noticed 22.4% speed-up in incremental no-op
gclient sync when run on arm-based machine.

Change-Id: I962c4fb0879d2931268f5bec1678ef782c56e7f2
Bug: 5076224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5076226
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 1 year ago
Ricardo Ribalda 8bd4d87e35 New lucicfg version 
This change includes commit:
luci: cq_tryjob_verifier: Add support for check_all_revision_kinds
https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5057018

BUG=b:311018627
TEST=cipd ensure-file-resolve -ensure-file cipd_manifest.txt

Change-Id: I68a694358edfcc91bf98554af56b224ae8d2131d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5075457
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 1 year ago
Takuto Ikuta b5393e57bb ninjalog_uploader.py: use cipd to check authenticated account 
Googlers authenticate with CIPD now to use reclient.

This is for
https://crrev.com/c/5035266/20#message-6bcb2d14f6758d0ba82d5cff99d699985c934707

Change-Id: Ie78675e6f7a8b47f7cafd85141f87139d1472f1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5058275
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 1 year ago
Chenlin Fan 9e5fc28b6b New vpython to depot_tools. 
This change includes commits:
00e23cbde55df05e0e42f7a574c79ff8bcf589c4 vpython: match tag before verify

Bug:1501997
Change-Id: Ibabde88c588a830707bf14be7e2998fa4b4152fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065788
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
 1 year ago
recipe-roller bba669b4d6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8763143780772239905

recipe_engine:
ee2fea4d6a
  ee2fea4 (iannucci@chromium.org)
      [file] Clean up some py2 compatibility things.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I72ecf283ff4b88b03295740c521823bd2f211c9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5068319
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller c4b10a0bb1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8763151332512699345

recipe_engine:
f91d29f252
  f91d29f (iannucci@chromium.org)
      [recipe_modules/buildbucket] Remove futures/six/past usage.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1632e5c8fcd16e4db9135752886ee14d5927b015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5068914
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Josip Sokcevic f2f8be1ca8 [pylint] Use correct variable name 
pylintrc should have been used instead of pylint.

R=ddoman@google.com

Change-Id: Ia1cef7645119af0e938714acfca17b8b69d2cad8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5066856
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
 1 year ago
recipe-roller 85c07c1f36 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8763189711682734545

recipe_engine:
2c98ffa51c
  2c98ffa (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e3def72641fe to 1ea45c182951

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id64a6b598112605541bb3828c3389ec46bbb9b7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065012
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
recipe-roller fad4d1ebd5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8763203553111530465

recipe_engine:
3586c437a4~..49696b810942f00f7ad460fb21cc37bb95c37bdc
  3586c43 (bryner@google.com)
      Use packaging_legacy to preserve the behavior of the version mo...
  49696b8 (mwarton@google.com)
      resultdb: roll recipe protos to latest version

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifd11ec760749b5c5c19b7ac5f8c45bcbcd6892cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065011
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 1 year ago
Takuto Ikuta ed596dadf9 Revert "autoninja.py: disallow external account from corp machine" 
This reverts commit 0d0f28a4fc.

Reason for revert:
http://b/309720176#comment7

Original change's description:
> autoninja.py: disallow external account from corp machine
>
> This disallows Googler to use non-google account with reclient and
> siso from corp machine.
>
> Bug: b/309720176
> Change-Id: I8077eff8bbf47f579462e1fefa3609a5d492a013
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035266
> Reviewed-by: Philipp Wollermann <philwo@chromium.org>
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>

Bug: b/309720176
Change-Id: I62b4891b1e2e2554d088d162057982b95c8adcd7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065849
Reviewed-by: Philipp Wollermann <philwo@chromium.org>
Owners-Override: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 1 year ago
Takuto Ikuta 0d0f28a4fc autoninja.py: disallow external account from corp machine 
This disallows Googler to use non-google account with reclient and
siso from corp machine.

Bug: b/309720176
Change-Id: I8077eff8bbf47f579462e1fefa3609a5d492a013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035266
Reviewed-by: Philipp Wollermann <philwo@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 1 year ago
Josip Sokcevic 0acc468d8b Trigger recipe roller 
To pick up pylint-2.17

R=ddoman@google.com

Change-Id: I49f9d7b50b0a0edd477f2ac75bd097535d3d54bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065009
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2 years ago
Josip Sokcevic a52cc055e4 pylint: Add pylint 2.17 
R=ddoman@google.com

Change-Id: Ice31996ebf774259a902399712774006ff4627ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5062345
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
recipe-roller 02b6134eb4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8763240043366315521

recipe_engine:
c12bd68609
  c12bd68 (mohrr@google.com)
      [path] Use os.makedirs(exist_ok=True)

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6a95dd0d28d26049d64ace0c0127c54665298c1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5062338
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller f01ca5848d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8763260172466735841

recipe_engine:
c6e4e93c25
  c6e4e93 (mohrr@google.com)
      [defer] Drop "collect" step

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id8a031287688f6e2ec7387b5de9f92d42f360655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5062329
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Takuto Ikuta 9c44fe5fca fix typo: director -> directory 
Change-Id: Ic2d3ea0dbaad27aad13dcfc6cc3c4f5c1fd8c545
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5055942
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2 years ago
Josip Sokcevic 25b4354fad Revert "pylint: Add pylint 2.13" 
This reverts commit 86c7f734f5.

Reason for revert: pylint 2.13 doesn't work well with py 3.11

Original change's description:
> pylint: Add pylint 2.13
>
> Bug: 1500415
> Change-Id: I05293251be810772c56530962ef5a33a0f0cc887
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030756
> Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
> Reviewed-by: Brian Ryner <bryner@google.com>
> Reviewed-by: Scott Lee <ddoman@chromium.org>
> Commit-Queue: Scott Lee <ddoman@chromium.org>

Bug: 1500415
Bug: 1504663
Change-Id: I4a679422385767a1b78493f3a322b2a065d75d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5055994
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
 2 years ago
recipe-roller 5eef793337 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8763690510186665841

recipe_engine:
259924fefe
  259924f (gbeaty@chromium.org)
      Enable setting a retcode for a canceled step.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibbef8dd4c6c08a6cb71c11aa2ded7e6120103e5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5054043
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Takuto Ikuta 8efb05d3d4 check `siso summary` 
This is to make sure that the command runs as intended and make more
verbose if it has some error.

Bug: b/312632221
Change-Id: I44b372452b37b744f6c02c5a2e34fafe3717e351
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5051585
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 2 years ago
recipe-roller 38b8de056e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8763864785755509953

recipe_engine:
421035bba2
  421035b (randymaldonado@google.com)
      [recipes-py] adding some task backend helper functions for migr...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib7577d5bdea5e8a7dcdd2546b1d471d4a77bee40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5046445
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Josip Sokcevic f078723bf4 [recipes] Trigger recipe roller 
To pick up pylint-2.13 fix

Change-Id: Ie1710a4bc54a7ee6144bc09da719ce1e7db1fa5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5046548
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2 years ago
Josip Sokcevic c348ad841f [pylint] Upgrade dill version 
pylint-2.13 with py3.11 doesn't work with dill-0.3.4. If multiprocessing
is used (--jobs > 1), pylint spins forever. Upgrading to dill-0.3.7
solves the problem.

Bug: 1502901
Change-Id: I78827c505146261e8ade7c907c0c9d2dc6fe8f7a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5046339
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
 2 years ago
Josip Sokcevic eb48a6ac0f git_cl: Fix xml format on Win 
Diff paths are no longer normalized, and we can use forward slashes as
separators regardless of the platform.

R=dpranke

Fixed: 1502689
Change-Id: I75a2fe824972f0d98b28eb2146c6f05ee4ae2d75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5038641
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 2 years ago
Michael Savigny af69249965 Fix deletion of old build logs 
The code rotating the old build logs expects to delete directories
(since it uses rmtree) but tries to delete all items returned by
os.listdir(...) which may includes symbolic links or regular files.

Change it to only consider the old build logs directories instead.

Based on crrev/5028323, with fix to unit test.

Fixed: b/310900283
Change-Id: I4c618e6618c0193331c063028ebf02d8c4e7baee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5038467
Auto-Submit: Michael Savigny <msavigny@google.com>
Reviewed-by: Ramy Medhat <abdelaal@google.com>
Commit-Queue: Michael Savigny <msavigny@google.com>
 2 years ago
Josip Sokcevic 06c4261af7 tests: Use collections.abc.MutableSet 
collections.MutableSet is deprecated and removed in py3.11

R=jojwang@google.com

Change-Id: Id09f6f4f64fd59ef66659e7369562f59b8aaa232
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5039630
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2 years ago
Sunny Sachanandani 44d6d1a666 Fix compile_single_file with remoteexec 
When using remoteexec, calling ninja directly instead of ninja_reclient
causes the build to hang. This also breaks compile_single_file since it
calls ninja directly. To fix this, switch it to call autoninja instead
which will take care of this and other details like using autosiso in
the near future.

Also, using autoninja has the side-effect of using a higher -j value
which can help when building a single file causes a lot of other files
to also be built.

Bug: 1502988
Change-Id: Ib86c5c820f7c53a8420973f1b83bf8e711a9af09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5037618
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org>
 2 years ago
Josip Sokcevic 74ed6becbf Trigger recipe roller 
This is to pick up pylint change

Change-Id: I89ad02336f84eff9b7b3d7d99eedac9bca896b16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5037334
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
 2 years ago
Chan Li 2f184917c4 [depot_tools] roll led 
Changes included in this roll:
- https://crrev.com/c/4970874
- https://crrev.com/c/5001774

Bug: 1495215
Change-Id: I9498cfa5a9b1f8b85e5aa9773eceb5e3e1eb981f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5037616
Auto-Submit: Chan Li <chanli@chromium.org>
Commit-Queue: Randy Maldonado <randymaldonado@google.com>
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
 2 years ago
recipe-roller c38b501c76 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764257370812906417

recipe_engine:
eeeea0249f
  eeeea02 (mohrr@google.com)
      recipes_cfg: Add option to not use OWNERS in rolls

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0a605ddde50065a6d24ed395acd8e42b52e25930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5036794
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Takuto Ikuta df3e577855 apply black and `git cl format` for ninja related python files 
This is made by
$ black --line-length 79 *ninja*.py
$ git cl format

Change-Id: Ic446898a5461ae536542f6312cae2ce126dfe82a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035265
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Philipp Wollermann <philwo@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2 years ago
Takuto Ikuta 0b98e7c063 fix for long line warnings 
This is preparation CL for https://crrev.com/c/5035265.

Change-Id: I9ab8ffed471d3813a0e94bbdb47bf95e3bb46337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5036119
Commit-Queue: Philipp Wollermann <philwo@chromium.org>
Reviewed-by: Philipp Wollermann <philwo@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2 years ago
Philipp Wollermann 58700cf7f8 Revert "gclient: Add skip-git experiment." 
This reverts commit 8672d51b79.

Reason for revert: crrev.com/c/5018522 has landed, so this is no longer required.

Original change's description:
> gclient: Add skip-git experiment.
>
> This experiment causes all dependencies of type 'git' to be skipped for
> all commands. This can be useful if you need to build Chromium in a
> working tree that is guaranteed to contain a consistent, pre-synced
> snapshot of the code that's managed by Git, but still need to install
> cipd dependencies and run the hooks to download the remaining
> dependencies.
>
> Bug: b/310485239
> Change-Id: Iee1e6a4d62b867b6d7235903817f927a9e806dc1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5018571
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
> Auto-Submit: Philipp Wollermann <philwo@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

Bug: b/310485239
Change-Id: If1fc93d493daa9515ddfb568aecf4374deb6ec03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035260
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Takuto Ikuta 5cbc521beb autoninja.py: remove use_rbe support 
This arg was not used anymore.

Change-Id: If578845fc3e200f4f23c8ca050542b92fcf13ef2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035261
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2 years ago
Josip Sokcevic f1cbc0c0b5 tests: Skip tests for old stacked changes flow 
R=jojwang

Bug: 5030767
Change-Id: I8e9ff580404f386b9ad8bbeac2328e6228afbe63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5033924
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2 years ago
Josip Sokcevic 4cf6518959 scm: Remove usage of distutil 
The package is deprecated and will be removed in py 3.12.

R=ddoman@google.com

Bug: 1500415
Change-Id: Ia130c556ad3f2135fac4a9b1d9bb4ecc088cfe9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030818
Reviewed-by: Scott Lee <ddoman@chromium.org>
Reviewed-by: Jonathan Nieder <jrn@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Commit-Queue: Jonathan Nieder <jrn@google.com>
 2 years ago
Josip Sokcevic 8fb358e5b6 Add support for Cog SCM 
Change-Id: I450e1ce7943fda55edf1cb8016f201ce08cd9251
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5018522
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
 2 years ago
recipe-roller 0d849838d9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8764325319822961137

recipe_engine:
5944dc6a18
  5944dc6 (jiesheng@google.com)
      Fix the swarming test data init.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I83ab38957eef40f62d72df98a6750c9a75705a2c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5034871
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Jie Sheng <jiesheng@google.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Josip Sokcevic 86c7f734f5 pylint: Add pylint 2.13 
Bug: 1500415
Change-Id: I05293251be810772c56530962ef5a33a0f0cc887
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030756
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 2 years ago