Robert Iannucci
bdb1123726
[osx_sdk] Fix properties when setting a single value.
...
Because of the (unfortunate) ways that PROPERTIES works currently,
setting defaults in the obvious way means that providing a subset of the
values as properties replaces the defaults entirely.
In this case we want to override the sdk_version without having to
override the toolchain app version.
R=jchinlee@chromium.org, tandrii@chromium.org
Change-Id: I13f4ee19e45a3bb147b37f69d10cb4ed4f734a21
Reviewed-on: https://chromium-review.googlesource.com/c/1438088
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
6 years ago
recipe-roller
eb2767b2eb
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/5fe47aa25ed8ffbd93a0cdc482dfe3691de97fe1 Enable requesting builds as experimental using buildbucket.put. (gbeaty@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I226b0bfb373dbdc7f1e127af25327b6d0a133c9c
Reviewed-on: https://chromium-review.googlesource.com/c/1437435
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
db34d87aff
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/b7ddcda6a85a7f6ddba7d0ca8151ca43daa1012e [file][symlink tree] Update registration logic (joshuaseaton@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5edce40d74347033c1508e9f0f5f8ff53aad64e9
Reviewed-on: https://chromium-review.googlesource.com/c/1436481
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
60574b5f91
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/43eff8591be49e62d8f264ec63ce1e162f88ab43 [isolated] Add UI link (joshuaseaton@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If322710d9bda1b3899106c29a5617c8d560f4bdf
Reviewed-on: https://chromium-review.googlesource.com/c/1436478
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
80b9cf7dfd
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/46401269c52f3dc9bfaa582f05736ad1b68b2498 Print ran steps when verifying no test data remains (martiniss@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If31f1b0e0096e3b8c5cb2242bd6a730e6f02de74
Reviewed-on: https://chromium-review.googlesource.com/c/1435974
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
Raul E Rangel
edfbc9ced2
Reland "httplib: Update to 0.11.3"
...
This is a reland of dd0c341bd2
The problem is that chromium-review.googlesource.com started requiring SNI.
httplib2 0.9.2 does not support that, but it seems to have been fixed since 0.10.1:
8aaecf4496
Original change's description:
> httplib: Update to 0.11.3
>
> The `DST Root CA X3` certificate was missing from cacerts.txt in the old
> version. This resulted in failure to connect to Let's Encrypt hosts.
> e.g., https://review.coreboot.org
>
> BUG=none
> TEST=Made sure my_activity.py continues to function and it can also
> connect to review.coreboot.org
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
> Change-Id: I519916b58a59b8f13c227218e93c392a63a24800
> Reviewed-on: https://chromium-review.googlesource.com/1173064
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Bug: 914564, 891505
Change-Id: Icd2a57da802864b2ebb17417b73434e1284a292d
Reviewed-on: https://chromium-review.googlesource.com/c/1432633
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
6 years ago
recipe-roller
4d965ee2d8
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/157d3d2973ebb66c21dce81dfa506695b8ab6926 [swarming] Expose isolated outputs ref (joshuaseaton@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I75a6a2e1e2fc78538effafecd7010a59fe8ed7cc
Reviewed-on: https://chromium-review.googlesource.com/c/1434574
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
695e7cf352
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/e82bce74a9b5c7682beeca35ba67ea747ded69f4 [swarming] Add api.swarming.collect() (joshuaseaton@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I54ee283fd0b0b070c4e944eec306f2cb432a4bc1
Reviewed-on: https://chromium-review.googlesource.com/c/1431632
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
Quinten Yearsley
f797143682
Update depot_tools README cpplint section
...
Context:
https://chromium-review.googlesource.com/c/infra/infra/+/1422779
Bug: 923438
Change-Id: Ib433e219b45065ae5064aece921e710545e41b59
Reviewed-on: https://chromium-review.googlesource.com/c/1423377
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
6 years ago
Takuto Ikuta
cf032973e3
Deploy git 2.20.1 to prod win depot_tools users
...
Bug: 887141
Change-Id: I9850238f3beb8e4c61deb20a1b2fdfd9e84df935
Reviewed-on: https://chromium-review.googlesource.com/c/1416492
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
6 years ago
recipe-roller
deab113bfb
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/91c13923c1d136dc688527fa39583ef61a3277f7 Fix a couple of typos in user_guide.md. (seanabraham@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0ea0ea1e67fbb54c562c8206da3b568962281966
Reviewed-on: https://chromium-review.googlesource.com/c/1415813
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
165153fde1
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/e9bab63ca257c333247040e2d9503aad2045082d [file] Expose root of SymlinkTree (joshuaseaton@google.com )
https://crrev.com/3b4c9d9b26618f331b01287b466946bd768170cd [swarming] roll swarming client (tikuta@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I225f6052eee8eaf18aa45c83519b328d3544ba72
Reviewed-on: https://chromium-review.googlesource.com/c/1416061
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
2c0cb639d6
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/f749c4664feacab9484dc8e24ae350b1114f0d12 [swarming] add OWNERS (tikuta@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I482c4836d081de9a6f29cf4cf4492d67dec4ec54
Reviewed-on: https://chromium-review.googlesource.com/c/1416060
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
ee2049b8a0
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/3e07686e1a32a7500c5bbd64f939c168546d360e [isolated] Re-roll isolated. (joshuaseaton@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7f041464d6249e9f57dd09571319c46152d16e45
Reviewed-on: https://chromium-review.googlesource.com/c/1416059
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
Takuto Ikuta
beeb6b4d52
Deploy git 2.20.1 to depot_tools on a bleeding edge
...
Bug: 887141
Change-Id: Ieaa53c18b01f6882f1b8f48c252ec1f9847f94fa
Reviewed-on: https://chromium-review.googlesource.com/c/1416491
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
6 years ago
recipe-roller
d1dba6482b
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/ed32454c59ca7ba6d05f313f32f75c1b8157d66e Remove unused features of package.proto. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia5ca69de1e13209c336bcc82d52f2aa508551569
Reviewed-on: https://chromium-review.googlesource.com/c/1416057
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
6a1a8b3520
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/b5365db8a7bac60b839af22029317e97bd2e77b4 Revert "Fix a couple of typos in user_guide.md". (seanabraham@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib6092bf23ff1c487c925f039dc26a57e2b3eb597
Reviewed-on: https://chromium-review.googlesource.com/c/1416055
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
Marc-Antoine Ruel
6ce18220f4
roll-dep: use Middle Out Compression ™️ for logs
...
Trimming at the bottom looses an important datapoint: which is the
oldest commit. To fix this problem, use Middle Out Compression™️ to
creates a better DEPS roll CL description.
Change-Id: I290073d25989b6880a4b608cd2b8f26a300cc3a1
Reviewed-on: https://chromium-review.googlesource.com/c/1415430
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Marc-Antoine Ruel <maruel@chromium.org>
6 years ago
recipe-roller
edc8925490
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/e44e828506a9b304dc0f9cc6e07dd701caf89b5b Fix a couple of typos in user_guide.md (seanabraham@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie92cc46fea3666575ffd1a45b2b9fec8afba3808
Reviewed-on: https://chromium-review.googlesource.com/c/1416053
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
e8eb462b4c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/7e20dd3b17a76f2d80f8323a2f8dbe1fe3165865 [isolated] Roll isolated client (joshuaseaton@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9f16ac37fdf3c3c5831d22099d5ab3368dc5ad92
Reviewed-on: https://chromium-review.googlesource.com/c/1415734
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
925c3a9e1d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/293aad67184cd21a3ce34e6af0623adbcb6c2216 Reland "Remove unused bootstrap flags" (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I78f5acb2f167e9b47bf26398778c5688a74f2c68
Reviewed-on: https://chromium-review.googlesource.com/c/1415732
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
4d9f86da4d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/156ac81c761820125051bd09a6c4d7fcd8c49c4f Revert "Remove unused bootstrap flags" (sergiyb@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3ad055c2cc708c69f0a8d12f2d9f945a86aa440c
Reviewed-on: https://chromium-review.googlesource.com/c/1415730
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
8df62ef402
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/9722f43a7d840356c83cc6e36a494761897c6994 Remove unused bootstrap flags (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I064db4e3560b31349e961d88abbef5854f09a822
Reviewed-on: https://chromium-review.googlesource.com/c/1412226
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
a94e65e63c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/2f65b24e319f41a6009c857b1928cb2f7aea9c45 Remove env, unused third party dependencies. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib643ae612138a2b3b97cb3572c7866b233cd2895
Reviewed-on: https://chromium-review.googlesource.com/c/1412224
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
e229a0e3c5
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/ad6fe3b8570a2ad3562510e3e563cbf32c01204b Remove arguments.proto entirely (finally). (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4b72efc944dcbc965842638f337b4e9780fdd3d1
Reviewed-on: https://chromium-review.googlesource.com/c/1412218
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
8432ec24a3
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/53e9006fc399f37445a3b3a3ec4779eb3ce3306f Remove use of op_args.annotation_flags.emit_initial_properties. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaada5f8e3c69075eed1009c2fa229b48c19bc8ee
Reviewed-on: https://chromium-review.googlesource.com/c/1407185
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
Robert Iannucci
51f0cd392c
[recipes] Remove deprecated (ignored) --use-bootstrap flag
...
This has been ignored for a long time, and I'd like to get rid of it.
R=jchinlee@chromium.org, nodir@chromium.org
Change-Id: I240d59cc10a2882041ac2c8abfeb1894237516a6
Reviewed-on: https://chromium-review.googlesource.com/c/1407425
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
6 years ago
recipe-roller
a099dbeb8d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/d4166b614aaea6fd574864a6b16b0363156a1720 Remove unused emit_timestamp flag. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icb9e096b4a84cf62aedb62bc64ae113b19fe0929
Reviewed-on: https://chromium-review.googlesource.com/c/1407183
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
dae1c0bf9c
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/d7bf17e6450a8aef49e08d4dfcac10b2bb558b8d [arguments.proto] Regenerate pb2. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I18b3968e7edf83a94e062dcb65fcc598afe0cd96
Reviewed-on: https://chromium-review.googlesource.com/c/1407180
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
f7854e9f3f
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/c1607f6eed6444c4918856cfc4bdabf895d4504c Reland "Remove engine_flags from everywhere." (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I77f45a9bd3039e32ad39a9f837df4925ed9f0d43
Reviewed-on: https://chromium-review.googlesource.com/c/1407170
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
David 'Digit' Turner
31a486419e
Improve no-long-lines check for Python files.
...
The previous implementation of CheckLongLines did not
handle global pylint disable/enable directives properly,
i.e. the difference between:
# pylint: disable=line-too-long
.... checks disabled for all lines here.
# pylint: enable=line-too-long
versus:
# Check only disabled for the line below
some python statements # pylint: disable=line-too-long
This CL changes the implementation to support Python files
properly. Note that in order to not disturb the mock-based
unit-tests, a new function is introduced to be able to
filter the list of affected files based on their file
extension.
BUG=890734
R=mattcary@chromium.org,ehmaldonado@chromium.org,dpranke@chromium.org
Change-Id: Id52deff53913b8d47a4157f42b1fffbd3b103201
Reviewed-on: https://chromium-review.googlesource.com/c/1396094
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
6 years ago
Takuto Ikuta
36248fcd63
[ninjalog] don't upload ninja log of no-op build
...
Check timestamp of .ninja_log before upload and don't upload if mtime is very old.
Bug: 900161
Change-Id: I0cf00ae29e23a9f609564e4c12b4b518320ca23a
Reviewed-on: https://chromium-review.googlesource.com/c/1404611
Commit-Queue: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
6 years ago
recipe-roller
4e23d9bac7
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/27cd207dfb18d832d94218e61720acbb0127a26b Whitespace change to watch Build Recipes Tester. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3cccdf1a524e2f0e0830d882db831f3bf9e01655
Reviewed-on: https://chromium-review.googlesource.com/c/1405558
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
80a1cf66b8
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/6fc662aae01eb4f6cfb1efe49dbdbaa0a7a4d912 [isolated] Fix bug (joshuaseaton@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I38c258a02c04acb20b2794b7e63c183f8390872e
Reviewed-on: https://chromium-review.googlesource.com/c/1405548
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
b1be3782a4
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/844a3eb30c85cc64f5b620dd96a787df9e40769a Remove engine_flags from everywhere. (iannucci@chromium.org )
https://crrev.com/d0f4f80818647cc84a836e2caa3dfbac4e28ea64 Revert "Remove engine_flags from everywhere." (tandrii@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8e927cdee578aff16e530d2eba6b666598a84f51
Reviewed-on: https://chromium-review.googlesource.com/c/1404280
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
Andrii Shyshkalov
8ec820957b
Revert "Roll recipe dependencies (trivial)."
...
This reverts commit 09aecb2159
.
Reason for revert: lead to breakage of everything.
https://crbug.com/920497
Original change's description:
> Roll recipe dependencies (trivial).
>
> This is an automated CL created by the recipe roller. This CL rolls recipe
> changes from upstream projects (e.g. depot_tools) into downstream projects
> (e.g. tools/build).
>
>
> More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
> recipe_engine:
> https://crrev.com/844a3eb30c85cc64f5b620dd96a787df9e40769a Remove engine_flags from everywhere. (iannucci@chromium.org )
>
>
> TBR=iannucci@chromium.org
>
> Recipe-Tryjob-Bypass-Reason: Autoroller
> Bugdroid-Send-Email: False
> Change-Id: I6d207b66261d150b4c9f327beccd10b14c41448e
> Reviewed-on: https://chromium-review.googlesource.com/c/1404278
> Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
> Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
TBR=iannucci@chromium.org,recipe-roller@chromium.org
Change-Id: I8104a656d0da076a8d0c4f8473a0724982b1f65d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1404564
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
6 years ago
recipe-roller
09aecb2159
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/844a3eb30c85cc64f5b620dd96a787df9e40769a Remove engine_flags from everywhere. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6d207b66261d150b4c9f327beccd10b14c41448e
Reviewed-on: https://chromium-review.googlesource.com/c/1404278
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
Takuto Ikuta
8794a84552
[ninjalog] re-enable log upload
...
I got launch approval. http://shortn/_dyJK6ME7C0
Detailed document of this log upload is in
https://chromium.googlesource.com/chromium/tools/depot_tools/+/HEAD/ninjalog.README.md
Bug: 900161
Change-Id: Iad2f954040d40caa5b7cc1f1eb39c1088f7f316e
Reviewed-on: https://chromium-review.googlesource.com/c/1401919
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
6 years ago
Jared Saul
2d4a955e90
Fix broken metrics collection dialog spacing
...
The change around line 29-30 in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1368409/2/metrics_utils.py
inadvertently removed an extra space. As a result, the metrics
collection dialog looks like this:
https://screenshot.googleplex.com/3aGtquydCXM.png
Change-Id: I7c9c08949b0df248e6de4f59ec9cfd573ff40901
Reviewed-on: https://chromium-review.googlesource.com/c/1403577
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
6 years ago
Avi Drissman
4157ba1c3c
Update cpplint.
...
da90c53e3d
was incorrect; the size()
functions take almost anything, not just word characters, and
std::extent() uses brackets.
BUG=837308
Change-Id: I6ee75a5da7a021758bbfb0996aeaef81f2003cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1401581
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
6 years ago
recipe-roller
9d5b468279
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/3535e529c7b925fb486cfaccc1f89e739402d54b [buildbucket] Populate ref from branch property (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I02ff1f10339bf828d57fe372e19fa794f766102d
Reviewed-on: https://chromium-review.googlesource.com/c/1402104
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
Takuto Ikuta
c8069af594
[ninjalog] fully anonymize build stats before sending
...
We cannot send PII data.
This CL tried to remove following data,
* build config that can contain build directory path
* build directory path
* hostname
* cwd
I use per build uuid instead of per user uuid.
Bug: 900161
Change-Id: Id533762749806ad8616b7dc07f21b27dfe632c9a
Reviewed-on: https://chromium-review.googlesource.com/c/1369473
Reviewed-by: Shinya Kawanaka <shinyak@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
6 years ago
recipe-roller
b61b09f11d
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/7d75cc6e379d1603027cb39420541ceaa8fd6a2c [swarming] enforce to set server if server is referred (tikuta@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I72e8a523c2dd431b75c52a49b7bdb556683f7097
Reviewed-on: https://chromium-review.googlesource.com/c/1402101
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
b3f56664c4
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/7e610e4cc8e12bf654b0ecfc1872cc50e1ceed8d Restore old user guide for now. (iannucci@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic8df1bbf114667e9f1012611f4569b4f7ab93681
Reviewed-on: https://chromium-review.googlesource.com/c/1401599
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
75612b0790
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/08b7a23ec10abc078fd0f7594dd1331c76ae30e4 Revert "Remove use_result_proto flag" (martiniss@chromium.org )
TBR=iannucci@chromium.org
NOPRESUBMIT=true
NOTRY=true
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe04b68b36fd509c22656e3a6cbd6403edf14818
Reviewed-on: https://chromium-review.googlesource.com/c/1401589
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
327dcb4c39
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/5e16623c2af04706ed78dec9aa25fcf367a2f0bc Remove use_result_proto flag (martiniss@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6655221dfa31991e53bcb2142abd1a92bcbee308
Reviewed-on: https://chromium-review.googlesource.com/c/1401585
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
118bb44e14
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/d44c26c543da894ac048a1a5f129790c2bb9923f [isolated] enforce to set server if server is referred (tikuta@chromium.org )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4dcc257d7303380f148abaae14febc33da632b61
Reviewed-on: https://chromium-review.googlesource.com/c/1401583
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
Avi Drissman
da90c53e3d
Update cpplint.
...
Using base/std::size and std::extent does not result in the creation
of a VLA; cpplint should not warn on their use.
BUG=837308
Change-Id: Ie133b2144b6c1c9f4f5e406144f28b333a212197
Reviewed-on: https://chromium-review.googlesource.com/c/1399961
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
6 years ago
recipe-roller
d16b51b9bf
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/1f61472de5efab2217261a2912af7682f0e5c62e [isolated] Allow ability to isolate a given root directory. (joshuaseaton@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie2bef3cefb24a9df75ba14608337897addd3d71d
Reviewed-on: https://chromium-review.googlesource.com/c/1398623
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago
recipe-roller
c0641b8e93
Roll recipe dependencies (trivial).
...
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a to file a bug.
recipe_engine:
https://crrev.com/c1b615b6808b8aa8001b5e4e1d5d234233ad8266 [buildbucket] Add set_output_gitiles_commit (nodir@google.com )
TBR=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia34028e3fe28469bf8202948ccaafdf38e15b9eb
Reviewed-on: https://chromium-review.googlesource.com/c/1396583
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
6 years ago