There is user interaction when the svn credential isn't cached. (Duh)
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7864007
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100462 0039d316-1c4b-4281-b951-d872f2087c98
stderr is not redirected by default. stdout is not allowed.
Both were oversight.
Do not override stdin=None in case the user would response to stderr output for
example.
Increase test coverage.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7860041
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100456 0039d316-1c4b-4281-b951-d872f2087c98
This is necessary for msysgit usage on windows.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7858008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100267 0039d316-1c4b-4281-b951-d872f2087c98
Fix case where git-try fails for branch not still uploaded to rietveld.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7860004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100244 0039d316-1c4b-4281-b951-d872f2087c98
Makes the code clearer by separating good and bad use cases.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7850018
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100198 0039d316-1c4b-4281-b951-d872f2087c98
It should be fine now that requirements with /@ works fine.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7782034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100162 0039d316-1c4b-4281-b951-d872f2087c98
Add support for a few svn:* properties.
Silently ignore svn:mergeinfo. It's useless once we're switched to git-land anyway.
More testing.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7840003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99952 0039d316-1c4b-4281-b951-d872f2087c98
I plan to do some refactoring and these tests will help reduce the likehood of
regression.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7739039
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99799 0039d316-1c4b-4281-b951-d872f2087c98
It breaks upstream webkit and nacl. I'll make then both use --jobs 1 before
relanding.
TBR=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7833051
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99761 0039d316-1c4b-4281-b951-d872f2087c98
Make tests more exhaustive in prospect to file move handling.
Rename 'c' variables to 'p' to easy copy paste.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7828017
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99439 0039d316-1c4b-4281-b951-d872f2087c98
gclient_scm_test.py throws randomly gclient_utils.Error.
Simply update the test expectation. It has no effect on runtime.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7828024
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99436 0039d316-1c4b-4281-b951-d872f2087c98
Verify correctness with a unit test written explicitly to verify all corner cases.
BUG=60725
TEST=new unit test
Review URL: http://codereview.chromium.org/6598087
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99234 0039d316-1c4b-4281-b951-d872f2087c98
This is in preparation to support file rename, as a source_filename needs to be
added and processed.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7809001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99185 0039d316-1c4b-4281-b951-d872f2087c98
That means some properties will being to be applied.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7776015
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@99182 0039d316-1c4b-4281-b951-d872f2087c98
Well, the funny thing is that it doesn't find the bug but the framework is
already good enough as-is to be worth checked-in, so the next commit can show
the relevant difference.
R=dpranke@chromium.org
BUG=60725
TEST=
Review URL: http://codereview.chromium.org/7773001
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98869 0039d316-1c4b-4281-b951-d872f2087c98
Still not enough to fix presubmit checks on commit queue but a step in the
right direction.
Review URL: http://codereview.chromium.org/7748020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98445 0039d316-1c4b-4281-b951-d872f2087c98
It's mostly for debugging when testing with a leaking service. It's going to be
rarely used but I used it often enough to warrant it being committed.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7744030
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@98438 0039d316-1c4b-4281-b951-d872f2087c98
---
Trap failure to get password from keyring
It happens when using upload.py from a ssh session without a X session but
gnomekeyring is used.
R=dpranke@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/7715013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@97909 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
asvitkine@chromium.org
tonyg@google.com
dilmah@chromium.org
zbehan@chromium.org