Update docstrings w.r.t. subprocess2.

No code change.

R=dpranke@chromium.org
BUG=
TEST=


Review URL: http://codereview.chromium.org/7858001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@100212 0039d316-1c4b-4281-b951-d872f2087c98

gclient_utils.py

@@ -320,10 +320,10 @@ def CheckCallAndFilter(args, stdout=None, filter_fn=None,
                        **kwargs):
   """Runs a command and calls back a filter function if needed.
 
-  Accepts all subprocess.Popen() parameters plus:
+  Accepts all subprocess2.Popen() parameters plus:
     print_stdout: If True, the command's stdout is forwarded to stdout.
     filter_fn: A function taking a single string argument called with each line
-               of the subprocess's output. Each line has the trailing newline
+               of the subprocess2's output. Each line has the trailing newline
                character trimmed.
     stdout: Can be any bufferable output.
 
@@ -337,7 +337,7 @@ def CheckCallAndFilter(args, stdout=None, filter_fn=None,
       args, bufsize=0, stdout=subprocess2.PIPE, stderr=subprocess2.STDOUT,
       **kwargs)
 
-  # Do a flush of stdout before we begin reading from the subprocess's stdout
+  # Do a flush of stdout before we begin reading from the subprocess2's stdout
   stdout.flush()
 
   # Also, we need to forward stdout to prevent weird re-ordering of output.

subprocess2.py

@@ -132,7 +132,7 @@ def get_english_env(env):
 
 
 def Popen(args, **kwargs):
-  """Wraps subprocess.Popen().
+  """Wraps subprocess.Popen() with various workarounds.
 
   Returns a subprocess.Popen object.
 
@@ -142,7 +142,8 @@ def Popen(args, **kwargs):
     shell parameter to a value.
   - Adds support for VOID to not buffer when not needed.
 
-  Note: Popen() can throw OSError when cwd or args[0] doesn't exist.
+  Note: Popen() can throw OSError when cwd or args[0] doesn't exist. Translate
+  exceptions generated by cygwin when it fails trying to emulate fork().
   """
   # Make sure we hack subprocess if necessary.
   hack_subprocess()