This will make it possible to cut away additional
levels of directories when applying patches from repos
that have a different directory hierarchy than Chromium.
BUG=438952
TESTED=Executed successfully in a local checkout using
(cwd was the dir above src/):
~/depot_tools/apply_issue.py --root_dir src/third_party/webrtc --issue 1978193002 --server https://codereview.webrtc.org --force --ignore_deps -v -v --no-auth --patchset 20001 --extra_patchlevel=1
Review-Url: https://codereview.chromium.org/1988583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300615 0039d316-1c4b-4281-b951-d872f2087c98
This would allow bot_update to differentiate between patch download and
aplication failures.
R=phajdan.jr@chromium.org,sergiyb@chromium.org
BUG=537417
Review URL: https://codereview.chromium.org/1380093003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296983 0039d316-1c4b-4281-b951-d872f2087c98
It is done in preparation for switching to OAuth2 as default (and only)
authentication method. Having all auth options handled by the same code makes it
easier to gradually add OAuth2 support.
As part of this, some options that would no longer work with OAuth2 (and that
are not being used from anywhere now, as far as I can tell) are removed:
* Passing account password for authentication via command line.
* Overriding 'Host' header when making requests to Rietveld (won't work with
SSL anyway).
* --account_type option (seems to be ClientLogin specific).
R=maruel@chromium.org
BUG=356813
Review URL: https://codereview.chromium.org/1075723002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294746 0039d316-1c4b-4281-b951-d872f2087c98
Handle KeyboardInterrupt gracefully rather the printing a
backtrace. Most users of these tools don't expect a
backtrace when then hit Ctrl-C.
Also, fix a few other inconsistencies found in the python
startup code of these different scripts:
- always call main function 'main' (rather than 'Main')
- always return 0 from main function
- if main takes args never include argv[0]
Review URL: https://codereview.chromium.org/955993006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294250 0039d316-1c4b-4281-b951-d872f2087c98
We changed apply_issue to stage the patch if its on git, so it doesn't make sense to pass in --revision because that causes gclient to run solutions in managed mode.
BUG=388374
Review URL: https://codereview.chromium.org/359443003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@280855 0039d316-1c4b-4281-b951-d872f2087c98
For a bot_update Git world, we don't really want to commit patches. Instead
we just want to leave them unstaged.
BUG=370503
Review URL: https://codereview.chromium.org/280063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269489 0039d316-1c4b-4281-b951-d872f2087c98
Reason for revert:
Borked all the tryjobs due to missing --base_ref, needed to land with https://codereview.chromium.org/273543002/
Original issue's description:
> Have apply_patch.py/checkout.py stage git patches instead of committing them
>
> For a bot_update Git world, we don't really want to commit patches. Instead
> we just want to leave them unstaged.
>
> BUG=370503
> TEST=ran locally with and without flag
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=269468
TBR=maruel@chromium.org,agable@chromium.org,hinoka@google.com,iannucci@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=370503
Review URL: https://codereview.chromium.org/271283003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269482 0039d316-1c4b-4281-b951-d872f2087c98
For a bot_update Git world, we don't really want to commit patches. Instead
we just want to leave them unstaged.
BUG=370503
TEST=ran locally with and without flag
Review URL: https://codereview.chromium.org/273543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@269468 0039d316-1c4b-4281-b951-d872f2087c98
Bot_update takes care of running gclient sync after apply_issue, so this is
unnecessary.
BUG=
Review URL: https://codereview.chromium.org/242433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@265031 0039d316-1c4b-4281-b951-d872f2087c98
This prevents apply_patch from attempting to check out a branch tracking 'origin/None'.
R=pgervais@chromium.org
Review URL: https://codereview.chromium.org/202483008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257763 0039d316-1c4b-4281-b951-d872f2087c98
This is to tackle the issue that slaves don't have global git vars set up.
BUG=339171
Review URL: https://codereview.chromium.org/175543006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252705 0039d316-1c4b-4281-b951-d872f2087c98
This add --force to ignore the flag file.
This also passes --base_ref so we can specify which ref we're basing off of so that it does not incorrectly assert that it is basing off origin/master
BUG=339171
Review URL: https://codereview.chromium.org/171763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@252464 0039d316-1c4b-4281-b951-d872f2087c98
Add an option to apply_issue to fail if anonymous access
triggers a login prompt.
- cherry-pick upload.py rietveld cl 37c73ece82d0 which
allows clients to request no authentication.
BUG=240634
Review URL: https://chromiumcodereview.appspot.com/20634003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@214023 0039d316-1c4b-4281-b951-d872f2087c98
This reverts commit 012dc07ce5.
Revert "Partially revert r208574 to get the CQ working again (hopefully)."
This reverts commit 74105cd2a0.
Pull the --no-commit change out completely.
TBR=dpranke@chromium.org
BUG=254556
Review URL: https://codereview.chromium.org/17944002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@208801 0039d316-1c4b-4281-b951-d872f2087c98
Without this change, if an entry is removed from a DEPS file, it won't be
effectively deleted. Specify --delete_unversioned_trees so the dependency is
properly deleted.
TBR=szager@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/14531006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@197081 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise the try slaves run the hooks twice, once in the apply_issue, another
in the runhooks step. It is unnecessary. It will reduce the problem with
apply_issue timeouts.
TBR=xusydoc@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11362176
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166826 0039d316-1c4b-4281-b951-d872f2087c98
apply_issue step hangs and the output is often in the reverse order. This CL is
to help diagnose the problem.
TBR=cmp@chromium.org
BUG=159868
Review URL: https://chromiumcodereview.appspot.com/11359093
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@166505 0039d316-1c4b-4281-b951-d872f2087c98
Stop using stderr so the output is more readable on buildbot.
Otherwise stderr arrives before stdout in apply_issue step.
TBR=rogerta@chromium.org
BUG=153284
Review URL: https://chromiumcodereview.appspot.com/11038002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159508 0039d316-1c4b-4281-b951-d872f2087c98
can be applied. This is the first part for this bug; the second part is in commands.py where this is called by the TS.
BUG=149941
Review URL: https://chromiumcodereview.appspot.com/10917306
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157355 0039d316-1c4b-4281-b951-d872f2087c98
It runs it by specifying BASE/HEAD to stay at the current revision.
This works around the lack of gclient sync when a DEPS file is applied on the
Try Server when triggered from Rietveld. This was handled my the Try Server
inside scripts/slave/chromium_command.py manually in the case a 'patch' is
specified.
TBR=rogerta@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10918264
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157110 0039d316-1c4b-4281-b951-d872f2087c98
agable
kjellander@chromium.org
tandrii@chromium.org
thakis@chromium.org
rmistry@google.com
vadimsh@chromium.org
sbc@chromium.org
hinoka@chromium.org
hinoka@google.com
pgervais@chromium.org
agable@chromium.org
stip@chromium.org
rmistry@google.com
ilevy@chromium.org
iannucci@chromium.org
dpranke@chromium.org
maruel@chromium.org
rogerta@chromium.org