Currently, 'bot_update' uses the 'gclient' that is on the system path.
Now, it will use the 'gclient.py' that is in the same 'depot_tools'
checkout as the 'bot_update' recipe module.
Also don't ignore "git_cache" move errors.
BUG=664254,663990,663440
TEST=None
Review-Url: https://codereview.chromium.org/2492963002
Before, presubmit_support would fail with not very useful stacktrace if
Gerrit returns 404, which is usually due to missing/invalid credentials.
This CL fixes that and improves the exception message, and also improves
logic in git_cl.
R=agable@chromium.org
BUG=
Change-Id: Iae8f0c24422c46af70929c7d5d71993164887511
Reviewed-on: https://chromium-review.googlesource.com/409650
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
New binaries for Mac, Linux32, Linux64, Windows. Also update shell script.
See the bug for how these were built.
The main "new" thing is a regression fix where 1.7.1 broke %e %r in
NINJA_STATUS.
BUG=663749
Review-Url: https://codereview.chromium.org/2489023002
It's too ridiculously slow on Windows and Mac, and there's very little benefit to finding files that were "copied" from an historical file (as
opposed to one that's in the current patch).
BUG=544889
Review-Url: https://codereview.chromium.org/2488823002
This is still important, but at least now it won't result
in a stacktrace.
Change-Id: If6e7e15a98b0a03df7e978201762fea670312ede
Reviewed-on: https://chromium-review.googlesource.com/408660
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Reason for revert:
Broke build CQ: https://luci-milo.appspot.com/swarming/task/324a5636a5cfdf10/steps/Uncaught_Exception/0/logs/exception/0
Original issue's description:
> fix swarmbucket infra path
>
> Do not rely on buildbot config which goes up 4 directories. Everything
> should happen in the workdir. Also exclude any project-specific paths.
>
> This fixes the problem that swarmbucket builds expect git_cache to be in
> /b/git_cache. It should be in the CWD/git_cache. This will fix Windows
> builders.
>
> R=vadimsh@chromium.org
> BUG=
>
> Committed: b8b5aaea92
TBR=vadimsh@chromium.org,nodir@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=
Review-Url: https://codereview.chromium.org/2484433002
Do not rely on buildbot config which goes up 4 directories. Everything
should happen in the workdir. Also exclude any project-specific paths.
This fixes the problem that swarmbucket builds expect git_cache to be in
/b/git_cache. It should be in the CWD/git_cache. This will fix Windows
builders.
R=vadimsh@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2477033002
Note: This CL originally just removed a deprecated use of Remove use of DoGetTrySlaves, suggested in http://crrev.com/2442153002, then was expanded to remove DoGetTrySlaves, GetPreferredTrySlaves and GetTrySlavesExecuter since these are all deprecated and unused.
BUG=660453
Review-Url: https://codereview.chromium.org/2453823002
Assuming that assuming bots are always just builder names, and they're never specified along with tests in git cl --bot options, then some logic used for git cl try can be removed.
Review-Url: https://codereview.chromium.org/2448193006
Reason for revert:
https://codereview.chromium.org/2444403003/ makes this pretty redundant. Reverting this.
Original issue's description:
> Call status before reset in gclient sync.
>
> Calling status before reset will ensure files that have no been changed do not
> get deleted by reset --hard.
>
> BUG=642711
>
> Committed: d74a7b4c14
TBR=sdefresne@chromium.org,maruel@chromium.org,dpranke@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642711
Review-Url: https://codereview.chromium.org/2453083002
Calling status before reset will ensure files that have no been changed do not
get deleted by reset --hard.
BUG=642711
Review-Url: https://codereview.chromium.org/2447813003
The purpose of this change is to prepare for modifying git cl try
so that builders on multiple masters can be triggered in one invocation
(http://crbug.com/640740).
This should not affect behavior; this CL makes several non-essential
changes to formatting and comments.
Review-Url: https://codereview.chromium.org/2442153002
Detect CC=<users> lines the way we detect R= and TBR=.
Add these as CC'ed users for rietveld and gerrit.
R=iannucci@chromium.org,hinoka@chromium.org,dnj@chromium.org
Review-Url: https://codereview.chromium.org/2433323004
This removes SVN support (most notably the SVNWrapper class, and the git-svn
logic in GitWrapper.GetUsableRev) from gclient_scm. It also removes some
references to SVN from comments in gclient_utils.
R=maruel@chromium.org
BUG=641588
Review-Url: https://chromiumcodereview.appspot.com/2393773003
dnj
scottmg
Andrii Shyshkalov
thakis
Aaron Gable
recipe-roller
nodir
martiniss
iannucci
katthomas
qyearsley
borenet
justincohen
skobes
bradnelson
hinoka