Commit Graph

7512 Commits (b34cd6d8fa4df214f77c8141d2113281e57790cc)
 

Author SHA1 Message Date
Edward Lesmes b34cd6d8fa Revert "[owners] Refactor OwnersClient."
This reverts commit 9c7f6c25c0.

Reason for revert:
Not working
https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8858807889610091152/+/steps/franky/0/steps/git_cl_upload/0/stdout

Original change's description:
> [owners] Refactor OwnersClient.
>
> - Remove GetChangeApprovalStatus and GetFilesApprovalStatus.
> - Make host, project and branch part of GerritClient.
> - Rename ListOwnersForFile to ListOwners.
>
> Change-Id: I1f610a64f0217ce54e5ce4a210026535adc1c2e5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2587268
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Gavin Mak <gavinmak@google.com>

TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I4928df90856526210a4fd4d104e6cc96aa005bc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2613925
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Edward Lesmes 3c57b27ae1 Revert "presubmit: Don't print comments for missing reviewers."
This reverts commit 276bab4c6e.

Reason for revert:
Possible cause of crbug.com/1163731

Original change's description:
> presubmit: Don't print comments for missing reviewers.
>
> Don't print owners comments when suggesting missing reviewers,
> as this won't be supported when using Gerrit API.
>
> Change-Id: I644b2f87b58a3c9ece3aa7d107100f3501bd3071
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2607675
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,gavinmak@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Bug: 1163731
Change-Id: I0b3d0f352e5483e754f6b790f70a9278df4eb3e2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2613924
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Stephen Martinis d48aa437c9 Followup fix for https://crrev.com/c/2587268
https://crrev.com/c/2587268 changed function signatures to remove a
project argument. One function call was missed in the CL. This CL fixes
the function call.

Change-Id: Ice45072aa467ed6c56efabf405a7aac03f4b047c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2613785
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
4 years ago
Nodir Turakulov 6650f7c238 [dirmd] Roll dirmd to 3d533070
Roll dirmd to git_revision:3d5330702211e01321af4fb53fec2f2f361137a7
to pick up https://chromium-review.googlesource.com/c/infra/infra/+/2597921

R=ehmaldonado@google.com

Bug: 1154541
Change-Id: I0fd0b56a42b63fd3518396aca0d99dde9fd95547
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612385
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Josip Sokcevic b038f724ec Update error message if unable to determine branch
git cl format can't accept branch name as argument as those are reserved
for files that need to be formatted. This CL clarifies what user needs
to do in case git cl is not able to determine upstream branch.

R=apolito@google.com, ehmaldonaldo@chromium.org

Bug: 832295
Change-Id: If6ff517d633b7e70a33dff48f3779f82df30f214
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2571838
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Edward Lesmes 276bab4c6e presubmit: Don't print comments for missing reviewers.
Don't print owners comments when suggesting missing reviewers,
as this won't be supported when using Gerrit API.

Change-Id: I644b2f87b58a3c9ece3aa7d107100f3501bd3071
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2607675
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Josip Sokcevic b631a88c6e Run git fetch with --prune on failed git cl upload
git fetch --prune removes all references that no longer exist on remote
server. This allows git cl to upload changes to correct destination
branch.

R=ehmaldonado@chromium.org

Bug: 1149640
Change-Id: I66bf8d2209242b08991c2dae0d3a7fbc892cef87
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2606613
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
recipe-roller 3a03505a9f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
d31ba13ede
  d31ba13 (chanli@chromium.org)
      [resultdb] Add query() to resultdb recipe_module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I63e587a289cee99e0eace03dfb9a7b359469c4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2610997
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 6128ceacf0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
905f47eac2
  905f47e (chanli@chromium.org)
      [swarming] Expose swarming task invocation names

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic1037dbea9b08c52a2fbdb184775ca1f9e8ef9ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612444
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Vadim Shtayura ac96016abc [cipd] Update CIPD client to 2.5.1.
To pick up https://chromium-review.googlesource.com/c/2594178.

The new version uses another zip compression library.

R=iannucci@chromium.org
BUG=1163308

Change-Id: Ib9df5e033c7c43fad4d19e8cfad47a8de664d0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2612114
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
4 years ago
Josip Sokcevic 7e73512268 Revert "Use HEAD instead of hardcoded branch"
This reverts commit 6651fd8847.

Reason for revert: broke some cros builds (check original CL for
discussion)

Original change's description:
> Use HEAD instead of hardcoded branch
>
> Repositories may have different default branches. This ensures to fetch
> remote HEAD branch which is default branch. Only downside to this
> approach is that actual branch (e.g. origin/main) reference won't be
> updated. Since we don't need it for this particular case, it should be
> fine to use HEAD.
>
> R=​apolito@google.com, ehmaldonaldo@chromium.org
>
> Bug: 1155492
> Recipe-Nontrivial-Roll: chromiumos
> Recipe-Nontrivial-Roll: infra
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Change-Id: Ib2e6e50901a0a10ed647acea3aeb517b83567702
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2580190
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

TBR=ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1155492
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: build
Change-Id: Ibd9f67bea71ee4a644b1077a365dbcd2a2c469f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2597065
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
4 years ago
recipe-roller 81098e59ad Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
21d171263a
  21d1712 (bryner@google.com)
      Fix swapped error messages for missing/unexpected exceptions.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic6e9cea41e0ddd4877027581cf457371d8306e12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2609869
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Edward Lesmes 364205c70e [depot_tools] Migrate metadata to DIR_METADATA.
Change-Id: I7e07de8746a269a31744f44296921cc9c6566a73
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2597738
Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
recipe-roller 3b39cefc61 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
b6f83ba9c0
  b6f83ba (qyearsley@chromium.org)
      recipes docs: Rename old_user_guide to walkthrough and add links

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I629b77027bfefb63ae83bc4ac4bb3642cf9f5d5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2605329
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 46ef281c52 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
32f0255a69
  32f0255 (qyearsley@chromium.org)
      recipes docs: remove backticks from section titles in user guide

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I51435508fa50e5a39298af73279650215951a3e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2603024
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Josip Sokcevic 67e12286df Add validation after downloading cache from GS
R=ehmaldonado@chromium.org, gavinmak@google.com

Bug: 1159123
Change-Id: I21aedd9e0c557f75d8c11e055013cc4a540ea20c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2595787
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
recipe-roller d5b38571d3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
c4e6ba917a
  c4e6ba9 (iannucci@chromium.org)
      [engine] Detect incomplete deps and circular dependencies.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib35e608fb688a3a39ceb8bbcb7d58185a5133cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2594487
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Josip Sokcevic d8fe52139f Check PACKFILE_OFFLOADING env variable
If set, set git config fetch.uriprotocols to https. This will be
initially set by codesearch builders. Once tested, this env variable can
be removed.

R=ehmaldonaldo@chromium.org

Bug: 1136986
Change-Id: I1c3da87bdbc74d18585ed00ffdc2cf21b84b16fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2591808
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Mike Frysinger f1c7d0dd2d gerrit_util: move changes: enable keep_all_votes
The default move behavior resets all non-blocking labels (including
Code-Review) which is not generally what we want.  Preserve them.

Change-Id: I9c49582b4147e27d3ed6a439a610c9c667d7aa7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2586110
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
4 years ago
recipe-roller b1d06a4d05 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
63a8f6a6dd
  63a8f6a (yuanjunh@google.com)
      [led] Remove ensure_led function

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I49578155d7f59270b7c49c8dfc683382f4f0823c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2593674
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Scott Lee 97752ea021 [resultdb] move cipd pin of infra/tools/rdb
This is to deploy the change of https://crrev.com/c/2549432 to depot_tools.

R=chanli@google.com,nodir@google.com
CC=maruel@google.com,yuanzhi@google.com

Bug: 1150844
Change-Id: I9aeb679009b0340536db0ad2063e3e8819271a01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2550945
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
4 years ago
recipe-roller 867d99d33c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
3cd5b2e316
  3cd5b2e (yuanjunh@google.com)
      [led] Support rbe-cas input

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb5f5e1499cca266135e20772670fe7d05b85b99
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2591807
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Edward Lesmes cf06cad1be [subprocess2] Replace VOID with DEVNULL
subprocess.DEVNULL was introduced in Python3 to serve same purpose
as subprocess2.VOID, so rename VOID to DEVNULL in subprocess2.

Change-Id: I6dade3306ffc3bc2441ac6083f362b099c2427e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2587758
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Edward Lesmes 9c7f6c25c0 [owners] Refactor OwnersClient.
- Remove GetChangeApprovalStatus and GetFilesApprovalStatus.
- Make host, project and branch part of GerritClient.
- Rename ListOwnersForFile to ListOwners.

Change-Id: I1f610a64f0217ce54e5ce4a210026535adc1c2e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2587268
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
4 years ago
Gavin Mak 99399caeac [owners] Add BatchListOwners
BatchListOwners uses git_common's ScopedPool method to run
ListOwnersForFile in parallel for multiple paths.

Change-Id: I545072e16181407665c8b009f87fccfb7355d7d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2585657
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
5 years ago
Gavin Mak c94b21d60c [owners] Use new API to list owners for file
This change implements ListOwnersForFile using gerrit's REST API in owners_client.py
Change-Id: Ic454dcd89a8f00f6b9e913e6b8ee9e1169581b38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2583327
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
5 years ago
Edward Lesmes d79114a2ed [presubmit] Add check to prevent new metadata in OWNERS files.
Bug: 1113033
Change-Id: I000cd307fea8862b9ef9cab907aafd357ee761bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2582566
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
5 years ago
Josip Sokcevic 6651fd8847 Use HEAD instead of hardcoded branch
Repositories may have different default branches. This ensures to fetch
remote HEAD branch which is default branch. Only downside to this
approach is that actual branch (e.g. origin/main) reference won't be
updated. Since we don't need it for this particular case, it should be
fine to use HEAD.

R=apolito@google.com, ehmaldonaldo@chromium.org

Bug: 1155492
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Change-Id: Ib2e6e50901a0a10ed647acea3aeb517b83567702
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2580190
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
Corentin Wallez 8732c0efd3 roll_dep.py: Fix outstanding references to subprocess
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2512921
changed roll_dep.py to use subprocess2 instead of subprocess but some
references weren't updated.

Bug: chromium:1156908
Change-Id: Icac020b463d1b68a4fca5b4ddf5cb80b9bfa9516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2581545
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
5 years ago
recipe-roller 0e323e7bff Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
c0e2975de1
  c0e2975 (yiwzhang@google.com)
      Revert "Log all keys in the input properties that maps to an in...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5a6593acba6b7e524638bb1cffdd1a9275623918
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2580763
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Nodir Turakulov 99b0e4a5f4 [dirmd] Roll dirmd in depot_tools
To pick up
optimization https://chromium-review.googlesource.com/c/infra/infra/+/2570537
and a fix https://chromium-review.googlesource.com/c/infra/infra/+/2577951

R=dpranke@google.com, ehmaldonado@google.com

Bug: 1154541
Change-Id: I43b9bc64ba24a642889b94f6f8344a66a18b7339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2580123
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
5 years ago
recipe-roller c1fbb82f9e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
802bc07a0b
  802bc07 (iannucci@chromium.org)
      [engine] Rewrite incoming properties to int-ify numbers which m...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib9b7d3fe27d35e0fbd55b0e762b787fa4c0d90e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2579644
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 1742f98791 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
5922510018
  5922510 (tikuta@chromium.org)
      [cas] add dummy output_text data for uploaded digest

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I68a357de636cbd0796874fbf26a864aafb2aa6d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2578357
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 5c5f0baa72 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
333bdf23f3
  333bdf2 (boleynsu@google.com)
      recipes.py: fix py3 compatibility

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7d65f16e394d10a8992eb9a079d17261c529cf9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2577875
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Nodir Turakulov 430315e951 Revert "[dirmd] Roll dirmd"
This reverts commit 8bbab2d874.

Reason for revert: there is a bug.
Fix: https://chromium-review.googlesource.com/c/infra/infra/+/2577951/

Original change's description:
> [dirmd] Roll dirmd
>
> To pick up optimization in https://chromium-review.googlesource.com/c/infra/infra/+/2570537
>
> R=​dpranke@chromium.org, ehmaldonado@google.com
>
> Bug: 1154541
> Change-Id: Ic7323d7fc1ff2ce719156e391541e930b3442deb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2577625
> Auto-Submit: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Dirk Pranke <dpranke@google.com>
> Reviewed-by: Dirk Pranke <dpranke@google.com>

TBR=dpranke@google.com,nodir@chromium.org,ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,dpranke@chromium.org

Change-Id: I97ea02bfb1a33d27be781479e04f1d33bae172d0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1154541
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2576761
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
5 years ago
recipe-roller 5ab3aa8e4d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
ea251c8bd2
  ea251c8 (yuanjunh@google.com)
      [proto] Update go.chromium.org/luci protos

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I069938fbf4df812de0ea815f753e14441cfde8c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2577872
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Josip Sokcevic df9a802ad2 Add change HEAD cli option to gerrit_client
This option modifies default branch of desired repository.

R=ehmaldonaldo@chromium.org, gavinmak@google.com

Change-Id: I1e20dc8d333c4301eacffff5049e3a98c3d59f75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575884
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
Nodir Turakulov 8bbab2d874 [dirmd] Roll dirmd
To pick up optimization in https://chromium-review.googlesource.com/c/infra/infra/+/2570537

R=dpranke@chromium.org, ehmaldonado@google.com

Bug: 1154541
Change-Id: Ic7323d7fc1ff2ce719156e391541e930b3442deb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2577625
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
5 years ago
Mike Frysinger 3b055d329e repo: use str(Path) for Python 3.5 a little longer
Give people one more month before we make 3.6 a hard requirement.

Change-Id: Ieb471b917c5ef5b9cb20b321305c4c13af675109
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575635
Reviewed-by: Michael Mortensen <mmortensen@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
5 years ago
recipe-roller 55e9ddf219 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
f0848ccd24
  f0848cc (tikuta@chromium.org)
      [swarming] update client

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I77248a2d12f1e3cb2840932572202a2fbc381f4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2576580
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller e602c60a2b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
4077ceeac8
  4077cee (qyearsley@chromium.org)
      Add a mapping of name to analyzer in tricium recipe module

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org, tandrii@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie7dc982f2db75d82e66d3cd03c3d4ec0dfac8ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2576035
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Gavin Mak e6a623392d [depot_tools] Use logging.warning
logging.warn is deprecated and should be replaced with logging.warning.

Bug:1097402
Change-Id: I55ce007bec47608eeafcf3cd9ac2b90f60073115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575621
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
5 years ago
Gavin Mak 18f45d2874 [depot_tools] Fix CMDlol
Hidden ascii art in git_cl.py needs to be decoded to utf-8 to print correctly.

Bug:1106660
Change-Id: Ie41490c789534ea6cb589bbc96aa06cd251943f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575620
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
5 years ago
recipe-roller fab6700b91 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
424f90b518
  424f90b (qyearsley@chromium.org)
      Edit comments in tricium recipe module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If4f54a989f40fd9025156938ddef1041a80fad6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575618
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller b283821099 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
6420c4e966
  6420c4e (yiwzhang@google.com)
      Log all keys in the input properties that maps to an int value

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0c18f4a5db2d4be543611af08efea9df34e2f675
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2575616
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 079a95bc72 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
577e2b3898
  577e2b3 (tikuta@chromium.org)
      [cas] update client revision

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic4a3cb54e1e8623a2f4ffa182ed9b9ba090b533d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2573582
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Edward Lesmes 968b1fe7d7 [git-cl] Use owners client when processing --[tb]r-owners.
Change-Id: Id094bce2aa731359cd8af16f10ce79ae7e02bd85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572809
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
5 years ago
Vitaly Buka b2c18f2f62 Support CMake generated build files
Chromium does not use CMake, however ninja with Goma is used by LLVM
team.

Change-Id: I38349d0574048b22b32365e45c587e604e045442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572805
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Vitaly Buka <vitalybuka@chromium.org>
5 years ago
Edward Lesmes ca45aff391 [owners] Fix SuggestOwners when there is only one owner.
If there are less than two owners for the given paths,
current implementation will get stuck in infinite loop.

Change it to return any possible owner.

Change-Id: I75f18e0a00057c58d227dac23dc8572f1fba23f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572802
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
5 years ago
recipe-roller 91cf42a075 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
dee64b8105
  dee64b8 (qyearsley@chromium.org)
      tricium: Remove indent in JSON string used for output property

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1046c027e1d60330b797d5a2ab733d2994e98765
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2572647
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago