Commit Graph

2186 Commits (97231b5fb51556cdb5507b516284f3dab7e83a87)
 

Author SHA1 Message Date
iannucci@chromium.org 97231b5fb5 Fix bad interpreters.
Somehow some (but not all) git helper scripts got the wrong interpreter. This
fixes them to use /usr/bin/env.

TBR=agable@chromium.org
BUG=

Review URL: https://codereview.chromium.org/212293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259522 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org 7122f7d66b Fix bug in git_squash_branch.py.
main takes args starting from 1, not 0.

TBR=agable@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/212223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259521 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org c050a5b2be Add a family of git-commands to assist with the management of multiple CLs/branches.
git-rebase-update - ensure all branches are up to date
git-new-branch - create branches
git-rename-branch - rename a branch while preserving parentage relationships
git-reparent-branch - change the parent of a branch, including rebasing it correctly onto that new parent.
git-squash-branch - collapse a branch into a single commit
git-upstream-diff - show the diff between the current branch and it's upstream branch
git-mark-merge-base - explicitly set what you want the above tools to consider the merge-base for the current branch.

R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/184253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259520 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org a5d9502e26 Add documentation for git-map-branches, git-map, git-nav-downstream,
git-nav-upstream, as well as introduce a generic 'depot_tools' manpage with a
listing of the other tools.

This change also fully colorizes the EXAMPLE sections for the git-* commands to
reflect their actual appearance on the console (html only, manpage has bolding
hints).

R=agable@chromium.org, szager@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/200903002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259338 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
isherman@chromium.org b5cded6951 Infer CL author and reviewer list from local state if the issue has not previously been uploaded.
R=agable@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/195793021

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259250 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
szager@chromium.org ff11329dfa Disabled threaded index-pack for known difficult repositories.
BUG=349576
R=mmoss@google.com

Review URL: https://codereview.chromium.org/210063005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@259164 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
borenet@google.com bda475e2f8 gclient: Fix nested checkout bug when validating .gclient
BUG=355492

Review URL: https://codereview.chromium.org/209963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258989 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
borenet@google.com 6a9b168463 Add warning batching in gclient_utils
BUG=

Review URL: https://codereview.chromium.org/209393006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258982 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
borenet@google.com 88d100836d gclient: in managed mode, warn if .gclient has a mismatched URL
BUG=

Review URL: https://codereview.chromium.org/195913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258617 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
deymo@chromium.org 29eb6e62ce my_activity.py: Parse rietveld dates without milliseconds.
Sometimes rietveld returns a datetime without the milliseconds part,
presumably when it is 0. This patch fixes the parsing of those cases.

BUG=chromium:323615
TEST=Ran "my_activity.py --week_of 11/18/13 --user jsbell" which returns "2013-11-18 20:42:30" for a bug.

Review URL: https://codereview.chromium.org/204013009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258189 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
phajdan.jr@chromium.org 174772e0ac Fix compatibility for gcl-try/git-try with repos not using tryserver.chromium
BUG=334892

Review URL: https://codereview.chromium.org/205633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258174 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
szager@chromium.org b000c1cdb2 Revert git-1.9.0.
I've received a few reports of:

error: inflate: data stream error (incorrect header check)
fatal: serious inflate inconsistency
fatal: index-pack failed
error: Could not fetch origin

TBR=mmoss@chromium.org
BUG=

Review URL: https://codereview.chromium.org/205443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258147 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
agable@chromium.org 3926228a5d Remove force push from GitCheckout.commit()
The CQ should not be able to force push -- this allows it to wipe out legitimate
commits if something goes wrong internally. This happened recently, with a CQ
commit orphaning 20 commits from the previous few days. This may have happened
any number of times previously, probably only wiping out one commit at a time,
whenever there was a race between the CQ and a developer's direct commit+push.

Repositories should also protect themselves by disallowing force push in their
ACLs.

BUG=261619

Review URL: https://codereview.chromium.org/196573041

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258092 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
szager@chromium.org 83f4767a60 Update to git-1.9.0.
Also, allow multiple git installations to exist side-by-side.
This makes it easier to revert back to an old version quickly.

BUG=
R=maruel@chromium.org

Review URL: https://codereview.chromium.org/203463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258058 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
agable@chromium.org 7e8c19df4b Revert changes to checkout.GitCheckout.
Things have gone wrong. This change and subsequent fixes were not as safe as
they should have been. Reverting until we can diagnose exactly what has gone
wrong, and how to prevent it from happening again.

This reverts commit fa3c388ec5.
This reverts commit e569f50330.
This reverts commit 7dc11449f0.

R=rmistry@chromium.org
TBR=rmistry@chromium.org
BUG=261619

Review URL: https://codereview.chromium.org/200923005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@258003 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
agable@chromium.org fa3c388ec5 Revert making apply_issue assume 'master'
Review URL: https://codereview.chromium.org/204013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257841 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
agable@chromium.org e569f50330 Assume 'master' when remote branch not specified.
This prevents apply_patch from attempting to check out a branch tracking 'origin/None'.

R=pgervais@chromium.org

Review URL: https://codereview.chromium.org/202483008

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257763 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
szager@chromium.org a4e4ef38a2 Fix push-basic.sh. How did it ever pass? We may never know.
BUG=

Review URL: https://codereview.chromium.org/203383005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257738 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
szager@chromium.org fc61638380 Rationalize the git config settings for index-pack performance.
BUG=

Review URL: https://codereview.chromium.org/202753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257728 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
szager@chromium.org 3407103d2c Presubmit check improvements.
- Don't pylint files in .gitignore or .git/info/excludes
- Print full path to modules in pylint.

BUG=

Review URL: https://codereview.chromium.org/202773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257672 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
hinoka@google.com 1b8f0abf17 Remove --shallow from git cache call in gclient
We don't want to do a shallow clone into the cache because it is not supported
on versions of git older than 1.9.

BUG=261741

Review URL: https://codereview.chromium.org/198103012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257578 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
szager@chromium.org 2b3ebf92c4 Fix error messages
BUG=
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/198723010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257541 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org 1520d9086a Remove python.new.bat instead of pylint.new.bat
python.new.bat was inadvertantly removed when iannucci@ committed
c64d3765a0

This restores pylint.new.bat and removes python.new.bat

Original CL: https://chromiumcodereview.appspot.com/140183007/

BUG=328453
AUTHOR=techtonik@gmail.com
R=agable@chromium.org

Review URL: https://codereview.chromium.org/196343024

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257489 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org c64d3765a0 Windows: Bootstrap Python first and get rid of Python 2.6 legacy
If loaded first, Python can then be used to replace JS bootstrapping
logic if appropriate libs are already present in depot_tools.

BUG=328453
AUTHOR=techtonik@gmail.com
R=iannucci@chromium.org, maruel@chromium.org

Review URL: https://codereview.chromium.org/140183007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257248 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org 9288d2ea36 Add git_docs folder to depot_tools.
Includes trial documentation for git-freeze and git-thaw, as well as a
make_docs.sh script which generates man and html documentation from the input
asciidoc files, using git 1.9's documentation toolchain.

R=szager@chromium.org, agable@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/196133007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257214 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
rvargas@chromium.org 0265260484 Presubmit: fix accepted copyright dates.
2006-2009/10 was a valid copyright date format before 2011 (when we decided to
use only one year, not a range).

The current directive with copyright is in fact to not change old copyright
dates, so there is no plan to go back and "fix" old files. As such, the
presubmit checks should not be complaining about old files.

BUG=none

Review URL: https://codereview.chromium.org/200643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@257181 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
phajdan.jr@chromium.org 8da7f27a2c Add an error message when explicitly specifying bots without specifying the master
BUG=352029

Review URL: https://codereview.chromium.org/199723003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256972 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
phajdan.jr@chromium.org 7f1e64490b Fix gcl try after PRESUBMIT files have been modified for multiple tryserver support
Note that other waterfalls are not guaranteed to support triggering via HTTP
or SVN. That's why this hardcodes tryserver.chromium.

BUG=334892

Review URL: https://codereview.chromium.org/197553009

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256947 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
szager@chromium.org 64e6f512af Emergency fix to avoid gerrit 2.9
BUG=

Review URL: https://codereview.chromium.org/199553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256925 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org 97345ebf1a Add git thaw/freeze to depot_tools.
R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/181043018

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256778 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org a112f03fcf Fix git_nav_downstream.py when origin/master is checked out.
Also fix missing copyright notices.

R=agable@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/196433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256777 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
tzik@chromium.org f204d4b81f Pass through "--filter" arguments from "git cl lint" to cpplint.py
Review URL: https://codereview.chromium.org/196943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256776 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
stip@chromium.org 626e77d9d3 Make rietveld test work on port 10000.
depot_tools PRESUBMIT.py and tools/build PRESUBMIT.py both run on cq.golo.

If broken dev_appserver.py instances are left around, they will conflict with
master ports.

BUG=351926

Review URL: https://codereview.chromium.org/197073007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256721 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
agable@chromium.org 7dc11449f0 Fix GitCheckout to be sane and use git-cache
The commit queue uses checkout.GitCheckout to manage the
local git repository. It resets it to a clean state,
commits patches locally, and pushes those changes to the
golden-source-of-truth repo.

This CL fixes the prepare() method to use the new git-cache
tool, and in the process makes it more consistent, more
readable, and more correct. It also makes minor changes to
other methods to bring them in line with the git-cache
approach.

R=iannucci@chromium.org, rmistry@chromium.org
BUG=261619

Review URL: https://codereview.chromium.org/175873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256681 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
agable@chromium.org 99f9c92f73 Accept remote urls as gospel in git_cache.
git_cache rewrites all urls to https://netloc/path when
setting them as remote urls. This doesn't work when the
remote is actually local on disk, and the "url" is a
/path/to/repo. This seems like an unlikely case, but it
is leveraged by testing, and it doesn't hurt to support
it, so now we do.

R=iannucci@chromium.org
BUG=261619

Review URL: https://codereview.chromium.org/196493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256386 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org 8bc9b5c101 Add git-map and git-map-branches to depot_tools.
git-map: Show your local repo's history in a pseudo-graphical format from the command line.

git-map-branches: Show the topology of all of your branches, and their upstream relationships.

git-nav-upstream: Navigate (checkout) to the upstream branch of the current branch.

git-nav-downstream: Navigate (checkout) to a downstream branch of the current branch. If there's more than one downstream branch, then present a menu to select which one you want.

R=agable@chromium.org, hinoka@chromium.org, stip@chromium.org, szager@chromium.org
BUG=

Review URL: https://codereview.chromium.org/184113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256384 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
szager@chromium.org ab4d438e34 Don't use -rc versions of gerrit.
This is an emergency patch to avoid picking up the
upcoming 2.9-rc0 version of gerrit, which requires java 7
and will break the chromeos bots.

BUG=346369
R=davidjames@chromium.org

Review URL: https://codereview.chromium.org/196063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256378 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
thestig@chromium.org 16c319dd46 Validate input dates in my_reviews.py.
Review URL: https://codereview.chromium.org/194753007

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256292 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
thestig@chromium.org 44202a28e9 Implement git cl lint.
Review URL: https://codereview.chromium.org/134223010

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256289 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
iannucci@chromium.org f52a6053e6 Refactor the way that git executables are launched in depot tools.
This introduces python_git_runner.sh, and makes git-cl, git-cache, git-number,
and git-try use it.

R=agable@chromium.org, szager@chromium.org
BUG=261738

Review URL: https://codereview.chromium.org/188383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256131 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org afc32ce3b6 Less attempted magic in pulling toolchain
- Don't try to wrap download_from_google_storage --config, instead just
request that the user runs it manually. (This is annoying either way
but making it magically run makes it less clear what's going on, and so
harder to debug when something goes wrong, per linked bug).

- Check that SHA1s are passed as expected on the command line in case
the script is run directly, rather than from gyp_chromium.

R=scherkus@chromium.org
BUG=349596

Review URL: https://codereview.chromium.org/189093017

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256049 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
thakis@chromium.org d0b0a5b08c Revert of Another attempt: gclient: delete mismatching checkouts (https://codereview.chromium.org/183283003/)
Reason for revert:
Broke `gclient sync` for me, failing with:

Error: 1> Can't update/checkout /Volumes/MacintoshHD2/src/chrome-git/src if an unversioned directory is present. Delete the directory and try again.


For someone else, it broke it with:

% gclient sync

________ unmanaged solution; skipping src

Error: Command svn info --xml returned non-zero exit status 1 in /Users/pawliger/chromium/src/.

<?xml version="1.0" encoding="UTF-8"?>

<info>

svn: E155007: '/Users/pawliger/chromium/src' is not a working copy

Original issue's description:
> Another attempt: gclient: delete mismatching checkouts
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=255930

TBR=iannucci@chromium.org,szager@chromium.org,maruel@chromium.org,mmoss@chromium.org,borenet@google.com
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/192323006

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@256005 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
plundblad@chromium.org 0455ed572c git gs: search .json files as well.
R=maruel@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/192293003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255960 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
borenet@google.com 7ff04292ac Another attempt: gclient: delete mismatching checkouts
Review URL: https://codereview.chromium.org/183283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255930 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 0d23d776e8 Move Googlers to gs:// based toolchain pull
The gs:// download path is much faster. Move anyone who could have
access to gs://chrome-wintoolchain/ over to that for less pain.

The downside is that we have to prompt them to run
download_from_google_storage --config which people are going to
complain about, but I think this is a better experience overall.

R=iannucci@chromium.org,hinoka@chromium.org
BUG=349964

Review URL: https://codereview.chromium.org/191373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255696 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
wittman@chromium.org 04d5a22ea9 Add git cl format --diff option to print format diff without modifying files
BUG=none

Review URL: https://codereview.chromium.org/180533012

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255667 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 6352945d3d x86 binaries for 7z for win_toolchain
To allow toolchain script to run successfully on x86 hosts.

R=phajdan.jr@chromium.org
TBR=iannucci@chromium.org
BUG=349824

Review URL: https://codereview.chromium.org/189563003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255641 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
scottmg@chromium.org 454f2ca9ed CHROME_HEADLESS is always Pro
Follow up to https://codereview.chromium.org/185423004/

The unzip is always Pro, and without setting this the data.json will
be getting the Express settings and so gyp will generate the wrong
project.

TBR=iannucci@chromium.org
BUG=323300

Review URL: https://codereview.chromium.org/188673003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255378 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
hinoka@google.com b16a16551d Be more aggressive about breaking locks
There is an issue where:
1. Lock for asdf.git acquires, which creates asdf.lock
2. asdf.git is cloned into tmp_asdf.git
3. Buildbot crashes, because timeouts
4. neither asdf.lock or tmp_asdf.git/config.lock gets cleaned out on the next unlock.

This aims to fix this issue by aggressively unlocking everything it can find that
vaguely resembles a lock.

BUG=339171

Review URL: https://codereview.chromium.org/187283005

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255138 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago
mdempsky@chromium.org d59e761ba8 Make missing PRESUBMIT.py warning consistent with others.
Review URL: https://codereview.chromium.org/188013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@255125 0039d316-1c4b-4281-b951-d872f2087c98
11 years ago