Commit Graph

5041 Commits (94580ab035eb3d05e352dc9c16b4908e9f744579)
 

Author SHA1 Message Date
Takuto Ikuta 9fce213bdb Partial revert of "git_cache: lower max num of .pack files before re-bootstrap on Win."
This partially reverts commit d51ed57edb.

Reason for revert:
New git client for windows was rolled including fix for slow `git fetch`.
I guess smaller pack limit causes frequent bootstrap taking 2~3 minutes longer than
the case it does not happen.
Let me see what happen if we increase pack limit 9 -> 30.
I will increase this to 50 if this won't cause regression again.

Original change's description:
> git_cache: lower max num of .pack files before re-bootstrap on Win.
>
> It used to be 50, I think ~9 gives best results for Chromium on Win:
>   on golo VM, it takes <4 minutes to re-boostrap + git fetch small
>   delta, assuming zipped git checkout for bootstrap is fresh (~1day).
>
> For other repos, which are significantly smaller, this change should
> have minor effect if at all.
>
> Test: I tested this using `led` tool on Win7 machines running LUCI
> stack extensively. For example,
>
>   * https://ci.chromium.org/swarming/task/3a0102e8c8657410
>     shows case with few .pack files, hence just 1 fetch
>
>   * https://ci.chromium.org/swarming/task/3a010282f9fd8010
>     shows case with 39 .pack files and so bootstrapping + fetch.
>     If you look at prior tasks on the same VM, you'd find this:
>     https://ci.chromium.org/swarming/task/39ffe843d01ed010
>     which spent 8 minutes doing 1 incremental fetch with 39 .pack
>     files.
>
> **Troopers/Sheriffs**: This change is safe to revert.
> However, beware that you should also at the same time revert the recipe
> roll of this CL to the repo, in which the failed builder's recipe is
> located, typically `chromium/tools/build`.
>
> Bug: 749709
> Change-Id: I18e2b63283100d466e9fb981a9094862463f6909
> Reviewed-on: https://chromium-review.googlesource.com/787174
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Takuto Ikuta <tikuta@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 749709
Change-Id: I3052abe4a9b53277a60c0791a85355e7a0bbdf8f
Reviewed-on: https://chromium-review.googlesource.com/823544
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
8 years ago
Mun Yong Jang cfb9a236fb [presubmit] Add logging for CheckChangedLUCIConfig
Add logging for location prefix

Bug: 761488
Change-Id: I2e742fced588111feacf94877487a6c65fffc78e
Reviewed-on: https://chromium-review.googlesource.com/833087
Commit-Queue: Mun Yong Jang <myjang@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago
Daniel Murphy 47d7464952 Revert "[vpython] Bump depot_tools version of vpython."
This reverts commit 454acc12ef.

Reason for revert: This causes run_webkit_tests to fail with the error
Traceback (most recent call last):
  File "{snip}/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 36, in <module>
    from webkitpy.common import exit_codes
ImportError: No module named webkitpy.common


Original change's description:
> [vpython] Bump depot_tools version of vpython.
>
> 9617f0f2a Roll infra/go/src/go.chromium.org/luci/ 1166f0f8e..79172f5b4 (8 commits)
> 26cfd6e55 [som] have staging hit findit staging.
> 7be5101e9 [Monorail] Parse and Preprocess hotlist searches
> 069fd6087 Introduces functions into the Tricium config.
> 34b45cfec chromium_build_stats: fix table message
> b9bb26a2f [Findit] Schema for Findit Analysis Events
> 57920812b [Findit] Flake Analyzer - Moving heuristic analysis to services
> 1e0e56837 Roll go.chromium.org/luci
> 6217fda16 [Monorail] Treat invalid oauth tokens as 401s.
> 6ca3ba437 Roll go.chromium.org/luci.
> 99d98fa4f Monorail: Reland command actions on alert emails.
> 6e2435fd1 Roll 'luci' DEPS.
> 099bbde1a Rolling 2 dependencies
> 21b330535 [CTF] Add new owners.
> 5c8bea6a2 [som] Update RELNOTES.md for weekly push
> e1a7ce224 [Monorail] Revert to returning 401s for expired oauth tokens.
> a9f648b3f [som] Add test result history fetching to the analyzer.
> f77237b66 [Monorail] Fix bug in training data loading function from previous refactor
> ff3cf9ec5 [Monorail] Reraise DB exception if we run out of retries.
> d5d1b7e2e [som] Separate alert links into "Useful" and less prominent "All"
> 4a3399a32 [Monorail] Add codesite files to spam training data
> 9f19d78d7 Install lsof on swarm_docker image
> a99057174 [vpython] Add chained-invocation integration test.
> c9095a4fa [som] Add support for using test run history from test-results server
> 07d9055ae [luci-migration] fix form action
> e8b915df5 [som] Some tweaks to render test results embedded in alerts.
> 31591036f luci-migration: copy "dry_run" if set when triggering tryjobs.
> ffbf69a37 [Monorail] Retry when we get database errors.
> 873617c36 [luci-migration] hide exp percentage on non-try builders
> 61eb55332 [Monorail] Make v1 API handlers close their DB connections.
> 16f7d35fd [Monorail]Monitor initial db connection time
> 3c1fb65c3 [buildbucket] add a test for explicit pool name
> f051010a6 [dockerbuild] build local pure python wheels
> 52399c135 [luci-migration] do not post comments twice
> 878fdf9d3 [buildbucket] fix default pool name
> 2c0cda242 Fix yaml syntax.
> cd71a211d chromium_build_stats: show by build-step time
> 345566bcc [Findit] Flake Analyzer - Fixing code coverage in recursive_flake_pipeline
> 388b9b698 [luci-migration] add "Start analysis now" button
> dcb818825 Roll luci-go and luci/gae DEPS.
> 958bfde84 [Predator] Fix a dashboard UI bugs.
> 311f433c5 [som] Stop splitting test failures into one alert per test failure.
> f949bd91a Roll infra/go/src/go.chromium.org/luci/ 3d94cf7eb..cab6ace71 (12 commits)
> 0460452ab [Monorail] Make all tests using testbed call deactivate().
> 387828527 [Findit] Use same GetStepLog to get tryjob report.
> 453a08cfa Use "copy" install mode in mpagent cipd package.
> eb747cc6a Add bug template for config propagation/validation tickets.
> f483132ee [Predator] Fix a typo bug in Predator for clusterfuzz.
> 558ace00a [som] Make a separate client services init for staging/prod
> 2ef7d0c72 [Monorail] Replace mentions of staging with prod in spam README
> e23dc277c [Monorail] Refactor more exception classes to exceptions.py.
> 83dd93631 Roll infra/luci/ 1e5342e46..e6fa13578 (19 commits)
> 495b48801 [Monorail] Finish support for custom fields in v1 API.
> ffbd73084 [buildbucket] fix entity skipping in query-based search
> 27a6be765 [buildbucket] return properties in LUCI builds
> 83da84670 [luci-migration] change metric to 1w
> bc798a5df [buildbucket] default pool to bucket name
> 498ac6a8e [luci-migration] hide "LUCI is Prod" on trybots
> 0d1009fbe [luci-migration] do not use relative time in reports
> ccfad35f2 Revert "Monorail: Add command actions to alert emails."
> b8e944ce9 [Predator] Disable TouchCrashedComponent and TouchCrashedDirectory for big regression range crashes.
> cd0113700 ChOpsUI: user-dopdown -> user-dropdown.
> 6fcaa7677 ChOpsUI-Gallery: Add Gitignore, edit Makefile, and update Bower.
> 4a19fceca [Predator] Catch exception globally.
> fcb0ff550 Monorail: Add command actions to alert emails.
> 033def824 SoM: Add crdx-header to SoM.
> ba5a63d14 [buildbucket] remove default swarming hostname field
> 975621029 [Findit] Refactor config validation.
> b255ab8c0 Revert "[Findit] Merge Heuristic pipelines for compile failures."
> 0bfe44fde Revert "[Findit] Merge Heuristic pipelines for test failures."
> c32afe359 Revert "[Findit] In _failure_analysis services, use int type build_number as keys in failure_info['builds']"
> 8bf2b13c1 [Findit] Flake Analyzer - Display times in local time
> 2d5155b50 luci_check: Fix recipe to run in checkout dir
> 3620b313a Revert "[Findit] Make HeuristicAnalysisForCompilePipeline inherit from new BasePipeline."
> 1e5cde891 Revert "[Findit] Flake Analyzer - Display times in local time"
> f04be69b8 [Predator] Clean up the log passing.
> 54b6b3102 [Predator] Fix bug in PredatorForChromeCrash.
> 4aa3ce3c5 [chromium-build] Fix chromecals javascript to use /deprecated/.
> 012da1352 [luci-migration] enable emails
> 72ab8187a update go/register-luci-project to use admin queue
> d8a5bcc19 Revert "[Fndit] Make HeuristicAnalysisForTestPipeline inherit from new BasePipeline."
> 5f7efcb4d Automate the process of retraining the spam predictor.
> 0e998e80f [Findit] Flake Analyzer - Display times in local time
> a81603075 [luci-migration] sort builders by status
> b1454d3e7 Roll luci-go deps.
> f9f33cd2b [Findit] Fix a bug in naming attribute definition metadata.
> 0a4b6a1c0 Add recipe to call infra.tools.luci_check
> a97924516 Flakiness Dashboard: Add CRDX Feedback button.
> 060bafc62 SoM: Restore custom labels per-tree to bug filing.
> 5a9193767 SoM: Make file bug dialog scrollable.
> 0751d9569 SoM: Update on-call links.
> 5c353879e [Predator] Fix KeyError exception.
> 0128ea6a6 [buildbucket] require swarming hostname
> 8b0834e80 [Findit] Treat an empty 'tests' key same as absent.
> 4927f86d7 chromium_build_stats: calculate weighted time
> 11d7448d1 Create packages for gerrit and isolated clients.
> c0c515630 [Findit] Not save extracted signals for test failures.
> 70548b555 [Findit] Workaround for too large signals.
> 9855f65b6 [Predator] Handle file name crash state.
> 8bc0df738 [kitchen] Remove some unnecessary flags.
> fd0f4b0d6 Roll luci-go deps.
> bdf91f698 [Predator] Handle and push back error message and result when there are errors in analysis.
> efaab3b1b luci_check: Check the diff between luci console and buildbot
> ef105ebcf [Monorail]Format url_type fields in issue details
> 7294ddb4b [dockerbuild] fix error with empty wheel regex
> fe09cfe76 chromium_build_stats: ninjalog dedup by cmd hash.
> 060753a04 [Monorail]Add url_value to Issue2FieldValue
> 552370e8c Roll luci-go and gae deps.
> 09fb10b6a [Monorail] Prevent restricted issues from being flagged spam
> 6c327c121 SoM: Update release notes.
> d176d3f6c [CTF] Check for duplicate bugs before filing.
> f25955a2a [Findit] Add default list of retriable exceptions for http interceptor.
> 13695716c [Findit] Default to 0 when confidence is returned as None.
> b706523bd [luci-migration] allow access to public masters
> 53655c36c SoM: Add chopsui dep.
> f8845fcf4 Revert "[Findit] Flake Analyzer - Convert timestamp to local time."
> 24531b06a ChopsUI: chops-ui -> chopsui.
> 34007b88a [Fndit] Make HeuristicAnalysisForTestPipeline inherit from new BasePipeline.
> 07700732c [Findit] Make HeuristicAnalysisForCompilePipeline inherit from new BasePipeline.
> e7de92d7e [buildbucket] fix assertion error
> f5c794263 [som] Fix bug filing form.
> 798475f67 [monorail] remove api/prpc
> 80684bc90 [luci-migration] Do not mark a builder as migrated twice
> 7d918d36f [luci-migration] set AnalysisTime when marking builder as migrated
> df0c9f2b6 [luci-migration] close bug when buildbot builder is deleted
> 19ff035a7 [cipd] Sort pkgs and dirs returned by API.
> 3b5e735ed [Findit] Use the new names for Findit's swarmbucket and pool.
> b6a606bf7 [luci-migration] Add oauth2 for bots.
> 305b22285 [buildbucket] improve error message for expired builds
> 053bd2ea9 [master-manager] Warn on attempting to restart an official master.
> 48367b9cb [Findit] In _failure_analysis services, use int type build_number as keys in failure_info['builds']
> ff9c111b3 [buildbucket] rename reset_expired_builds
> c0e91eca6 ChOpsUI: add header element.
> 8381d259b [Findit] Make Findit not flag changes by certain accounts as culprit.
> 6485b539d [luci-migration] add Builder compound index
> 0a9afb421 [buildbucket] Add access API.
> e9701c393 [som] update RELNOTES.md
> b2fb31f1a Roll infra/luci/ 9761e1747..1e5342e46 (87 commits)
> a57d95fe8 Roll luci-go and luci/gae DEPS.
> 2026eaab6 [rietveld] Fix test_views.py.
> 3e9fee3ce [som] Send a *pointer* to a proto struct to eventuploader
> 07f77f164 [Findit] Flake Analyzer - Minor css and polymer tweaks
> a8efd0ae0 android_docker: Mount /etc/sudoers* in the containers.
> 1bc2dc1ea [crbadge] refactor a little.
> 36b0e1b2c android_docker: Set isolate cache size in containers based on disk space
> 1afce8b07 [Predator] Publish back result for every crash.
> 0eb02b776 [Findit] Flake Analyzer - Add pipeline to determine isolated sha of commit position
> 989999772 SoM: add snippet about user to inline-filed bugs.
> c8b558b2a [test-results] Remove table schema comparison code
> 2daaf183b [Findit] Flake Analyzer - Convert timestamp to local time.
> 006253c6a [som, TA/DA] Add link to test expectation editor.
> 91ca088ec Roll go dependencies and luci-go DEPS.
> da194ebbc "Reland chromium-build redirection changes"
> 25ec7fd1b [Findit] Flake Analyzer - Always show heuristic results if available
> ee6d97628 [luci-migration] discover CI builders
> 2e716e1e3 [bigquery] refactor BigQueryHelper
> f64f2c1ce Remove references to phajdan.jr
> 5af01dd6d Fix 500s from json serialization of datetimes
> 206b4474c [kitchen] Fix logging nit related to devshell disablement on Windows.
> 35db563a4 [Findit] Flake Analyzer - Adding diagnostic logging for missing swarming tasks
> c433034fa [kitchen] Use gsutil authentication helper in addition to DevShell.
> 66dc8a1ba [test-results] fix nil field error.
> fd4b4bfa4 Roll luci-go DEPS.
> ec1186473 [som] RELNOTES.md update
> d7108a228 [Monorail] Enable API rate limiting.
> 798871461 [Findit] Merge Heuristic pipelines for test failures.
> 2efbaf68e [Findit] Merge Heuristic pipelines for compile failures.
> 4fdf96945 [Findit] Make sure not append a try_job result which is already in results.
> ac97a9bc4 Correct link formatting in CONTRIBUTING.md
> df59914d7 Revert "[som] Update RELNOTES.md for weekly push."
> 4f09c9256 [som] Fix some text entry issues with email autocomplete
> d46e115c5 [Findit] Flake Analyzer - Give filed bugs priority and a status
> abe5d330f [som] Update RELNOTES.md for weekly push.
> 6ce4d0da8 [Findit] Refactor identify_test_try_job_culprit_pipeline to use new BasePipeline.
> 91dcf3242 [Findit] Flake Analyzer - Fix blank value for culprit analysis status
> 866f8be3a [Findit] Mock urlfetch on testcase to stop tests using http.
> b864c5a49 [Findit] Merge scheduling and monitoring test try job pipelines.
> 18f03641b [Findit] Support 'use_swarmbucket' config for defaults.
> c8dfa8ea0 [Findit] Flake Analyzer - Allow minimum confidence threshold to be configurable
> 3d17e151c Add autocomplete UI for cc: field in bug form.
> 60a2dcb8b [Findit] Flake Analyzer - Account for try job result being None
> e4840fe3b [Findit] Refactor identify_compile_try_job_culprit_pipeline to use new BasePipeline.
> cad0bc77c [Findit] Flake Analyzer - Remove process flake swarming tasks from main
> d79426efc [Findit] Flake Analyzer - Check for a previously filed bug for test
> 68ec397c6 [Findit] Merge scheduling and monitoring compile try job pipelines.
> ed65c5e98 [Monorail] Fix issue list cells for enum custom fields.
> da379bd77 Handle better lkgr_finder failures.
> 273ef7d9c Roll go.chromium.org/luci
> 11b4c4615 SoM: Restore autofilling CCed user.
> 64860d91a [Findit] Add urlsafe_try_job_key to parameters to run a try job.
> c0fc9ff2d buildbucket: return build numbers
> 4521a5432 Put PRESUBMIT in correct location
> 80e2480c9 [Findit] Mock GetBotsByDimension in TryJobTest.
> ab434669c [buildbucket] index experimental
> d77ddb92b [buildbucket] do not cancel tasks
> cdcb665d7 [Findit] Move logic in monitor_try_job_pipeline to service module
> bf39d808f [buildbucket] do not monitor experimental builds
> b47b6de09 [buildbucket] simplify metrics.fields_for
> f1a52871b [buildbucket] move build normalization to model
> a358efe8a [Findit] Flake Analyzer - Unlock throttling and add config override.
> 3e893cdb0 Upload lkgr status page even if lkgr_finder fails.
> ad252d114 Adds Feedback RPCs.
> 88f3e20cd [Monorail]Fix template2field table col
> 190d224fb [Monorail] Define IssueDelta to simplify DeltaUpdateIssue() args.
> 4a677ceb7 Adds comment creation time.
> c1ec1ceb1 Adds comment UUIDs.
> dd27550ff [buildbucket] exclude experimental builds from search results
> f76b4c852 [buildbucket] add build.experimental attribute
> 30944d69f [buildbucket] extract common property validation
> d2779848b [som] Add a user email autocomplete handler.
> 2b69be620 mac_toolchain: update file permissions post-install
> c4e95932f Add presubmit script for config validation
> 894cac284 mac_toolchain: add "package" command
> e2de5cb7c [Findit] Flake Analyzer - Removing unused queue
> cac592bef [Findit] Making code coverage 99% to account for disabled tests
> 5ad3123bc [Findit] Disable another flaky test.
> 8424c14cf [Findit] Flake Analyzer - Deprecating trigger flake swarming task from findit_api
> 20af972ae Reland "[Predator] Store log in datastore for each crash."
> 90b64a3b3 [Findit] Reenable testUpdateFirstFailureOnTestLevelThenUpdateStepLevel
> 26ee39500 [Predator] Fix a minor bug in result feedback page.
> 0e3a203b9 [Findit] Flake Analyzer - Find nearby build that's valid.
> b6fddda68 Roll luci/luci-go and luci/gae DEPS.
> dee11894e [Monorail] Add MarkupDescription and ParseIssueRequestFields tests
> c638d37a5 [Findit] Fix flaky tests in service/test_try_job_test.py
> a0bc466dd [Findit] Support swarmbucket bots for flake tryjobs.
> 6da824aa7 [Findit] Temporarily disable some flaky tests.
> 49a01b212 [buildbucket] make migration_host a message field
> 40b132329 ChOpsUI: Add crdx- prefix to all elements.
> 6d7a1b94a [Findit] Support new build url format for luci tryjobs.
> 3f14a67ab [Findit] Use a new url to get all rotations.
> dc0bf59c7 Keep bolded text after issue description edits
> 5ca67600a Revert chromium-build redirection changes
> 19f4568f9 [som] Update RELNOTES.md for weekly push
> d406cf231 [luci/server/portal] Adapt to rename of /admin/settings -> /admin/portal.
> 692fa6e48 [Findit] Parse dict dependency in DEPS file.
> fd63f5a0a [Monorail] Update footer links to be https.
> 43c9fd9cb [cr-buildbucket] Add LUCI Migration App support for swarmbucket.
> b2481685e [Findit] Flake Analyzer - Implement new schedule flake try job pipeline to compile and isolate only
> 1e8154971 [bigquery] simplify imports
> 78468fe15 chromium-build: Reroute all main handler routes to ci.chromium.org
> 9d5e9479c [ctf] update the json field keys try-flakes looks for.
> 4a992e1d3 [Issue Wizard] Update template list of other browsers.
> b35e075ac Roll luci/luci-go and luci/gae DEPS.
> b78c8f693 chromium-build: redirect to ci.chromium.org
> 19029c011 [Findit] Flake Analyzer - Encapsulate analysis entities and improve ui
> a38b31469 [infra/libs/bigquery] modify to expect protos
> d06bf514a WebRTC: Display html page with lkgr_finder info.
> e05e0bd3d Cleans up Gerrit project mapping.
> e73516d3f Make url_types links throughout monorail
> 2fa99e600 Roll luci-go and gae
> b5f87f503 [Monorail] Allow dashes in domain part of /u/EMAIL urls.
> 50cf28d29 SoM: Make +/- buttons in menu sections toggleable.
> fd8aa212f Revert "[Findit] Flake Analyzer - Run all flaky gtests experiment"
> ecb4cfb2d Check url_values before saving
> a1f26f2a1 [Monorail] Temporarily disable comment classification
> 49b05561c [Findit] Make swarmbucket requests specify mastername prop.
> 6e420fe71 [Monorail] Avoid a DB write for action limits of whitelisted users.
> dc9d7df49 [Monorail] Block an IP hitting the same URL every 5s.
> 3522bfc28 [bootstrap] add urllib3 package
> d05bd20a3 [testresults] add event logging
> 5dfc798ee WebRTC: Remove Memcheck from LKGR config.
> 3142575bb [ts_mon]: metrics.py: Add __eq__ methods
> 26940384c [bootstrap] update google-cloud-bigquery
> 19c5ba0a7 [luci-migration] schedule builds without got_revision
> 5c0c2bac7 [dockerbuild] Allow building on native platform.
> 0e1c8b0ce Revert "[bootstrap] update google-cloud-bigquery"
> 74c7de65a Fix chromium.android LKCR entry.
> 1821be50b Roll luci-go.
> 54472fa9f led: improvements in led get-build subcommand.
> d221ca328 [buildbucket] add error field to all response messages
> 01aecd1b0 [bootstrap] update google-cloud-bigquery
> 5be4bb563 Update cros builders used in LKCR determination.
> 70205ddef [Monorail] Make the v1 API require issue owners to be project members.
> 9673d2fe9 [Findit] Use basestring instead of str for pipeline output_type.
> a74430167 Update Android bot locations after the move to chromium.android.
> 90984bd47 [luci-migration] Add LUCIIsProd bool and JSON GET API.
> d229b6939 Move link regex to _constants
> 06810efc4 SoM: Remove per-alert group button.
> c318694c8 [Findit] Update the parameters when calling the pipeline to start a test try job.
> 276854c5e Finish url_type validation
> 0d174bafc [Findit] Use a dedicated pipeline to identify test try job culprits.
> 1f9a01ecc Make url_type custom fields searchable
> e164be065 [Findit] move remaining logic in culprit action wrapper pipelines to service.
> 49374d0ff Remove unused const `repo` from rpc_analyze.go.
> 6f8050b96 [Findit] Flake Analyzer - Link flake culprit pages to dashboard
> 4bc16b954 [Findit] Flake Analyzer - Run all flaky gtests experiment
> 03c7c90a1 [Findit] Flake Analyzer - Allow cancellation if tryjob is still in progress
> 66ea9e832 [swarmbucket] Filter with tags after applying tags to task :)
> 3f5a70e3f Monorail: Remove trooper autoassignment for alert bugs.
> 90422d4dc Make url_type fields modifiable
> 57f4c0c10 [dockerbuild] add more google-* wheels and --wheel_re.
> 9362ae533 [Findit] Refactor schedule try job pipelines to use new BasePipeline. (2/2)
> 600f4e13d [Findit] Import from new pipelines.py instead of the deprecated pipeline_wrapper.py
> 09ed0cfc0 mac_toolchain: include symlinks
> 1bd943446 [Monorail] Update spam.py to accept files, not stdin
> cc8c14881 [Findit] Flake Analyzer - Add confidence score to flake culprit page
> fb8c467b1 [Findit] Move pipeline inputs and outputs to services for a more general use.
> eaaedf26d [luci-migration] run analysis once in 4h
> bcfd58a61 Fix to make the parser work for infra
> b070a823c Correct two minor spelling typos in tricium.proto
> 405152ea0 Revert "[Predator] Store log in datastore for each crash."
> 6707984c0 [led] Add ability to set buildbucket tags on get-builder command.
> f75c79ff1 [Monorail] Loosen +1 prevention for project members
> 1f1e7caea [3pp] Fix exception when getting gsutil version with newline in it.
> e878ba8a7 [Predator] Store log in datastore for each crash.
> 6d1a8303b [dockerbuild] Add google-cloud wheel.
> 2fc37a078 [Findit] Flake Analyzer - Adding improved detection for nonexistent tests
> 9530714a4 [Findit] Flake Analyzer - Use yield when starting pipelines with delay
> e724c2e47 [Monorail] Spam: only use word_hashes as a feature
> a3b979c41 Lay foundation for ability to create url_type custom fields
> 6dd059518 [Monorail] Suppress confirmation when switching a blank template
> 57d1b8f53 [Monorail] Fix unquoting of form data for issue template name.
> 29b44ca85 [Monorail] Add role="presentation" to monobar navigation table.
> 4806953a6 Updates proto message documentation.
> b7755a6bc [buildbucket] unflakify swarming tests
> edc03273d [build] add vpython-native package.
> dca6e39ec [crbadge] Add references to assets
> 2dbbefc4e [crbadge] Commit code to compute 'code-number_of_files_added', 'code-number_of_files_touched' and 'code-number_of_files_removed'
> e60bf5182 Rename badge code-revert_consecutive_x2 -> code-revert_consecutive.
> f1fd4f60d [crbadge] add to_json.py
> dec53d0c6 [crbadge] Add readme
> c582795d5 Add login: admin to app.yaml
> fc34ccc62 [swarmbucket] Add conditionals for objects in task definition.
> 1f10693f2 [Findit] Refactor pipelines to schedule try jobs (part 1/2)
> 44a4189fa Updated readme to reflect more descriptive monorail instructions.
> c4dd374e3 Update documentation to point to correct lines
> 9010ba713 led: emit luci UI URL on successful launch.
> 48b2a8277 Refactor fileBugDialog into separate element.
> e56341506 Roll luci-go DEPS.
> abd258fda [Findit] Flake Analyzer - Include more information for filed bug
> 1b77c874e [Findit] Use basestring for str/unicode type of attributes in StructuredObject
> 14c444d3d Update README
> bead4bb6d [Findit] Flake Analyzer - Remove swarming_rerun_results from MasterFlakeAnalysis
> fafa4b02e [eventupload] modify to expect protos
> fb10d6264 [Findit] Use test specific pipeline to run try job.
> 87194899d Remove deprecated and unused android_docker_image_builder recipe
> 932f7aff0 Use chops-ui elements and demos to create chopsui-gallery app.
> 06dd43cf3 Rename the directory to match the image name
> 07300c5ba Allow to override dir name where docker image script is located
> fddbe6fc6 Add swarm_docker CIPD package
> b7e37aebc Add a generic recipe for building docker images
> bb1ef5414 Revert "[luci-migration] run analysis more often"
> fb6e95fa3 [luci-migration] run analysis more often
> 7e8a5129c Redo imports
> b5128904e [Findit] Add a new owner.
> d91c95e92 [Findit] Flake Analyzer - Check if test is disabled before filing bug.
> 5a33648a5 Revert "Reland "luci-go recipe: make precise-32 builder fail if run on luci.""
> 3e7c7695d [Findit] Add the Universal Feedback Button to each user-facing pages.
> f91092f8e [Monorail] New subscriptions default to "All issues".
> a5fc1d460 sysmon: Pick up multiple types of ambient temp sensors.
> a6afbcc20 [Monorail] Update our work-around to urlize() quirks.
> a9c0a8ab8 [Findit] When getting logdog logs, retry when get empty log or log in wrong format.
> e5ff2c59f Reland "luci-go recipe: make precise-32 builder fail if run on luci."
> 961372709 [buildbucket] use new LUCI UI build URLs
> 6610de181 Recreate bower.json
> a01c58c9c [Findit] Add retry logic to irc message sending.
> c0769eed9 Rename back to chops-ui
> 4deec5e2e Take [] out near the 171 mark
> fd38369af Keep only one html file in bower.json main
> 2d72ed64f Remove android-specific remarks from the comments and docs
> c5ad87f85 Tricium service: Allow requests from any origin
> a7be75200 [Monorail] Only do on-page profiling for the main python thread.
> 8ccafa7b8 Splits up swarming info in progress response
> 3bf36b432 gerrit_api: do not delete users' draft comments
> 8cb566883 [test-results] remove event schema
> 8617ab58c Specify versions
> cccc52d9f Fix bower json file
> 912271c29 Edit chopsui name
> 553eb9b07 [Findit] Login should redirect to the current page instead of the referred one.
> f68e2c8d2 Update version in bower.json to match git tag I just pushed.
> 7e6cf0833 Revert "luci-go recipe: make precise-32 builder fail if run on luci."
> 085df35a5 luci-go recipe: make precise-32 builder fail if run on luci.
> 92039ff16 Link fileBugDialog to bugDialog
> 1f2ab2f33 [Findit] Update links in header.
> 47358bf85 [Findit] Flake Analyzer - Check that test is flaky on recent build before filing.
> 626a7de21 [Findit] Allow generator pipelines to return without yielding
> 1f7c77e4d [Findit] Fix path conflict of protobuf for non-production environment.
> f655df340 Buildbucket: add `swarming.auto_builder_dimension` config flag.
> 010f09872 [som] TA/DA: allow adding expectations for tests that don't already have them in any existing expectations files.
> e3a2ddd67 Link new issue to alerts
> 7128c378c [Monorail] Fix component auto-cc in case where all are removed.
> cadf7b6db [Findit] Separate logics in build_failure_analysis to better modules.
> 89ed9aa4d [Predator] Always redo cracas analysis.
> 9e07cecb3 [Findit] refactor revert_and_notify_test_culprit_pipeline to use new Basepipeline.
> 94fdd3cf0 [Findit] Refactor revert_and_notify_compile_culprit_pipeline to use New BasePipeline.
> eb8ee5857 fix typo: python_version instead of python.
> 38eded8ba mac_toolchain: add -service-account-json option
> f1776bcaf Re-create chopsui-gallery
> 5c0c0a19d Add inline bug filing
> 78dfe8f06 Remove Prediction API related code and clean up docs
> 54258fbe7 [Findit] Flake Analyzer - (2) Limit bugs per day
> 3781a3172 rename chopsui folder
> 55d09a098 [Predator] Fix a minor bug in run-predator.py local script.
> dea304ea5 [test-results] Stop sending events to BigQuery
> efdce776e [Monorail] Fix email and display of amendments to custom fields.
> 534b6969d [test-results] Change milo links to use vanity URLs.
> 492b166f4 [som] Change milo links to point to vanity URL and use public name.
> c2c275503 [buildbucket] raise exception on invalid gerrit buildset
> 9e24410bb Add file bug handler and som-file-bug element
> 52887aa8e [som] Update RELNOTES.md for weekly push
> 9735db23e [Findit] Flake Analyzer - Limit the number of bugs that can be filed daily
> d333ad987 Start cross-compiling luci_machine_tokend for ARM.
> 35aacd3d0 [Findit] Fix the assertion error when getting configs.
> 0ceb1fee7 [Findit] Add survey link to review message.
> bdb8e9bc9 V8: Add win-msvc bot to lkgr
> 728f30c51 Docs: Update builders.pyl docu for multibots
> 67dc28365 [som] Don't rewrite go links to https.
> 1be879723 [Findit] Flake Analyzer - Change task id to green.
> 5eb62e84c [dockerbuild] Fix OpenCV building.
> e517b566b [Monorail] Mitigate and log error in profiler.
> 53e12b3a4 mac_toolchain: implement installation of Xcode.app
> ccd0caade mac_toolchain: Implement packaging of Xcode.app
> 0656e799f Allows for no run ID in progress request for Gerrit change
> b96c3ec5a Keep luci-py checkout at the root of infra/luci-py CIPD package.
> e6c2ae3a0 led: Don't ignore task service account.
> 1cacf773b Roll luci-go DEPS.
> fe07e9d46 [Findit] Flake Analyzer - Do not reuse try jobs without usable data
> c1198b6d8 Fix ML Engine response key error
> 2d17c3f26 Add luci-py CIPD package definition.
> 1881f4891 [Findit] Modify StructuredObject to use TypedDict and TypedList.
> 82f19de9b [Findit] Add dict-like and list-like objects to limit element type
> 74c5afaf5 Revert "Disable WPT auto-import temporarily by skipping the upload step"
> 40a6bfb08 Create infra/tools/luci/mmutex CIPD package
> 9167001d7 Docs: Change Chrome OS Waterfall Pin Bumps / Restarts link.
> af4499655 [Findit] Refactor send_notification_for_culprit_pipeline to use new BasePipeline.
> 2b54e247a Rietveld: remove never-called delta calculation task
> 2b399feb4 Rieveld: remove as much chromium-specific code as possible
> dc598cd81 Rietveld: remove all account statistic tracking and display
> 9c381f0af Move shared to crdx
> 2f462c227 [Findit] refactor send_notification_to_irc_pipeline to use new BasePipeline.
> 42f4710ca [Findit] Refactor submit_revert_pipeline to use new BasePipeline.
> 904a7886b [dockerbuild] Internally-universal Wheels.
> 010431510 Rietveld: remove cq and tryjob update tasks
> 38bc018e1 Rietveld: remove stat calculation task
> 22f1e628b [Findit] Skip mal-formatted changelog string.
> d773070c2 [Predator] Pass features options to TouchCrashedDirectory and TouchCrashedCompoennt.
> a0a4300e3 [luci-migration] make builder-not-found a permanent error
> bf774e830 [som] convert logging from txt proto tabledefs to plain protos
> 9be6ca443 [cr-buildbucket] log more in tag index maintenance
> 00d6abeff Disable WPT auto-import temporarily by skipping the upload step
> c44213d85 kitchen: Mint one token with cloud-platform scope instead of 3 different tokens.
> f7ca6da12 recipes: Simple gsutil recipe
> 6b8ee512f [bbroll] Only abort if changes is None
> 158004459 Create time-stamp element.
> e1336ba2d [som] Update RELNOTES.md for an off-schedule push
> f03031504 Create package for gitiles client
> c35304164 Make default spam FP bug owner jeffcarp@, add spam-fp label
> 686a57de3 Transition from calling Prediction API to calling ML Engine
> cfcf1a445 Roll "luci-go"
> ef26201ef [Findit] Flake Analyzer - Fix for only the first task being tracked
> d42277eb4 Update git patches for v2.15.0
> f8cd51e0e [som] Move annotation key into POST body.
> bccd8b7ba [third_party_packages/git] Fix Git test.
> 9615eb7c2 Reland "recipe_roll_tryjob: Add individual manifest name to bot update steps"
> 13fbf3117 Add scripts for creating new elements
> 57b2f8c99 [Findit] Whitelist more auto-commit accounts to skip auto-revert.
> 43fc206f8 [buildbucket] Add project to Build message.
> fc9ee7a7b Revert "recipe_roll_tryjob: Add individual manifest name to bot update steps"
> f47e08fb2 SOM: Split alerts by test
> fcc359a08 recipe_roll_tryjob: Add individual manifest name to bot update steps
> 348cede58 [luci-migration] include result in the response
> 97ac496c0 gerrit_api: allow custom instrumentation_id.
> 9b2147287 kitchen: Hook up DevShell support
> 36bb94e1c [som] Update RELNOTES.md
> 8dc0690c4 [Findit] Flake Analyzer - File bugs against prod
> afaf08cfa [Predator] Fix a bug in result feedback page to show error messages.
> ee0f03737 Make bug-link accept non-chromium bugs
> bc33ef865 [Findit] Add manual link to messages to sheriff and cl owner.
> 97623c9ec Make bug-input accept non-chromium bugs
> 3d4ca3e04 [Monorail] Refactor issue starring to go through WorkEnv.
> d1f68cb18 [Monorail] Refactor issue and comment deletion into WorkEnv.
> 3b36b5479 Remove luci_go_web_packager.
> ddacaf91e Add Win (more configs) to WebRTC lkgr finder.
> 7b9be6aa0 Add configuration_id field for sampling profiler and use in identifier
> 7c820a5f4 Roll infra/go/src/go.chromium.org/luci/ fbb8a7b77..4d42df061 (14 commits)
> 8b3b49345 [Monorail] Correct the CSS cursor for the no-results messsages.
> 3e0a1a806 [Findit] Turn on/off auto-commit instead of auto-revert.
> 86de88180 [Monorail] Re-enable formerly-flakey tests.
> ca1bea8e8 [Predator] Add r'.*(ERROR|WARNING): ?UndefinedBehaviorSanitizer' to ubsan detectors.
> 833b3a01d Limit sampling profiler signature length
> 01dd8a349 [Predator] Fix a type error exception.
> e6ca34602 [Predator] Add configuration for features.
> 25361c0df Revert "[crbadge] fix bugs in commit.py"
> f4e6cc903 [crbadge] fix bugs in commit.py
> f1c2c905f bugtemplate: add template=Build Infrastructure
> 1bdc53483 Support deployment to predator-for-me prod app id
> def9c899d [test-results] define a proto message to eventually replace json.
> bc85c99b8 [bqschemaupdater] remove bqschemaupdater
> ef0b4313e SOM: Fix reason merging
> a82f4664b [who] Move to experimental
> ac026a559 Who: Make Crwho deployable again.
> 1569ec4e0 [Findit] Flake Analyzer - Moving build info functions to shared location
> 1cb547e64 [Findit] Get isoalted sha of master/builder/build number/step
> 8db6622eb Allow builders in chromium.goma master to upload test results.
> 264feef45 [Monorail] Initialize shared cache in a test class that uses it.
> e3678f36c V8: Make fuchsia bots block lkgr
> efc10ee0f Rietveld: fix old UI rendering of message threads
> e97ed50ae Rietveld: remove db write operations when computing diffs
> 50a99ceea Rietveld: remove more dead code
> bf9304a11 Template for ios-ops-ticket
> 9ab65c8ee [luci-migration] fetch failure_reason and cancelation_reason
> 9998dc220 Who: CSS
> bded288ea [event pipeline] update docs
> 99cb9041d [dockerbuild] Add "pypiwin32".
> 6b4e09721 Use position:sticky for floating details panel when supported
> a0bd74542 Fix total awarded count and make badge counts non-cummulative.
> b2d222016 crbadge: add badge level counts
> 6d1e8a61c Make badge <div> taller so that there is room for longer titles.
> 61a5e0d57 Allow more chararacters in URLs
> 823ae9bcf [opstoberfest] Some bugfixes
> 9d0b46027 crbadge: fix icons
> 900533912 [opstober] Filling out array even if there's no data
> 67e6c30db Who: Create a CRDX header element.
> 8c5908401 [crbadge] Fix more bugs.
> 1b23b6972 [Findit] Parse git HEAD to local commit for local git repository.
> 40074d961 crbadge: Fix uploader, add TimeOfDay badges.
> 341ffe8c5 crbadge: Batch userdata ingestion
> e49433824 [opstoberfest] Day-details works!
> c5482eb6c [crbadge] description.py
> f04961b1b Disable flaky tests
> bcecdab66 Load badge data from datastore.
> 4ae3542ed [opstoberfest] Transforming activities to weekly activities
> ad1100678 Specify element versions
> 2237172f6 [opstoberfest] Redux works!
> b2e1d3cd5 [opstoberfest] Add activity-table element.
> 60ef65a26 Extract generic Docker functionality into swarm_docker module
> 627289e4b [crbage] Fix bug.
> cb06c45ba Initial implementation of page for badge details.
> 3015e1281 Who: Add basic routing.
> fd3b0fdb1 PWA boilerplate
> 47268705b [who] implement the user and date filtering for history and detail
> b64b78aae crbadge: reverts
> 2bdea8866 crbadge: Make uploader.sh actually upload stuff.
> dece00068 Who: Make gae.py a symlink.
> 019f87667 [who] fix some trailing semicolons that casued js errors
> 9cdb8b973 [who] update bower for paper-item etc
> 9ad00b8b2 [who] fix relative paths for html imports
> 21a6a2d1b [who] fix malformed bower.json
> f2bee5f20 [crbadge] Add commit_streak_days.py.
> 4b3d241ef Fix todo placement.
> e59dc0d2f Make badges have shield-shaped backgrounds.
> 9a7b95227 [crbadge] Add commit.py to compute badge.
> d57ae9d90 [who] get real activity counts by day, from monorail and gerrit
> 980a1ff17 [Findit] Make LocalGitRepository handle None start_revision and None end_revision.
> e13c6ef16 crbadge: Fix uploader
> 550005d42 Serve large actual images and calc badge view details.
> fc662e9bc [who] Add dummy API calls for /_/history and /_/detail
> eb12d4604 CrBadge: Ingestion pipeline
> d332e30a7 crbadge: datastore models
> 7832d6abb add shared
> c9ce1f036 [crbadge] Uploader.sh skeleton
> 7bb1de2be Implemented basic page serving.
> 9505420d7 add day-details.
> 89ece1c4d [who] Add auth stuff
> 1e7cf9257 [opstoberfest] Add elements/who-page.html
> f67a1ae1d [opstoberfest] Add actions.js with action types
> 840a8a469 Add day-icon
> 01e81714b [opstoberfest] Require redux via package.json in who.
> 36aeb6031 [crbadge] Fix typo...
> 4f9d4a8f9 [crbadge] Add libs and local_libs from findit.
> fa8bbd96d CrBadge initial source file layout.
> 64dc776ff [who] bower stuff
> 3b924b1a8 [who] initial dir
> 453d15550 cr-buildbucket: Put 'buildbucket🪣...' tag into delegation tokens.
> 88a96b309 Roll infra/luci.
> 16a22aa58 [Predator] Fix a bug in dashboard html since we have internal dashboard and public-dashboard.
> 06141bb1b [buildbucket] tolerate null annotations
> 4c88428f0 Extract non-Android-specific functionality in android_docker module
> c2da32d33 Create Docker container for swarming multibots
> c68540f47 Add bug link
> b8f002b5d [buildbucket] add ui info into result_details
> 4056ce32c [luci-migration] reduce buildbucket egress
> 0d2b6b069 Roll infra/go/src/go.chromium.org/luci/ 63bd11762..fbb8a7b77 (6 commits)
> a06566faa [led] Accept new gerrit patchset URL format.
> e33799493 [Findit] Taskqueue - Implement model for swarming task request
> f04fedae9 [vpython] Fix documentation for common spec.
> f07f4a144 Revert "[buildbucket] include annotations in Build"
> b2dad3980 [bqschemaupdater] squash 3 flags into 1
> 31a9a3709 [eventupload] remove TableDef references
> 8b0919365 Use F2 instance class for chromium_build_stats
> 854c2c13b SoM: Removed unused code.
> 1abfcb0e2 [dockerbuild] Markdown fixes.
> 367a3549f [buildbucket] warn if gerrit CL buildset is invalid
> fbfb29dec [dockerbuild] Generate Markdown for wheels.
> b52afe14d [luci-migration] use buildbucket package
> ad3728c62 [buildbucket] restore ndb.toplevel
> 4a6e6859a [bqschemaupdater] read .proto instead of .pb.txt
> 7d3a7ef3c Add demo for tree-status element.
> a2797036b Add bug-input element
> 92b1d5f8a third_party_packages: gsutil recipe
> 2755618a0 [Findit] Flake Analyzer - Reuse existing try job data point
> 0f15b9384 [Findit] Let calls to rpc_util override retries, timeout, etc.
> 411a0ecd2 WebRTC: Send lkgr e-mail to troopers instead of a set of e-mails.
>
> R=​nodir@chromium.org
>
> Bug: 793325, 786503
> Change-Id: Ifd1eaf3004c54b2c3c46ad5ee272e80e8d8fae8c
> Reviewed-on: https://chromium-review.googlesource.com/831338
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

TBR=iannucci@chromium.org,nodir@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

TBR: iannucci@chromium.org
Bug: 793325, 786503, 795638
Change-Id: I3cd14bc8182ae9407e741672330dfb7f15a31b2f
Reviewed-on: https://chromium-review.googlesource.com/831706
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
8 years ago
Robert Iannucci 454acc12ef [vpython] Bump depot_tools version of vpython.
9617f0f2a Roll infra/go/src/go.chromium.org/luci/ 1166f0f8e..79172f5b4 (8 commits)
26cfd6e55 [som] have staging hit findit staging.
7be5101e9 [Monorail] Parse and Preprocess hotlist searches
069fd6087 Introduces functions into the Tricium config.
34b45cfec chromium_build_stats: fix table message
b9bb26a2f [Findit] Schema for Findit Analysis Events
57920812b [Findit] Flake Analyzer - Moving heuristic analysis to services
1e0e56837 Roll go.chromium.org/luci
6217fda16 [Monorail] Treat invalid oauth tokens as 401s.
6ca3ba437 Roll go.chromium.org/luci.
99d98fa4f Monorail: Reland command actions on alert emails.
6e2435fd1 Roll 'luci' DEPS.
099bbde1a Rolling 2 dependencies
21b330535 [CTF] Add new owners.
5c8bea6a2 [som] Update RELNOTES.md for weekly push
e1a7ce224 [Monorail] Revert to returning 401s for expired oauth tokens.
a9f648b3f [som] Add test result history fetching to the analyzer.
f77237b66 [Monorail] Fix bug in training data loading function from previous refactor
ff3cf9ec5 [Monorail] Reraise DB exception if we run out of retries.
d5d1b7e2e [som] Separate alert links into "Useful" and less prominent "All"
4a3399a32 [Monorail] Add codesite files to spam training data
9f19d78d7 Install lsof on swarm_docker image
a99057174 [vpython] Add chained-invocation integration test.
c9095a4fa [som] Add support for using test run history from test-results server
07d9055ae [luci-migration] fix form action
e8b915df5 [som] Some tweaks to render test results embedded in alerts.
31591036f luci-migration: copy "dry_run" if set when triggering tryjobs.
ffbf69a37 [Monorail] Retry when we get database errors.
873617c36 [luci-migration] hide exp percentage on non-try builders
61eb55332 [Monorail] Make v1 API handlers close their DB connections.
16f7d35fd [Monorail]Monitor initial db connection time
3c1fb65c3 [buildbucket] add a test for explicit pool name
f051010a6 [dockerbuild] build local pure python wheels
52399c135 [luci-migration] do not post comments twice
878fdf9d3 [buildbucket] fix default pool name
2c0cda242 Fix yaml syntax.
cd71a211d chromium_build_stats: show by build-step time
345566bcc [Findit] Flake Analyzer - Fixing code coverage in recursive_flake_pipeline
388b9b698 [luci-migration] add "Start analysis now" button
dcb818825 Roll luci-go and luci/gae DEPS.
958bfde84 [Predator] Fix a dashboard UI bugs.
311f433c5 [som] Stop splitting test failures into one alert per test failure.
f949bd91a Roll infra/go/src/go.chromium.org/luci/ 3d94cf7eb..cab6ace71 (12 commits)
0460452ab [Monorail] Make all tests using testbed call deactivate().
387828527 [Findit] Use same GetStepLog to get tryjob report.
453a08cfa Use "copy" install mode in mpagent cipd package.
eb747cc6a Add bug template for config propagation/validation tickets.
f483132ee [Predator] Fix a typo bug in Predator for clusterfuzz.
558ace00a [som] Make a separate client services init for staging/prod
2ef7d0c72 [Monorail] Replace mentions of staging with prod in spam README
e23dc277c [Monorail] Refactor more exception classes to exceptions.py.
83dd93631 Roll infra/luci/ 1e5342e46..e6fa13578 (19 commits)
495b48801 [Monorail] Finish support for custom fields in v1 API.
ffbd73084 [buildbucket] fix entity skipping in query-based search
27a6be765 [buildbucket] return properties in LUCI builds
83da84670 [luci-migration] change metric to 1w
bc798a5df [buildbucket] default pool to bucket name
498ac6a8e [luci-migration] hide "LUCI is Prod" on trybots
0d1009fbe [luci-migration] do not use relative time in reports
ccfad35f2 Revert "Monorail: Add command actions to alert emails."
b8e944ce9 [Predator] Disable TouchCrashedComponent and TouchCrashedDirectory for big regression range crashes.
cd0113700 ChOpsUI: user-dopdown -> user-dropdown.
6fcaa7677 ChOpsUI-Gallery: Add Gitignore, edit Makefile, and update Bower.
4a19fceca [Predator] Catch exception globally.
fcb0ff550 Monorail: Add command actions to alert emails.
033def824 SoM: Add crdx-header to SoM.
ba5a63d14 [buildbucket] remove default swarming hostname field
975621029 [Findit] Refactor config validation.
b255ab8c0 Revert "[Findit] Merge Heuristic pipelines for compile failures."
0bfe44fde Revert "[Findit] Merge Heuristic pipelines for test failures."
c32afe359 Revert "[Findit] In _failure_analysis services, use int type build_number as keys in failure_info['builds']"
8bf2b13c1 [Findit] Flake Analyzer - Display times in local time
2d5155b50 luci_check: Fix recipe to run in checkout dir
3620b313a Revert "[Findit] Make HeuristicAnalysisForCompilePipeline inherit from new BasePipeline."
1e5cde891 Revert "[Findit] Flake Analyzer - Display times in local time"
f04be69b8 [Predator] Clean up the log passing.
54b6b3102 [Predator] Fix bug in PredatorForChromeCrash.
4aa3ce3c5 [chromium-build] Fix chromecals javascript to use /deprecated/.
012da1352 [luci-migration] enable emails
72ab8187a update go/register-luci-project to use admin queue
d8a5bcc19 Revert "[Fndit] Make HeuristicAnalysisForTestPipeline inherit from new BasePipeline."
5f7efcb4d Automate the process of retraining the spam predictor.
0e998e80f [Findit] Flake Analyzer - Display times in local time
a81603075 [luci-migration] sort builders by status
b1454d3e7 Roll luci-go deps.
f9f33cd2b [Findit] Fix a bug in naming attribute definition metadata.
0a4b6a1c0 Add recipe to call infra.tools.luci_check
a97924516 Flakiness Dashboard: Add CRDX Feedback button.
060bafc62 SoM: Restore custom labels per-tree to bug filing.
5a9193767 SoM: Make file bug dialog scrollable.
0751d9569 SoM: Update on-call links.
5c353879e [Predator] Fix KeyError exception.
0128ea6a6 [buildbucket] require swarming hostname
8b0834e80 [Findit] Treat an empty 'tests' key same as absent.
4927f86d7 chromium_build_stats: calculate weighted time
11d7448d1 Create packages for gerrit and isolated clients.
c0c515630 [Findit] Not save extracted signals for test failures.
70548b555 [Findit] Workaround for too large signals.
9855f65b6 [Predator] Handle file name crash state.
8bc0df738 [kitchen] Remove some unnecessary flags.
fd0f4b0d6 Roll luci-go deps.
bdf91f698 [Predator] Handle and push back error message and result when there are errors in analysis.
efaab3b1b luci_check: Check the diff between luci console and buildbot
ef105ebcf [Monorail]Format url_type fields in issue details
7294ddb4b [dockerbuild] fix error with empty wheel regex
fe09cfe76 chromium_build_stats: ninjalog dedup by cmd hash.
060753a04 [Monorail]Add url_value to Issue2FieldValue
552370e8c Roll luci-go and gae deps.
09fb10b6a [Monorail] Prevent restricted issues from being flagged spam
6c327c121 SoM: Update release notes.
d176d3f6c [CTF] Check for duplicate bugs before filing.
f25955a2a [Findit] Add default list of retriable exceptions for http interceptor.
13695716c [Findit] Default to 0 when confidence is returned as None.
b706523bd [luci-migration] allow access to public masters
53655c36c SoM: Add chopsui dep.
f8845fcf4 Revert "[Findit] Flake Analyzer - Convert timestamp to local time."
24531b06a ChopsUI: chops-ui -> chopsui.
34007b88a [Fndit] Make HeuristicAnalysisForTestPipeline inherit from new BasePipeline.
07700732c [Findit] Make HeuristicAnalysisForCompilePipeline inherit from new BasePipeline.
e7de92d7e [buildbucket] fix assertion error
f5c794263 [som] Fix bug filing form.
798475f67 [monorail] remove api/prpc
80684bc90 [luci-migration] Do not mark a builder as migrated twice
7d918d36f [luci-migration] set AnalysisTime when marking builder as migrated
df0c9f2b6 [luci-migration] close bug when buildbot builder is deleted
19ff035a7 [cipd] Sort pkgs and dirs returned by API.
3b5e735ed [Findit] Use the new names for Findit's swarmbucket and pool.
b6a606bf7 [luci-migration] Add oauth2 for bots.
305b22285 [buildbucket] improve error message for expired builds
053bd2ea9 [master-manager] Warn on attempting to restart an official master.
48367b9cb [Findit] In _failure_analysis services, use int type build_number as keys in failure_info['builds']
ff9c111b3 [buildbucket] rename reset_expired_builds
c0e91eca6 ChOpsUI: add header element.
8381d259b [Findit] Make Findit not flag changes by certain accounts as culprit.
6485b539d [luci-migration] add Builder compound index
0a9afb421 [buildbucket] Add access API.
e9701c393 [som] update RELNOTES.md
b2fb31f1a Roll infra/luci/ 9761e1747..1e5342e46 (87 commits)
a57d95fe8 Roll luci-go and luci/gae DEPS.
2026eaab6 [rietveld] Fix test_views.py.
3e9fee3ce [som] Send a *pointer* to a proto struct to eventuploader
07f77f164 [Findit] Flake Analyzer - Minor css and polymer tweaks
a8efd0ae0 android_docker: Mount /etc/sudoers* in the containers.
1bc2dc1ea [crbadge] refactor a little.
36b0e1b2c android_docker: Set isolate cache size in containers based on disk space
1afce8b07 [Predator] Publish back result for every crash.
0eb02b776 [Findit] Flake Analyzer - Add pipeline to determine isolated sha of commit position
989999772 SoM: add snippet about user to inline-filed bugs.
c8b558b2a [test-results] Remove table schema comparison code
2daaf183b [Findit] Flake Analyzer - Convert timestamp to local time.
006253c6a [som, TA/DA] Add link to test expectation editor.
91ca088ec Roll go dependencies and luci-go DEPS.
da194ebbc "Reland chromium-build redirection changes"
25ec7fd1b [Findit] Flake Analyzer - Always show heuristic results if available
ee6d97628 [luci-migration] discover CI builders
2e716e1e3 [bigquery] refactor BigQueryHelper
f64f2c1ce Remove references to phajdan.jr
5af01dd6d Fix 500s from json serialization of datetimes
206b4474c [kitchen] Fix logging nit related to devshell disablement on Windows.
35db563a4 [Findit] Flake Analyzer - Adding diagnostic logging for missing swarming tasks
c433034fa [kitchen] Use gsutil authentication helper in addition to DevShell.
66dc8a1ba [test-results] fix nil field error.
fd4b4bfa4 Roll luci-go DEPS.
ec1186473 [som] RELNOTES.md update
d7108a228 [Monorail] Enable API rate limiting.
798871461 [Findit] Merge Heuristic pipelines for test failures.
2efbaf68e [Findit] Merge Heuristic pipelines for compile failures.
4fdf96945 [Findit] Make sure not append a try_job result which is already in results.
ac97a9bc4 Correct link formatting in CONTRIBUTING.md
df59914d7 Revert "[som] Update RELNOTES.md for weekly push."
4f09c9256 [som] Fix some text entry issues with email autocomplete
d46e115c5 [Findit] Flake Analyzer - Give filed bugs priority and a status
abe5d330f [som] Update RELNOTES.md for weekly push.
6ce4d0da8 [Findit] Refactor identify_test_try_job_culprit_pipeline to use new BasePipeline.
91dcf3242 [Findit] Flake Analyzer - Fix blank value for culprit analysis status
866f8be3a [Findit] Mock urlfetch on testcase to stop tests using http.
b864c5a49 [Findit] Merge scheduling and monitoring test try job pipelines.
18f03641b [Findit] Support 'use_swarmbucket' config for defaults.
c8dfa8ea0 [Findit] Flake Analyzer - Allow minimum confidence threshold to be configurable
3d17e151c Add autocomplete UI for cc: field in bug form.
60a2dcb8b [Findit] Flake Analyzer - Account for try job result being None
e4840fe3b [Findit] Refactor identify_compile_try_job_culprit_pipeline to use new BasePipeline.
cad0bc77c [Findit] Flake Analyzer - Remove process flake swarming tasks from main
d79426efc [Findit] Flake Analyzer - Check for a previously filed bug for test
68ec397c6 [Findit] Merge scheduling and monitoring compile try job pipelines.
ed65c5e98 [Monorail] Fix issue list cells for enum custom fields.
da379bd77 Handle better lkgr_finder failures.
273ef7d9c Roll go.chromium.org/luci
11b4c4615 SoM: Restore autofilling CCed user.
64860d91a [Findit] Add urlsafe_try_job_key to parameters to run a try job.
c0fc9ff2d buildbucket: return build numbers
4521a5432 Put PRESUBMIT in correct location
80e2480c9 [Findit] Mock GetBotsByDimension in TryJobTest.
ab434669c [buildbucket] index experimental
d77ddb92b [buildbucket] do not cancel tasks
cdcb665d7 [Findit] Move logic in monitor_try_job_pipeline to service module
bf39d808f [buildbucket] do not monitor experimental builds
b47b6de09 [buildbucket] simplify metrics.fields_for
f1a52871b [buildbucket] move build normalization to model
a358efe8a [Findit] Flake Analyzer - Unlock throttling and add config override.
3e893cdb0 Upload lkgr status page even if lkgr_finder fails.
ad252d114 Adds Feedback RPCs.
88f3e20cd [Monorail]Fix template2field table col
190d224fb [Monorail] Define IssueDelta to simplify DeltaUpdateIssue() args.
4a677ceb7 Adds comment creation time.
c1ec1ceb1 Adds comment UUIDs.
dd27550ff [buildbucket] exclude experimental builds from search results
f76b4c852 [buildbucket] add build.experimental attribute
30944d69f [buildbucket] extract common property validation
d2779848b [som] Add a user email autocomplete handler.
2b69be620 mac_toolchain: update file permissions post-install
c4e95932f Add presubmit script for config validation
894cac284 mac_toolchain: add "package" command
e2de5cb7c [Findit] Flake Analyzer - Removing unused queue
cac592bef [Findit] Making code coverage 99% to account for disabled tests
5ad3123bc [Findit] Disable another flaky test.
8424c14cf [Findit] Flake Analyzer - Deprecating trigger flake swarming task from findit_api
20af972ae Reland "[Predator] Store log in datastore for each crash."
90b64a3b3 [Findit] Reenable testUpdateFirstFailureOnTestLevelThenUpdateStepLevel
26ee39500 [Predator] Fix a minor bug in result feedback page.
0e3a203b9 [Findit] Flake Analyzer - Find nearby build that's valid.
b6fddda68 Roll luci/luci-go and luci/gae DEPS.
dee11894e [Monorail] Add MarkupDescription and ParseIssueRequestFields tests
c638d37a5 [Findit] Fix flaky tests in service/test_try_job_test.py
a0bc466dd [Findit] Support swarmbucket bots for flake tryjobs.
6da824aa7 [Findit] Temporarily disable some flaky tests.
49a01b212 [buildbucket] make migration_host a message field
40b132329 ChOpsUI: Add crdx- prefix to all elements.
6d7a1b94a [Findit] Support new build url format for luci tryjobs.
3f14a67ab [Findit] Use a new url to get all rotations.
dc0bf59c7 Keep bolded text after issue description edits
5ca67600a Revert chromium-build redirection changes
19f4568f9 [som] Update RELNOTES.md for weekly push
d406cf231 [luci/server/portal] Adapt to rename of /admin/settings -> /admin/portal.
692fa6e48 [Findit] Parse dict dependency in DEPS file.
fd63f5a0a [Monorail] Update footer links to be https.
43c9fd9cb [cr-buildbucket] Add LUCI Migration App support for swarmbucket.
b2481685e [Findit] Flake Analyzer - Implement new schedule flake try job pipeline to compile and isolate only
1e8154971 [bigquery] simplify imports
78468fe15 chromium-build: Reroute all main handler routes to ci.chromium.org
9d5e9479c [ctf] update the json field keys try-flakes looks for.
4a992e1d3 [Issue Wizard] Update template list of other browsers.
b35e075ac Roll luci/luci-go and luci/gae DEPS.
b78c8f693 chromium-build: redirect to ci.chromium.org
19029c011 [Findit] Flake Analyzer - Encapsulate analysis entities and improve ui
a38b31469 [infra/libs/bigquery] modify to expect protos
d06bf514a WebRTC: Display html page with lkgr_finder info.
e05e0bd3d Cleans up Gerrit project mapping.
e73516d3f Make url_types links throughout monorail
2fa99e600 Roll luci-go and gae
b5f87f503 [Monorail] Allow dashes in domain part of /u/EMAIL urls.
50cf28d29 SoM: Make +/- buttons in menu sections toggleable.
fd8aa212f Revert "[Findit] Flake Analyzer - Run all flaky gtests experiment"
ecb4cfb2d Check url_values before saving
a1f26f2a1 [Monorail] Temporarily disable comment classification
49b05561c [Findit] Make swarmbucket requests specify mastername prop.
6e420fe71 [Monorail] Avoid a DB write for action limits of whitelisted users.
dc9d7df49 [Monorail] Block an IP hitting the same URL every 5s.
3522bfc28 [bootstrap] add urllib3 package
d05bd20a3 [testresults] add event logging
5dfc798ee WebRTC: Remove Memcheck from LKGR config.
3142575bb [ts_mon]: metrics.py: Add __eq__ methods
26940384c [bootstrap] update google-cloud-bigquery
19c5ba0a7 [luci-migration] schedule builds without got_revision
5c0c2bac7 [dockerbuild] Allow building on native platform.
0e1c8b0ce Revert "[bootstrap] update google-cloud-bigquery"
74c7de65a Fix chromium.android LKCR entry.
1821be50b Roll luci-go.
54472fa9f led: improvements in led get-build subcommand.
d221ca328 [buildbucket] add error field to all response messages
01aecd1b0 [bootstrap] update google-cloud-bigquery
5be4bb563 Update cros builders used in LKCR determination.
70205ddef [Monorail] Make the v1 API require issue owners to be project members.
9673d2fe9 [Findit] Use basestring instead of str for pipeline output_type.
a74430167 Update Android bot locations after the move to chromium.android.
90984bd47 [luci-migration] Add LUCIIsProd bool and JSON GET API.
d229b6939 Move link regex to _constants
06810efc4 SoM: Remove per-alert group button.
c318694c8 [Findit] Update the parameters when calling the pipeline to start a test try job.
276854c5e Finish url_type validation
0d174bafc [Findit] Use a dedicated pipeline to identify test try job culprits.
1f9a01ecc Make url_type custom fields searchable
e164be065 [Findit] move remaining logic in culprit action wrapper pipelines to service.
49374d0ff Remove unused const `repo` from rpc_analyze.go.
6f8050b96 [Findit] Flake Analyzer - Link flake culprit pages to dashboard
4bc16b954 [Findit] Flake Analyzer - Run all flaky gtests experiment
03c7c90a1 [Findit] Flake Analyzer - Allow cancellation if tryjob is still in progress
66ea9e832 [swarmbucket] Filter with tags after applying tags to task :)
3f5a70e3f Monorail: Remove trooper autoassignment for alert bugs.
90422d4dc Make url_type fields modifiable
57f4c0c10 [dockerbuild] add more google-* wheels and --wheel_re.
9362ae533 [Findit] Refactor schedule try job pipelines to use new BasePipeline. (2/2)
600f4e13d [Findit] Import from new pipelines.py instead of the deprecated pipeline_wrapper.py
09ed0cfc0 mac_toolchain: include symlinks
1bd943446 [Monorail] Update spam.py to accept files, not stdin
cc8c14881 [Findit] Flake Analyzer - Add confidence score to flake culprit page
fb8c467b1 [Findit] Move pipeline inputs and outputs to services for a more general use.
eaaedf26d [luci-migration] run analysis once in 4h
bcfd58a61 Fix to make the parser work for infra
b070a823c Correct two minor spelling typos in tricium.proto
405152ea0 Revert "[Predator] Store log in datastore for each crash."
6707984c0 [led] Add ability to set buildbucket tags on get-builder command.
f75c79ff1 [Monorail] Loosen +1 prevention for project members
1f1e7caea [3pp] Fix exception when getting gsutil version with newline in it.
e878ba8a7 [Predator] Store log in datastore for each crash.
6d1a8303b [dockerbuild] Add google-cloud wheel.
2fc37a078 [Findit] Flake Analyzer - Adding improved detection for nonexistent tests
9530714a4 [Findit] Flake Analyzer - Use yield when starting pipelines with delay
e724c2e47 [Monorail] Spam: only use word_hashes as a feature
a3b979c41 Lay foundation for ability to create url_type custom fields
6dd059518 [Monorail] Suppress confirmation when switching a blank template
57d1b8f53 [Monorail] Fix unquoting of form data for issue template name.
29b44ca85 [Monorail] Add role="presentation" to monobar navigation table.
4806953a6 Updates proto message documentation.
b7755a6bc [buildbucket] unflakify swarming tests
edc03273d [build] add vpython-native package.
dca6e39ec [crbadge] Add references to assets
2dbbefc4e [crbadge] Commit code to compute 'code-number_of_files_added', 'code-number_of_files_touched' and 'code-number_of_files_removed'
e60bf5182 Rename badge code-revert_consecutive_x2 -> code-revert_consecutive.
f1fd4f60d [crbadge] add to_json.py
dec53d0c6 [crbadge] Add readme
c582795d5 Add login: admin to app.yaml
fc34ccc62 [swarmbucket] Add conditionals for objects in task definition.
1f10693f2 [Findit] Refactor pipelines to schedule try jobs (part 1/2)
44a4189fa Updated readme to reflect more descriptive monorail instructions.
c4dd374e3 Update documentation to point to correct lines
9010ba713 led: emit luci UI URL on successful launch.
48b2a8277 Refactor fileBugDialog into separate element.
e56341506 Roll luci-go DEPS.
abd258fda [Findit] Flake Analyzer - Include more information for filed bug
1b77c874e [Findit] Use basestring for str/unicode type of attributes in StructuredObject
14c444d3d Update README
bead4bb6d [Findit] Flake Analyzer - Remove swarming_rerun_results from MasterFlakeAnalysis
fafa4b02e [eventupload] modify to expect protos
fb10d6264 [Findit] Use test specific pipeline to run try job.
87194899d Remove deprecated and unused android_docker_image_builder recipe
932f7aff0 Use chops-ui elements and demos to create chopsui-gallery app.
06dd43cf3 Rename the directory to match the image name
07300c5ba Allow to override dir name where docker image script is located
fddbe6fc6 Add swarm_docker CIPD package
b7e37aebc Add a generic recipe for building docker images
bb1ef5414 Revert "[luci-migration] run analysis more often"
fb6e95fa3 [luci-migration] run analysis more often
7e8a5129c Redo imports
b5128904e [Findit] Add a new owner.
d91c95e92 [Findit] Flake Analyzer - Check if test is disabled before filing bug.
5a33648a5 Revert "Reland "luci-go recipe: make precise-32 builder fail if run on luci.""
3e7c7695d [Findit] Add the Universal Feedback Button to each user-facing pages.
f91092f8e [Monorail] New subscriptions default to "All issues".
a5fc1d460 sysmon: Pick up multiple types of ambient temp sensors.
a6afbcc20 [Monorail] Update our work-around to urlize() quirks.
a9c0a8ab8 [Findit] When getting logdog logs, retry when get empty log or log in wrong format.
e5ff2c59f Reland "luci-go recipe: make precise-32 builder fail if run on luci."
961372709 [buildbucket] use new LUCI UI build URLs
6610de181 Recreate bower.json
a01c58c9c [Findit] Add retry logic to irc message sending.
c0769eed9 Rename back to chops-ui
4deec5e2e Take [] out near the 171 mark
fd38369af Keep only one html file in bower.json main
2d72ed64f Remove android-specific remarks from the comments and docs
c5ad87f85 Tricium service: Allow requests from any origin
a7be75200 [Monorail] Only do on-page profiling for the main python thread.
8ccafa7b8 Splits up swarming info in progress response
3bf36b432 gerrit_api: do not delete users' draft comments
8cb566883 [test-results] remove event schema
8617ab58c Specify versions
cccc52d9f Fix bower json file
912271c29 Edit chopsui name
553eb9b07 [Findit] Login should redirect to the current page instead of the referred one.
f68e2c8d2 Update version in bower.json to match git tag I just pushed.
7e6cf0833 Revert "luci-go recipe: make precise-32 builder fail if run on luci."
085df35a5 luci-go recipe: make precise-32 builder fail if run on luci.
92039ff16 Link fileBugDialog to bugDialog
1f2ab2f33 [Findit] Update links in header.
47358bf85 [Findit] Flake Analyzer - Check that test is flaky on recent build before filing.
626a7de21 [Findit] Allow generator pipelines to return without yielding
1f7c77e4d [Findit] Fix path conflict of protobuf for non-production environment.
f655df340 Buildbucket: add `swarming.auto_builder_dimension` config flag.
010f09872 [som] TA/DA: allow adding expectations for tests that don't already have them in any existing expectations files.
e3a2ddd67 Link new issue to alerts
7128c378c [Monorail] Fix component auto-cc in case where all are removed.
cadf7b6db [Findit] Separate logics in build_failure_analysis to better modules.
89ed9aa4d [Predator] Always redo cracas analysis.
9e07cecb3 [Findit] refactor revert_and_notify_test_culprit_pipeline to use new Basepipeline.
94fdd3cf0 [Findit] Refactor revert_and_notify_compile_culprit_pipeline to use New BasePipeline.
eb8ee5857 fix typo: python_version instead of python.
38eded8ba mac_toolchain: add -service-account-json option
f1776bcaf Re-create chopsui-gallery
5c0c0a19d Add inline bug filing
78dfe8f06 Remove Prediction API related code and clean up docs
54258fbe7 [Findit] Flake Analyzer - (2) Limit bugs per day
3781a3172 rename chopsui folder
55d09a098 [Predator] Fix a minor bug in run-predator.py local script.
dea304ea5 [test-results] Stop sending events to BigQuery
efdce776e [Monorail] Fix email and display of amendments to custom fields.
534b6969d [test-results] Change milo links to use vanity URLs.
492b166f4 [som] Change milo links to point to vanity URL and use public name.
c2c275503 [buildbucket] raise exception on invalid gerrit buildset
9e24410bb Add file bug handler and som-file-bug element
52887aa8e [som] Update RELNOTES.md for weekly push
9735db23e [Findit] Flake Analyzer - Limit the number of bugs that can be filed daily
d333ad987 Start cross-compiling luci_machine_tokend for ARM.
35aacd3d0 [Findit] Fix the assertion error when getting configs.
0ceb1fee7 [Findit] Add survey link to review message.
bdb8e9bc9 V8: Add win-msvc bot to lkgr
728f30c51 Docs: Update builders.pyl docu for multibots
67dc28365 [som] Don't rewrite go links to https.
1be879723 [Findit] Flake Analyzer - Change task id to green.
5eb62e84c [dockerbuild] Fix OpenCV building.
e517b566b [Monorail] Mitigate and log error in profiler.
53e12b3a4 mac_toolchain: implement installation of Xcode.app
ccd0caade mac_toolchain: Implement packaging of Xcode.app
0656e799f Allows for no run ID in progress request for Gerrit change
b96c3ec5a Keep luci-py checkout at the root of infra/luci-py CIPD package.
e6c2ae3a0 led: Don't ignore task service account.
1cacf773b Roll luci-go DEPS.
fe07e9d46 [Findit] Flake Analyzer - Do not reuse try jobs without usable data
c1198b6d8 Fix ML Engine response key error
2d17c3f26 Add luci-py CIPD package definition.
1881f4891 [Findit] Modify StructuredObject to use TypedDict and TypedList.
82f19de9b [Findit] Add dict-like and list-like objects to limit element type
74c5afaf5 Revert "Disable WPT auto-import temporarily by skipping the upload step"
40a6bfb08 Create infra/tools/luci/mmutex CIPD package
9167001d7 Docs: Change Chrome OS Waterfall Pin Bumps / Restarts link.
af4499655 [Findit] Refactor send_notification_for_culprit_pipeline to use new BasePipeline.
2b54e247a Rietveld: remove never-called delta calculation task
2b399feb4 Rieveld: remove as much chromium-specific code as possible
dc598cd81 Rietveld: remove all account statistic tracking and display
9c381f0af Move shared to crdx
2f462c227 [Findit] refactor send_notification_to_irc_pipeline to use new BasePipeline.
42f4710ca [Findit] Refactor submit_revert_pipeline to use new BasePipeline.
904a7886b [dockerbuild] Internally-universal Wheels.
010431510 Rietveld: remove cq and tryjob update tasks
38bc018e1 Rietveld: remove stat calculation task
22f1e628b [Findit] Skip mal-formatted changelog string.
d773070c2 [Predator] Pass features options to TouchCrashedDirectory and TouchCrashedCompoennt.
a0a4300e3 [luci-migration] make builder-not-found a permanent error
bf774e830 [som] convert logging from txt proto tabledefs to plain protos
9be6ca443 [cr-buildbucket] log more in tag index maintenance
00d6abeff Disable WPT auto-import temporarily by skipping the upload step
c44213d85 kitchen: Mint one token with cloud-platform scope instead of 3 different tokens.
f7ca6da12 recipes: Simple gsutil recipe
6b8ee512f [bbroll] Only abort if changes is None
158004459 Create time-stamp element.
e1336ba2d [som] Update RELNOTES.md for an off-schedule push
f03031504 Create package for gitiles client
c35304164 Make default spam FP bug owner jeffcarp@, add spam-fp label
686a57de3 Transition from calling Prediction API to calling ML Engine
cfcf1a445 Roll "luci-go"
ef26201ef [Findit] Flake Analyzer - Fix for only the first task being tracked
d42277eb4 Update git patches for v2.15.0
f8cd51e0e [som] Move annotation key into POST body.
bccd8b7ba [third_party_packages/git] Fix Git test.
9615eb7c2 Reland "recipe_roll_tryjob: Add individual manifest name to bot update steps"
13fbf3117 Add scripts for creating new elements
57b2f8c99 [Findit] Whitelist more auto-commit accounts to skip auto-revert.
43fc206f8 [buildbucket] Add project to Build message.
fc9ee7a7b Revert "recipe_roll_tryjob: Add individual manifest name to bot update steps"
f47e08fb2 SOM: Split alerts by test
fcc359a08 recipe_roll_tryjob: Add individual manifest name to bot update steps
348cede58 [luci-migration] include result in the response
97ac496c0 gerrit_api: allow custom instrumentation_id.
9b2147287 kitchen: Hook up DevShell support
36bb94e1c [som] Update RELNOTES.md
8dc0690c4 [Findit] Flake Analyzer - File bugs against prod
afaf08cfa [Predator] Fix a bug in result feedback page to show error messages.
ee0f03737 Make bug-link accept non-chromium bugs
bc33ef865 [Findit] Add manual link to messages to sheriff and cl owner.
97623c9ec Make bug-input accept non-chromium bugs
3d4ca3e04 [Monorail] Refactor issue starring to go through WorkEnv.
d1f68cb18 [Monorail] Refactor issue and comment deletion into WorkEnv.
3b36b5479 Remove luci_go_web_packager.
ddacaf91e Add Win (more configs) to WebRTC lkgr finder.
7b9be6aa0 Add configuration_id field for sampling profiler and use in identifier
7c820a5f4 Roll infra/go/src/go.chromium.org/luci/ fbb8a7b77..4d42df061 (14 commits)
8b3b49345 [Monorail] Correct the CSS cursor for the no-results messsages.
3e0a1a806 [Findit] Turn on/off auto-commit instead of auto-revert.
86de88180 [Monorail] Re-enable formerly-flakey tests.
ca1bea8e8 [Predator] Add r'.*(ERROR|WARNING): ?UndefinedBehaviorSanitizer' to ubsan detectors.
833b3a01d Limit sampling profiler signature length
01dd8a349 [Predator] Fix a type error exception.
e6ca34602 [Predator] Add configuration for features.
25361c0df Revert "[crbadge] fix bugs in commit.py"
f4e6cc903 [crbadge] fix bugs in commit.py
f1c2c905f bugtemplate: add template=Build Infrastructure
1bdc53483 Support deployment to predator-for-me prod app id
def9c899d [test-results] define a proto message to eventually replace json.
bc85c99b8 [bqschemaupdater] remove bqschemaupdater
ef0b4313e SOM: Fix reason merging
a82f4664b [who] Move to experimental
ac026a559 Who: Make Crwho deployable again.
1569ec4e0 [Findit] Flake Analyzer - Moving build info functions to shared location
1cb547e64 [Findit] Get isoalted sha of master/builder/build number/step
8db6622eb Allow builders in chromium.goma master to upload test results.
264feef45 [Monorail] Initialize shared cache in a test class that uses it.
e3678f36c V8: Make fuchsia bots block lkgr
efc10ee0f Rietveld: fix old UI rendering of message threads
e97ed50ae Rietveld: remove db write operations when computing diffs
50a99ceea Rietveld: remove more dead code
bf9304a11 Template for ios-ops-ticket
9ab65c8ee [luci-migration] fetch failure_reason and cancelation_reason
9998dc220 Who: CSS
bded288ea [event pipeline] update docs
99cb9041d [dockerbuild] Add "pypiwin32".
6b4e09721 Use position:sticky for floating details panel when supported
a0bd74542 Fix total awarded count and make badge counts non-cummulative.
b2d222016 crbadge: add badge level counts
6d1e8a61c Make badge <div> taller so that there is room for longer titles.
61a5e0d57 Allow more chararacters in URLs
823ae9bcf [opstoberfest] Some bugfixes
9d0b46027 crbadge: fix icons
900533912 [opstober] Filling out array even if there's no data
67e6c30db Who: Create a CRDX header element.
8c5908401 [crbadge] Fix more bugs.
1b23b6972 [Findit] Parse git HEAD to local commit for local git repository.
40074d961 crbadge: Fix uploader, add TimeOfDay badges.
341ffe8c5 crbadge: Batch userdata ingestion
e49433824 [opstoberfest] Day-details works!
c5482eb6c [crbadge] description.py
f04961b1b Disable flaky tests
bcecdab66 Load badge data from datastore.
4ae3542ed [opstoberfest] Transforming activities to weekly activities
ad1100678 Specify element versions
2237172f6 [opstoberfest] Redux works!
b2e1d3cd5 [opstoberfest] Add activity-table element.
60ef65a26 Extract generic Docker functionality into swarm_docker module
627289e4b [crbage] Fix bug.
cb06c45ba Initial implementation of page for badge details.
3015e1281 Who: Add basic routing.
fd3b0fdb1 PWA boilerplate
47268705b [who] implement the user and date filtering for history and detail
b64b78aae crbadge: reverts
2bdea8866 crbadge: Make uploader.sh actually upload stuff.
dece00068 Who: Make gae.py a symlink.
019f87667 [who] fix some trailing semicolons that casued js errors
9cdb8b973 [who] update bower for paper-item etc
9ad00b8b2 [who] fix relative paths for html imports
21a6a2d1b [who] fix malformed bower.json
f2bee5f20 [crbadge] Add commit_streak_days.py.
4b3d241ef Fix todo placement.
e59dc0d2f Make badges have shield-shaped backgrounds.
9a7b95227 [crbadge] Add commit.py to compute badge.
d57ae9d90 [who] get real activity counts by day, from monorail and gerrit
980a1ff17 [Findit] Make LocalGitRepository handle None start_revision and None end_revision.
e13c6ef16 crbadge: Fix uploader
550005d42 Serve large actual images and calc badge view details.
fc662e9bc [who] Add dummy API calls for /_/history and /_/detail
eb12d4604 CrBadge: Ingestion pipeline
d332e30a7 crbadge: datastore models
7832d6abb add shared
c9ce1f036 [crbadge] Uploader.sh skeleton
7bb1de2be Implemented basic page serving.
9505420d7 add day-details.
89ece1c4d [who] Add auth stuff
1e7cf9257 [opstoberfest] Add elements/who-page.html
f67a1ae1d [opstoberfest] Add actions.js with action types
840a8a469 Add day-icon
01e81714b [opstoberfest] Require redux via package.json in who.
36aeb6031 [crbadge] Fix typo...
4f9d4a8f9 [crbadge] Add libs and local_libs from findit.
fa8bbd96d CrBadge initial source file layout.
64dc776ff [who] bower stuff
3b924b1a8 [who] initial dir
453d15550 cr-buildbucket: Put 'buildbucket🪣...' tag into delegation tokens.
88a96b309 Roll infra/luci.
16a22aa58 [Predator] Fix a bug in dashboard html since we have internal dashboard and public-dashboard.
06141bb1b [buildbucket] tolerate null annotations
4c88428f0 Extract non-Android-specific functionality in android_docker module
c2da32d33 Create Docker container for swarming multibots
c68540f47 Add bug link
b8f002b5d [buildbucket] add ui info into result_details
4056ce32c [luci-migration] reduce buildbucket egress
0d2b6b069 Roll infra/go/src/go.chromium.org/luci/ 63bd11762..fbb8a7b77 (6 commits)
a06566faa [led] Accept new gerrit patchset URL format.
e33799493 [Findit] Taskqueue - Implement model for swarming task request
f04fedae9 [vpython] Fix documentation for common spec.
f07f4a144 Revert "[buildbucket] include annotations in Build"
b2dad3980 [bqschemaupdater] squash 3 flags into 1
31a9a3709 [eventupload] remove TableDef references
8b0919365 Use F2 instance class for chromium_build_stats
854c2c13b SoM: Removed unused code.
1abfcb0e2 [dockerbuild] Markdown fixes.
367a3549f [buildbucket] warn if gerrit CL buildset is invalid
fbfb29dec [dockerbuild] Generate Markdown for wheels.
b52afe14d [luci-migration] use buildbucket package
ad3728c62 [buildbucket] restore ndb.toplevel
4a6e6859a [bqschemaupdater] read .proto instead of .pb.txt
7d3a7ef3c Add demo for tree-status element.
a2797036b Add bug-input element
92b1d5f8a third_party_packages: gsutil recipe
2755618a0 [Findit] Flake Analyzer - Reuse existing try job data point
0f15b9384 [Findit] Let calls to rpc_util override retries, timeout, etc.
411a0ecd2 WebRTC: Send lkgr e-mail to troopers instead of a set of e-mails.

R=nodir@chromium.org

Bug: 793325, 786503
Change-Id: Ifd1eaf3004c54b2c3c46ad5ee272e80e8d8fae8c
Reviewed-on: https://chromium-review.googlesource.com/831338
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
recipe-roller 99da619f6c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/32e6ba22dd1c75f8b3276bb86112d10542d5e32b [buildbucket] fix scheduling of experimental builds (nodir@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I481e7c1222d07be2a0b4a72de9116616c0052fd5
Reviewed-on: https://chromium-review.googlesource.com/831068
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
Lei Zhang d3f769a710 Change "ldap" to "username".
Change-Id: Ic993758ea901d039c5fdac978e516ba20f95005d
Reviewed-on: https://chromium-review.googlesource.com/830611
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
8 years ago
Robert Iannucci 41d9d87e96 [recipe_modules/depot_tools] Add on_path helper.
This will be used by various things in build and build_internal which
"need" a depot_tools on PATH (though I suspect most of those should be
refactored to use the depot_tools in chromium/src.git).

R=tandrii@chromium.org

Bug: 789808
Change-Id: I5d0590ccdc5482bd8e3048ad46a39b5aedacbddb
Reviewed-on: https://chromium-review.googlesource.com/828465
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Robert Iannucci 069dd4fa6b [bot_update] Put depot_tools at the end of $PATH on LUCI.
This should prevent bot_update from overriding vpython by accident.

R=tandrii@chromium.org

Recipe-Nontrivial-Roll: build
Bug: 789808
Change-Id: Ia574204439588862f29f94a80e978b2ff4b57586
Reviewed-on: https://chromium-review.googlesource.com/828069
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
recipe-roller 029a0e2d98 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2dd87ee7779e4f9cb39619a7d0b235495ed12dda [context] Add env_suffixes to context module. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia8612776ab8b9ab908b20fc8b539cb023bf54e0f
Reviewed-on: https://chromium-review.googlesource.com/828384
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
Jao-ke Chin-Lee 760ef9c24a Rename trigger file.
Bug:
Change-Id: I8cb512b5353e277aaf7b0cb9bde8b3d1008e8cd6
Reviewed-on: https://chromium-review.googlesource.com/827669
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
Jao-ke Chin-Lee 6e5d5a6a7c Kick recipes and add trigger_build file.
TBR=tandrii@chromium.org

Bug:
Change-Id: Ie1f3c48762711061ee63956ea6293d2458ce7bbe
Reviewed-on: https://chromium-review.googlesource.com/827594
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
Reviewed-by: Jao-ke Chin-Lee <jchinlee@chromium.org>
8 years ago
Ryan Tseng 2e8d8348b8 gsutil.py: bump default version to 4.28 from 4.13
Picks up about 2 years worth of changes.  Should be relatively risk-free since
we pin gsutil.py in almost all of our scripts.

Bug:
Change-Id: Iff1365ee6d6f31e03da8d8876b6ccd0b47a033c2
Reviewed-on: https://chromium-review.googlesource.com/801355
Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Jao-ke Chin-Lee <jchinlee@chromium.org>
8 years ago
Chris Watkins ba28e460fb Add a --dry-run option to git cl split
git cl split previously had no way to find out what it would do before
it went ahead and uploaded CLs. Now you can use --dry-run to get it
to print info about each CL it would upload.

Change-Id: If2ac74a89b0a8b30d86819e16ece46f487b1e7c7
Reviewed-on: https://chromium-review.googlesource.com/821336
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Chris Watkins <watk@chromium.org>
8 years ago
Marc-Antoine Ruel 85a8c108a4 roll_dep: Allow rolling multiple dependencies simultaneously
The way it is done is by switching to a multiple phases model:
- Gather data
- Calculate actions
- Execute

Rolling multiple dependencies simultaneously is occasionally needed.
This will permit to supersede roll-deps.py in infra.git.

R=agable@chromium.org
Bug:
Change-Id: Ibdc7883268b2b08c8a0db1637a9601ffce943c48
Reviewed-on: https://chromium-review.googlesource.com/817616
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
8 years ago
Aaron Gable f4068aa3ea Use core.quotePath=false for more git diffs
This includes a minor refactor so that some gclient_scm methods
can all share the same core.quotePath specifier.

R=iannucci

Bug: 792302
Change-Id: Iaadf190f5c0666787cf7c2ccda88d6dba9aace9b
Reviewed-on: https://chromium-review.googlesource.com/823131
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
8 years ago
Aaron Gable cde045d55b Update depot_tools prod win git to 2.15.1.2
R=iannucci

Bug: 749709
Change-Id: I2b2dbde5ac74e20c36da0c691999f9dc09ea7ca5
Reviewed-on: https://chromium-review.googlesource.com/806996
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
8 years ago
Aaron Gable 7817f02543 Reland "Use core.quotePath=false when git is listing files"
This is a reland of 9219d35688

The original was reverted due to a typo (core,quotePath instead
of core.quotePath). This version is fixed.

Original change's description:
> Use core.quotePath=false when git is listing files
>
> This prevents git from putting quotes around some file names
> (those that have astral-plane characters) and not around others.
>
> R=maruel
>
> Bug: 792302
>
> Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db
> Reviewed-on: https://chromium-review.googlesource.com/815454
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

Bug: 792302
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Change-Id: I28d2260948aaf63bd865888c2f60e4cdee9aea48
Reviewed-on: https://chromium-review.googlesource.com/822990
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
Quinten Yearsley a563d7222f Add more fields to try-results --json for WPT importer
Context: The WPT importer consumes the JSON produced by
git cl try-results is consumed and uses it to determine
when the CQ has passed (whether all non-experimental cq
jobs were successful) and where layout test results are
stored.

Added fields:
  created_ts: This could be used to sort builds by time.
  tags: Includes user_agent tag and experimental tag, as well as
  experimental: whether the job is experimental

Bug: 792652
Change-Id: Ic6099a21b21db668b88b1a8e54aefd84529a2a91
Reviewed-on: https://chromium-review.googlesource.com/819573
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
Robbie Iannucci 6aaee3065c Revert "Use core.quotePath=false when git is listing files"
This reverts commit 9219d35688.

Reason for revert: unfortunately this says "core,quotePath" and since it includes recipe changes, we need something that the roller can munch on :(

Original change's description:
> Use core.quotePath=false when git is listing files
> 
> This prevents git from putting quotes around some file names
> (those that have astral-plane characters) and not around others.
> 
> R=​maruel
> 
> Bug: 792302
> Recipe-Nontrivial-Roll: build
> Recipe-Nontrivial-Roll: build_limited_scripts_slave
> Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db
> Reviewed-on: https://chromium-review.googlesource.com/815454
> Commit-Queue: Aaron Gable <agable@chromium.org>
> Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>

TBR=maruel@chromium.org,agable@chromium.org

Change-Id: I226388f19024403240a1443eb2b878b9293220e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792302
Reviewed-on: https://chromium-review.googlesource.com/821671
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Aaron Gable 9219d35688 Use core.quotePath=false when git is listing files
This prevents git from putting quotes around some file names
(those that have astral-plane characters) and not around others.

R=maruel

Bug: 792302
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Change-Id: I3b6a6b36c4720116de811b40177b59aa25c263db
Reviewed-on: https://chromium-review.googlesource.com/815454
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
8 years ago
Aaron Gable e8856eea42 git-cl: fix 'status --field=patch' for Gerrit
We don't set the branch.<name>.gerritpatchset git config value
during "git cl upload" because it isn't returned from the
server either during push or during any of our subsequent RPCs,
and adding another RPC just for that metadata would be slower
that we would like.

But calling "git cl status" already makes an RPC per branch, so
take advantage of that to cache the gerritpatchset value during
that operation.

R=robertma

Bug: 792611
Change-Id: I37b09f3c4cfced86668b457eff82f2424012b14b
Reviewed-on: https://chromium-review.googlesource.com/815137
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
8 years ago
recipe-roller fa4112f5f9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/3b02d79e002f4cea48de2f512157eb2def6081d1 Allow properties to load default values from environment. (vadimsh@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib6e807caf90e1e39760d4ba4fdffb1172a325ad5
Reviewed-on: https://chromium-review.googlesource.com/815670
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
Aaron Gable 92e9f38865 gerrit_util: Slightly modify retry backoff behavior
This is a bandaid (over Gerrit's replication lag), but hopefully
this will increase the likelihood of success and improve the
messaging around retries at the same time.

R=tandrii

Bug: 792679
Change-Id: Ia6e3133cc23ea9b2abfeacc05750c002f8804e8b
Reviewed-on: https://chromium-review.googlesource.com/812564
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
Robert Iannucci 777c1527f5 [led] Reland: Update led to the latest version.
Now using a version that's actually uploaded to cipd (and verified with
PRESUBMIT).

infra.git relevant Changelog:
8bc0df738 [kitchen] Remove some unnecessary flags.
54472fa9f led: improvements in led get-build subcommand.
6707984c0 [led] Add ability to set buildbucket tags on get-builder command.

R=nodir@chromium.org, vadimsh@chromium.org

Bug:
Change-Id: I1927c19097d6a6057c48ddbaa185368cc3520ac3
Reviewed-on: https://chromium-review.googlesource.com/813089
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
recipe-roller ad9cc11121 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6acef55ce230375622724fc75c023fae38065664 buildbucket recipe_module: make each step an infra step. (tandrii@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I999cb1c7f4e85988c34f4d8b606f0320fe83fe63
Reviewed-on: https://chromium-review.googlesource.com/812995
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
Robert Iannucci 7d47eb5495 [PRESUBMIT] Add cipd package checks for all known manifests.
This also improves the cipd manifest canned check to produce unique
names in order to debug PRESUBMIT's more easily.

Adds onto
  https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/708354

R=maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org

Bug:
Change-Id: I9f086996998608092a4d23f5c98fbac34117a9e4
Reviewed-on: https://chromium-review.googlesource.com/811445
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Marc-Antoine Ruel 0afcd10430 Revert "[led] Update led to the latest version"
This reverts commit 9c02a833e2.

Reason for revert: the referenced hash doesn't have a cipd package.
It breaks gclient sync for src.git.

Original change's description:
> [led] Update led to the latest version
> 
> infra.git relevant Changelog:
> 8bc0df738 [kitchen] Remove some unnecessary flags.
> 54472fa9f led: improvements in led get-build subcommand.
> 6707984c0 [led] Add ability to set buildbucket tags on get-builder command.
> 
> R=​nodir@chromium.org
> 
> Bug:
> Change-Id: If1e664f402fdac73fe16ae351d9a5d819f426909
> Reviewed-on: https://chromium-review.googlesource.com/809947
> Reviewed-by: Nodir Turakulov <nodir@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

TBR=iannucci@chromium.org,nodir@chromium.org

Change-Id: Idbed632448a986f714579c63c4da8b49068757ce
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/810164
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
8 years ago
Robert Iannucci 9c02a833e2 [led] Update led to the latest version
infra.git relevant Changelog:
8bc0df738 [kitchen] Remove some unnecessary flags.
54472fa9f led: improvements in led get-build subcommand.
6707984c0 [led] Add ability to set buildbucket tags on get-builder command.

R=nodir@chromium.org

Bug:
Change-Id: If1e664f402fdac73fe16ae351d9a5d819f426909
Reviewed-on: https://chromium-review.googlesource.com/809947
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Aaron Gable 873be6fd45 Update depot_tools bleeding-edge win git to 2.15.1.2
R=iannucci

Bug: 749709
Change-Id: Id254c60b9fba981824b267ccaaf4dc7f35428a8a
Reviewed-on: https://chromium-review.googlesource.com/806974
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
8 years ago
Mun Yong Jang b278ddd939 [presubmit] Remove line
Bug:
Change-Id: Ife9b3eaec3031de1fa4324e345f8e30012ed618a
Reviewed-on: https://chromium-review.googlesource.com/806241
Commit-Queue: Mun Yong Jang <myjang@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago
Aaron Gable ad64abd69a git-cl: Fix 'git cl issue --reverse'
While ripping SVN support out of git-cl, the Changelist() constructor
changed to require that the branch name start with "refs/heads/",
but the CMDissue --reverse code was never updated to feed it the
fully-qualified refname.

R=thestig

Bug: 791176
Change-Id: Ia7fee0f77fec080d91f34ad43bfd9f7c6a4bf64b
Reviewed-on: https://chromium-review.googlesource.com/806239
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
8 years ago
Mun Yong Jang 17995a9f12 [depot_tools] Remove deprecated config check in canned checks
Bug: 785114
Change-Id: Ic98995d670b22ba17ef6139ed086cb1b31c7d39c
Reviewed-on: https://chromium-review.googlesource.com/804736
Commit-Queue: Mun Yong Jang <myjang@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago
recipe-roller 6c5a1c4c3c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/0f093b369402a86363de15a3fae0c98eab4c8e00 Remove references to phajdan.jr (phajdan.jr@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I899048a12034fc054e7e2c8e6f971b1fd94fff4d
Reviewed-on: https://chromium-review.googlesource.com/803796
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
Achuith Bhandarkar f6b946d71d Also print key in commit message.
BUG=
TEST=manual

Change-Id: Ic0335ecae5809e1cf328e130a29d2e42acc463ce
Reviewed-on: https://chromium-review.googlesource.com/798591
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Eric Boren <borenet@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
8 years ago
Andrii Shyshkalov 009150b7af bot_update: be explicit when checking out branches.
$ git checkout <name>

may be interpreted by git as checking out a file named <name>
if <name> has slashes. Thus,

$ git checkout infra/config

ends up checking out infra/config directory of the (typically)
master branch that was checked out before. To avoid confusion,
we have to add '--' separator between branch name and file names:

$ git checkout <name> --

This in turns allows to run CQ-based presubmit on infra/config branches.

R=nodir@chromium.org

Bug: 790738
Change-Id: I6ce31a8f0fbd66fd59ac7c2ea9cccd3ff97d1f0e
Reviewed-on: https://chromium-review.googlesource.com/802136
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago
Aaron Gable 8076c2854d Give git-cl-presubmit an --all option
This will let developers run PRESUBMIT against all files in the
repo, rather than just those their CL touches. This will be
particularly helpful when modifying PRESUBMIT.py itself.

R=maruel@chromium.org

Bug: 519046
Change-Id: I5775eef8aecefe0cd358537c9218afc7480a7619
Reviewed-on: https://chromium-review.googlesource.com/798056
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
Aaron Gable bd95f41abd Fix fetch --dry-run to not invoke git
This was broken by 209a681f9c,
which replaced self.run() with git_common.run(), thus
bypassing self.run()'s dry_run check.

Bug: 788562
Change-Id: I9964c169b0ff56778c4660acab7ef7c010e37a36
Reviewed-on: https://chromium-review.googlesource.com/797611
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
recipe-roller 9e51906ffb Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6d6af8922b3707d7b02c8ed31f5a839a9be7eb80 Add truncate() to file api (kjharland@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I55fc4af937e2570b12bf355f1582d2e1ace0f584
Reviewed-on: https://chromium-review.googlesource.com/794044
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
Andrii Shyshkalov 1b30125fbc bot_update: don't remove git cache's .lock files.
bot_update and gclient invokes git cache with --ignore-locks.
This should also reduce noisiness of bot_update stdout.

R=iannucci@chromium.org

Bug:
Change-Id: I6baf9e5665d244d08aab58a7d3327e6c3204b2b5
Reviewed-on: https://chromium-review.googlesource.com/791536
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
recipe-roller 24650b6c5a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/16114fcab34af737bd1488b163a5af97efdd4aab [autoroll] Skip backwards rolls instead of terminating. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9d52be2d5888088bdb76b16fc73ea972b45f2204
Reviewed-on: https://chromium-review.googlesource.com/792431
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
Andrii Shyshkalov 77ce4bdc7d gclient on bots: don't cleanup lock files.
bot_update & gclient on bots instruct git cache locks
to be ignored, so there is no need to clean them up.

R=hinoka@chromium.org

Change-Id: I81c52cfcd44a42d13b641847439ac92053a7bc98
Reviewed-on: https://chromium-review.googlesource.com/791652
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
Mun Yong Jang 1728f5f3e6 [depot_tools] Fix timestamp issues related to local auth
Bug: 509672
Change-Id: I5abb813d5f78291b4bf2d8e856c6fd71fcad5b68
Reviewed-on: https://chromium-review.googlesource.com/791472
Commit-Queue: Mun Yong Jang <myjang@google.com>
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
8 years ago
recipe-roller ad3e639bae Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6c2cb40870d113be8dddefc69ea6a4177d5fc884 [vpython] Assume vpython in $PATH for bootstrap. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I88f5b9ee7c66b79425692fdd21f87283f66704bd
Reviewed-on: https://chromium-review.googlesource.com/791153
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org>
8 years ago
Andrii Shyshkalov 46a672bafa gclient: don't update cache if needed revision is already there.
Tested end-to-end, for example
  https://ci.chromium.org/swarming/task/3a0147207378b910
which contains:
  src/media/cdm/api (Elapsed: 0:00:01)
  ----------------------------------------
  [0:00:00] Started.
  _____ src\media\cdm\api at ea5df8e78fbd0a4c24cc3a1f3faefefcd1b45237
  [0:00:00] running "git cat-file -e ea5df8e78fbd0a4c24cc3a1f3faefefcd1b45237" in "e:\b\s\w\ir\cache\git\chromium.googlesource.com-chromium-cdm"
  skipping mirror update, it has rev=ea5df8e78fbd0a4c24cc3a1f3faefefcd1b45237 already

thereby saving on needless git fetch (~40s in glcient sync on win trybots),
and reducing the rate of .pack file accumulation inside cache directories.


Risks: silently broken recipes which run gclient sync (or worse, bot_update)
as a means of fetching latest commits in all repos of a solution. I think
the benefit of faster bot_update in chromium CQ is worth the potential risk.

PSA: https://groups.google.com/a/chromium.org/d/msg/infra-dev/UYLdBwAXm1Y/OV9QB6JnBQAJ

Bug: 749709
Change-Id: I7a9e8ab82a5e2b848e450f19a798ac18a0b5e201
Reviewed-on: https://chromium-review.googlesource.com/787331
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
8 years ago
Andrii Shyshkalov 568f473e4b bot_update: add mooooooore chars in logs.
Before, bot_update would print after command:
  Succeeded (Failed) in 0.1 mins
but figuring out which command takes a lot of scrolling/searching
for previous
  Running <cmd with args>
This CL fixes that:
  Succeeded (Failed) in 0.1 mins <cmd with args>



R=machenbach@chromium.org, maruel@chromium.org
TEST=end-to-end with led tool, but only on LUCI stack.

Bug: 749709
Change-Id: Id3031a12b9013ab136ea03cdf6d325930722e50f
Reviewed-on: https://chromium-review.googlesource.com/787175
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
Andrii Shyshkalov d51ed57edb git_cache: lower max num of .pack files before re-bootstrap on Win.
It used to be 50, I think ~9 gives best results for Chromium on Win:
  on golo VM, it takes <4 minutes to re-boostrap + git fetch small
  delta, assuming zipped git checkout for bootstrap is fresh (~1day).

For other repos, which are significantly smaller, this change should
have minor effect if at all.

Test: I tested this using `led` tool on Win7 machines running LUCI
stack extensively. For example,

  * https://ci.chromium.org/swarming/task/3a0102e8c8657410
    shows case with few .pack files, hence just 1 fetch

  * https://ci.chromium.org/swarming/task/3a010282f9fd8010
    shows case with 39 .pack files and so bootstrapping + fetch.
    If you look at prior tasks on the same VM, you'd find this:
    https://ci.chromium.org/swarming/task/39ffe843d01ed010
    which spent 8 minutes doing 1 incremental fetch with 39 .pack
    files.

**Troopers/Sheriffs**: This change is safe to revert.
However, beware that you should also at the same time revert the recipe
roll of this CL to the repo, in which the failed builder's recipe is
located, typically `chromium/tools/build`.

Bug: 749709
Change-Id: I18e2b63283100d466e9fb981a9094862463f6909
Reviewed-on: https://chromium-review.googlesource.com/787174
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@google.com>
8 years ago
Andrii Shyshkalov 0083130c97 Whitespace change inside recipes to kick recipe autoroller.
TBR=iannucci@chromium.org

Bug: 749709
Change-Id: I8aa02f780c5f2a3c2f8c0c408f83b061ba11c672
Reviewed-on: https://chromium-review.googlesource.com/788244
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
Andrii Shyshkalov 4f56f234f9 git_cache: add more diagnostic logging wrt bootstrapping.
This is short of sending this metrics to ts_mon, but is still useful
for diagnose and then claim improvements in git cache performance on
bots.

This change has been tested for realz with led, particularly on windows
https://ci.chromium.org/swarming/task/3a01358af14a7d10

Bug: 749709
Change-Id: I2b3589079d2caa7f70007f90fcbce85a0205d24b
Reviewed-on: https://chromium-review.googlesource.com/787173
Reviewed-by: Takuto Ikuta <tikuta@google.com>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
8 years ago
Sergey Berezin 05ecc0e484 Roll mac_toolchain to 2b69be620
Relevant commit:
  2b69be620 mac_toolchain: update file permissions post-install
  894cac284 mac_toolchain: add "package" command
  09ed0cfc0 mac_toolchain: include symlinks

BUG=475693
TBR=iannucci@chromium.org

Change-Id: I65d146fd99ab8dd378b04714b8e3b88e0cf51907
Reviewed-on: https://chromium-review.googlesource.com/775667
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
8 years ago
Daniel Cheng d36fce4408 Fix silly bug in presubmit_support implementation of AppendCC.
The executor needs to accumnulate more_cc, not overwrite them.

Bug: 786386
Change-Id: Iadfe836ae9623f1b66d2db8209d347b5e61ccae8
Reviewed-on: https://chromium-review.googlesource.com/784553
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
8 years ago