Andrii Shyshkalov
							
						 
						
							 
							
							
							
								
							
								90e958b3b8 
								
							
								 
							
						 
						
							
							
								
								bot_update: set fake user.{name,email} when running rebase.  
							
							 
							
							... 
							
							
							
							R=agable@chromium.org,sergeyberezin@chromium.org,iannucci@chromium.org
BUG=722853
Change-Id: I9bd8c259a87cc65e320e99d9c5e18838b970d543
Reviewed-on: https://chromium-review.googlesource.com/505495 
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								0faadc983e 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/3343170e687e1cfa402e70c6e90019f9f88f913f  [package.py] prevent overriding undeclared repo dependency. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb8cdb6411ae501b8c967fe780571eb6a875a9ae
Reviewed-on: https://chromium-review.googlesource.com/505440 
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Achenbach
							
						 
						
							 
							
							
							
								
							
								7f8c775571 
								
							
								 
							
						 
						
							
							
								
								Revert "gclient: return non-zero exit code on unknown command"  
							
							 
							
							... 
							
							
							
							This reverts commit 2c199e1ec4 .
Reason for revert: This makes calls to gclient that have the only intention of updating gclient fail, like:
https://cs.chromium.org/chromium/src/v8/tools/try_perf.py?l=93 
Reverting for now to give time to clean up such scripts before reland.
Original change's description:
> gclient: return non-zero exit code on unknown command
> 
> Bug: none
> Change-Id: I447f66765679b7b66b5748af1cf1f501610603bf
> Reviewed-on: https://chromium-review.googlesource.com/504408 
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
> 
TBR=iannucci@chromium.org,phajdan.jr@chromium.org,dpranke@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug: none
Change-Id: I9496f7192dfde1e38c186a94ac985190b76b2438
Reviewed-on: https://chromium-review.googlesource.com/506563 
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								99afc7e2d6 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/1a90c2644e03337ecfd91dd1e76a7c2713b42808  [platform] improve testing assertions. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic9dc336b8df3651d928628d07f22a3f675efa21d
Reviewed-on: https://chromium-review.googlesource.com/505556 
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								e3506f34d4 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/ea1ac7522268ac435550c701790fd1276f3e6a05  [post_process] make the check function return True if the expression is (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If7a208614fb52b33108907bd274ce1fa9b44a833
Reviewed-on: https://chromium-review.googlesource.com/505871 
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								3fd4877189 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/def1c0f3b0bc9712e87e58031eb08e967e7ee46c  [test] improve test failure message with retraining instructions. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0c21757c3859b9a24cc1535e0d762900aaa3e6ce
Reviewed-on: https://chromium-review.googlesource.com/505632 
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Dan Jacques
							
						 
						
							 
							
							
							
								
							
								a3ba888db8 
								
							
								 
							
						 
						
							
							
								
								[bot_update] Remove "git retry" call.  
							
							 
							
							... 
							
							
							
							The Git wrapper now implicitly retries, so this call is unnecessary.
BUG=chromium:721450
TEST=None
R=hinoka@chromium.org, iannucci@chromium.org 
Change-Id: I79e42aa050f6fec14506b685d379a76e8296fea3
Reviewed-on: https://chromium-review.googlesource.com/506493 
Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								0041e708cd 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/b5078f1d18d40c1e8e073ca0e17c6ac382ddcb57  [test] Don't print coverage version by default. (dnj@google.com )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I050d1692bf3ade52b35d91e94f060bacc0ffa7b8
Reviewed-on: https://chromium-review.googlesource.com/505533 
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Dan Jacques
							
						 
						
							 
							
							
							
								
							
								e2af38e019 
								
							
								 
							
						 
						
							
							
								
								[git retry] Fix Git wrapper fallthrough.  
							
							 
							
							... 
							
							
							
							Currently, when the Infra Git wrapper is installed in PATH and a user
calls "git retry", the "git_retry.py" script is supposed to ignore the
request and fall through to the underlying command, relying on the Git
wrapper to handle retries.
However, Git apparently prepends its own executable path to PATH when it
is called, preventing the Git wrapper from being invoked the second time
and removing retries altogether.
We circumvent this by removing Git's new PATH influence when falling
through.
BUG=chromium:721450
TEST=local
  - Ran locally before and after patch, confirmed that after
  successfully retries throgh the wrapper.
R=agable@chromium.org, iannucci@chromium.org 
Change-Id: Iae3d7a8bf805a5ba2bf827b06006a990d94e96d9
Reviewed-on: https://chromium-review.googlesource.com/506374 
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								71c661ecd9 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/9be63aeb7800439b172aaf2d77a156ff5d523947  [context] Fix "check_type" error. (dnj@google.com )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I06b8c9d6786dd480f3079251ca8e238ba6163830
Reviewed-on: https://chromium-review.googlesource.com/505532 
Reviewed-by: Recipe Roller <recipe-roller@chromium.org>
Commit-Queue: Recipe Roller <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Aaron Gable
							
						 
						
							 
							
							
							
								
							
								93248c5ccb 
								
							
								 
							
						 
						
							
							
								
								owners: handle CLs which only have partial OWNERS  
							
							 
							
							... 
							
							
							
							If every file in a change has OWNERS, then the code would find
them fine. Similarly, if no files has OWNERS, then this code would
return an empty set just fine.
But if some files had OWNERS while others didn't, it would crash
when it tried to find an OWNER for file 'foo' while all the possible
OWNERS only provided coverage for file 'bar'.
This code purges the list of possible OWNERS as they become useless
for providing additional coverage, and returns whatever set we have
accumulated so far when the set of possible OWNERS becomes empty.
R=iannucci@chromium.org 
Bug: 715062
Change-Id: I408601bd89379381db1cc7df56beed97ab3c27e6
Reviewed-on: https://chromium-review.googlesource.com/506239 
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Dan Jacques
							
						 
						
							 
							
							
							
								
							
								8b5d230254 
								
							
								 
							
						 
						
							
							
								
								Roll "vpython".  
							
							 
							
							... 
							
							
							
							Roll "vpython" to: 00f5394a90dfa98e53e191d5a6b543bce70c295f
BUG=None
TEST=None
TBR=iannucci@chromium.org 
Change-Id: Ia8b5d29a916fb186bdbff9dac4d63526c5f3e2ac
Reviewed-on: https://chromium-review.googlesource.com/505930 
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Scott Graham
							
						 
						
							 
							
							
							
								
							
								c482674289 
								
							
								 
							
						 
						
							
							
								
								Add support for hooks_os in .gclient  
							
							 
							
							... 
							
							
							
							This adds support for 'hooks_os' in .gclient which runs the given hooks
only when the associated os is specifed in target_os.
Bug: 706592
Change-Id: If70e51e0e784f8a8c6e45b33f59605b883a16f6e
Reviewed-on: https://chromium-review.googlesource.com/503534 
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Paweł Hajdan, Jr
							
						 
						
							 
							
							
							
								
							
								2c199e1ec4 
								
							
								 
							
						 
						
							
							
								
								gclient: return non-zero exit code on unknown command  
							
							 
							
							... 
							
							
							
							Bug: none
Change-Id: I447f66765679b7b66b5748af1cf1f501610603bf
Reviewed-on: https://chromium-review.googlesource.com/504408 
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								1423955b09 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/63fd5fef30ebf0db04266b4f4723f77838979365  [url]: get_file has default (empty) test data (dnj@google.com )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I429c5501fa69fdaa4fdf76948663a598e6aee64b
Reviewed-on: https://chromium-review.googlesource.com/505530 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								58c3c5f2d4 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/e9c7176184ed588bbf66335e834834496f28cf9c  [url] Cleanup, bugfix, step_test_data. (dnj@google.com )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If2cace0cf51bbbf68122a4422bd9ff57b2e5168a
Reviewed-on: https://chromium-review.googlesource.com/505389 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								ba1ed45043 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/0070123d9c8f830d813e6ec1064b9bf24a5b29db  [context] Fix docstring. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0378db40829110017a9b096edcf14153cb450bee
Reviewed-on: https://chromium-review.googlesource.com/505529 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Dan Jacques
							
						 
						
							 
							
							
							
								
							
								69e760e4a5 
								
							
								 
							
						 
						
							
							
								
								Switch to recipe engine "url" module.  
							
							 
							
							... 
							
							
							
							BUG=None
TEST=expectations
R=iannucci@chromium.org 
Change-Id: I43a65405c957cb6dddd64f61846b926d81046752
Reviewed-on: https://chromium-review.googlesource.com/505278 
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Aaron Gable
							
						 
						
							 
							
							
							
								
							
								9b46527628 
								
							
								 
							
						 
						
							
							
								
								git-cl: let 'git config gerrit.host false' work  
							
							 
							
							... 
							
							
							
							R=tandrii@chromium.org 
Change-Id: I2c669303d2320d672538b363fbb15fb9e5cf37a8
Reviewed-on: https://chromium-review.googlesource.com/505267 
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								9fe907de63 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/60cc7f3f49737e8cf852e396b4436c2b6bd3f56d  Add vpython support to Python recipe module. (dnj@chromium.org )
  https://crrev.com/c6560f3627af81c9004024079525ef63a223d33a  Add "url" recipe module to base. (dnj@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iecc732789febe840a4fe42374d8264f5e9ea0f06
Reviewed-on: https://chromium-review.googlesource.com/504967 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								d5378e9b2e 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/b7c18e0258998652eeb302c83680f6a2b1aee398  Revert of include Package proto into Result proto (patchset #3  id:40001 of https://codereview.chromium.org/2802693003/  ) (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I74e8a446f7cdea5ff6b1784b70ca2ab0ca7c5632
Reviewed-on: https://chromium-review.googlesource.com/503670 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								fc6905908d 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/c7d91ef9861b04e41c6a2381382efd58d111fe19  include Package proto into Result proto (nodir@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I716db1f3d8f12fb7d440877cc4fa0ad4d2fe1e77
Reviewed-on: https://chromium-review.googlesource.com/503628 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								3cc1e5cc99 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/6eaacf24833ebd2565177157d368da33780fced9  Fix repeated test 'mkdir' failure. (dnj@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I65d09fa7702f99172a4afae174dcd1236883532a
Reviewed-on: https://chromium-review.googlesource.com/503727 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Robert Iannucci
							
						 
						
							 
							
							
							
								
							
								5702f0baef 
								
							
								 
							
						 
						
							
							
								
								[recipes] convert all recipe_modules to use new context module.  
							
							 
							
							... 
							
							
							
							R=recipe-roller@chromium.org 
Bug:
Change-Id: I84c19965b779f1010c00cd8c857b7533eec7413f
Reviewed-on: https://chromium-review.googlesource.com/502929 
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Andrii Shyshkalov
							
						 
						
							 
							
							
							
								
							
								1a91c6080a 
								
							
								 
							
						 
						
							
							
								
								Nit fix for git_footers.  
							
							 
							
							... 
							
							
							
							TBR=machenbach@chromium.org 
Bug: 717504
Change-Id: Ifa71fa4cac0b57ed11ba5e7eb93516b23b72a496
Reviewed-on: https://chromium-review.googlesource.com/502809 
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Andrii Shyshkalov
							
						 
						
							 
							
							
							
								
							
								04b51d6de0 
								
							
								 
							
						 
						
							
							
								
								Reland of Relax git_footers parsing to match that of Gerrit (JGit).  
							
							 
							
							... 
							
							
							
							Previously landed as:
> Change-Id: Ieb6415d55e85b91f11f9052b0fd08cf982b64d51
> Reviewed-on: https://chromium-review.googlesource.com/501849 
R=agable@chromium.org,machenbach@chromium.org
Bug: 717504
Change-Id: Iede5c29ff4c317b68d8c2bca319edec140a176f5
Reviewed-on: https://chromium-review.googlesource.com/502908 
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Andrii Shyshkalov
							
						 
						
							 
							
							
							
								
							
								43ec62ec71 
								
							
								 
							
						 
						
							
							
								
								Revert "Relax git_footers parsing to match that of Gerrit (JGit)."  
							
							 
							
							... 
							
							
							
							This reverts commit 28a5d5defd .
Reason for revert: breaks assumption in function for adding footers
Original change's description:
> Relax git_footers parsing to match that of Gerrit (JGit).
> 
> R=agable@chromium.org
> 
> Bug: 717504
> Change-Id: Ieb6415d55e85b91f11f9052b0fd08cf982b64d51
> Reviewed-on: https://chromium-review.googlesource.com/501849 
> Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Aaron Gable <agable@chromium.org>
> 
TBR=agable@chromium.org,machenbach@chromium.org,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Bug: 717504
Change-Id: I9b4d619b2972be8434aff9464f1959fbcb3abd32
Reviewed-on: https://chromium-review.googlesource.com/503030 
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Paweł Hajdan, Jr
							
						 
						
							 
							
							
							
								
							
								beec006697 
								
							
								 
							
						 
						
							
							
								
								gclient validate: add schema checking  
							
							 
							
							... 
							
							
							
							Bug: 570091
Change-Id: I1297f817f2e3d791c22b256de40f12c0c23dceb5
Reviewed-on: https://chromium-review.googlesource.com/500807 
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								57a86929f6 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/275cbaae0e81a737ff1be9c73049b2cd124388ad  [context] Add user-facing context module. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib38b90315a8009f38472761e0390a920f7d58fa6
Reviewed-on: https://chromium-review.googlesource.com/502248 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								8a2f54e5c6 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/c594d93e17bd0e32f02620808deed9b1833bd81f  [autoroll] Remove support for 'config section' in doc/recipes.py (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8f6f9ee8f5b82ee3a0565815ca1ec31f0af2ba24
Reviewed-on: https://chromium-review.googlesource.com/502587 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Dan Jacques
							
						 
						
							 
							
							
							
								
							
								fa16a83dd2 
								
							
								 
							
						 
						
							
							
								
								vpython: proper shebang :)  
							
							 
							
							... 
							
							
							
							BUG=None
TEST=None
R=sergeyberezin@chromium.org 
Change-Id: I2bb22ad002b82767c6a7efb68412f9c1dbf57c27
Reviewed-on: https://chromium-review.googlesource.com/502228 
Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								2debb847bd 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/23230785ddaec6e199d3ede6d496131ec178c183  config: fix config.Dict with no value type (nodir@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2cb5dff9c4e745003db3732e23a564272ecedf22
Reviewed-on: https://chromium-review.googlesource.com/502227 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Andrii Shyshkalov
							
						 
						
							 
							
							
							
								
							
								28a5d5defd 
								
							
								 
							
						 
						
							
							
								
								Relax git_footers parsing to match that of Gerrit (JGit).  
							
							 
							
							... 
							
							
							
							R=agable@chromium.org 
Bug: 717504
Change-Id: Ieb6415d55e85b91f11f9052b0fd08cf982b64d51
Reviewed-on: https://chromium-review.googlesource.com/501849 
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Andrii Shyshkalov
							
						 
						
							 
							
							
							
								
							
								8e4576f385 
								
							
								 
							
						 
						
							
							
								
								git cl upload: fix confusing warning.  
							
							 
							
							... 
							
							
							
							R=machenbach@chromium.org 
BUG=718264
Change-Id: Id238a53dbc22b94010b0eb22263de824da300fbd
Reviewed-on: https://chromium-review.googlesource.com/501809 
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Andrii Shyshkalov
							
						 
						
							 
							
							
							
								
							
								1e250cdeb3 
								
							
								 
							
						 
						
							
							
								
								git cl creds-check: understand '~' in path to .gitcookies.  
							
							 
							
							... 
							
							
							
							Before, git cl creds-check expected `http.cookiefile` of git config
to have path without '~' which git understands on Linux/Mac.
R=machenbach@chromium.org 
Bug: 719728
Change-Id: Ica1308b776b62bda7a8b85113c0c0df837c7d933
Reviewed-on: https://chromium-review.googlesource.com/501828 
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								6dce8fa1f2 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/c93ed98c3c3e6c9be82e88496e55cb1f3dd13372  [recipe_modules/step] do not set cwd if it is start_dir. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iba7fa64ddd5485eb52294c610761cd524385787f
Reviewed-on: https://chromium-review.googlesource.com/501210 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Aaron Gable
							
						 
						
							 
							
							
							
								
							
								6dadfbfcf7 
								
							
								 
							
						 
						
							
							
								
								git-cl-upload: Set all reviewers and ccs in a single batch api call  
							
							 
							
							... 
							
							
							
							The old system had two faults:
* It set reviewers and ccs via different mechanisms, which is confusing
* It set CCs with a single call for each, resulting in N separate emails,
  with each email going to the uploader and all reviewers and all previous
  CCs.
This new system just collects all reviewers and CCs, and sets them
in a single call. That call will fail if *any* of the individual
reviewers or ccs fail, so it also parses the response and retries with
only the ones which would have succeeded on their own. If that second
call fails, or the first fails in an unexpected way, it raises an
exception like normal
Bug: 710028
Change-Id: I1be508487a41f0b68f9c41908229b8f5342830a3
Reviewed-on: https://chromium-review.googlesource.com/479712 
Commit-Queue: Aaron Gable <agable@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								4e8058a449 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/9f2573a386ee07450095cbeb3562df94a644962f  bootstrap: show a better missing CIPD error (dnj@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie97ecdd0092bd72f0d0a4226f294a529c4444ab8
Reviewed-on: https://chromium-review.googlesource.com/501047 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								070c2e3eee 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/bf2ff828987549b946135919bd1bffd6e42fd8fd  [doc/recipes.py] Add option to recipes.py to allow it to work without .git (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I73f11890503702e9af7c24941457425c5cc46267
Reviewed-on: https://chromium-review.googlesource.com/499770 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								8cb8f71a99 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/e7bbbf6cfac944157d80cc92fd78837165e69d3f  Fix a race crash when recipe expectations directory exists (phajdan.jr@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3686b56ed29c3333f77feee0118a5020acb73abf
Reviewed-on: https://chromium-review.googlesource.com/499603 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Paweł Hajdan, Jr
							
						 
						
							 
							
							
							
								
							
								e2f9feecaf 
								
							
								 
							
						 
						
							
							
								
								Add validate command to gclient  
							
							 
							
							... 
							
							
							
							Inspired by https://chromium-review.googlesource.com/c/411515/  .
Bug: 570091
Change-Id: I7bf9653178c06125ae8be1dee021acfc187b2bdc
Reviewed-on: https://chromium-review.googlesource.com/497848 
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								69a239e477 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/497f5b7f92cea8e5273d56cc3cba876fb18b42d9  [doc/recipes.py] fix issue when running recipes.py from . (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6bae466acee1d5131d689a01803780dbea2ca174
Reviewed-on: https://chromium-review.googlesource.com/499929 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								1ae7d33b5d 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/e90c11af854574dd68edd0e7c7a5e04ceb49ffd0  [recipes.cfg] remove support for api_version 1. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4037656dd987d0f8aca762761e0ff8ae9034f19f
Reviewed-on: https://chromium-review.googlesource.com/499987 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								80b30caf53 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/cfeeb53051e02856a35395a69b09f822ad35e2e5  [doc/recipes.py] Improve copypasta bootstrap script. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie57e5caef2c447be3d44866c1f75b1d655effe84
Reviewed-on: https://chromium-review.googlesource.com/499768 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								73405e188b 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/d6c4a597be2da8be7971b4d5f66e3d95e8fc325c  [recipes.py] refactor PackageContext to remove --no-fetch logic. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id973ff1bd5d0cab2336bf1764acf8bb0d6381251
Reviewed-on: https://chromium-review.googlesource.com/499509 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Aaron Gable
							
						 
						
							 
							
							
							
								
							
								0bbd1c28d5 
								
							
								 
							
						 
						
							
							
								
								git-cl: upload to merge-base with master, not tip of origin/master  
							
							 
							
							... 
							
							
							
							Previously, if the branch structure was
origin/master
  master [ 3 commits behind origin/master ]
    my-branch [ 1 commit ahead of master ]
then git-cl would see that the upstream branch is master,
and decide to diff against origin/master instead. But that
diff would contain the contents of the three commits that
the local master branch hasn't caught up with yet. That's
not what we want.
This CL makes it so that basing on top of local master is
the same as basing on top of remote branches. Just like
when based on top of origin/master, it simply calculates
the merge-base with the parent commit (which is assumed
to be present in the remote), and uploads that diff.
Change-Id: I91caa30f6256a6e019e613dc5ff624734bca027e
Reviewed-on: https://chromium-review.googlesource.com/499307 
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								14f825d5a2 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/487e5e371bf8140b0467c6366f94042581f5c63c  [recipes.py] refactor PackageContext to remove unused --deps-path arg. (iannucci@chromium.org )
  https://crrev.com/92c5b73ff81fb30c80a33bab91be51551d5e67b7  Bump "vpython" bootstrap version. (dnj@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I76d61ae0975b7b8290f3df364d568a74f9c28edf
Reviewed-on: https://chromium-review.googlesource.com/499347 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								recipe-roller
							
						 
						
							 
							
							
							
								
							
								850d66ab8e 
								
							
								 
							
						 
						
							
							
								
								Roll recipe dependencies (trivial).  
							
							 
							
							... 
							
							
							
							This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD . Use https://goo.gl/noib3a  to file a bug.
recipe_engine:
  https://crrev.com/66338449f4d727da096422c1df1b6654224d6512  [bootstrap] don't change directories when bootstrapping. (iannucci@chromium.org )
TBR=iannucci@chromium.org 
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I50628e79e36d08da42b7d3cb4409aae617b4ea5e
Reviewed-on: https://chromium-review.googlesource.com/498971 
Reviewed-by: <recipe-roller@chromium.org>
Commit-Queue: <recipe-roller@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Dan Jacques
							
						 
						
							 
							
							
							
								
							
								4ebaaf9d9c 
								
							
								 
							
						 
						
							
							
								
								Bump "vpython" version.  
							
							 
							
							... 
							
							
							
							Bump develooper "vpython" version.
AFAIK nothing uses this yet, so this should be safe.
BUG=None
TEST=None
TBR=iannucci@chromium.org 
Change-Id: I484aae767b584222fd8aeee06317be9e1f889c61
Reviewed-on: https://chromium-review.googlesource.com/499151 
Reviewed-by: Daniel Jacques <dnj@chromium.org>
Commit-Queue: Daniel Jacques <dnj@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Michael Achenbach
							
						 
						
							 
							
							
							
								
							
								b4a7969036 
								
							
								 
							
						 
						
							
							
								
								Add back helper method still used in build repo  
							
							 
							
							... 
							
							
							
							Follow up fix for:
https://chromium-review.googlesource.com/c/497432 
TBR=tandrii@chromium.org 
Bug: 717457
Change-Id: I66fb86f46cbdc6d9e34ce656541760af313beea8
Reviewed-on: https://chromium-review.googlesource.com/497410 
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org> 
							
						 
						
							9 years ago