2 Commits (8d16d4a754cc1de3f25c8618672aa95e7189edda)

Author	SHA1	Message	Date
Brian Osman	a0cf432171	Tweak ninja fallback logic ... In Skia (for example), GetPrimarySolutionPath works, but FindGclientRoot does not (users tend not to use gclient to sync DEPS, etc). Without this change, we'd get to the loop. If a user had pulled ninja to third_party/ninja/ninja, then it would work just fine. If they hadn't, python would throw an exception on the os.path.join line, because we'd be passing a NoneType as the first argument. Bug: chromium:1340825 Change-Id: Iab86450c5b6f00bc9c2716b9504debc9a56d9bb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4034942 Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Nico Weber <thakis@chromium.org>	2 years ago
Junji Watanabe	1f67d5573f	Add ninja wrappers to trigger DEPS ninja ... This is the first step to deprecate ninja binaries in depot_tools. depot_tools/{ninja, ninja.bat} will call ninja.py, which finds CIPD ninja under src/third_party in the current gclient source tree. https://crrev.com/c/3869740 If it fails to find, it does fallback to an existing ninja binary in depot_tools, until removing the references to the legacy ninja binaries. # For those who see the deprecation message, You need to install ninja using DEPS at your project. (https://crrev.com/c/3869740 is an example.) If your project doesn't have DEPS, you need to install ninja and include it in PATH manually. e.g. sudo apt install ninja-build Test: Linux builder: https://ci.chromium.org/swarming/task/5e9cfc917aa3f110?server=chromium-swarm.appspot.com Windows builder: https://ci.chromium.org/swarming/task/5e9d48885c460b10?server=chromium-swarm.appspot.com Bug: 1340825 Change-Id: I70d1863d72ddfa65b87a62c9bde8ff63f7641d13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3925341 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Junji Watanabe <jwata@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>	2 years ago