aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,215 Commits
6 Branches
0 Tags
190 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '8d16d4a754'
${ noResults }
Commit Graph

9215 Commits (8d16d4a754cc1de3f25c8618672aa95e7189edda)
 

Author SHA1 Message Date
Riley Wong 8d16d4a754 Updating Lucicfg vs to 1.35.2 Fixes Nil Issue 
Bug:b/261078137
Change-Id: Icb87ded407ade1bcd1713a36b94bad8f2387b9dd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4079324
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 3 years ago
Dirk Pranke ec1882fbc2 Add dpranke@ back as an OWNER. 
Change-Id: I774348ae01769a0ea8e2032d66728e10dbb428fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4074124
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
recipe-roller c4044d4e06 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8795931707510102881

recipe_engine:
928ef44068
  928ef44 (chanli@chromium.org)
      [recipes-py] led get builder accept builder in the format of "p...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1aec64ee23d3f8272294722a18086c038f3e806f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4073904
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Riley Wong 0922aaade1 Revert "Updating Lucicfg V 1.35.0 to 1.35.1" 
This reverts commit fa0a108281.

Reason for revert: Creating a null pointer issue

Original change's description:
> Updating Lucicfg V 1.35.0 to 1.35.1
>
> Version updates a bug where lucicfg fmt was erroring out on sentinel when it should safely continue
>
> Change-Id: Ic62d82176b4c9b8ded139338c7742a2b0cbe56a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072884
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Riley Wong <rgw@google.com>

Change-Id: I47c56e110f0b3acc2011fa0c169d979297856a3c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072086
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 3 years ago
Chan Li 8f9920ba6f [depot_tools] roll led 
to release https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/4072425

Change-Id: Ifdfc00d5aa7b092ecfeee35776bb8fdba94563fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072031
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 3 years ago
recipe-roller 0909a5aa38 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8795946175345122097

recipe_engine:
c66df993a7
  c66df99 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6f2c3501d383 to 4814885a05fd

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icbfb7dbb38c23488f7ee1cd193830efd2abc99ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072026
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Riley Wong fa0a108281 Updating Lucicfg V 1.35.0 to 1.35.1 
Version updates a bug where lucicfg fmt was erroring out on sentinel when it should safely continue

Change-Id: Ic62d82176b4c9b8ded139338c7742a2b0cbe56a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4072884
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 3 years ago
Robbie Iannucci de9b59989f Revert "[lucicfg] Update v1.34.1 -> v1.35.0" 
This reverts commit 391cc612d0.

Reason for revert: This broke `lucicfg fmt`.

Original change's description:
> [lucicfg] Update v1.34.1 -> v1.35.0
>
> This is to pick up 91566b068c
>
> Change-Id: I1a644f362dbd16cc53825a619faf83d9b2c70ac1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4067805
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Robbie Iannucci <iannucci@chromium.org>

Change-Id: I7a6e10eaa66fb068fbeb78e5638af9cb4a51590e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4067398
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Anushruth Sasivehalli <anushruth@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 3 years ago
Riley Wong 391cc612d0 [lucicfg] Update v1.34.1 -> v1.35.0 
This is to pick up 91566b068c

Change-Id: I1a644f362dbd16cc53825a619faf83d9b2c70ac1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4067805
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 3 years ago
Junji Watanabe ad452a7204 Fix autoninja to call ninja.py 
ninja.exe will be removed from depot_tools soon.
Calling ninja.py finds the ninja installed by DEPS or one in PATH.

Bug: 1340825
Change-Id: I32ed6d8e5b0498347042490eedeca19972d35233
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4061247
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
 3 years ago
Chan Li 141be0c7fe [depot_tools] roll led 
Bug: 1393265
Change-Id: I57e5ae59ea6e35755c50f9cdaa7e44fe81ea1f63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4064699
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
 3 years ago
recipe-roller 67828ff1bb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8796177701879779825

recipe_engine:
67bac822e5
  67bac82 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 7d56fc0f58a4 to 7a04ca7c0fd3

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7c95ef2ba5daba8f6380702a0c745edb10210e6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4063573
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Junji Watanabe fc04ff1628 Call ninja.py from compile_single_file.py 
ninja.exe will be removed from depot_tools soon.
depot_tools/ninja.py finds the ninja installed by DEPS (or fallback to ninja in PATH).

Bug: 1340825
Change-Id: I0fefe7a3fdb254ca0025d9d8d4490675ac718184
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4061246
Commit-Queue: Junji Watanabe <jwata@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 3 years ago
Victor Vianna 9a6aa08468 Suggest --no-fetch flag after git rebase-update conflict 
This spares an unnecessary git fetch.

Change-Id: I552148bdfadc3482bda0d71d75aaf9d9ed61d75d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4062088
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 3 years ago
Mike Frysinger 84edf22d0e repo: update to 2.30 launcher 
Change-Id: I66a830a22488a9b8b7d8cc00857efa144e153648
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4054940
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
 3 years ago
Travis Lane 738b48a0bf Avoid full fetches with gclient sync --no-history 
This reworks the behavior of gclient sync --no-history to avoid fetching
the full repository history. This is accomplished by initializing a bare
repository and fetching the ref we are interested in.

Bug: 1305189
Change-Id: Ifea2a061308c354be15abd4e945141599ec20c9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3883766
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Travis Lane <travislane@google.com>
 3 years ago
Gavin Mak d83509c0c3 Move presubmit_canned_checks tests under tests/ and fix 
Only tests under tests/ are run on presubmit, so
presubmit_canned_checks_test.py is not run. Move these there and fix
them.

Bug: 1385693
Change-Id: Ib01a816b0a81919722ea49e5551010251c0e3287
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4038514
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
 3 years ago
Bruce Dawson 0115386a26 Switch from VS 2017/2019 support to VS 2019/2022 
This drops support for packaging toolchains based on VS 2017 and adds
support for VS 2022. This will allow us to package a toolchain for
building Chrome using the latest tools.

Bug: 1273169
Change-Id: I1981c935d1a9f3f4ae25e4643b9956fbdd705be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4054349
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
 3 years ago
recipe-roller 73a26246e5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8796660886911891793

recipe_engine:
ff5ce51cea
  ff5ce51 (sshrimp@google.com)
      Revert "Check created_by to ensure cq tags were copied on retry...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4748ec97c46ebb28bdfd12b48aeafd3d736fcff0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4054460
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 6fde0fbe92 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8796734484111755233

recipe_engine:
189a0bb4a1
  189a0bb (akashmukherjee@google.com)
      [bcid] Uprev provenance broker tool.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8a4dc43b8384e422d439ae8896efb7124b227501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4050460
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Allen Xie 60af816019 depot_tools: Roll rdb and result sink 
Include crrev.com/c/4037071 via
337392bc26

Regenerate cipd_manifest.versions using `cipd ensure-file-resolve -ensure-file ./cipd_manifest.txt`

rdb rollout example: crrev.com/c/3627691

BUG=https://bugs.chromium.org/p/chromium/issues/detail?id=1385957
TEST=No test

Change-Id: I311bede115afa0bcb3b5e0530d3381c46ceb37ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4050062
Commit-Queue: Zhihui Xie <zhihuixie@google.com>
Auto-Submit: Zhihui Xie <zhihuixie@google.com>
Reviewed-by: Chan Li <chanli@chromium.org>
 3 years ago
recipe-roller 2fc7e1ffd5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8796757773764910801

recipe_engine:
6fefccf8bd
  6fefccf (bpastene@chromium.org)
      Allow chrome branch projects to call cq recipe_mod's owner_is_g...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I561d40bec1d53c797d82e78dae9b332695a140ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4049625
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Fumitoshi Ukai 30e3ce8b1c Roll out goma client VERSION=255 
Bug: b/256548869, crbug.com/1386100
Change-Id: If9367944461e8b4d1b775a087abd8fcc1a224b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4045102
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
 3 years ago
recipe-roller d06e475934 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797135889494218401

recipe_engine:
b63398006f
  b633980 (kuanhuang@chromium.org)
      LUCI Analysis: roll the proto.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id10141d7f13cd13bbb412a9a885be44466a3cea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4037596
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Brian Osman a0cf432171 Tweak ninja fallback logic 
In Skia (for example), GetPrimarySolutionPath works, but FindGclientRoot
does not (users tend not to use gclient to sync DEPS, etc).

Without this change, we'd get to the loop. If a user had pulled ninja to
third_party/ninja/ninja, then it would work just fine. If they hadn't,
python would throw an exception on the os.path.join line, because we'd
be passing a NoneType as the first argument.

Bug: chromium:1340825
Change-Id: Iab86450c5b6f00bc9c2716b9504debc9a56d9bb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4034942
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
 3 years ago
Bruce Dawson 31ca877242 Fix CheckLicense tests 
A last minute change to the CheckLicense tests in crrev.com/c/4032366
used the _GetLicenseText function in the wrong place, thus neutering one
test and duplicating code in another. This fixes the tests so that they
minimize duplication and actually test the CSS/C style comments.

Change-Id: Ibbe880dec8d1e85416ed1b7ce94922c6f2c2a543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4037103
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 3 years ago
Junji Watanabe 1f67d5573f Add ninja wrappers to trigger DEPS ninja 
This is the first step to deprecate ninja binaries in depot_tools.

depot_tools/{ninja, ninja.bat} will call ninja.py, which finds CIPD ninja under src/third_party in the current gclient source tree. https://crrev.com/c/3869740

If it fails to find, it does fallback to an existing ninja binary in depot_tools, until removing the references to the legacy ninja binaries.

# For those who see the deprecation message,
You need to install ninja using DEPS at your project. (https://crrev.com/c/3869740 is an example.)

If your project doesn't have DEPS, you need to install ninja and include it in PATH manually. e.g. sudo apt install ninja-build

Test:
Linux builder: https://ci.chromium.org/swarming/task/5e9cfc917aa3f110?server=chromium-swarm.appspot.com
Windows builder: https://ci.chromium.org/swarming/task/5e9d48885c460b10?server=chromium-swarm.appspot.com

Bug: 1340825
Change-Id: I70d1863d72ddfa65b87a62c9bde8ff63f7641d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3925341
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 3 years ago
recipe-roller aad574d446 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797220197766658801

recipe_engine:
cd88b2f65f
  cd88b2f (yuanjunh@google.com)
      [file] handle non-encodable string in listdir cmd

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9b46affdb5017b1f3e634278b696b9faf8fb2b5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4035067
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Gavin Mak f35a9ebe8a Don't prompt unsignificant external changes 
Description changes shouldn't prompt. Changes like these that don't
change code or the merge base won't get overriden anyway.

Bug: 1382528
Change-Id: Ie1947a28ea97a8383a791e76738a2ad20c349878
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4033329
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 3 years ago
recipe-roller be242dbeac Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797228374896861665

recipe_engine:
a2528d57f4
  a2528d5 (sshrimp@google.com)
      Check created_by to ensure cq tags were copied on retry builds

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibae12c0e282e078c53c459270ae723212f51203b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4034374
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Victor Hugo Vianna Silva fe46d759b5 Add presubmit warning to update references to (re)moved OWNERS files 
file:// references in OWNERS files can become invalid when the file
is moved or deleted.

Bug: 1385205
Change-Id: Icf1a65b3d96d6ad298eac6645d8f692cb09dc75a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4029143
Auto-Submit: Victor Vianna <victorvianna@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Victor Vianna <victorvianna@google.com>
 3 years ago
mark a. foltz fadcbfdb27 [depot_tools] Adds a better error message for copyright header checks. 
The current message prints a regular expression.
This new message prints the correct copyright header which can be
copy-pasted into new files.

Bug: 1376752
Change-Id: Ifb03924641ad75d2b58158a752e0a62648436edc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4032368
Commit-Queue: Mark Foltz <mfoltz@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 3 years ago
Bruce Dawson 25cf78395c Fix two CheckLicense bugs and improve tests 
Some recent "improvements" to CheckLicense were buggy, at least
partially because I did not increase test coverage when adding new code
paths. This change fixes two known mistakes and greatly increases test
coverage.

One bug was that the code assumed that match.groups()[0] would always be
the current year, but that assumption is invalid when a license regex is
passed in.

Another bug is that the new_license_re took away the possibility of the
license ending with */ but that is used in .css files.

The increased test coverage catches these and validates other
assumptions around new files.

The failures were reproduced and then the fixes validated using this
command:

  vpython3 tests/presubmit_unittest.py

Bug: 1098010
Change-Id: Ic91ca9f7a182660aef7b1eead79e841f58e15a3e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4032366
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 3 years ago
Alexander Thomas ca3ebf119e Revert "Reset origin/HEAD in git_cache if it points to master" 
This reverts commit 63fea808b0.

Reason for revert: broke bot_update for dart, b/259380822

Original change's description:
> Reset origin/HEAD in git_cache if it points to master
>
> This change resets refs/remotes/origin/HEAD if it points to master. With the master to main migration going on with chromium repositories, some of the cached git repositories end up pointing to master instead of main. This change aids in fixing this issue.
>
> Bug: 1364030
> Change-Id: Ic181b0179daf7b2b842cff7f7187d94d9fb20007
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4029356
> Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Bug: 1364030
Change-Id: I96842c15eba886f5b95cdd10f323b907d5ea165d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4030304
Reviewed-by: Gavin Mak <gavinmak@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 3 years ago
Aravind Vasudevan 63fea808b0 Reset origin/HEAD in git_cache if it points to master 
This change resets refs/remotes/origin/HEAD if it points to master. With the master to main migration going on with chromium repositories, some of the cached git repositories end up pointing to master instead of main. This change aids in fixing this issue.

Bug: 1364030
Change-Id: Ic181b0179daf7b2b842cff7f7187d94d9fb20007
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4029356
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 3 years ago
recipe-roller 8de7b2d51b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797472484239524337

recipe_engine:
6a02d019c4
  6a02d01 (bryner@google.com)
      Run pycurl under python 3.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I67c4895968049441634dc5b76479a0f2e4b28fb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4027287
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Gavin Mak 4e5e39951e Handle external changes on `git cl upload` 
upload currently overwrites any external changes, e.g. edits/rebases
in Gerrit. Check for these on upload and provide the ability to
incorporate those into the CL.

Bug: 1382528
Change-Id: Id32bf8804c4cdeb12b6a5a7cf206e033bbccd453
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3975855
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 3 years ago
recipe-roller 6352336718 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797485067664714897

recipe_engine:
60e31a3201
  60e31a3 (qyearsley@google.com)
      Proofread recipes-py for consistency.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ec1b22addaa9dfc9ab8226c0a362cc9b9bdb850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4022257
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 7aaca94286 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797760002002113297

recipe_engine:
d9f99a765e
  d9f99a7 (yiwzhang@google.com)
      cq: add a new api to tell whether the run owner is a googler

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3d8b8cb431cb68d02aeae1dfb173ac301053481a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4023997
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 31a803fb04 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797765038376560817

recipe_engine:
5db708b8f3
  5db708b (gredelston@google.com)
      buildbucket: Add builder_full_name()

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia831e91d34236805a1af1247863faf54c1fe1b61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4023987
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller 87f204ff53 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797830469493076177

recipe_engine:
e505794d54
  e505794 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 5e09374ddde8 to b3e65829bfd6

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ida831e53db0dd799d0c7a8f7ab6ad3627e8e79af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4022475
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
recipe-roller f9c1305612 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8797838017222574737

recipe_engine:
42064c3659
  42064c3 (yiwzhang@google.com)
      cv: roll the proto to the latest

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic13147a2b5e0bb13b360db47b4b094738f21379e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4022466
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Josip Sokcevic 9d351f8b5a Revert "Update Presubmit to python3" 
This reverts commit 1b7204d841.

Reason for revert: py2 presubmits no longer running, and some
aren't migrated to run py3 yet.

Original change's description:
> Update Presubmit to python3
>
> Recipe-Nontrivial-Roll: build
> Bug:1370463
> Change-Id: I0bf182badc16f0d75c7330f52906f4cf9ff66e08
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3975294
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Riley Wong <rgw@google.com>

Change-Id: I82c3f0f0d502ee896d4e79a6bb330aee71b4d309
Recipe-Nontrivial-Roll: build
Bug: 1370463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4021307
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 3 years ago
Vadim Shtayura ae1a708917 Update lucicfg to v1.33.7. 
To pick up
https://chromium.googlesource.com/infra/luci/luci-go/+/a21cc1db9

R=iannucci@chromium.org

Change-Id: I5e3ba5acf16a8b8c65b0e88ab193a10d5bdd0835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4015282
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 3 years ago
Gavin Mak be2e926c5e Add new constants for last-upload-hash and gerritsquashhash 
Also add comments.

Bug: 1382528
Change-Id: If4311f36e7d1f591be48a6d0de772701290d69db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4015279
Auto-Submit: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 3 years ago
recipe-roller 35ac4b47f6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8798039340317423649

recipe_engine:
f1dbdbfbc0
  f1dbdbf (bshai@google.com)
      switch to inspect.getfullargspec in py3

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6971c86f228e2cb9dd629fede4f52e01bded696a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4014620
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago
Peter Kasting e6f3d66bae Fix bad regex. 
This corrects an oversight in
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4004597
that led to IWYU zealously over-recommending #includes.

Bug: chromium:1368812
Change-Id: Ic4b2f93271206be79371378038bdedd40f7079ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4010619
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 3 years ago
Theodore Siu d9db3f6fd8 Add arch flag and env variable for overriding on mac 
R=sokcevic@google.com

Change-Id: I2c07c2157a404b0eb29da8b46b22990a470576c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4005186
Commit-Queue: Theodore Siu <theosiu@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
 3 years ago
Peter Kasting 03b187d9c8 Avoid IWYU warnings on other namespaces for <algorithm>. 
Cherry-pick of https://github.com/google/styleguide/pull/722.

Bug: chromium:1368812
Change-Id: I3a604ce2e617b3f145c02519ec3528bff22f691c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4004597
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 3 years ago
recipe-roller 8fbdc51e88 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8798477219512840497

recipe_engine:
e31bdf086d
  e31bdf0 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 51ea7aad25ff to f8f64a8c560d

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3ddc30e50d559325705e9d66fe3e683cedb1fe2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4005061
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 3 years ago