Otherwise, the files are opened in 'whatever happens to be the current encoding'
which is highly system-dependent. Even if some files are not encoded with utf-8,
the status quo is even worse. So it's worth trying out.
TBR=cmp@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10697036
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@145306 0039d316-1c4b-4281-b951-d872f2087c98
'git rev-parse foo' with foo being any 40 character hex string will succeed.
Strip one char to force git to do a proper hash table lookup.
TBR=bauerb@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10693008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@144481 0039d316-1c4b-4281-b951-d872f2087c98
This should make a `gclient sync` faster, especially on Windows, where git hangs regularly.
BUG=none
TEST=gclient sync -v doesn't print "Fetching origin" all the time
Review URL: https://chromiumcodereview.appspot.com/10668020
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@143898 0039d316-1c4b-4281-b951-d872f2087c98
First, the environment variable for the child process was created but not
specified to subprocess.call().
Second, third_party/logilab/__init__.py tried to initialize itself with
pkg_resources.
TBR=chrisha@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10582031
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@143111 0039d316-1c4b-4281-b951-d872f2087c98
This CL adds pylint (and its dependencies) to third_party. It plumbs them into presubmit_canned_checks, and exposes a command-line tool to access pylint.
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10447014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@143016 0039d316-1c4b-4281-b951-d872f2087c98
This is backwards compatible, and should be done prior
to upgrading repo's internals to 1.9.4.
BUG=chromium-os:31841
TEST=manual validation
Review URL: https://chromiumcodereview.appspot.com/10541155
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@142238 0039d316-1c4b-4281-b951-d872f2087c98
Enable copy detection for git-cl upload. This makes
it possible to copy a directory containing many files,
add+commit the new path, and then upload a patch to
Rietveld that shows the files were copied.
In my tests, -C -C was needed to pick up a basic
file copy. -C was not enough. I'm not sure why
exactly. The output generated in the diff looks
like:
sh$ git diff -C -C HEAD~1..HEAD
diff --git a/slave/Makefile b/slave2/Makefile
similarity index 100%
copy from slave/Makefile
copy to slave2/Makefile
...
(This change requires r141676 /
https://chromiumcodereview.appspot.com/10543116/ which
updates upload.py to use --find-copies-harder.)
R=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10545107
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@141689 0039d316-1c4b-4281-b951-d872f2087c98
The effect of this is to preserve the behavior of `git status`,
i.e., only changes in the top-level repository will be reported.
Updated test expectations; I have no idea what I'm doing.
Review URL: https://chromiumcodereview.appspot.com/10454088
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140396 0039d316-1c4b-4281-b951-d872f2087c98
Enable copy detection for git-cl upload. This makes
it possible to copy a directory containing many files,
add+commit the new path, and then upload a patch to
Rietveld that shows the files were copied.
In my tests, -C -C was needed to pick up a basic
file copy. -C was not enough. I'm not sure why
exactly. The output generated in the diff looks
like:
sh$ git diff -C -C HEAD~1..HEAD
diff --git a/slave/Makefile b/slave2/Makefile
similarity index 100%
copy from slave/Makefile
copy to slave2/Makefile
...
Review URL: https://chromiumcodereview.appspot.com/10412027
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@140314 0039d316-1c4b-4281-b951-d872f2087c98
While this is not yet necessary, it could be soon and I prefer to do this before
too many people uses it since it breaks everyone.
R=cmp@chromium.org,groby@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10440030
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138886 0039d316-1c4b-4281-b951-d872f2087c98
So that a command like
"git config rietveld.viewvc-url http://src.chromium.org/viewvc/chrome?view=rev&revision="
works fine.
Fix the description automatically generated for the hooks to be using the same
code than for the one presented to the user.
R=cmp@chromium.org
BUG=
TEST=Tested manually on cygwin, win32, linux
Review URL: https://chromiumcodereview.appspot.com/10447021
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138874 0039d316-1c4b-4281-b951-d872f2087c98
These files are created when using msysgit and git-cl on Windows.
R=cmp@chromium.org
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10440016
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138872 0039d316-1c4b-4281-b951-d872f2087c98
No space between -- and merge.
Review URL: https://chromiumcodereview.appspot.com/10428002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138562 0039d316-1c4b-4281-b951-d872f2087c98
on http://codereview.appspot.com/6221063/ which makes sure that rietveld will
upload non-image binary files.
BUG=23608
TEST=Use apply_issue.py with an issue that contains binary files, and make
sure the files download correctly.
Review URL: https://chromiumcodereview.appspot.com/10422006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138472 0039d316-1c4b-4281-b951-d872f2087c98
BUG=None
TEST=gcl upload now uploads any type of binary file, not just images.
Review URL: https://chromiumcodereview.appspot.com/10332313
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@138469 0039d316-1c4b-4281-b951-d872f2087c98
Merge upstream master.
- Includes -V option to see current ninja version (120514).
- Faster build_log loading.
TBR=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10386135
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@137074 0039d316-1c4b-4281-b951-d872f2087c98
correctly. Also fix git_cl.py.
BUG=None
TEST=Make sure that the -m command line option to gcl upload/git cl upload
does not add a new message to the rietveld issue. The string associated to the
--message argument should only be used as the patchset title.
Review URL: https://chromiumcodereview.appspot.com/10384150
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136922 0039d316-1c4b-4281-b951-d872f2087c98
converts -m and --message to -t.
BUG=None
TEST=When uploading a patch to rietveld, make sure no new message is added to
the CL.
Review URL: https://chromiumcodereview.appspot.com/10384131
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@136861 0039d316-1c4b-4281-b951-d872f2087c98
- Nico's improvements to memchr; didn't help perf on Windows, but to avoid diverging.
- Fix bug in ninja-deplist-helper that could cause crash when growing database
sometimes.
Review URL: https://chromiumcodereview.appspot.com/10377038
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@135743 0039d316-1c4b-4281-b951-d872f2087c98
maruel@chromium.org
bauerb@chromium.org
szager@chromium.org
scottmg@google.com
scottmg@chromium.org
chrisha@chromium.org
chrisha@google.com
ferringb@google.com
cmp@chromium.org
ukai@chromium.org
tony@chromium.org
rogerta@chromium.org
szager@google.com
zork@chromium.org
erg@chromium.org
rsleevi@chromium.org