This allow using "fetch ios_internal" to setup a repository for Chrome
on iOS (this still requires being a Google employee as this fetch a
private downstream repository).
The repository URL was already public as it is in every public bug that
is linked from a downstream CL, e.g. http://crbug.com/459705#c115.
BUG=None
Review-Url: https://codereview.chromium.org/2028413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300689 0039d316-1c4b-4281-b951-d872f2087c98
With this change, we can run chromium tryjobs for changes to catapult.
R=tandrii@chromium.org, nednguyen@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2030623002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300688 0039d316-1c4b-4281-b951-d872f2087c98
It used to clear just issue number and patchset, but that's not
all state that associates a given branch with codereview site.
R=andybons@chromium.org
BUG=609295
Review-Url: https://codereview.chromium.org/2032433003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300683 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a bug when issue was incorrectly over-written
in another branch. Add a test case.
* Refactor for better flow.
* Update outdated errors on wrong arguments.
BUG=616105
R=andybons@chromium.org,sergiyb@chromium.org
Review-Url: https://codereview.chromium.org/2022183003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300681 0039d316-1c4b-4281-b951-d872f2087c98
Otherwise, the program continues, and an exception is printed.
The message is still there, but easy to miss.
R=andybons@chromium.org
BUG=
Review-Url: https://codereview.chromium.org/2004303003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300674 0039d316-1c4b-4281-b951-d872f2087c98
The change in https://codereview.chromium.org/1982243002
didn't take into account that the script runs on the actual
bot OS, so Windows will have backslashes as dir separators.
BUG=438952
Review-Url: https://codereview.chromium.org/2021783003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300672 0039d316-1c4b-4281-b951-d872f2087c98
BUG=591814
TEST=gclient sync prints the correct report locally
when config is wrong.
Review-Url: https://codereview.chromium.org/2018803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300671 0039d316-1c4b-4281-b951-d872f2087c98
The old hammer entry points and use of scons for chromium is long gone.
Dropping it.
BUG=None
TEST=None
R=dpranke@chromium.org
Review-Url: https://codereview.chromium.org/2016053004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300667 0039d316-1c4b-4281-b951-d872f2087c98
Previously, git cl upload would send email every time.
This CL changes that to send email only if -s or --send-mail is given.
R=andybons@chromium.org
BUG=612728
Review-Url: https://codereview.chromium.org/2007873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300662 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/57ddcf7e783c42d00574fa17caf0324c1c48e0a2 Set SEM_FAILCRITICALERRORS as well. (iannucci@chromium.org)
R=dpranke@chromium.org,iannucci@chromium.org,martiniss@chromium.org,tansell@chromium.org
BUG=522396
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/2007673005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300661 0039d316-1c4b-4281-b951-d872f2087c98
Lets you get CL tags for a given CL.
BUG=591172
Review-Url: https://codereview.chromium.org/1915833003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300658 0039d316-1c4b-4281-b951-d872f2087c98
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)
recipe_engine:
https://crrev.com/0617526e048a61e76599cc8588bf79ebae6369b6 Update links to build_limited (agable@chromium.org)
R=agable@chromium.org,sergiyb@chromium.org,iannucci@chromium.org
BUG=600447
TBR=martiniss@chromium.org,phajdan.jr@chromium.org
Review-Url: https://codereview.chromium.org/1998123003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300657 0039d316-1c4b-4281-b951-d872f2087c98
The --extra_patchlevel flag was added in
https://codereview.chromium.org/1988583002/
In order to make it possible for WebRTC patches to apply in
src/third_party/webrtc of a Chromium checkout, one directory
level needs to be trimmed.
BUG=438952, 611808
Review-Url: https://codereview.chromium.org/1982243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300618 0039d316-1c4b-4281-b951-d872f2087c98
'git apply' works on Git indexes, so it's not possible
to apply a patch to src/third_party/webrtc with cwd=src/third_party.
Instead, set the cwd to the correct dir and add an extra patch
level using the new flag in https://codereview.chromium.org/1988583002/
This essentially reverts https://codereview.chromium.org/1977373002/
+ sets the project path correctly to src/third_party/webrtc.
BUG=438952
Review-Url: https://codereview.chromium.org/1984993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300616 0039d316-1c4b-4281-b951-d872f2087c98
This will make it possible to cut away additional
levels of directories when applying patches from repos
that have a different directory hierarchy than Chromium.
BUG=438952
TESTED=Executed successfully in a local checkout using
(cwd was the dir above src/):
~/depot_tools/apply_issue.py --root_dir src/third_party/webrtc --issue 1978193002 --server https://codereview.webrtc.org --force --ignore_deps -v -v --no-auth --patchset 20001 --extra_patchlevel=1
Review-Url: https://codereview.chromium.org/1988583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300615 0039d316-1c4b-4281-b951-d872f2087c98
This will have the revision set properly to 'HEAD' before attempting
to apply the patch.
It should also solve the problem that analyze is ending up with
no changes when running 'git diff'.
Expectation update in: https://codereview.chromium.org/1984673002
BUG=438952
Review-Url: https://codereview.chromium.org/1977373002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300603 0039d316-1c4b-4281-b951-d872f2087c98
After the deletion of page_cycler.morejs benchmark, these are the only two
gclient configs we need across chromium.perf, chromium.perf.fyi, and
tryserver.chromium.perf. Rename from "perf" to "chromium_perf" to match chromium
config. This CL will be followed up with one to delete "perf".
BUG=611484
Review-Url: https://codereview.chromium.org/1976843002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300600 0039d316-1c4b-4281-b951-d872f2087c98
This reverts commit 3f0dacf095.
Reason for revert:
Is causing staged changes to be reverted.
BUG=607913
TBR=hinoka,dnj
Review URL: https://codereview.chromium.org/1983963002 .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300598 0039d316-1c4b-4281-b951-d872f2087c98
Test case being added in https://codereview.chromium.org/1984623002/
NOTICE:
* Only patches from the webrtc/ subdirectory in a standalone
WebRTC checkout will work, since the root is set to src/third_party.
This can be changed once http://crbug.com/611808 is fixed.
* The Chromium checkout will be synced to the DEPS-pinned revision
of WebRTC. Changing this to HEAD will be addressed in a future CL.
BUG=438952
Review-Url: https://codereview.chromium.org/1976243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300588 0039d316-1c4b-4281-b951-d872f2087c98
I often ends up with a corrupt toolchain because I've used Windbg and there's now a bunch of PDB files in win_sdk/Debuggers/sym/... , I think that it's safe to ignore these files (the original package doesn't contain any of these files).
It's also useful to have more details about which files are missing and or which ones shouldn't be here when we get an invalid toolchain hash.
Finally, if you the hash of a toolchain doesn't correspond to the name of its root directory then it should be removed.
Review-Url: https://codereview.chromium.org/1974453003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300557 0039d316-1c4b-4281-b951-d872f2087c98
This change adds a --override option to the VC++ packaging script so
that an arbitrary bin/include/lib containing directory can be used to
package up those components of VC++. See this post for details:
https://blogs.msdn.microsoft.com/vcblog/2016/02/16/try-out-the-latest-c-compiler-toolset-without-waiting-for-the-next-update-of-visual-studio/
Typical usage is like this:
package_from_installed.py 2015 --override <projdir>\packages\VisualCppTools.14.0.24109-Pre\lib\native
In order to make this work the path tuple support was fixed so that the
local relative path was propagated to the destination path, instead of
just the file name.
At the same time, the code to package up the UCRT installers was deleted
because it isn't needed, and windows.winmd is filtered out because it
makes consistent package creation impossible (it is different on every
machine).
While removing the UCRT installers I discovered nested if VS_VERSION
checks. Oops. Fixed.
BUG=440500
Review-Url: https://codereview.chromium.org/1967653002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300527 0039d316-1c4b-4281-b951-d872f2087c98
This was breaking presubmit because the linked gae_ts_mon subdir was absent.
R=andybons@chromium.org, dsansome@chromium.org, dnj@chromium.org
BUG=608490
Review-Url: https://codereview.chromium.org/1959193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300511 0039d316-1c4b-4281-b951-d872f2087c98
recipe-roller@chromium.org
tandrii@chromium.org
sdefresne@chromium.org
dpranke@chromium.org
dsansome@chromium.org
clemensh@chromium.org
kjellander@chromium.org
levarum@chromium.org
nodir@chromium.org
iannucci@chromium.org
bradnelson@chromium.org
phajdan.jr@chromium.org
agable@chromium.org
martiniss@chromium.org
dtu@chromium.org
smut@google.com
sebmarchand@chromium.org
brucedawson@chromium.org
hans@chromium.org