aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,374 Commits
6 Branches
0 Tags
185 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '6154fb127e'
${ noResults }
Commit Graph

6374 Commits (6154fb127e5cb4d9e7acfcabf2551566ad66f5cc)
 

Author SHA1 Message Date
recipe-roller 6154fb127e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/beadb7584b9086527329b8054230344de88d1873 Revert "[futures:examples/background_helper] Speculatively switch to os._exit" (tandrii@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idd63dd43eb571e5cb5b2170fadb29ea5cf73df17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1836181
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Michael Moss 6b4c2a88f3 Run git_cl commands as a python step. 
Otherwise this fails on Windows because git_cl.py "is not a valid Win32
application".

R=gbeaty@google.com, iannucci@google.com

Bug: 726111
Change-Id: I4b9fea6b5271241e14407aeab175ce73d1ee8349

Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: release_scripts
Recipe-Nontrivial-Roll: infra
Change-Id: I4b9fea6b5271241e14407aeab175ce73d1ee8349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835598
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
recipe-roller 2458b31208 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/39baf65a40b3d08e7cd414493fe607eaf18637d0 [futures:examples/background_helper] Speculatively switch to os._exit (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6aec1774291320d3efcb98badb2ca14895615750
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835593
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller d9682cc2dc Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/88c098c1d36351d6b551c604122ddb27236b2038 [step] Improve cost model to cover memory, disk and network resources, too. (iannucci@chromium.org)
  https://crrev.com/b82054e1d929cdff567df166edf927361181bf67 Revert "[step] Improve cost model to cover memory, disk and network resources, too." (iannucci@chromium.org)
  https://crrev.com/ba63a44cf653ce3c0689eb83c9e1e1ac9c56cd19 [step] Reland: Improve cost model to cover memory, disk and network resources, too. (iannucci@chromium.org)
  https://crrev.com/1420284b2c0f4907392b8381d60fcb72d3a2faa9 [stream/luci] Initially mark steps as SCHEDULED. (iannucci@chromium.org)
  https://crrev.com/7323ee69d6f28d139a8713e9c4d89dbe10f3ac4e [third_party/logdog] Remove defunct features. (iannucci@chromium.org)
  https://crrev.com/343724f653bf18d849d16fb07d0050a4ea7d93cc [luciexe] Make butler streams async, throttle build.proto updates. (iannucci@chromium.org)
  https://crrev.com/76efe56b109dde457e2a2dec61923759bd21083c [luciexe] Mark non-subprocess steps as started, too :) (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib87050a805a3811639d43196f0451e0992a91e58
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835050
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Andrii Shyshkalov 2025b98401 recipes: update to stop using legacy properties. 
The only exception is 'revision' of gclient's weird RevisionResolver,
which will be tackled in https://crbug.com/949334

R=ehmaldonado

Bug: 877161
Change-Id: Ic65a2d13578802cf093f2a1cfb4002fe97509b3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818973
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
 6 years ago
Edward Lemur 5eac9d3013 depot_tools: Fix bug when running download_from_google on Python 3. 
Issue caused by utf-8 vs byte mismatch in python 3.

Bug: 1009698
Change-Id: I8ab6b129ea9ab18f06f8ff4eb5da3aa018829365
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1832773
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
 6 years ago
Edward Lesmes 451e8babe2 depot_tools: Fix gclient_test on Windows. 
Bug: 1007580
Change-Id: I8265b3f4e64b95d7f107b50eb8c68983d6002468
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1828080
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
 6 years ago
Edward Lemur b9aca9494e gclient: Skip calling update_depot_tools if DEPOT_TOOLS_UPDATE is 0. 
Change-Id: Id33839077b3bc8748185d93ab13ed028a05b7fd1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825994
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Bruce Dawson f1b21e4633 Make gclient.py warn on Python 3 
An increasing number of Windows developers are "accidentally" ending up
with Python 3 installed on their machine through the Windows Store. If
this version is first in the path then gclient may fail in non-obvious
ways. This adds a python version check to give a clear warning message.

R=vapier@chromium.org

Change-Id: I7a292fba2ab7d059a6149644d0b1fd92d2371dce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825945
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
 6 years ago
Quinten Yearsley a19d35307b Add `git cl upload --retry-failed` 
The expected behavior is that for CLs that were already uploaded
before, where some tryjobs were run and failed, git cl upload
--retry-failed will be kind of like git cl upload --cq-dry-run
except it will only trigger tryjobs that failed.

Bug: 985887
Change-Id: I6371bca3ba501b1ea2cd7160e2f933530d7e633f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1828322
Auto-Submit: Quinten Yearsley <qyearsley@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Mirko Bonadei cbff54b4ac Fail to repackage if win_sdk\Debuggers doesn't exist. 
This is easy to miss and a toolchain package without win_sdk\Debuggers
will not work as expected so this CL adds a check to stop the
packaging/repacking process as soon as possible.

Bug: 1006238
Change-Id: I272fbaf3e1cbde48a3e260e38e34ffc10d6c86df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1829272
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 6 years ago
recipe-roller f656f57a36 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/a22f35df63082cd00ab30bb71aa95f30d5745e5f [platform] Fix consistency with cpu_count, add total_memory. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib76d806c6ff7d2ab1c259d9fdf4c0a6f3e831b4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1830311
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 1e9e3d2e9e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9217b5d873035e5f0a4b5c2debe089217432e482 [engine] Fix crash when RECIPE CRASH step name has pipe character. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iac90d9f0cbb87e495798a08640ae16072e691bc3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1830310
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Mike Frysinger 286fb1607d gclient: have git operations specify the git dir by default 
If the .git/ subdir exists and mostly looks OK, but in reality git
doesn't accept it, gclient will blindly run git in the subdir and
think it's operating on the local .git/.  Kind of like:
  $ cd src/third_party/emoji-segmenter/src/
  $ rm -rf .git && mkdir .git
  # This works on the top level src/.git/.
  $ git <operation>

Instead of relying on this automatic git behavior, use GIT_DIR by
default so we force git to only look at that specific checkout.  If
it's broken, git will fail on us (good) instead of silently falling
back to the parent (bad).
  $ cd src/third_party/emoji-segmenter/src/
  $ rm -rf .git && mkdir .git
  $ GIT_DIR=$PWD/.git git <operation>
  <this now hard fails>

Bug: 1000825
Test: `gclient sync -j1` with a broken src/third_party/emoji-segmenter/src/.git/ caused the sync to halt
Change-Id: I777d67cd5daa354b32c424414d93a61b3b600f54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1785957
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Robert Iannucci 0081c0ff17 [git-cache] Add option to update_bootstrap to skip the populate step. 
This will allow us to separate the 'populate' and 'upload' phases
in the git cache updater recipe, which will allow us to do all the
'populate' steps in parallel, but then limit the parallelism of the
`pack/gc/upload` operations.

R=tandrii@chromium.org

Change-Id: I8b8a9155f86350be37ed5a67c592ff1fec4d42ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1830857
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 6 years ago
Edward Lemur 39058571f7 Reland "gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3." 
This is a reland of e656e98831

Original change's description:
> gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3.
> 
> Bug: 1008202
> Change-Id: I23dd70b72089a09c2a7cdc74e2a63c135a924ebe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825996
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1008202
Change-Id: I5181a7f8efb39bdd6adc99db90663cf3cf3cd0bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1828334
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lesmes 69d781151b Revert "Reland "depot_tools: Use vpython to execute fetch."" 
This reverts commit b37784118c.

Reason for revert: <INSERT REASONING HERE>
Skia still has problems

Original change's description:
> Reland "depot_tools: Use vpython to execute fetch."
> 
> This is a reland of 028367fe4a
> 
> Should work on Skia after https://skia-review.googlesource.com/c/skia/+/244116
> 
> Original change's description:
> > depot_tools: Use vpython to execute fetch.
> >
> > Bug: 1002153
> > Change-Id: I11286bebc23bedada239d6ddb8ebb86207a41485
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815707
> > Reviewed-by: Anthony Polito <apolito@google.com>
> > Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> > Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
> 
> Bug: 1002153
> Change-Id: Ifdde3c4a817ab6ca222c82c5448d630e85bf2a4b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827719
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,jcgregorio@chromium.org,apolito@google.com

Change-Id: I1963c5bccf36692209dfe10aa30d77650e40c6f1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1829971
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lemur b37784118c Reland "depot_tools: Use vpython to execute fetch." 
This is a reland of 028367fe4a

Should work on Skia after https://skia-review.googlesource.com/c/skia/+/244116

Original change's description:
> depot_tools: Use vpython to execute fetch.
>
> Bug: 1002153
> Change-Id: I11286bebc23bedada239d6ddb8ebb86207a41485
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815707
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

Bug: 1002153
Change-Id: Ifdde3c4a817ab6ca222c82c5448d630e85bf2a4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827719
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lesmes 2b82936829 Revert "gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3." 
This reverts commit e656e98831.

Reason for revert: Defaults to Python 3 unless GCLIENT_PY3 is 1...

Original change's description:
> gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3.
> 
> Bug: 1008202
> Change-Id: I23dd70b72089a09c2a7cdc74e2a63c135a924ebe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825996
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

TBR=ehmaldonado@chromium.org,apolito@google.com

Change-Id: I8c63d8c9e0be84b1286275142fab1885597b1551
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1008202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1828330
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lemur e656e98831 gclient: Add a GCLIENT_PY3 env var to allow users to execute gclient using Python 3. 
Bug: 1008202
Change-Id: I23dd70b72089a09c2a7cdc74e2a63c135a924ebe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825996
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Mirko Bonadei e4174f483e Add VS 2019 support to package_from_installed.py. 
This CL also removes VS 2015 support.

Bug: 1006238
Change-Id: Ib05b3d211341fcd5805c3acca3bc4c0aa894831d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1823961
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
 6 years ago
recipe-roller e37b1ec5e4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/210148729e3ecd749cdfc83a1a4e874c04b84f84 delete unused argument (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic61ec4725e5a3ef46bbe411323eefd1fb7a8a411
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827720
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Edward Lemur bbd70fd7b9 depot_tools: Enable more tests for windows. 
Bug: 1007580
Change-Id: Ic407566149f78a8de5f173ae4c8726fc25834b8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1750146
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Quinten Yearsley 983111f039 Add `git cl try --retry-failed` 
Bug: 985887
Change-Id: I5aab64a21961ea8f57d77f6523f2ddc5f74e78a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818624
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 6 years ago
recipe-roller 1ab7b6816f Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/d0b2d249e189cfec7a051393a095031d6427f193 Refactoring Context API (liviurau@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa49f1a9b7daacbd2488c953fd182bc03cc538a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827477
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller f45fc45e7e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/1e7de3da0e9935baa8bd6ff46e410846728643a0 [luciexe] Use proper base log name for url. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2282b466dd2cb99400b647b7f42fcf1d7d476c61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827079
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 43d1c05fe4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bdb99d9b9906a2abfdf8965e4889a63462fd049e Expose ability to explicitly close currently open step to userspace. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5af3225bbc5fd6359a302c5d3dd8c8968b3290b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1827077
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 07cec8f6cb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bb7ba6bbd413d490ff7a74bcf1bbfcfa7247ae5c [luciexe] Protocol updates/fixes. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4ac2e2d6fac5cc53760a19154bdbfbf48acfa087
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825911
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 731ce5cd88 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/53f8e3450bf14f7bad9c585a4b9d6cf49768e72f [protos] Generalize update script and update protos. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia6d0ecf1fcbc643d48cd7ef375e2addfdf6d8ad5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825910
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Edward Lemur 9a5bb612e6 git-cl: Make Ctrl+C work again. 
Bug: 961724
Change-Id: I4fc8f86c02fb53310c5967284594ba1fbbbcbafc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1826054
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 6 years ago
Edward Lemur f0faf48ddb git-cl: Set legacy properties. 
Will be removed back again on Oct 9, 2019.

Bug: 1004447
Change-Id: I7003fac9ae8b184e2a7073b516535e8fd599f4f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825446
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 6 years ago
Victor Costan 69b63c9f97 Fix sys.platform mapping in download_from_google_storage.py. 
Relevant documentation: https://docs.python.org/3/library/sys.html#sys.platform

Bug: 1007872
Change-Id: Id4bb6e1da1d3244fcd245569fd74fd204ce1e9ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1824843
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Victor Costan <pwnall@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
recipe-roller 6a5cb2517a Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/92e5e4828b44e502f549181cfc9aeebbbaf0ba7a cipd: link directly to created package on chrome-infra-packages. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I23c457fa5248378b2fc9894fd3e46cf2a692d925
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1825693
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Robert Liao 7211cf6444 Import gclient_utils for gclient_paths CheckCallAndFilter 
CheckCallAndFilter isn't part of the global namespace, and as a result,
this call was silently failing.

BUG=1007553

Change-Id: Ie2f3135fc3d56be189d8be0fe996a068e0645705
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1823664
Auto-Submit: Robert Liao <robliao@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
 6 years ago
Edward Lesmes d48cbf9345 Revert "depot_tools: Use vpython to execute fetch." 
This reverts commit 028367fe4a.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> depot_tools: Use vpython to execute fetch.
> 
> Bug: 1002153
> Change-Id: I11286bebc23bedada239d6ddb8ebb86207a41485
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815707
> Reviewed-by: Anthony Polito <apolito@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>

TBR=tandrii@google.com,ehmaldonado@chromium.org,apolito@google.com

Change-Id: I0924e77a3862b8a75195db7fe719286e1cb3ac7e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1002153
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1824217
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lemur 028367fe4a depot_tools: Use vpython to execute fetch. 
Bug: 1002153
Change-Id: I11286bebc23bedada239d6ddb8ebb86207a41485
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815707
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lemur 4c707a2c53 git-cl: Re-write some tests to use mock. 
I think this makes tests easier to read and write.

Change-Id: I9430a5d40e3466ff2a24b6b40253419aea3f30b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1820034
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Anthony Polito 8b95534d33 [git-cl] allow setting the bug during force mode 
Bug: 1001709
Change-Id: I53e7699cb38d810d0a8c88d40907bf249174ad8b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1804603
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>
 6 years ago
Edward Lemur ba5bc99b6a auth: Use luci-auth to get credentials. 
Bug: 1001756
Change-Id: Ieab5391662e92ec9e2715a81fce2cef41717c2e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1790607
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
 6 years ago
Quinten Yearsley 3841eaa164 Remove unused imports in depot_tools/*.py 
I know that sometimes imports can have side-effects,
so unused imports shouldn't always be removed, but these
ones look like they could be.

Change-Id: Iea9f82afa99b0ea35f29a28f20ce0493b579cfee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819860
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
 6 years ago
Edward Lemur 6f18e68719 gclient: Execute python hooks using vpython. 
Change-Id: I032c838c07ca8b715976bd9dc428c1bd6a77d80b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1793009
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Andrii Shyshkalov fdb59f0d90 Revert "git-cache: don't limit pack files to 2GiB." 
This reverts commit 82ae4b4b7d.

Reason for revert: didn't help. Something else limits 'git gc' by 2GB.
However, even so, total amount of .pack files for chromium/src is <7.5GB.

Original change's description:
> git-cache: don't limit pack files to 2GiB.
>
> This is only relevant to 1 builder which updates git cache bundles.
> Since some time in 2018-2019, it started creating several 2GiB packs
> for chromium/src. I verified that the setting affecting it is
>   core.deltaBaseCacheLimit
>
> Log file of a build which I observed while ssd-ed into the machine (internal):
>   https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8901682638839779824/+/steps/Updating_https:__chromium.googlesource.com_chromium_src/0/stdout
> Git version: version:2.21.0.chromium16
>
> R=​ehmaldonado
>
> Change-Id: I52cadfb9f34faea09a57d53387cab7e0538362b9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818076
> Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

TBR=tandrii@google.com,ehmaldonado@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I24915555c703bc92fda921524820405de5d69f7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1817101
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Ryan Harrison 06e1869f2b Add Dawn to projects for my_activity.py 
Change-Id: Id22cde5b5c113fb1145c30afb6671ac2ec32afb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819547
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Quinten Yearsley 90a67e2fc1 Remove some unused private things in git_cl 
There are many functions in git_cl that appear unused, although
it's possible that some of them are used in other places, where
git_cl may be imported as a library.

This CL just removes some of the private ones, which at least
were not supposed to be used from other places.

Things removed here:

 - _get_commiter_timestamp
 - _git_amend_head
 - GitCookiesChecker._get_usernames_of_domain
 - constants MERGE_BRANCH, CHERRY_PICK_BRANCH;
   the comment says that these are supposed to
   be used in CMDland, but apparently they aren't.
   contextlib which is only used by this, is also
   removed
 - CodereviewSettingsFileMock in git_cl_test;
   it is not used anywhere in the test, and I
   assume that nobody's importing and using
   git_cl_test...

git_cl_test still passes, git cl seems to still work

Change-Id: Ib8eee0dfb181c8cda04c0894d2daea52b3ad42ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818621
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
 6 years ago
recipe-roller 314adcb844 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/494a88f6f8c345512a5dbb9136ca99ab10bc6dd5 Convert entire tricium Results message to JSON only once (garymm@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I23d06ccdd70f5e03f6e81574c05a06fb5d192d4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1819539
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller b5578f4f0b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e8d0b68df47a63f3a184f64c138404a139e046ed [swarming] expose current bot_id and task_id on api.swarming. (tandrii@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I02270fd71a462c1b3a342e851baef35af27ec655
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818976
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Andrii Shyshkalov 7cb60e812f git-cache: fix bug in prior CL. 
cwd param isn't necessary, because actual cwd is already correct --
see 'git gc' invocation below.

R=ehmaldonado, iannucci

Change-Id: Ia885ad32b11b0de37d3b0e4e5359d2031b6852d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818455
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
Andrii Shyshkalov 82ae4b4b7d git-cache: don't limit pack files to 2GiB. 
This is only relevant to 1 builder which updates git cache bundles.
Since some time in 2018-2019, it started creating several 2GiB packs
for chromium/src. I verified that the setting affecting it is
  core.deltaBaseCacheLimit

Log file of a build which I observed while ssd-ed into the machine (internal):
  https://logs.chromium.org/logs/infra-internal/buildbucket/cr-buildbucket.appspot.com/8901682638839779824/+/steps/Updating_https:__chromium.googlesource.com_chromium_src/0/stdout
Git version: version:2.21.0.chromium16

R=ehmaldonado

Change-Id: I52cadfb9f34faea09a57d53387cab7e0538362b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1818076
Auto-Submit: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Raul Tambre 383f6cf02d gclient_utils: Actually pass the include_zero parameter to Annotated constructor 
Change-Id: I3d1e155ed2b6c4b4d6549bfb609358538dcdcd0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815868
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Raul Tambre a79f0e50bb tests/gclient_scm_test.py: Fix invalid escape sequences in regex strings 
Note that on line 504 I also fixed the test on windows by allowing \. Also properly escaped /.

Errors:
C:\Google\depot_tools\tests\gclient_scm_test.py:42: SyntaxWarning: invalid escape sequence \[
  TIMESTAMP_RE = re.compile('\[[0-9]{1,2}:[0-9]{2}:[0-9]{2}\] (.*)', re.DOTALL)
C:\Google\depot_tools\tests\gclient_scm_test.py:504: SyntaxWarning: invalid escape sequence \.
  "breaking lock.*\.git/index\.lock")

Bug: 958138
Change-Id: I19ef98538a1c172d7139ca2d7097a7fbc33ebe80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1815866
Commit-Queue: Raul Tambre <raul@tambre.ee>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Raul Tambre <raul@tambre.ee>
 6 years ago