maruel@chromium.org
b044218cca
Fix gcl in the case there is no CODEREVIEW_SETTINGS file in the repository.
...
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118265
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17727 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
laforge@chromium.org
85532fc2e5
Added some new functionality to gcl:
...
- Create a new parameter for "gcl change 12354 <filename>" to read comments from a text file. This allows us to programmatically inject comments into a gcl upload
- Added helper methods in change to order of which other_files have changed (brings changed files to the top of the list). This makes it easier to find which files have change, and simply cut and paste the top of the list (after many merges, the list of unmodified files grows to be quite extensive... very useful)
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17684 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
4661e0c77b
The broken PRESUBMIT.py was fixed so reintegrating revision 17554 (which was good in the first place).
...
BUG=none
TEST=none
TBR=joi
Review URL: http://codereview.chromium.org/119130
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17578 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0018e7313d
Seems like revision 17554 busted the presubmit scripts, reverting.
...
TEST=None
BUG=None
TBR=joi
Review URL: http://codereview.chromium.org/119122
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17561 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
8b40a9b81b
Fix ListRelevantPresubmitFiles().
...
It was affected by the current directory!
Review URL: http://codereview.chromium.org/119101
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17554 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
143993e97b
Fix gcl unit tests.
...
Review URL: http://codereview.chromium.org/118159
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17488 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1ab7ffcce9
Fix gclient config with a trailing backslash.
...
Review URL: http://codereview.chromium.org/118160
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17487 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
d6f5181c49
Delete the git-cl and git-try copies
...
Review URL: http://codereview.chromium.org/114076
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17486 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
3b217f537f
Remove the tree open check since it's now a presubmit script.
...
Review URL: http://codereview.chromium.org/115996
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17330 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1bb04aa1c0
Remove the use of --non-recursive flag.
...
Review URL: http://codereview.chromium.org/115994
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17328 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
ca14c12a62
Rewrite the presubmit test to be much more hermetic.
...
Review URL: http://codereview.chromium.org/115964
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17314 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
388f1d2656
Save 50 lines by converting the unit test to mox.MoxTestBase.
...
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/118019
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17215 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
b76227689c
Convert gclient_test.py to mox.MoxTestBase and saves 40+ lines
...
Review URL: http://codereview.chromium.org/118014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17213 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
f669982a2b
Use os.path.join() instead of hardcoding /
...
Review URL: http://codereview.chromium.org/115926
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17206 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
77c4f0f135
Remove SVN-specific function InputApi.FilterTextFiles().
...
Review URL: http://codereview.chromium.org/115923
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17202 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
15bdffa063
Make AffectedFile member variables private.
...
Cache SvnAffectedFile.IsTextFile() return value.
Improve the unit test by not/less relying on the local file system.
Review URL: http://codereview.chromium.org/113964
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17180 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
skylined@chromium.org
df0032c057
Add code to handle errors in .gclient configuration files and output human readble information rather than a raw exception stack.
...
Review URL: http://codereview.chromium.org/113968
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17179 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
786886257e
warnings.catch_warnings() is only available on python 2.5
...
Review URL: http://codereview.chromium.org/115881
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17114 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1e08c00d60
Add AffectedFile.IsTextFile() and deprecate AffectedTextFiles().
...
Make DepotToLocalPath() and LocalToDepotPath() not static. It is necessary for a subsequent change since I need to factor out it's SCM assumption.
Review URL: http://codereview.chromium.org/113933
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17091 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
6ebe68a73d
Make the member variable 'protected' in the python sense.
...
Review URL: http://codereview.chromium.org/113899
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@17039 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e1a524ff00
Remove SPECIAL_KEYS and GclChange.Changelist() to simplify the code.
...
Review URL: http://codereview.chromium.org/113883
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16983 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
f3eee5692c
Add a unit test for input_api.change.tags.
...
Review URL: http://codereview.chromium.org/113859
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16959 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
ce30ef7ceb
Fix the PRESUBMIT.py for depot_tools.
...
Ironically, it was broken.
Review URL: http://codereview.chromium.org/115679
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16856 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
9711bbafde
Add InputApi.version so the presubmit script can mark a minimum supported version for instance.
...
BUG=None
R=joi
Review URL: http://codereview.chromium.org/115719
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16819 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
dbbeedc691
Factor out SVN-specific methods out of AffectedFile.
...
TEST=New unit tests.
BUG=None
Review URL: http://codereview.chromium.org/113783
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16785 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
73e36ed387
Fix AffectedFile.IsDirectory() to use the right path.
...
BUG=gcl commit doesn't show any "svn: 'bleh' is not a working copy" error
R=jam
Review URL: http://codereview.chromium.org/113782
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16781 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0ff1fab804
Add repository root presubmit support.
...
Review URL: http://codereview.chromium.org/115616
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16738 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
657aaf250d
When the svn diff output (on Windows) is sent as a single POST and
...
some of the files have attribute changes, the server responds with a
list of files where the files with attribute changes have backslashes
(as they do in the svn diff output). Fix this in the client.
A server-side fix might also be nice; where does the server-side code live?
BUG=none
TEST=none
Patch contributed by Joi.
Review URL: http://codereview.chromium.org/112050
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16688 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
053ba90ed1
Use the --non-recursive flag when committing.
...
BUG=12339
TEST=see bug for repro steps.
Review URL: http://codereview.chromium.org/113709
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16620 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
98fc2b9bf6
Add support to cache arbitrary file.
...
Rename repository_root to REPOSITORY_ROOT.
Review URL: http://codereview.chromium.org/115615
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16598 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
374d65e518
Move the changelist files into a subdirectory for cached files implementation.
...
Review URL: http://codereview.chromium.org/115612
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16597 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
672343d7f4
Fix the print_error parsing, which caused spurious errors on gcl usage.
...
Review URL: http://codereview.chromium.org/113656
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16513 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
8c3ccf39eb
Fix error printing in gcl.GetRepositoryRoot() and fix its unit tests.
...
Review URL: http://codereview.chromium.org/113650
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16499 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
003c269b98
When -s or --server is used, don't try the patch.
...
Review URL: http://codereview.chromium.org/115534
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16477 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e9dd73ce1e
Fix upload.py with git when diff.external is set.
...
Review URL: http://codereview.chromium.org/113586
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16476 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
7b305e8c18
Add new presubmit check RunPythonUnitTests.
...
Review URL: http://codereview.chromium.org/115516
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16390 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
5771f2622c
Clean up revert.py and fixes an issue when only one file is reverted in a subdirectory.
...
Add a basic unit test.
Review URL: http://codereview.chromium.org/115514
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16388 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
178d06c779
Sync git-cl and git-try to the master branch.
...
Remove import readline since it is not used and not available on win32
Fix the tempfile.NamedTemporaryFile() handling on win32.
Review URL: http://codereview.chromium.org/113480
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16220 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
3d23524cb0
Add more presubmit support. Add PRESUBMIT.py to depot_tools.
...
Changed InputApi.PresubmitLocalPath() to contain the absolute path without the script name.
Review URL: http://codereview.chromium.org/113354
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16157 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1998c6d137
Raise an human readable exception if an unversioned directory exists.
...
Review URL: http://codereview.chromium.org/115354
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16156 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
2806acc58c
Remove two seams options.gclient and options.scm_wrapper in gclient.
...
Review URL: http://codereview.chromium.org/115322
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16155 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
e08149a25c
Fix revert.py.
...
Review URL: http://codereview.chromium.org/113353
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15977 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
0329e67bae
Remove the options.path_exists which only existed as a seam. It's not really needed in python.
...
Also fix 2 other mocks.
Review URL: http://codereview.chromium.org/115286
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15976 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
1033accb23
Rename presubmit.py to presubmit_support.py to reduce confusion and be able to add a PRESUBMIT.py check into depot_tools.
...
Review URL: http://codereview.chromium.org/113337
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15954 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
c315020307
Fix a regression on svn cp|ren|mv on gcl upload.
...
BUG=11884
Review URL: http://codereview.chromium.org/113341
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15953 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
7196846f83
Change the python.new.bat and svn.new.bat to work around potential dynamic dll loading issues.
...
Review URL: http://codereview.chromium.org/113323
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15938 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
8626ff72df
Finally implement the code to automatically switch checkout when there is no local modification.
...
Bail off as soon as there is anything showing up on svn status.
TBR=sgk
Review URL: http://codereview.chromium.org/113319
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15929 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
maruel@chromium.org
39593706a7
Fix unit test due to change r15911.
...
TBR=estade
Review URL: http://codereview.chromium.org/115283
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15928 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
estade@chromium.org
3bcc6cebff
Pass "gcl help upload" to upload.py.
...
Review URL: http://codereview.chromium.org/113303
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15911 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago
kuchhal@chromium.org
00c41e457b
Add presubmit checks to look for BUG= and TEST= tags in change list description (Part 1 of 2).
...
BUG=11287
TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used.
Review URL: http://codereview.chromium.org/113294
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@15905 0039d316-1c4b-4281-b951-d872f2087c98
16 years ago