Stop using stderr so the output is more readable on buildbot.
Otherwise stderr arrives before stdout in apply_issue step.
TBR=rogerta@chromium.org
BUG=153284
Review URL: https://chromiumcodereview.appspot.com/11038002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159508 0039d316-1c4b-4281-b951-d872f2087c98
Nobody cares about those .orig files and they get in the way on the try server
for some specific license check.
R=cmp@chromium.org
BUG=152507
Review URL: https://chromiumcodereview.appspot.com/10983092
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159329 0039d316-1c4b-4281-b951-d872f2087c98
The try slaves run 'git revert' to clean up from the previous run. This only runs 'git reset --hard', which does not remove any untracked files, so if a CL adds a new file it will still be present after 'gclient revert'. Adding git clean -f -d removes untracked files (-f) and directories (-d).
Review URL: https://chromiumcodereview.appspot.com/10986032
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@159020 0039d316-1c4b-4281-b951-d872f2087c98
For an unknown reason, 'svn propset svn:executable * foo.sh' doesn't work on
Windows. It is even more awkward that 'svn propset svn:executable . foo.sh'
works just fine, in particular, subversion replaces the value, as long as it's
not an empty string, back to '*'.
R=petermayo@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10967071
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158281 0039d316-1c4b-4281-b951-d872f2087c98
if depot tools is in the path.
BUG=149941
Review URL: https://chromiumcodereview.appspot.com/10966042
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@158039 0039d316-1c4b-4281-b951-d872f2087c98
This brings back git cl try to try at LKGR instead of HEAD, which is coherent
with git-try and gcl try.
R=rogerta@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10963013
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157810 0039d316-1c4b-4281-b951-d872f2087c98
can be applied. This is the first part for this bug; the second part is in commands.py where this is called by the TS.
BUG=149941
Review URL: https://chromiumcodereview.appspot.com/10917306
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157355 0039d316-1c4b-4281-b951-d872f2087c98
It runs it by specifying BASE/HEAD to stay at the current revision.
This works around the lack of gclient sync when a DEPS file is applied on the
Try Server when triggered from Rietveld. This was handled my the Try Server
inside scripts/slave/chromium_command.py manually in the case a 'patch' is
specified.
TBR=rogerta@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10918264
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@157110 0039d316-1c4b-4281-b951-d872f2087c98
_check_output_svn sets the cwd to project_path
therefore files should not have project_path.
R=maruel@chromium.org,cmp@chromium.org
BUG=149702
Review URL: https://chromiumcodereview.appspot.com/10909254
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@156953 0039d316-1c4b-4281-b951-d872f2087c98
On both mac and linux, I ran:
git checkout v1.0.0
ninja
./ninja ninja_test
./ninja_test # all passed
strip ninja
Changes since the last push:
* NINJA_STATUS can now print rates via the o and c format chars
* The version switch is now --version, -V no longer works
* -t list now works without a build.ninja
* Old .ninja_log files now trigger a rebuild instead of an error
* Missing .d files make the corresponding .o file dirty
* Allow @ and = in paths in depfiles
* Ninja's output is now lower-case ("error:" instead of "ERROR:" etc)
* Lots of Windows features (which doesn't affect Mac and Linux)
On Linux, I switched from gcc4.4.3 to clang r163126. The clang-built
binary is 125856 bytes (compared to 129944 bytes previously), and it does
an empty 'chrome' build about 70ms faster (0.94s instead of 1.01s).
The speed difference is almost completely in faster depfile parsing:
clang-built (0.943s):
$ time ../../ninja/ninja -C out/Release chrome -d stats
ninja: Entering directory `out/Release'
ninja: no work to do.
metric count avg (us) total (ms)
.ninja parse 716 507.8 363.6
canonicalize str 113486 0.2 27.7
canonicalize path 1305641 0.1 184.1
lookup node 1305641 0.2 200.9
.ninja_log load 1 11144.0 11.1
node stat 37828 2.6 98.0
depfile load 9266 80.9 749.3
path->node hash load 0.98 (48241 entries / 49157 buckets)
real 0m1.162s
user 0m0.980s
sys 0m0.170s
gcc-built (1.013s):
$ time ninja -C out/Release chrome -d stats
ninja: Entering directory `out/Release'
ninja: no work to do.
metric count avg (us) total (ms)
.ninja parse 716 516.4 369.7
canonicalize str 113486 0.2 27.6
canonicalize path 1305641 0.1 181.0
lookup node 1305641 0.2 260.0
.ninja_log load 1 11012.0 11.0
node stat 37828 2.6 98.2
depfile load 9266 86.3 799.3
path->node hash load 0.98 (48241 entries / 49157 buckets)
real 0m1.220s
user 0m0.970s
sys 0m0.240s
On Mac, I alsow used clang r163126. The binary size stayed at 125104 bytes,
performance didn't change. An empty build of chrome takes 1.26s. While
node stat is a bit slower, and there are more defiles to parse compared
to linux, most of the time difference is in slower .ninja parsing:
mac (1.263s):
$ time ../../ninja/ninja -C out/Release/ chrome -d stats
ninja: Entering directory `out/Release/'
ninja: no work to do.
metric count avg (us) total (ms)
.ninja parse 687 823.4 565.7
canonicalize str 115002 0.3 31.1
canonicalize path 1120853 0.2 175.6
lookup node 1120853 0.2 202.9
.ninja_log load 1 54126.0 54.1
node stat 38860 4.1 160.4
depfile load 9649 86.1 830.8
path->node hash load 0.99 (48522 entries / 49157 buckets)
real 0m1.478s
user 0m1.121s
sys 0m0.351s
TBR=scottmg
Review URL: https://codereview.chromium.org/10918242
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@156751 0039d316-1c4b-4281-b951-d872f2087c98
There are several places where we advise people
to use custom_deps with { "foo" : None } to avoid
checking out certain sub-repos. This caused wtf to
crash on startup.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10917220
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@156373 0039d316-1c4b-4281-b951-d872f2087c98
It relied on a behavior that doesn't hold on python 2.7 anymore w.r.t. tuple
comparison to non-tuple objects.
Now be explicit about having source files to be first.
R=rogerta@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10915240
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@156355 0039d316-1c4b-4281-b951-d872f2087c98
Thin wrapper to process --bot and --testfilter to keep compability with gcl try
and git-try and pass the data directly to Rietveld.
R=rogerta@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10916118
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@155176 0039d316-1c4b-4281-b951-d872f2087c98
This is mainly to reduce the spam that the commit queue adds to
commit-bot@chromium.org as all follow up emails on code reviews are sent to it
because it was adding itself as a reviewer, even if it is not.
R=rogerta@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10918075
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@155141 0039d316-1c4b-4281-b951-d872f2087c98
allows one to run the presubmit script without
submitting locally (alternative would be to make
this a warning I guess).
Also, pass option.verbose through to DoGetTrySlaves()
so it will log which PRESUBMIT files are taking part
in the decision.
BUG=
Review URL: https://chromiumcodereview.appspot.com/10915072
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@154838 0039d316-1c4b-4281-b951-d872f2087c98
(Adding this after the pretty bad build bustage today.)
Review URL: https://chromiumcodereview.appspot.com/10891039
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@153966 0039d316-1c4b-4281-b951-d872f2087c98
apply_issue.py didn't have output, making it a bit boring. Now it's super cute.
R=rogerta@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10889037
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@153948 0039d316-1c4b-4281-b951-d872f2087c98
Add new test cases to verify it properly handles "-1 +1, 2" and "-1 +1" for
short files.
R=petermayo@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10894036
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@153906 0039d316-1c4b-4281-b951-d872f2087c98
Issue and patchset can only be int, so store them as ints.
This fixes git cl comment, which was broken by r152756.
R=petermayo@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10894019
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@153885 0039d316-1c4b-4281-b951-d872f2087c98
This ensures we don't send incorrect values like None or random strings.
R=cmp@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/10836348
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@152756 0039d316-1c4b-4281-b951-d872f2087c98
iannucci@chromium.org
maruel@chromium.org
lliabraa@chromium.org
szager@chromium.org
ilevy@chromium.org
rogerta@chromium.org
sbc@chromium.org
scottmg@google.com
binji@chromium.org
thakis@chromium.org
jam@chromium.org
erg@chromium.org