This reverts commit 4c67f856f0.
Reason for revert: crbug.com/1200657
Original change's description:
> git-cache: Add option to fetch commits.
>
> Add option to git cache to fetch commits.
> And use it in bot_update and gclient sync to make sure
> the needed commits are present on the checkout.
>
> Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942
> Reviewed-by: Gavin Mak <gavinmak@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Change-Id: I31a1defb26119bcb46894ab4084d626b65c45fed
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2837413
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Add option to git cache to fetch commits.
And use it in bot_update and gclient sync to make sure
the needed commits are present on the checkout.
Change-Id: I9e90da9e3be6e7bacf714b22bf0b735463e655b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2829942
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
This is a reland of 75271a0744
Should be safe to re-land now, as the roller will catch the
build error. Then we can re-land in conjunction with the
change to rename the angle gclient config.
Original change's description:
> Reland "Remove ANGLE recipe config."
>
> This is a reland of b8686d2622
> Must land after https://crrev.com/c/2831999
>
> Original change's description:
> > Remove ANGLE recipe config.
> >
> > This config is now located in the ANGLE recipe_module.
> >
> > Bug: angleproject:5114
> > Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
> > Auto-Submit: Jamie Madill <jmadill@chromium.org>
> > Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
> > Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
>
> Bug: angleproject:5114
> Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Jamie Madill <jmadill@chromium.org>
Bug: angleproject:5114
Change-Id: I85c3d6218b790ef62b19c62eb42ec9a8622d613f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2836327
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
This is a reland of b8686d2622
Must land after https://crrev.com/c/2831999
Original change's description:
> Remove ANGLE recipe config.
>
> This config is now located in the ANGLE recipe_module.
>
> Bug: angleproject:5114
> Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
> Auto-Submit: Jamie Madill <jmadill@chromium.org>
> Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
> Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Bug: angleproject:5114
Change-Id: I858d50f49466707eae7194fd82713de7b0b2e6d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2835386
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
We're looking at dropping Python 3.5 support from repo. Lets roll
this back out in Chromium a little early to get a better idea of
who is still relying on it.
Change-Id: Idcdd5b0a957f5a2f8b146149c407c26347be0aa5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2830590
Reviewed-by: Stephane Belmon <sbelmon@google.com>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
I recently encountered an error where I forgot to add a changeid locally to
some-but-not-all commits in a stack of commits. When attempting to upload
these commits via `git cl upload --no-squash`, I received a confusing message
instructing me to install the Gerrit commit-msg hook even after the hook was
installed. In order to debug this problem locally, I added the ability to
prevent `git cl upload ...` from attempting to change the contents of
messages. If the --no-add-changeid flag is passed, then the command will
simply fail quasi-informatively.
BUG=None
TEST=attempted to upload this CL via `git cl upload --no-squash --no-add-changeid`, confirm that it fails.
Change-Id: Id5f721c18143448db801095946f490880bb61786
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2828775
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Gregory Nisbet <gregorynisbet@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
91d88f5f33
91d88f5 (iannucci@chromium.org)
[led] Default to RBE-CAS, add helper for rbh value.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie182491703dd1dc52e789aba2a154e0a2d53574a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2828771
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This config is now located in the ANGLE recipe_module.
Bug: angleproject:5114
Change-Id: I2c4cc51dafeb94378056c135538d0d13bac9c8cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2826242
Auto-Submit: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
The version of expr shipped on macOS does not support `substr`
command and prints `expr: syntax error`. Change the invocation
of `expr` to use the `:` operator which match rhs regexp into
lhs string and return the length of the match.
This should be supported by all versions of `expr` that are
POSIX compliant.
Bug: 1199260
Change-Id: Ib932702fedbbbc772d65086ebc371dc0a9023c0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2827931
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
bbbf2ecbd0
bbbf2ec (olivernewman@google.com)
[tricium] Fix pylint analyzer executable name
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4f9b1505d0dfce4289bed1d327ff996dc3281745
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2827152
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
7c1ba3120b
7c1ba31 (weiweilin@google.com)
[recipe] support configuring test presentation in MiloApi.
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22f39bf7f8d263fc3704c55e1a864dd339fc5308
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2824176
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Windows builders have issues fetching from chromium/src, and increasing
timeout may help - recommended by git team.
Bug: 1198581
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: chrome_release
Recipe-Nontrivial-Roll: build
Change-Id: Ic650dea2a175e9642a6d3d5b8f1c54fa9979e12a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2823020
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
In crbug.com/1196159, a build got stuck at "gerrit changes" step for 3
hours. It would be good to add a timeout so that it fails early.
Also adjust the timeout for get_changes to 60s, from 600s
Bug: 1196159
Change-Id: Id2327ab40dd2fd8d95aaad6bb724f7ed06e6c244
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: chromiumos
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2811899
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
This picks up a change to make 'debug sleep' work on luciexe jobs.
R=yiwzhang
Bug: 1197300
Change-Id: Iea7a061e84f7011b6a7f1cc64cca34b0267b6ec1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2818885
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
91f81ea469
91f81ea (olivernewman@google.com)
[tricium] Add `run_legacy` option to skip emitting comments
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2c0827476d48af10bdc44c707dce996215262af8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2812318
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
mass-abandon allows users to mass abandon CLs based on search query.
Owner is always specified (either "me" or user defined via -p).
R=gavinmak@google.com, thakis@chromium.org
Change-Id: I789a3a1f3af22867ebbbc50c35b60486206ff403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2811005
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Also adds a new canned_presubmit_checks_test.py and supporting mocks,
based on the PRESUBMIT_*.py under chromium/src.
If this is OK, there are subsequent CLs for removing the original code
from chromuim/src and infra/infra, and having their PRESUBMIT scripts
just reference this canned check instead.
Change-Id: I67dfb7ac0b4cdc36bd62ec2dc062ca5c78c2244e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2805268
Commit-Queue: Sean McCullough <seanmccullough@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
With this, `gclient` completes bootstrap after running
echo "mac-arm64" > .cipd_client_platform
as long as you also run
export VPYTHON_BYPASS="manually managed python not supported by chrome operations"
Things work enough that you can `fetch chromium`. You can then build
all of chrome (if you want to build all tests, you also need to
`echo "mac-arm64" > third_party/depot_tools/.cipd_client_platform`
in your chromium checkout).
Parts of depot_tools that actually need the env managed by vpython,
such as `git cl`, don't work. So you can't `git cl upload` for now.
Bug: 1184768,1103326,1184766,1184765,1103236
Change-Id: Ib559c35e9665b826db9841dd8a4fe0dea16f37ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2807956
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
This change includes the following commits from the infra/infra
repository:
97ee9cecaa Pinpoint: introduce fakelegacy-based smoke test. (chowski@google.com)
7f5c67efcb pinpoint: Translate ExperimentCommit properly (dberris@google.com)
6c32245733 Pinpoint cli: add actionable error when GCS credentials fail. (chowski@google.com)
5ed9722479 pinpoint fakelegacy: support /api/new endpoint. (chowski@google.com)
9d26e75b86 pinpoint: add copyright heading to files which are missing it. (chowski@google.com)
2c07962627 Pinpoint server: use the new ShouldBeStatusError assertion more. (chowski@google.com)
830e31f6b1 Pinpoint server: add unit test for ScheduleJob. (chowski@google.com)
c27f979330 Pinpoint cli: infer some flag defaults from `git cl issue`. (chowski@google.com)
ed69e2428f Pinpoint fakelegacy: support ListJobs. (chowski@google.com)
5f0e1e9a35 Pinpoint: first stab at a fake Legacy Pinpoint implementation. (chowski@google.com)
3aae5c2e6b pinpoint: Support wait+download for experiments (dberris@google.com)
6a634f7926 Replace 'master' with 'main' in test data. (chowski@chromium.org)
81ccbd091d Pinpoint server: support ListJobs' filter argument. (chowski@chromium.org)
575bd02e5a pinpoint: Update docs, support non-chromium/src (dberris@google.com)
e53451b2ca pinpoint server: support Cancel RPC. (chowski@chromium.org)
cb65ecf501 pinpoint: Reduce duplication in server_test (chowski@chromium.org)
e91e4e899d pinpoint: Support optional patchset for CLs (dberris@google.com)
R=dpranke@google.com
Bug: chromium:1175615
Change-Id: I4ac6407d822bf1905cbba02d29649ac4e400aecb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2807336
Auto-Submit: Dean Berris <dberris@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.
recipe_engine:
9e296d9de0
9e296d9 (yiwzhang@google.com)
Set step end_time to start_time if it is earlier than the start...
More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
R=iannucci@chromium.org
Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iba11781abb42db07f3a43f8020daa10181edf713
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2803201
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
This check has been disabled basically everywhere since about 2013. It
should be safe to remove this; there will be warnings when trying to
skip it, but it shouldn't fail any builds.
Recipe-Nontrivial-Roll: build
Bug: 1194216
Change-Id: I84878f9e46543ae71f7e4e057b99d15a034e0d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2794799
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Add calls to support creating changes, as well as editing and publishing
them in gerrit_client and gerrit_util.
Bug=b:182613582
Change-Id: I0514cf08dce63ab29d99d4485d96fa124006326a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2800811
Auto-Submit: LaMont Jones <lamontjones@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: LaMont Jones <lamontjones@chromium.org>
When uploading a large-scale change, many users are automatically CC'ed
on a change. This adds a warning if this is the case and links to a more
appropriate approval for a large-scale change.
Bug: 1194514
Change-Id: Icd336ebdffbccbc9f30a89a33e244a788a768cfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2798963
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Edward Lesmes
Edward Lesmes
Linkun Chen
Mike Frysinger
Jamie Madill
Garrett Beaty
Josip Sokcevic
Fumitoshi Ukai
Gregory Nisbet
recipe-roller
Sylvain Defresne
Dirk Pranke
Mirko Bonadei
Owen Rodley
Haiyang Pan
Robert Iannucci
Chan Li
Michael Achenbach
Nico Weber
seanmccullough
Dean Michael Berris
Stephen Martinis
LaMont Jones
Gavin Mak
Solomon Kinard