Allow the user to interact with the svn password prompt
if needed. Verify the svn server is reachable before
proceeding. Clean extra UI issues up. Readability
fixes.
BUG=none
TEST=prompted for a svn password if ~/.subversion/auth
is empty, bad svn server causes early timeout
Review URL: http://codereview.chromium.org/267059
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29552 0039d316-1c4b-4281-b951-d872f2087c98
drover: switch to use optparse, and add the arguments to be able to support
the revert bot.
Review URL: http://codereview.chromium.org/294005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29446 0039d316-1c4b-4281-b951-d872f2087c98
pymox auto-checkout never really worked well so check-in pymox directly.
pprint.pformat is non-determinist in one test. Worked around the issue.
TEST=unit tests
BUG=none
Review URL: http://codereview.chromium.org/266043
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29398 0039d316-1c4b-4281-b951-d872f2087c98
the python code we have. 90% of the changes are removing
trailing spaces.
Review URL: http://codereview.chromium.org/282014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29312 0039d316-1c4b-4281-b951-d872f2087c98
BUG=5339
TEST=excluding depot_tools from PATH shows an
instructive error, trying to run the hook with
git_cl_hooks.py missing shows an instructive error
Review URL: http://codereview.chromium.org/264069
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@29156 0039d316-1c4b-4281-b951-d872f2087c98
* Actually print unknown files
* Put things in the proper order (i.e. files with no changelist under the "no changelist" header)
Review URL: http://codereview.chromium.org/270047
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28719 0039d316-1c4b-4281-b951-d872f2087c98
as an answer.
Review URL: http://codereview.chromium.org/268023
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28557 0039d316-1c4b-4281-b951-d872f2087c98
This new method allows us to install pre-cl-upload
and pre-cl-dcommit hook files which should rarely need
to be updated (with luck). These hooks load the real
hooks lib from depot_tools which takes over execution
of the presubmit tests.
BUG=5339
TEST=hooks are run by git cl upload/dcommit and behave
as expected
Review URL: http://codereview.chromium.org/243118
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28409 0039d316-1c4b-4281-b951-d872f2087c98
This reverts commit 28058.
BUG=24081
TEST=gclient sync without --force is not working anymore.
TBR=dpranke
Review URL: http://codereview.chromium.org/269006
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28271 0039d316-1c4b-4281-b951-d872f2087c98
Provide git-cl upload and dcommit hooks based on this
single hooks file. Installed via git-cl config.
Loads and calls the PresubmitSupport library.
Test failure before a dcommit halts the check-in.
BUG=5339
TEST=hooks file runs presubmit checks and halts
checkin (dcommit) or repeats error messages (upload).
hooks file runs and doesn't interrupt process if no
errors present.
Review URL: http://codereview.chromium.org/256075
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28125 0039d316-1c4b-4281-b951-d872f2087c98
Expand presubmit_support and gclient_scm to support
getting basic status and changed files from a Git
checkout.
BUG=5339
TEST=presubmit_support.py works from a git checkout,
gcl presubmit works from a svn checkout
Review URL: http://codereview.chromium.org/242140
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28092 0039d316-1c4b-4281-b951-d872f2087c98
Its side-effect caused tree breakages, at least on the try slaves.
TBR=dpranke
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/251095
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28058 0039d316-1c4b-4281-b951-d872f2087c98
messages when --verbose is specified or when something actually happens.
Also, remove --manually_grab_svn_rev, because we need this to happen all
the time to get gclient update to shut up if we're comparing against HEAD.
It doesn't look like there are any real side effects of removing this.
An alternative change would be to wrap this behind a --quiet flag.
Note that the change to tests/trychange_unittest.py is an unrelated fix to get
all the tests to pass.
R=maruel@chromium.org
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/257023
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@28039 0039d316-1c4b-4281-b951-d872f2087c98
Replaced a call to CaptureSVNStatus with a SCMWrapper::status
gclient: store gclient_entries as a dict
Currently we only store the relative path for entries.
We need to also store the url so that learn the repo type: git or snv.
Review URL: http://codereview.chromium.org/248011
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27370 0039d316-1c4b-4281-b951-d872f2087c98
gclient_tests: add GitWrapper test cases
gclient_scm: make RunGit private and add url check
gclient_scm: add revert, run_hooks, and status
gclient_scm: add git implementations of cleanup, diff, and export
gclient_scm: implment GitSCM::update
gclient_scm: add a checks for unsupported scm and unimplemented method
Review URL: http://codereview.chromium.org/235005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27241 0039d316-1c4b-4281-b951-d872f2087c98
When using svn for try job for the first time, svn will ask for the credentials.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/223024
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27103 0039d316-1c4b-4281-b951-d872f2087c98
Current checkout revision was ignored so it was always acting like if --force was used.
This was overloading the subversion server, creating timeouts, causing a cascading effect that destroyed the tree.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/225022
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@27027 0039d316-1c4b-4281-b951-d872f2087c98
It was adding a space in front of every line.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/223009
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26973 0039d316-1c4b-4281-b951-d872f2087c98
Currently, revision numbers are stored as int. This won't work
for git's SHA1s. So storing revisions as strings.
Review URL: http://codereview.chromium.org/208060
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26940 0039d316-1c4b-4281-b951-d872f2087c98
This is for situations where the solution is checked out by another SCM
mechanism (e.g. update-webkit or just svn co) but we want to use gclient to
fetch the dependencies.
Review URL: http://codereview.chromium.org/211057
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26876 0039d316-1c4b-4281-b951-d872f2087c98
gclient_scm: use a map for deciding whether or not the scm is supported
gclient_scm: add a checks for unsupported scm and unimplemented method
git_scm: pull out svn code into SVNWrapper
gclient_scm: create a create_scm factory method
Use a factory method to abstract SCMWrapper creation. This method
will eventually return the correct subclass of SCMWrapper. Initially,
there will only be SVNWrapper.
Review URL: http://codereview.chromium.org/215022
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26823 0039d316-1c4b-4281-b951-d872f2087c98
and append them to the patch sent to the try bots. This is
very useful for chromium+webkit tries.
Review URL: http://codereview.chromium.org/212034
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26817 0039d316-1c4b-4281-b951-d872f2087c98
svn revert is broken in too many ways to work around it. I just discovered --revision BASE and it does everything I need.
BUG=none
TEST=gclient revert ignores externals, work with switched directories, work with files with inconsistent line endings (sigh)
Review URL: http://codereview.chromium.org/209052
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26707 0039d316-1c4b-4281-b951-d872f2087c98
This method will eventually return the correct subclass of SCMWrapper. Initially, there will only be SVNWrapper.
gclient_scm: add test for unsupported scm
gclient_scm: make SCMWrapper constructor parameters non-optional
gclient_scm: add a checks for unsupported scm and unimplemented method
git_scm: pull out svn code into SVNWrapper
gclient_scm: create a create_scm factory method
TEST=
BUG=none
Review URL: http://codereview.chromium.org/216014
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@26602 0039d316-1c4b-4281-b951-d872f2087c98
pkasting@chromium.org
laforge@chromium.org
maruel@chromium.org
chase@chromium.org
nsylvain@chromium.org
shess@chromium.org
mattm@chromium.org
thestig@chromium.org
gspencer@google.com
dpranke@google.com
bradnelson@google.com
msb@chromium.org
thakis@chromium.org
yaar@chromium.org
msb@google.com