Commit Graph

7602 Commits (4e6de222491534c20af18cae871fc5d0edb801cc)
 

Author SHA1 Message Date
recipe-roller 4e6de22249 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
b0e8da7877
  b0e8da7 (bryner@google.com)
      Revert "Run extract.py with python3 to handle .tar.xz files."

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib3913f86fd1cb6f9a59f84dfef496f3e61b7a693
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2669928
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Josip Sokcevic 69902d0941 Support main branch as default branch in roll-dep
R=ehmaldonado@google.com

Bug: 1172028
Change-Id: Ica77db151eeb48c65f62043cbe30828dfa17bf95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2659510
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
recipe-roller 3d3f7cfab0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
5de3e62cc8
  5de3e62 (gbeaty@chromium.org)
      Set the output gitiles commit in buildbucket.build.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I264b5089af675a8049a31bc2af8dad0cf79037d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2669277
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Edward Lesmes 15801268f8 gclient: Split gclient smoke tests.
Hopefully this will decrease the time it takes to run
presubmit tests and avoid them timing out.

Change-Id: If12abf2f7c64d6f05bb7b492ad53dee1fa6dbbb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666670
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Edward Lesmes b1174d733e split-cl: Walk the tree instead of using owners db.
Change-Id: I9dc9cda5a30833938fe13476deb76f4ed5770eab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666668
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
4 years ago
recipe-roller 13e0b55dce Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
c2aff19048
  c2aff19 (gbeaty@chromium.org)
      Preserve the commit list state in case a candidate is rejected.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I26b2a4601f304199cd53b902b71bc18a357207c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2668980
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Nico Weber 499a2fd61b Reland "win toolchain: Prepare downloader for windows sdk dir switch"
This is a reland of e72789f5b4

Original change's description:
> win toolchain: Prepare downloader for windows sdk dir switch
>
> crrev.com/c/2655836 tries to move the Windows SDK from
> "win_sdk" to "Windows Kits/10".
>
> get_toolchain_if_necessary.py (in depot_tools) saves the path to the SDK to
> third_party/depot_tools/win_toolchain/data.json which then gets copied
> by a script in the chromium repo to build/win_toolchain.json.
> For the SDK move to work, chromium's pinned depot_tools
> must write the new SDK path when rolling in the new toolchain package.
> This change makes depot_tools handle win packages that have the
> windows sdk either win "win_sdk" or in "Windows Kits\10".
>
> The plan is:
>
> 1. Land this change, which can handle both path styles
> 2. Wait for depot_tools in chromium to update
> 3. Then roll to a win toolchain package with the new layout
>
> In a few years, when we no longer need the old layout,
> we can remove this detection code again and assume the new layout.
>
> Bug: 1173176
> Change-Id: Iaefc5c16685d3dbfff87a3e50a7b20b457366e44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666429
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

Bug: 1173176,1173393
Change-Id: Ic706f694f8f0260208fa637864e62d7cc4f7ce93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2668127
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
4 years ago
Takuto Ikuta 8bb3513349 Roll out new goma client binary VERSION=213
Bug: b/178747003
Change-Id: I2dff72f688ea67228dc691e94cc17e419cfc8f21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666652
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
4 years ago
Takuto Ikuta 98cc028bbe Revert "win toolchain: Prepare downloader for windows sdk dir switch"
This reverts commit e72789f5b4.

Reason for revert: 
This broke goma builder.

Original change's description:
> win toolchain: Prepare downloader for windows sdk dir switch
>
> crrev.com/c/2655836 tries to move the Windows SDK from
> "win_sdk" to "Windows Kits/10".
>
> get_toolchain_if_necessary.py (in depot_tools) saves the path to the SDK to
> third_party/depot_tools/win_toolchain/data.json which then gets copied
> by a script in the chromium repo to build/win_toolchain.json.
> For the SDK move to work, chromium's pinned depot_tools
> must write the new SDK path when rolling in the new toolchain package.
> This change makes depot_tools handle win packages that have the
> windows sdk either win "win_sdk" or in "Windows Kits\10".
>
> The plan is:
>
> 1. Land this change, which can handle both path styles
> 2. Wait for depot_tools in chromium to update
> 3. Then roll to a win toolchain package with the new layout
>
> In a few years, when we no longer need the old layout,
> we can remove this detection code again and assume the new layout.
>
> Bug: 1173176
> Change-Id: Iaefc5c16685d3dbfff87a3e50a7b20b457366e44
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666429
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Bruce Dawson <brucedawson@chromium.org>

TBR=thakis@chromium.org,brucedawson@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I8d133f4fa199f81978f5245bdb2155c62bc9cc88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1173176
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666651
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
4 years ago
Nico Weber e72789f5b4 win toolchain: Prepare downloader for windows sdk dir switch
crrev.com/c/2655836 tries to move the Windows SDK from
"win_sdk" to "Windows Kits/10".

get_toolchain_if_necessary.py (in depot_tools) saves the path to the SDK to
third_party/depot_tools/win_toolchain/data.json which then gets copied
by a script in the chromium repo to build/win_toolchain.json.
For the SDK move to work, chromium's pinned depot_tools
must write the new SDK path when rolling in the new toolchain package.
This change makes depot_tools handle win packages that have the
windows sdk either win "win_sdk" or in "Windows Kits\10".

The plan is:

1. Land this change, which can handle both path styles
2. Wait for depot_tools in chromium to update
3. Then roll to a win toolchain package with the new layout

In a few years, when we no longer need the old layout,
we can remove this detection code again and assume the new layout.

Bug: 1173176
Change-Id: Iaefc5c16685d3dbfff87a3e50a7b20b457366e44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2666429
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
4 years ago
Josip Sokcevic 8c95595001 Remove non-inclusive parameters from presubmit
R=ehmaldonado@google.com

Bug: 1118435, 1118436
Change-Id: Ie66b2cb39a3d8abc83679bee44d2e594eba77442
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657981
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Gavin Mak 0f790421b2 Update ListOwners for GerritClient in owners_client
The REST endpoint used by GerritClient.ListOwners needs to be updated as
of https://gerrit-review.googlesource.com/c/plugins/code-owners/+/293806

Change-Id: I5c142f16443b157c9d8edfa5bcf418cbedd2b193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2658609
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
4 years ago
recipe-roller 037b0821fc Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
2ae42d0673
  2ae42d0 (bryner@google.com)
      Run extract.py with python3 to handle .tar.xz files.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia444e768024f2b99a33967787154a560ed231a2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2664735
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Edward Lesmes 1ea233380f git_drover: Replace with instructions on how to cherry-pick.
Change-Id: I4cf7591df2b89bceb5618abb8fad92fd29e066bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2653952
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andy Perelson <ajp@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Nico Weber cb07c525c0 win toolchain: Remove some old MSVS 2013 references.
We used to use this many years ago.

Bug: none
Change-Id: I1df268c793bbfe7423ecf86ea99ebbe918e280d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2658676
Auto-Submit: Nico Weber <thakis@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
4 years ago
Henrique Nakashima 25b2cb499a [recipe_modules/depot_tools] Add dirmd_path to api
This is required to parse DIR_METADATA files.

Bug: 1135347
Change-Id: I620656d4dbec5e918bfc0f535397869c869446b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644827
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
4 years ago
Chan Li 801121c27c [depot_tools] roll rdb to 0c7d9eb
To include change https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2648266

Bug: 1030191
Change-Id: I6328efa2cc5acf42d0ec386f70f955fa77237260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2659507
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
4 years ago
recipe-roller 1f97007e75 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
bf5ee52777
  bf5ee52 (chanli@chromium.org)
      [ResultDB] recipe_module: remove chromium_derive

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I140894030f83ffcd413deb9c4e611cae83ecf115
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2660020
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 3328717600 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
d3edd66d0a
  d3edd66 (bryner@google.com)
      Basic python3 compatibility changes for extract.py.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibcab4b76f0b7077c24696ce5de3f4107c8b51ac9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2659495
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 6325d60679 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
6fbe4305b3
  6fbe430 (iannucci@chromium.org)
      Add integration tests for some gnarlier annotator/bbagent hacks.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I10afde1fd84c6de6258bb762f3e679aebac17fdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2659113
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 6ff74e1dce Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
ebdb512224
  ebdb512 (chanli@chromium.org)
      [ResultDB] api.resultdb.wrap: support location_tags_file

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Idaef48ffd695ed873afab6c0148faa622f6149ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657990
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Edward Lesmes 1ab6dbc0a7 Revert "Change whitespace.txt"
This reverts commit 07bd252238.

Reason for revert: Still testing chromium-behavior

Original change's description:
> Change whitespace.txt
>
> Will use this change to test reverting in the Gerrit UI.
> Using TBR= so as to not spam anyone else.
>
> TBR=
>
> Change-Id: If95898b00d6468512157d120e24c8246c1655f8f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2645231
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

TBR=

No-Try: true
No-Presubmit: true
Change-Id: Iaf547a6f5916490c85baeb8a32758c4b40abe4c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657869
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Yoshisato Yanagisawa 558a30422e Roll out new goma client binary VERSION=212
Bug: b/178452801
Change-Id: Ief04267764a1e67219912af0a8a1c8a4aa46a6be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2654599
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
4 years ago
Josip Sokcevic 2c9dbb89fb Revert "Add previous_got_revision and previous_got_revision_cp to output"
This reverts commit 6d0c0ffef5.

Reason for revert: this appears to  break builders if reference
is a commit hash:

git log --format=%B -n1 HEAD failed with code 128

Original change's description:
> Add previous_got_revision and previous_got_revision_cp to output
>
> As chrome browser infra works to improve CQ times, we would like to
> easily glance at builds and see how many new commits were checked out.
> Currently you have to open up bot_update stdout to see the previous
> HEAD revision and go from there. Having this conveniently outputted
> would be very convenient.
>
> If the bot has previously checked out the repo, output which revision
> and commit position were checked out.
>
> example LED build showing new output: https://ci.chromium.org/swarming/task/51592e46d6a70e10?server=chromium-swarm.appspot.com
>
> Change-Id: Ib8a6f152a593446ce4082477bc9ada44f1fd1fc3
> Bug: 1170568
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644829
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Stephanie Kim <kimstephanie@google.com>

TBR=infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com,kimstephanie@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1170568
Change-Id: I50d6ef6802c2eb1614cca804391c7826a79a2cf9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657023
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
recipe-roller 9bdbb8f944 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
51dda3f289
  51dda3f (iannucci@chromium.org)
      [buildbucket] Properly handle set_output_gitiles_commit in luci...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ieb513b225e97465660fb6f41a5d834f9f2748fac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2657030
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller ea89b0d66a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
01f6be9de7
  01f6be9 (tikuta@chromium.org)
      cas: disallow overriding instance

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib31f328ae203bf7a269661d4f7742122c3a5a2df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2654717
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Gavin Mak 9a18e37fb9 Add documentation for --inject_current
This change adds documentation and demos missing for the flag
--inject_current used in git new-branch.

Bug: 1167943
Change-Id: Id6305b876ade2c47eb7435a5edd055ae4fe2f323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2648615
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
4 years ago
recipe-roller 882bf8a509 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
a129633548
  a129633 (vadimsh@chromium.org)
      [scheduler] Add properties and tags to GitilesTrigger.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib5758aff14710ada26f260c7b030f0eab6b31ff6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2654254
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 92fb40c122 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
4e80714e17
  4e80714 (gbeaty@chromium.org)
      Return None from CommitList.advance_to for backwards advances.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If35f2ee09a01b6dd859a6eacb8e9f37483594872
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2654083
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller fade894c7e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
1cf8c5966f
  1cf8c59 (vadimsh@chromium.org)
      [proto] Update go.chromium.org/luci protos.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5f27fc78df5b07b43b877ad11274f74b791d8fdf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2651464
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller c03bb97e5f Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
da848b8552
  da848b8 (lamontjones@chromium.org)
      [buildbucket] include ref in try_build_message

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7bb907c81a55ffcb43b51f1de77460e19e727e29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2651456
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Stephanie Kim 6d0c0ffef5 Add previous_got_revision and previous_got_revision_cp to output
As chrome browser infra works to improve CQ times, we would like to
easily glance at builds and see how many new commits were checked out.
Currently you have to open up bot_update stdout to see the previous
HEAD revision and go from there. Having this conveniently outputted
would be very convenient.

If the bot has previously checked out the repo, output which revision
and commit position were checked out.

example LED build showing new output: https://ci.chromium.org/swarming/task/51592e46d6a70e10?server=chromium-swarm.appspot.com

Change-Id: Ib8a6f152a593446ce4082477bc9ada44f1fd1fc3
Bug: 1170568
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644829
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Stephanie Kim <kimstephanie@google.com>
4 years ago
Josip Sokcevic 76d0e6aca7 [bot_update] Resolve revision only if patching
If bot_update is not patching, it shouldn't look into gitiles patch
information.

R=ehmaldonado@google.com

Bug: 1147625
Recipe-Nontrivial-Roll: build
Change-Id: I111f0dc1c36d588341c02930bf1cda1f5b8cc2e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2644199
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Edward Lesmes d686b1d1c8 bot_update: Set encrypted debug headers when retrying fetch.
Bug: b/178502800
Bug: 1170806
Change-Id: If66cf06b9954520ddd909dce869e2a15da3055ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2650965
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
recipe-roller e65446e4e4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
21a0be68ef
  21a0be6 (iannucci@chromium.org)
      [buildbucket] Remove validation of output commit id in test mode.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I527dea0540fffafb517635d532aeace372594654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2650776
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller c636aac7ec Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
90828211ca
  9082821 (adrexler@google.com)
      Update go.chromium.org/luci/ protos.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I73c4ecd5e9bdfe046fc67c16cbfeed81b83528c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2650353
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Ola Rozenfeld ca63c0551c Making reclient changes work on Windows.
Bug: 1149386
Change-Id: I7b04450b4da84ca0a1f599a7fe1bfe27d1dd648f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2639604
Commit-Queue: Ola Rozenfeld <olaola@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
4 years ago
Edward Lesmes 1076f38947 Reland "presubmit: Use new API to check for owners approval"
This is a reland of 0489cc12af

Don't remove email_regexp argument, as downstream still passes it.

Original change's description:
> Reland "presubmit: Use new API to check for owners approval"
>
> New API was updated to properly support '*' as owner.
>
> Change-Id: If14144f83484731fd5534c03cb9fde4b18f49fe9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2628703
> Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

Change-Id: Id137aca0036c2ebf11ec56a12f4e053cd2cc6637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2639411
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
4 years ago
Gavin Mak d36dbbd730 [owners] Use owners_client in owners_finder.py
This change also adds a ScoreOwners function in owners_client
that replaces user scoring functionality in owners_finder.

Change-Id: Ifd8841c6d320d9bb644907b6eca0a02d4ef35640
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2641532
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
4 years ago
Gavin Mak 68e6cf3c9f Don't open text editor when using --message-file
When using git cl upload --message-file, the text editor prompts the
user to edit the description. This change suppresses the editor when
a message file is passed in.

Change-Id: Ifa568e155e72eeb49f55ded0ddac1b5a940687af
Bug:916230
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2643781
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
4 years ago
Yoshisato Yanagisawa f08e425f2d Revert "Roll out new goma client binary VERSION=211"
This reverts commit 6c93986030.

Reason for revert:
I started to see Exceptions after the rollout.
Let me speculatively revert.

Original change's description:
> Roll out new goma client binary VERSION=211
>
> Bug: b/177285551
> Change-Id: I59ca57d05555a2fe922d3056e6d52842b4bb66ac
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2646141
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Reviewed-by: Fumitoshi Ukai <ukai@google.com>
> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>

TBR=ukai@google.com,yyanagisawa@chromium.org,tikuta@chromium.org,yekuang@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com

Change-Id: I94b829d33f7f0bc897cdf661e892ff1264e773e1
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: b/177285551
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2646767
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
4 years ago
Yoshisato Yanagisawa 6c93986030 Roll out new goma client binary VERSION=211
Bug: b/177285551
Change-Id: I59ca57d05555a2fe922d3056e6d52842b4bb66ac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2646141
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
4 years ago
Edward Lesmes 07bd252238 Change whitespace.txt
Will use this change to test reverting in the Gerrit UI.
Using TBR= so as to not spam anyone else.

TBR=

Change-Id: If95898b00d6468512157d120e24c8246c1655f8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2645231
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
4 years ago
Edward Lesmes 5397151e88 Add whitespace.txt
Change-Id: I70fad9c369e36d7dcbf3cb8a4eb2c8ee66ceb7b6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2642771
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
4 years ago
Josip Sokcevic 361ccce124 Revert "Support main branch in bot_update"
This reverts commit e7a31f42cd.

Reason for revert: has typo and doesn't work if typo is fixed

Original change's description:
> Support main branch in bot_update
>
> Change-Id: I58e88e9505779c309ac0af9d5b78b45feaa75543
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2528669
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

TBR=ehmaldonado@chromium.org,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib6b266250b854e2554249b956766214be84ec522
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2643961
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
4 years ago
Chan Li 03fc9a3eb3 [depot_tools] Update rdb pin
To deploy change https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/2639156

Bug: 1103287
Change-Id: Idf7fe6f7c355321aaa72afbd96c710d33c7af5d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2642768
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Chan Li <chanli@chromium.org>
4 years ago
Vadim Shtayura 02e777d04e [lucicfg] Update v1.21.0 => v1.21.5.
Changes:
[lucicfg] Add `extends` to luci.bucket(...).
[resultdb] Add history options to starlark files.
[lucicfg] Fix issues related to Go deps roll.
Remove experiment gating luci.tree_closer.
[Lucicfg] change repository_whitelist to repository_allowlist

R=iannucci@chromium.org, tandrii@chromium.org
CC=robertocn@chromium.org

Change-Id: Ife18f8469a6083a476fae817a0163f7f9e6a1448
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2642769
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
4 years ago
recipe-roller af0dca3dc9 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
34f43c5158
  34f43c5 (bryner@google.com)
      Fix JSON serialization of PackageDef preserve_mtime/preserve_wr...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4c58ee1065e40a447c428bb5ac2e3a239361e3d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2641533
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
recipe-roller 13ea742361 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
5edec0a657
  5edec0a (yiwzhang@google.com)
      [luciexe] Normalize each segment instead of the entire stream name

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I53524d132ae5871a94ecbe50ec4e3e9f1cefe7d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2641048
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
4 years ago
Takuto Ikuta 3253a1deca autoninja: roll back to python from python3
python3 is currently not recognized on git bash.
https://crrev.com/c/2629087/15#message-b5093e69201df42adb7ac643e4f97f9f366a299d

This is partial revert of
https://crrev.com/c/2629087
https://crrev.com/c/2631396

Bug: b/177465438
Change-Id: I1b2698f5fc27144035598249c43800d25801a0f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2638834
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
4 years ago