Commit Graph

10294 Commits (3c79cfc485fc84571d0136e35031f20c474d4b6c)
 

Author SHA1 Message Date
Josip Sokcevic 31a590e0cd [scm] Cache ResolveCommit call
The cache won't be used if ResolveCommit throws an exception or when
non-sha1 is used.

This optimization saves about 7% of overall gclient sync on
chromium/src.

R=gavinmak@google.com

Change-Id: I9c36d937dc7b8553818888e2e9c4eecd029a978c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5147496
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
1 year ago
Gavin Mak e010fbf0a5 Remove git drover
git drover was deprecated 3 years ago in favor of cherry picking:
https://crrev.com/c/2653952

Change-Id: I12273f7691de73eef939a13ac5a4fdfec65356f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5153632
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
1 year ago
Josip Sokcevic 42b995792c [gclient] Cache rev-list HEAD call
This optimization saves about 9% of overall gclient sync on
chromium/src.

R=gavinmak@google.com

Change-Id: I4700e9db9e91a69746e212f6f04376dfb38bef91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5147495
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
1 year ago
Josip Sokcevic 1bdc5c8db4 [presubmit] Don't replace os.environ
Assigning os.environ the result of os.environ.copy() replaces it
with a standard dict. This breaks reflection into the actual
environment, as well as features such as case-insensitivity on
Windows, leading to undefined standard library behavior.

R=bryner, gavinmak

Bug: 1511316
Change-Id: I63d026387104ae92669256567854f8bf9d2397a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5133887
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
1 year ago
Joey Arhar 0e40b92d9e Don't try squashing only one commit
This patch makes git rebase-update only try squashing when rebasing
fails if there is more than one commit present in the branch it is
rebasing.

Squashing adds an extra step for the user when rebasing fails, and when
there is only one commit, squashing is guaranteed not to help.

Fixed: 1434450
Change-Id: I1952c1172dbf6a44060ed2da2d79ec07d67893d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5068315
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
1 year ago
Josip Sokcevic 911ccd864c [win_toolchain] Add DIR_METADATA
This should route crash reports (e.g. https://crbug.com/1451128) to the
right component.

Fixed: b/285971982
Change-Id: If3391e4fb2b7af4f9fe91261283e8ef79a9e6759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5141486
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
1 year ago
recipe-roller 8191486420 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8760517731482306737

recipe_engine:
110c9cee8a
  110c9ce (bryner@google.com)
      Remove python script added by mistake.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I33ab5317e979c2da0b38fac7617ac9ab60c6656d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5153634
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1 year ago
Ruben Rodriguez Buchillon 007dd45a94 cros: expand to cover more roots
The background is we maintain a fork of a fork of cros and as we're
moving to submodules this is what our repo looks like e.g. chromite is
at the top, and it's using submodules.

It doesn't seem like this would negatively affect anyone else, and would
make our system a lot simpler.

Change-Id: Ib1c9fd95a36e55fc13bede9bb539daedd5efe0ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5132338
Commit-Queue: Ruben Rodriguez Buchillon <coconutruben@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
1 year ago
recipe-roller 390005586b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761692344201209681

recipe_engine:
30f87e440d
  30f87e4 (vadimsh@chromium.org)
      Revert "[swarming] [recipe] Use prpc swarming cli for all recipes"

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6fd6600a995e5659ae7a59f92023757cf1576d0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5123955
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1 year ago
Gavin Mak 38c697d3ec Don't print "Updating depot_tools"
This message is not useful.

Bug: 1418413
Change-Id: I37f92933dd6c5b40229cd8472551c0d1a3b5e962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5123952
Reviewed-by: Will Harris <wfh@chromium.org>
Auto-Submit: Gavin Mak <gavinmak@google.com>
Commit-Queue: Will Harris <wfh@chromium.org>
1 year ago
Robert Iannucci 710996478e [yapf] Update yapf to a version which supports python3.11 syntax.
R=bryner, yiwzhang@google.com

Change-Id: Iec8b5750d1f4889b301c6efe4ee42b399660897d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5123295
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
1 year ago
Michael Savigny f26dddb204 Add use_goma deprecation warning to autoninja.
Adds the same warning to every use_goma build that is currently printed
on a gn gen with use_goma=true.

Bug:b/277197166
Change-Id: Icf9781f814416dfbeb2826fc88372465155fcd2b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5123231
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Michael Savigny <msavigny@google.com>
1 year ago
recipe-roller 5ce8e010db Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761755888906628305

recipe_engine:
242059d678
  242059d (mohrr@google.com)
      [path] Add annotations

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4735ab98d2e8dea44fde597e677e35a7cf96333a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119289
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1 year ago
Helmut Januschka 6444de14d1 fix crash in case HEAD exists as a file
Bug: 1428373
Change-Id: If9d988d542345dbfa0e02f7c3d6f935b48372df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5018937
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Helmut Januschka <helmut@januschka.com>
1 year ago
recipe-roller e29896a0f7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761791744613897537

recipe_engine:
ed4f1addee
  ed4f1ad (jonahhooper@google.com)
      [swarming] [recipe] Use prpc swarming cli for all recipes

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaa3b7ca815f01000ce1b3f83da0415d22ef9eca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119282
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1 year ago
Ben Pastene d6aaf4522a Revert "Reland "Upgrade python to 3.11""
This reverts commit 32c1207c9e.

Reason for revert: spec reverting for `FileNotFoundError: shell not found` errors on win-presubmit
https://ci.chromium.org/ui/p/chromium/builders/try/win-presubmit?limit=200
eg
https://ci.chromium.org/ui/p/chromium/builders/try/win-presubmit/377708/overview

Original change's description:
> Reland "Upgrade python to 3.11"
>
> This is a reland of commit 6a167d1e1f
>
> Original change's description:
> > Upgrade python to 3.11
> >
> > R=bryner
> >
> > Bug: 1500415
> > Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
> > Reviewed-by: Brian Ryner <bryner@google.com>
> > Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
>
> Bug: 1500415
> Change-Id: I0cce81772186a26c3bdb67c5b49ce383b8a1443e
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5118884
> Commit-Queue: Peter Wen <wnwen@chromium.org>
> Reviewed-by: Brian Ryner <bryner@google.com>

Bug: 1500415
Change-Id: Ic57bdd4919f44b38b7edc334dc7e504e19256067
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119766
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
1 year ago
Garrett Beaty 7a9218d13f Enable searching starlark files with git gs.
Change-Id: Ib4688483cca43b10f88cfc529b03e119b8d2d267
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119764
Commit-Queue: Gavin Mak <gavinmak@google.com>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
1 year ago
Chan Li 305904f4ee [depot_tools] roll lucicfg to 1.43.1
To pick up the heartbeat_timeout support

Bug: 5078993
Change-Id: Ic5161516f74f1bfee36cbcb25fd8fed10814619d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5119765
Commit-Queue: Randy Maldonado <randymaldonado@google.com>
Auto-Submit: Chan Li <chanli@chromium.org>
Reviewed-by: Randy Maldonado <randymaldonado@google.com>
1 year ago
Josip Sokcevic 32c1207c9e Reland "Upgrade python to 3.11"
This is a reland of commit 6a167d1e1f

Original change's description:
> Upgrade python to 3.11
>
> R=bryner
>
> Bug: 1500415
> Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
> Reviewed-by: Brian Ryner <bryner@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

Bug: 1500415
Change-Id: I0cce81772186a26c3bdb67c5b49ce383b8a1443e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5118884
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Brian Ryner <bryner@google.com>
1 year ago
Josip Sokcevic 18bb70aed6 Revert "Upgrade python to 3.11"
This reverts commit 6a167d1e1f.

Reason for revert: https://crbug.com/1511105

Original change's description:
> Upgrade python to 3.11
>
> R=bryner
>
> Bug: 1500415
> Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
> Reviewed-by: Brian Ryner <bryner@google.com>
> Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>

Bug: 1500415
Change-Id: I8d0b04ca679c1581d4572e89efbb8cf2012cfa78
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5118878
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
1 year ago
Josip Sokcevic 6a167d1e1f Upgrade python to 3.11
R=bryner

Bug: 1500415
Change-Id: Ie379744131f7a9ced204a31f21079cb697c889a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5030767
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
1 year ago
Jeff Yoon d9dab49dc6 [dirmd] Roll dirmd into depot_tools
Changes included:
* crrev/c/5079176

Bug: 1505875
Change-Id: I5407acdec01043c679228aa09f2577dfd4c614ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5115874
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeff Yoon <jeffyoon@google.com>
1 year ago
recipe-roller 1be8112f4d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761886748901891713

recipe_engine:
77b6d81cb7
  77b6d81 (jonahhooper@google.com)
      [swarming] [recipe] Support non-finalized task results returned...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I37c16d7799fa0baa940cac15948bb7489c2cf853
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5115873
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1 year ago
Takuto Ikuta aa65be9856 autoninja: cache negative result of gcloud account check
This is to remove 1~3 seconds from no-op build using autoninja.

Bug: b/309720176
Change-Id: I2c15a43517d5a99eae794015c18c884a3f3fdef4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5092847
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Philipp Wollermann <philwo@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
1 year ago
recipe-roller eddb1eed5e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761957845504635889

recipe_engine:
8ab71176a6
  8ab7117 (vadimsh@chromium.org)
      Revert "[swarming] [recipe] Changed prpc version of the swarmin...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie2ff012fc36feeacac1c856b430ca20ea7f01801
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5113004
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1 year ago
recipe-roller 14f85613ae Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761968538861863873

recipe_engine:
b4cc213c27
  b4cc213 (jonahhooper@google.com)
      [swarming] [recipe] Changed prpc version of the swarming CLI to...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I77a9a6d36852331bcd97cfa77d33e99612c80fcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5113001
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1 year ago
recipe-roller 4d2ef1c41d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8761970424400254529

recipe_engine:
99fd1ace63
  99fd1ac (gregorynisbet@google.com)
      Add funcall function to recipe API.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I950491afb8bf918153f957f2495f67794362036f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5112999
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
1 year ago
Scott Lee 1714cc6e5a [depot_tools] fix args to pass --depth
The current code appends "--depth 1" as a single parameter.

Change-Id: I87cf34ffc45d0d9ce49453a7449b82e526989924
Recipe-Nontrivial-Roll: infra
Recipe-Nontrivial-Roll: build
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5105224
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
Josip Sokcevic c90f05ebd3 [git cl]: Support --dependencies in new flow
This patch adds functionality for --dependencies if new stack change is
used. However, the user must ensure that parent branch didn't diverge by
running git rebase-update [-n].

Bug: 1441132
Change-Id: Ib2e3e841b6dd22bbdefdc7844d5d157b1d1241d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5095961
Auto-Submit: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
2 years ago
recipe-roller 7cd5059e92 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762290033355235505

recipe_engine:
00e6ad645f
  00e6ad6 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2d6ddad2ca9c to d8744c99a9e1

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic3b2a7d5813cf726304067e2ba51f8d630133597
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5103468
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
Eric Lok 6c172e5efc Update version of reclient to 0.124.1
Fixes the issue where failure to read an input file fails the entire remote action.

http://shortn/_7Lc4quSjb5

BUG=b:302230815
TEST=Build chromeos-chrome locally

Change-Id: I8ff8efc789b0f22e967df8d30b4ebbed415c4cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5101699
Auto-Submit: Eric Lok <lokeric@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Eric Lok <lokeric@google.com>
2 years ago
Chenlin Fan 05a55efaa9 Revert "New vpython to depot_tools."
This reverts commit 9e5fc28b6b.

Reason for revert: crbug.com/1506442

Original change's description:
> New vpython to depot_tools.
>
> This change includes commits:
> 00e23cbde55df05e0e42f7a574c79ff8bcf589c4 vpython: match tag before verify
>
> Bug:1501997
> Change-Id: Ibabde88c588a830707bf14be7e2998fa4b4152fc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065788
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Chenlin Fan <fancl@chromium.org>

Bug: 1501997
Change-Id: I7de1b42f2dbd661cf05371572be3d5e1e9785680
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5091007
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
2 years ago
Josip Sokcevic cd3fa0389e [download_from_google_storage] Add envvar for num_threads
R=engeg@google.com

Change-Id: Iedfa8b1fb18a8687c134867d8db6ca9f738bb4ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5100054
Reviewed-by: George Engelbrecht <engeg@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
recipe-roller 303821d970 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762344770266258721

recipe_engine:
873a960e33
  873a960 (iannucci@chromium.org)
      [path] Completely remove "dynamic_paths" config.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I40de8b179badf079c652ea9d36ddc1b2c12693c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5099972
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
Scott Lee a3f3465f48 [depot_tools] add optional param `depth` in git checkout
It can be used to reduce the size of payloads to download in git fetch
operations.

Change-Id: I631af18bee01eaa829d3d4755a57935690a99a85
Bug: 1508826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5091760
Commit-Queue: Scott Lee <ddoman@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
recipe-roller 60f6c8a860 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762411459081330273

recipe_engine:
bb81400a29
  bb81400 (iannucci@chromium.org)
      [path] Remove dependency of path module on the platform module.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4c0fe7ce1c9a2e022a48703365a6b03e51b83029
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5095960
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
recipe-roller 916dda0a0b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762530363196749409

recipe_engine:
66b4d49410
  66b4d49 (iannucci@chromium.org)
      Remove platform_ext from Path.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib2e3017aa4e706578de2bde6e944bebb000aba21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5085724
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
recipe-roller 963000950b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762590764419191425

recipe_engine:
a2efad720f
  a2efad7 (iannucci@chromium.org)
      [step] Clarify how steps without cmd should be used.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iaf3b506ea7158ea42a5a7c033c7f4ecebc740faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5086211
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
Aravind Vasudevan 259774c3ac [gclient_scm] Update _CheckClean() to use `git status`
This change updates the `_CheckClean()` fn to use `git status` instead
of `git update-index` and `git diff-index`. The `_CheckClean()` fn is
run during every update and this change reduces the subprocess calls
made by it by half.

Change-Id: Ie9a23b0bce748bec4cac88df09655569e88e4841
Bug: 1501984
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5076224
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
2 years ago
recipe-roller 29672fbb92 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762595163202012961

recipe_engine:
1359680708~..d0e40ef56fa57e2dd3c0fae03f7bec723a56916a
  1359680 (olivernewman@google.com)
      [engine] Improve error for missing test deps
  d0e40ef (chanli@chromium.org)
      [recipes-py] Roll LUCI proto

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I7843c2b9dc889446993aeb74c82e1f3a3407da43
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5086208
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
recipe-roller 34256ef66a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8762596427481436401

recipe_engine:
b16c348b02
  b16c348 (bryner@google.com)
      Run archive module scripts under python 3.11.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I596527cf4c5c9fbc100ad90a060b2fd94a8a1dfc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5086207
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
2 years ago
Ryan Macnak 1fd8a6fa56 Roll packages to make linux-riscv64 available.
Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1138584
Bug: https://github.com/dart-lang/sdk/issues/48545
Change-Id: Ibcd10ce402abc8d3d4b3e6e2c045be9c97fb5c0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5076225
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
2 years ago
Chan Li 68a9928f42 [depot_tools] release led
Change-Id: I1c80cf822751b48791b88a848aa1dde4a1631eef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5084558
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
2 years ago
Dirk Pranke 081bca8cb3 git_cl: Attempt again to fix xml format on Win
It turns out that we need forward slashes in one place and back
slashes in two other places, so neither path by itself will work.

This CL changes things to do the slash substitution as needed.

Bug: 1502689
Change-Id: I05681ca5aff9f02a1c4ecc14c3c4e877312118ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5074657
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
2 years ago
Michael Savigny 8d97b6d89b Add mac-specific reclient tweak.
Set cas_concurrency for mac builds to 100.  It doesn't affect
performance on high-speed networks, but has shown an improvement on
networks prone to congestion.

Note that these adjustments have been checked out for builds on macs, and the cas_concurrency value being a default of 100 for mac doesn't mean it should be the default for other oses.

Bug: b/304616237
Change-Id: I9431fdb35737f9f2b236296625af2f2a31e52754
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5075857
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Michael Savigny <msavigny@google.com>
2 years ago
Takuto Ikuta cccca95d8f Revert^2 "autoninja.py: disallow external account from corp machine"
This reverts commit ed596dadf9.

Reason for revert:
Ignore exception when getting account for application default
credentials.

Original change's description:
> Revert "autoninja.py: disallow external account from corp machine"
>
> This reverts commit 0d0f28a4fc.
>
> Reason for revert:
> http://b/309720176#comment7
>
> Original change's description:
> > autoninja.py: disallow external account from corp machine
> >
> > This disallows Googler to use non-google account with reclient and
> > siso from corp machine.
> >
> > Bug: b/309720176
> > Change-Id: I8077eff8bbf47f579462e1fefa3609a5d492a013
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5035266
> > Reviewed-by: Philipp Wollermann <philwo@chromium.org>
> > Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
>
> Bug: b/309720176
> Change-Id: I62b4891b1e2e2554d088d162057982b95c8adcd7
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065849
> Reviewed-by: Philipp Wollermann <philwo@chromium.org>
> Owners-Override: Takuto Ikuta <tikuta@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: b/309720176
Change-Id: Ib9aef1b7fa8e3c9bb20ac8d6b461c6bcff72dc83
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065052
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
2 years ago
Aravind Vasudevan 8197d724a6 [detect_host_arch] Cache HostArch() function
From my recent go/gclient-sync-no-ops analysis, I noticed that
HostArch() is repeated called within get_builtin_vars() fn. The
`platform.architecture()` call made in arm-based systems and some x64 is
expensive and adds to gclient sync's runtime when repeatedly called.

When caching HostArch(), I noticed 22.4% speed-up in incremental no-op
gclient sync when run on arm-based machine.

Change-Id: I962c4fb0879d2931268f5bec1678ef782c56e7f2
Bug: 5076224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5076226
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
2 years ago
Ricardo Ribalda 8bd4d87e35 New lucicfg version
This change includes commit:
luci: cq_tryjob_verifier: Add support for check_all_revision_kinds
https://chromium-review.googlesource.com/c/infra/luci/luci-go/+/5057018

BUG=b:311018627
TEST=cipd ensure-file-resolve -ensure-file cipd_manifest.txt

Change-Id: I68a694358edfcc91bf98554af56b224ae8d2131d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5075457
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
2 years ago
Takuto Ikuta b5393e57bb ninjalog_uploader.py: use cipd to check authenticated account
Googlers authenticate with CIPD now to use reclient.

This is for
https://crrev.com/c/5035266/20#message-6bcb2d14f6758d0ba82d5cff99d699985c934707

Change-Id: Ie78675e6f7a8b47f7cafd85141f87139d1472f1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5058275
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Junji Watanabe <jwata@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
2 years ago
Chenlin Fan 9e5fc28b6b New vpython to depot_tools.
This change includes commits:
00e23cbde55df05e0e42f7a574c79ff8bcf589c4 vpython: match tag before verify

Bug:1501997
Change-Id: Ibabde88c588a830707bf14be7e2998fa4b4152fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5065788
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Chenlin Fan <fancl@chromium.org>
2 years ago