Commit Graph

3515 Commits (31c2115e6a5a75f2ad2da8afc68c17385a73b0cc)
 

Author SHA1 Message Date
iannucci 31c2115e6a Whitespace change to trigger cipd package for git installer.
TBR=phajdan@chromium.org, vadimsh@chromium.org
BUG=635421

Review-Url: https://codereview.chromium.org/2251883002
9 years ago
Robert Iannucci ed7d0e3804 Make git version numbers external to batch script.
R=stip@chromium.org, phajdan.jr@chromium.org
BUG=635421

Review URL: https://codereview.chromium.org/2249163005 .
9 years ago
phajdan.jr 40ca0f912a upload recipe bootstrap script (6a4b2e4)
TBR=martiniss

BUG=none

Review-Url: https://codereview.chromium.org/2249943004
9 years ago
phajdan.jr 289d03e1c8 git-cl status: allow querying just the status of current CL
BUG=620494

Review-Url: https://codereview.chromium.org/2252473004
9 years ago
tobiasjs 2836bcf810 Support additional user presubmit scripts named PRESUBMIT*.py.
This allows users to specify additional local presubmit tests that
do not need to exist as locally maintained changes to PRESUBMIT.py
files.

BUG=

Review-Url: https://codereview.chromium.org/2232203002
9 years ago
recipe-roller d090526a27 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/f50a2af3c5190b5b9780855085bd5a8df0d4ec58 Add the ability to dump initial recipe properties. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:628770

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2247133002
9 years ago
iannucci e7f68952a4 Change default codereview instance to one we maintain.
R=agable@chromium.org
BUG=637561

Review-Url: https://codereview.chromium.org/2250573002
9 years ago
iannucci e38699bd95 Fix broken git tests on mac.
Unfortunately there's a bunch of other broken stuff, but it's something :/

R=agable@chromium.org, thakis@chromium.org
BUG=607344

Review-Url: https://codereview.chromium.org/2244023003
9 years ago
tandrii 0c561b329b Cleanup old debugging code.
TBR=phajdan.jr@chromium.org
BUG=537417

Review-Url: https://codereview.chromium.org/2242123003
9 years ago
recipe-roller 00c6a32890 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/9581df50945817b006054cc9a4415a38803885a7 Revert of Require internal recipe tryjob (patchset #1 id:1 of https://codereview.chromium.org/2187493005/ ) (martiniss@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=628801

Recipe-Tryjob-Bypass-Reason: Autoroller
Review-Url: https://codereview.chromium.org/2244013002
9 years ago
martiniss 8f8e75bf00 Revert of Require internal recipe tryjob (patchset #1 id:1 of https://codereview.chromium.org/2187073004/ )
Reason for revert:
Waiting until can land all 3 next week.

Original issue's description:
> Require internal recipe tryjob
>
> BUG=628801
>
> Committed: 1dae95a13f

TBR=estaab@chromium.org,nodir@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=628801

Review-Url: https://codereview.chromium.org/2238403002
9 years ago
phajdan.jr 7929675b19 Add cipd recipe module to depot_tools
Copied from dfd62794c4/scripts/slave/recipe_modules/cipd/

It's being moved so that we can use the module in git recipe module in depot_tools. See https://goto.google.com/jmywn for more context.

BUG=635421, 629679

Review-Url: https://codereview.chromium.org/2243773002
9 years ago
maruel 9e198a84a9 Overhaul the README files a bit.
I didn't change the content much but deleted some obviously wrong stuff. Renamed
the files to .md so they will be processed by gitiles.

This change is in no way "sufficient" but that's a start.

R=tandrii@chromium.org

Review-Url: https://codereview.chromium.org/2232303002
9 years ago
recipe-roller dafd4f0c9a Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/85dbcfb4d81379d40b4461436daa5264008904bf Make recipes.py run give better messages. (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2238753002
9 years ago
recipe-roller 8a65a02164 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/aa5141a2236738b8a3d0e0fa57e1220066df29a4 Add support for operational arguments protobuf. (dnj@chromium.org)

R=dnj@chromium.org
BUG=chromium:628770

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2238723002
9 years ago
recipe-roller ca5f2c8c49 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/267db0f8954e4cd624e35d79482039811ab2cc5b Bump vendoring, move to proto3 release. (dnj@chromium.org)

R=dnj@chromium.org
BUG=chromium:628770

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2239473002
9 years ago
hinoka d2c82a25e8 Bot_update recipe output: Add 'Try Rebasing' to patch failure output
I still see confusion around patch failures.  This should clearify things.

BUG=

Review-Url: https://codereview.chromium.org/2231953002
9 years ago
phajdan.jr 7c3841abdf git cl set-commit: actually apply passed --rietveld / --gerrit options
BUG=600945

Recipe-Tryjob-Bypass-Reason: expectation changes expected and wanted
Review-Url: https://codereview.chromium.org/2234873002
9 years ago
phajdan.jr 6859823bf8 git cl set-commit: allow forcing code review system
Also default to latest patchset if no other one is specified locally.

BUG=600945

Review-Url: https://codereview.chromium.org/2230883002
9 years ago
recipe-roller eb0dc31ad0 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/6a4b2e47ebde45f546588ed9d733969fbc0634e7 Fixes for autoroll when repo_type=GITILES is used (phajdan.jr@chromium.org)

R=phajdan.jr@chromium.org
BUG=chromium:459840

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2234713002
9 years ago
recipe-roller fff0635af2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/87823726a3c8ef0016780ac1b752a758f2191a55 Require internal recipe tryjob (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=628801

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2229163002
9 years ago
martiniss 1dae95a13f Require internal recipe tryjob
BUG=628801

Review-Url: https://codereview.chromium.org/2187073004
9 years ago
Andrew Bonventre f83fa37b34 Add flag to rebase before gclient sync when applying a Gerrit patch
BUG=612417

Change-Id: I695bb93afd5ccde2c34b0dfc78989248e9b923e9
9 years ago
dsinclair 99d3017946 Make sure thread pool has at least 1 worker.
When doing a 'git cl archive' if there are no branches other then master the
command will crash with a 'ValueError: Number of processes must be at least 1'
when attempting to create the thread pool.

This Cl modifies the code to use the maximum of the changes and 1 as the number
of threads to create so we have at least one thread to work with.

Review-Url: https://codereview.chromium.org/2228723003
9 years ago
hanpfei 13f9c37185 Update top_dir with git repo root just when cwd locate in a git repo.
if when execute command "git rev-parse --show-toplevel" in a directory
that is not a subdirectory of a git repo, CheckCallAndFilter will not
throw exception, so the top_dir may be updated with a invalid path.

BUG=633971

Signed-off-by: hanpfei <hanpfei@gmail.com>
Review-Url: https://codereview.chromium.org/2200193003
9 years ago
brettw 4b8ed59b7b Update "git cl format" for GN changes.
"gn format" changed to remove the --in-place argument. This updates the
instructions for formatting and fixes existing usage.

git cl format --diff never worked, it just printed the full formatted output
unconditionally. This change improves things slightly by indicating there's a
diff for a file. A proper diff can be hooked up in a later stage if somebody
so desires.

Review-Url: https://codereview.chromium.org/2220123002
9 years ago
phajdan.jr d755329820 git: fix git cache support
It's now based on bot_update logic.

BUG=630601

Review-Url: https://codereview.chromium.org/2209383002
9 years ago
recipe-roller 5c24f62d69 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/28882da017c8638118faba38890c54d2507fabc0 Regenerate vendored items (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2204373003
9 years ago
recipe-roller f18f176089 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/0e4cf8f18b3062e8bd3eac0c09c2bfcb094f2e24 Improve verbose logging (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2213833003
9 years ago
wychen 3c1c172d64 Extract patchset in Rietveld URLs better
Parse URL in the form of:
https://domain/<number>/#ps<patchset>

Review-Url: https://codereview.chromium.org/2215433004
9 years ago
raphael.kubo.da.costa 05c8359194 gclient_scm: Make calls to "git merge-base" non-fatal.
It might be the case for some repositories that there is no merge base
between the current git HEAD and origin/master, which causes git
merge-base to exit with a non-zero code and cause calls to gclient
status/diff/pack to fail, as well as gclient sync if the repository in
question has been removed from DEPS.

This is true for the external/webrtc/trunk/talk repository, for example.
Its recent release branches (branch-heads/45 all the way to /53 at
least) have no ancestry shared with its master branch, so gclient
sync'ing from a Chromium M51 checkout to an M52 one (where it's no
longer in DEPS) fails because of the failed git merge-base calls.

We now ignore failures and just don't specify a merge base when calling
"git diff".

BUG=633962
R=iannucci@chromium.org,agable@chromium.org,maruel@chromium.org

Review-Url: https://codereview.chromium.org/2215673002
9 years ago
iannucci eaca0336ae Fix freeze when running from a non-root directory.
R=agable@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2204423002
9 years ago
dsansome 72decfedaa If cit is run with an unknown tool, print usage rather than throwing an exception
BUG=
TBR=hinoka

Review-Url: https://codereview.chromium.org/2181413004
9 years ago
borenet 9d5696da80 Make git recipe api add depot_tools to PATH
"git retry" assumes that depot_tools is in PATH; in some cases it isn't,
and there's currently no way to add it.

BUG=

Recipe-Tryjob-Bypass-Reason: Expectations known to change
Review-Url: https://codereview.chromium.org/2192163002
9 years ago
nodir abb9b22752 remove luci hacks
the luci entry point is swarmbucket now

R=hinoka@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2196843002
9 years ago
recipe-roller 8bf327cbfa Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/a32538a0b1f13b77635f059d8438c8b10c3ac57a Refactor rolling, allow project filtering. (martiniss@chromium.org)
  https://crrev.com/36d9d216129000237e6c2d30e4d15db161a5b30f cq.cfg: switch to luci builders (nodir@chromium.org)

R=nodir@chromium.org,martiniss@chromium.org
BUG=629676

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2191753002
9 years ago
nodir 27d3c7ec06 cq.cfg: switch to luci builders
R=estaab@chromium.org
BUG=629676

Review-Url: https://codereview.chromium.org/2184253003
9 years ago
recipe-roller ca1655ac36 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/61ead7b5857f1ccb18d35403d66a43fe0d9422da expect_tests: cherry pick fca8c5f (nodir@chromium.org)

R=iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=629676

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2190713003
9 years ago
tandrii 4d843595aa git cl set-commit: fix for Rietveld if cq dry run is active.
If dry-run was active, git cl set-commit didn't actually trigger a
full CQ run, but was just a no-op.

TBR=machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2184643004
9 years ago
machenbach 1278dbd127 Enable testing ICU CLs on chromium trybots
BUG=631575

Review-Url: https://codereview.chromium.org/2183393002
9 years ago
recipe-roller caf2838015 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/7f3ae3a4fae4e71019d3434f8c1aa786bccb0e06 cq.cfg: add swarming builders (nodir@chromium.org)

R=estaab@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=629676

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2181413003
9 years ago
agable e3144ea359 Remove git-try from depot_tools
R=mmoss@chromium.org
BUG=609893

Review-Url: https://codereview.chromium.org/2188493004
9 years ago
agable c903d73f3c Give 'gclient revert' a --merge option to match sync
This is a workaround for the fact that 'gclient revert' calls
'gclient update' with the same `options` object, despite not
actually having the same set of command line options.

R=iannucci@chromium.org, kevcheng@chromium.org
BUG=631220

Review-Url: https://codereview.chromium.org/2184493002
9 years ago
recipe-roller cbfbd2c342 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/c5e569d259d3d408b4189baa912d0aebb6805302 raw_io: do not call os.path.exists on testdata (nodir@chromium.org)

R=iannucci@chromium.org,nodir@chromium.org,martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2184523002
9 years ago
martiniss ac74456f1e Require recipe tryjob in CQ
BUG=628801

Review-Url: https://codereview.chromium.org/2157503003
9 years ago
recipe-roller 6f3bb6a3f2 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

recipe_engine:
  https://crrev.com/dc09456c693ea913133396141d8d2ad384254ae9 Validate previous step result before attempting to access (martiniss@chromium.org)

R=martiniss@chromium.org
BUG=

TBR=martiniss@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2175393002
9 years ago
tandrii 6da50398be bot_update: improve UX when gclient is not configured.
Instead of long stacktrace, explain what went wrong.

R=sergiyb@chromium.org,andybons@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2175343002
9 years ago
martiniss 8697dfcf8b Fix bot_update to correctly handle exceptions
If an exception occurs during a try block which prevents a step from actually executing, then the finally block's attempt to access step.active_result will fail, and the original exception will be hidden behind a new exception from the recipe engine. This CL changes this behavior so that the original exception will always fire.

Review-Url: https://codereview.chromium.org/2175103002
9 years ago
Nodir Turakulov aa71dd9f50 cq.cfg: add experimental swarmbucket builder
R=estaab@chromium.org, vadimsh@chromium.org
TBR=tandrii@chromium.org
BUG=629676

Review URL: https://codereview.chromium.org/2177713002 .
9 years ago
nodir 248331450c infra_paths module: swarmbucket config
add infra_swarmbucket config for infra_paths module to override
git_cache. The value of path_config property value will be specified by
kitchen.

This will still delete cache every time. The goal of this change is to
fix build.git swarmbucket builds.

TBR=dnj@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2176913002
9 years ago