1d2ac68728
testing_support: fix Gerrit releases URL.
...
R=szager@chromium.org,sergiyb@chromium.org
BUG=579160
Review URL: https://codereview.chromium.org/1820923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299408 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
375aa58877
Make the config -> pythonish conversion a gclient module function.
...
Also makes bot_update use this.
This allows for clank to manually set the gclient config.
BUG=590788
Review URL: https://codereview.chromium.org/1815863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299398 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
5b48e48c1a
Set default --lock_timeout to 5m
...
gclient-sync + git-cache are racy because if two different DEPS files
dependent on the same repo URL, even if depsed to different checkout
dirs, they use same git cache dir. If both checkout dirs are synced at
the same time, one of them cannot acquire a lock.
This is a cheap solution to change --lock_timeout option default value
from 0 to 5m.
R=hinoka@chromium.org
BUG=593468
Review URL: https://codereview.chromium.org/1785083005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299386 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
b12008466d
add AppEngine files downloaded for running tests to gitignore.
...
R=andybons@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1813813004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299383 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
139595ec3e
Gerrit git cl: temporarily disable gerritissue setting.
...
Reason: it breaks re-upload.
R=andybons@chromium.org,machenbach@chromiu.org,mmentovai@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1810683003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299354 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
9fc50db2cc
Gerrit git cl: fix change-id appending.
...
Special case when the change description has no footers, but looks
like a footer.
R=machenbach@chromium.org,andybons@chromium.org
BUG=579176
Review URL: https://codereview.chromium.org/1812803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299343 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
29c3b34610
bot_update: Rewrite to use properties, and add override options for patches.
...
Depends on https://codereview.chromium.org/1755593003
BUG=591172
Review URL: https://codereview.chromium.org/1741983002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299332 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
21217f42df
Convert the bot_update module to use properties
...
R=iannucci@chromium.org
BUG=591172
Review URL: https://codereview.chromium.org/1805113003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299329 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
a342c92be8
Gerrit git cl upload: record issue id for a branch.
...
BUG=
Review URL: https://codereview.chromium.org/1777603002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299312 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
5e8bb9a26b
Remove legacy DownloadHooks as no longer used.
...
R=andybons@chromium.org,jbudorick@chromium.org
BUG=579176
Review URL: https://codereview.chromium.org/1763153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299295 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
e7d3d1652c
Stop installing Gerrit commit-msg hooks in git cl config.
...
R=bauerb@chromium.org,ukai@chromium.org,andybons@chromium.org
BUG=579176,579160
Review URL: https://codereview.chromium.org/1799553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299293 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
6cf98c8bd5
git cl try-results: make color force-able.
...
Inspiration:
$ watch -n 10 "git cl try-results"
$ watch --color "ls -al --color"
R=nodir@chromium.org,sergiyb@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1799203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299291 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
5e2a68736a
Delete super old and unused git-cl-upload-hook.
...
Follow up on https://codereview.chromium.org/6758001
R=maruel@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1795753005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299283 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
20b3a844f0
Roll recipe dependencies (trivial).
...
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1798163002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299278 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
dabddd8a68
depot_tools: use ninja.exe instead of just ninja on Windows
...
BUG=437264
Review URL: https://codereview.chromium.org/1778243008
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299267 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
f3874aff0d
depot_tools: expose location of ninja
...
BUG=437264
Review URL: https://codereview.chromium.org/1787633003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299263 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
fa2707ee95
Log the location where we start to search .gclient for
...
R=phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/1789713004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299261 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
5fc657ba8a
Reland of Use gclient's git_cache setting in bot_update/api.py
...
https://codereview.chromium.org/1762513002/
Use gclient's git_cache setting in bot_update/api.py
BUG=589140
R=szager@chromium.org,iannucci@chromium.org
Review URL: https://codereview.chromium.org/1784043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299260 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
a516b59197
Roll recipe dependencies (trivial).
...
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1786883003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299256 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
62a585a61d
Roll recipe dependencies (trivial).
...
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1781083002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299218 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
059ff5017d
Roll recipe dependencies (trivial).
...
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1784623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299202 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
88e173be1a
depot_tools: adjust for resource API changes in recipe engine
...
This is rolling in https://codereview.chromium.org/1777003003
BUG=593420
Review URL: https://codereview.chromium.org/1785443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299187 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
8159374e44
Don't use 'git remote get-url', which is a new-ish feature.
...
Apparently most Mac's have git 2.6.2, which doesn't have this
feature.
This only affects end developers, so there's no urgency to push
this out to the bots.
TBR=agable@chromium.org,wkorman@chromium.org
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/1777043002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299185 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
d12b7210a7
Let package_from_installed actually package the json files it now writes.
...
I failed to do this in https://codereview.chromium.org/1706423002
BUG=495204
Review URL: https://codereview.chromium.org/1776283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299179 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
f04a6e6c14
git cl upload: print patchset when uploading to Rietvled.
...
R=andybons@chromium.org,phajdan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1772293003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299174 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
151ebcff42
Enable git-cl-land for git-cache checkouts.
...
The key piece here is that when running 'git cl land' from a cache checkout, refs/pending/* must be fetched from / pushed to the cache mirror's remote.
BUG=589140
R=wkorman,agable,iannucci,martiniss
Review URL: https://codereview.chromium.org/1777693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299166 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
907a1e7c8e
Revert of Use gclient's git_cache setting in bot_update/api.py (patchset #6 id:100001 of https://codereview.chromium.org/1762513002/ )
...
Reason for revert:
Roll into build breaks infra crons.
Original issue's description:
> Use gclient's git_cache setting in bot_update/api.py
>
> BUG=589140
> R=agable@chromium.org
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299120
TBR=agable@chromium.org,hinoka@chromium.org,hinoka@google.com,iannucci@chromium.org,wkorman@chromium.org,szager@chromium.org
BUG=589140
Review URL: https://codereview.chromium.org/1776193002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299160 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
ae9e80cc6b
Roll recipe dependencies (trivial).
...
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1771893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299159 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
6196039380
depot_tools: expose path to download_from_google_storage
...
BUG=585401
Review URL: https://codereview.chromium.org/1770383004
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299158 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
3ce9b4446d
Make CACHE_DIR set by default in most gclient configs.
...
This is needed because bot_update changed from getting the cache directory from
the global path module to the gclient config.
BUG=589140
Review URL: https://codereview.chromium.org/1768893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299143 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
baff4e1c8c
git-cl-try: print proper access denied error msg
...
git-cl-try does not properly print error message when the response
status code is 403, because response parsing is broken.
Fix response parsing.
R=sheyang@chromium.org, tandrii@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1773963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299137 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
88be9a1c5a
Use gclient's git_cache setting in bot_update/api.py
...
BUG=589140
R=agable@chromium.org
Review URL: https://codereview.chromium.org/1762513002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299120 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
1062500617
git cl: stop downloading Gerrit commit-hook with --squash mode.
...
BUG=579176
Review URL: https://codereview.chromium.org/1760063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299117 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
675bec320d
Update TODO for cleaning up DownloadGerritHooks.
...
TBR=phajdan.jr@chromium.org,andybons@chromium.org
BUG=579176
Review URL: https://codereview.chromium.org/1762343002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299110 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
57d8654568
git cl for Gerrit: make --squash generate Change-Id directly.
...
BUG=579183
Review URL: https://codereview.chromium.org/1763593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299107 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
c55295c327
temporary fix for repos that directly used DownloadHooks from git_cl.py.
...
TBR=phajdan.jr@chromium.org,andybons@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1768583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299106 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
09d7a6a817
git cl upload for Gerit no-squash: correct detect missing Change-Id.
...
BUG=579183
Review URL: https://codereview.chromium.org/1761743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299105 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
b371370eb9
cq.cfg: use presubmit builder to tryserver.infra.
...
Corresponding build CL: https://codereview.chromium.org/1759553007 ,
land OR revert both Cls in tandem.
TBR=phajdan.jr@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1763013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299098 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
18630d61d2
Gerrit: announce deprecation of auto-download of commit-msg hook.
...
BUG=579176
Review URL: https://codereview.chromium.org/1764453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299095 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
65874e1466
git cl: add python implementation of Change-Id generation.
...
This allows to generate new IDs on the fly without installing
commit-msg hook and works just fine on Windows.
BUG=579183
Review URL: https://codereview.chromium.org/1757133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299094 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
3c3c034d82
Add Gerrit's Change-Id handling to git_footers.
...
This should insert the message according to Gerrit's own commit-msg
hook implementation.
BUG=579183
Review URL: https://codereview.chromium.org/1758943002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299093 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
6593d9331d
Fix `git cl format` for dart code.
...
The part that runs dartfmt was relying on the part that runs (or not)
Clang to set the |env| local variable, which no longer happens after
https://codereview.chromium.org/1734863002 , making `git cl format` fail
with:
Traceback (most recent call last):
File "/usr/local/google/home/ppi/projects/depot_tools/git_cl.py", line 3957, in <module>
sys.exit(main(sys.argv[1:]))
File "/usr/local/google/home/ppi/projects/depot_tools/git_cl.py", line 3939, in main
return dispatcher.execute(OptionParser(), argv)
File "/usr/local/work/depot_tools/subcommand.py", line 252, in execute
return command(parser, args[1:])
File "/usr/local/google/home/ppi/projects/depot_tools/git_cl.py", line 3837, in CMDformat
stdout = RunCommand(command, cwd=top_dir, env=env)
UnboundLocalError: local variable 'env' referenced before assignment
It seems that we don't need to override env for dartfm anyway - the
clang part is doing this to put clang_format_tool in PATH.
This patch just drops env= from RunCommand for dartfmt.
Review URL: https://codereview.chromium.org/1760873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299072 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
b4f6a22935
git cl status: do not show CQ Dry run as 'commit'.
...
R=jsbell@chromium.org,phajdan.jr@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1764463002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299068 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
51c35a1ba9
Roll recipe dependencies (trivial).
...
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1750213005
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299063 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
15cdcfe30e
Add a Syzygy fetch config.
...
Review URL: https://codereview.chromium.org/1749213002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299057 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
24bf00858c
Roll recipe dependencies (trivial).
...
R=
BUG=
TBR=martiniss@chromium.org
Review URL: https://codereview.chromium.org/1753813003
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299041 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
8ea011cf6e
my_activity fetches issues from monorail. Also deleted some projects which are not hosted on monorail.
...
Blocked on deployment of https://chromereviews.googleplex.com/365267013/
BUG=monorail:762
Review URL: https://codereview.chromium.org/1754433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299032 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
5c2f2a6768
Fix recipe module git to use package_resouce.
...
TBR=phajdan.jr@chromium.org,martiniss@chromium.org
BUG=590806
Review URL: https://codereview.chromium.org/1751003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299027 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
70a43af908
Read got_revision_mapping from built in spec
...
Sometimes the spec passed in via parameters also have got_revision_mapping that
we want to use.
BUG=590788
Review URL: https://codereview.chromium.org/1748143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299015 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
e8f4da09ba
Revert of Fix git recipe module to use git.bad as package resouce. (patchset #1 id:1 of https://codereview.chromium.org/1742403002/ )
...
Reason for revert:
broke win builder bug 590806
Original issue's description:
> Fix git recipe module to use git.bad as package resouce.
>
> R=phajdan.jr@chromium.org
> BUG=579160
>
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299005
TBR=phajdan.jr@chromium.org,tandrii@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=579160
Review URL: https://codereview.chromium.org/1750733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299011 0039d316-1c4b-4281-b951-d872f2087c98
9 years ago
tandrii@chromium.org
martiniss@chromium.org
nodir@chromium.org
recipe-roller@chromium.org
phajdan.jr@chromium.org
sergiyb@chromium.org
szager@chromium.org
thakis@chromium.org
ppi@chromium.org
sebmarchand@chromium.org
sheyang@chromium.org
hinoka@chromium.org