aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
8,564 Commits
6 Branches
0 Tags
188 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '0a233e1760'
${ noResults }
Commit Graph

8564 Commits (0a233e176044b6d9b9ff9fb30b589bfb18f9ca04)
 

Author SHA1 Message Date
recipe-roller 0a233e1760 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828454759779818049

recipe_engine:
b49dd7dd21
  b49dd7d (iannucci@chromium.org)
      [step] Add documentation for nest behavior with greenlets.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I50ce1209d2e13e26637e50614e44a9ba9af710d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3321293
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller 45e67e97f8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828474893293298369

recipe_engine:
d26dc7cae0
  d26dc7c (gbeaty@chromium.org)
      Enforce that the correct type of test data was provided.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5de7cefbd0c424a250f557e32788b799d01923e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3321288
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Robert Iannucci ea3ba237b1 Move linux-arm64 to "fully supported" platforms section. 
R=dpranke

Change-Id: If4ff162d06ddd3bd4fb9df1b0ff7b88fcb655afe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3321286
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
 4 years ago
Robert Iannucci 1693c67f39 [led] Update led to get latest Build protos. 
R=ddoman, vadimsh, yuanjunh

Bug: 1254504
Change-Id: I109435f1cb9d2e01234168f691b9e53d9f9e864d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3321285
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Scott Lee <ddoman@chromium.org>
Commit-Queue: Scott Lee <ddoman@chromium.org>
 4 years ago
recipe-roller b5c7bf81ba Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828513270620724641

recipe_engine:
2beefed237
  2beefed (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e2de65e5c13c to 31175eb1a271

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I25b4196e13e1d9b45160100953d5c7977cc20e94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3319710
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller 82f35125f4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828561082276873953

recipe_engine:
cd5e256849
  cd5e256 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 929fc1600ebf to c01c6da99bb0

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifadf7044de0cc4399b44c63671ae12a90762eeff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3318587
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller 440d06ad1a Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828598189979054433

recipe_engine:
841e0e7d3e
  841e0e7 (tikuta@chromium.org)
      cas: update client revision

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22e996d97b6d308b24251d48de3fd7455b21b855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3317476
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller ed0048904e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828619596768405569

recipe_engine:
202ad55fc6
  202ad55 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 6578c26ab505 to f58188e7754b

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia7a41341305022675450a4eacf7508b84cfbcece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3316025
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller 203a6447ad Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828829717730219857

recipe_engine:
9e184408eb
  9e18440 (iannucci@chromium.org)
      Make python warning system work for warnings issued within gree...

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I88bd8874de603841048a382702063541a4207929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3315379
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Takuto Ikuta 26bfecdd07 include filename in LUCI config validation 
Fixed: 1254615
Change-Id: Ic6d5350c7a89a597c1126ec05235a3e63eb2ad09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3312231
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
 4 years ago
Garrett Beaty 18785bb297 Fix the environment for calling git number. 
Calling git number requires that that depot tools is on the path so that
git-number can be found and requires the CHROME_HEADLESS environment
variable to be set.

Change-Id: Iabb8ec6732ca2bcc0f3209449e23a7d0a4f629e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3314033
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 4 years ago
recipe-roller 3f1f2128c5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828846088460117121

recipe_engine:
f3b50b1d03~..6fc52ceac19cb00ced1b7976056c9e61add3868f
  f3b50b1 (gbeaty@chromium.org)
      Remove the include_log argument to file.write_raw.
  414e051 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f9ac0b5e43be to 378218dcdbb1
  7594d98 (iannucci@chromium.org)
      [warnings] Allow warnings to be ignored by wrapping functions.
  6fc52ce (iannucci@chromium.org)
      Add documentation support for DEPRECATED callouts.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I58c2210f47b7ebe47ecb127605930b61c71fdc94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3314937
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller 4b017c4d06 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828910261704258817

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
7e70723004
  7e70723 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 2927dee37b79 to 1ebd4afb7f59

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=sokcevic@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I16b384a76202717c95a25b71331be01043a6dbfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3314076
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
 4 years ago
Alex Gough 98be56f2e0 [windows_sdk] allow env json to not be relative 
SetEnv json entries in cipd packages for more recent Windows SDKs are
changed from:

       [
         "..",
         "..",
         "win_sdk",
         "Include",
         "10.0.17134.0",
         "um"
       ],

to

       [
         "Windows Kits",
         "10",
         "Include",
         "10.0.19041.0",
         "um"
       ],

so we should accept these paths now.

R=iannucci@chromium.org

Bug: 1250098
Change-Id: I56c84bc5ed46dda354e018b0abac2fae0bad8199
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3296663
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
 4 years ago
recipe-roller 3e68015b7f Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8828911520299782337

recipe_engine:
f923130a5a
  f923130 (bpastene@chromium.org)
      swarming: Only reserve 10% of a CPU core when collecting tasks.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4fba339158ce4347bfe3ff46c1f8a050cd483d34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3313431
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller fc79a33466 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829008290925895649

recipe_engine:
74207fa63a
  74207fa (yuanjunh@google.com)
      [autoroll] Run again no matter which type of error is thrown

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifa3c194323e0164d9d7726510b4c9fe193fbb981
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3312081
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller 04c4da0ef6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829020361632760209

recipe_engine:
4dcc60114c
  4dcc601 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 35f3f4525eec to 893bb89a656c

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iadfa0d49a464c0cc7e3911f2f340df2dfed26a0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3311738
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Josip Sokcevic 9cbe9a07ec Cache condition evaluation results in gclient 
Condition evaluation checks are fairly expensive, and turns out we
repeat a lot of checks. All those checks are also done in a single
thread.

With this cache on my workstation, a noop gclient runhooks takes 9.5s.
Without one, it takes 26.2s.

R=gavinmak@google.com

Change-Id: Ie00b7af22cd124d08dd9fd218de77b34bbdfe6ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309823
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 4 years ago
Christian Flach e685543855 Enable 'elaborate line editing' in `gclient_utils.AskForData` 
The (raw_)input Python function used by `gclient_utils.AskForData`
supports additional 'elaborate line editing' [1] [2] features, such as
the ability to use backspace to fix a typo, if the readline module is
loaded. Make sure that readline is loaded by importing it locally in
`gclient_utils.AskForData`.
It does not appear to be possible to write a test that verifies this
behavior - assigning `io.StringIO` to `sys.stdin` appears to cause
(raw_)input to fall back to basic input processing.

[1] https://docs.python.org/2.7/library/functions.html#raw_input
[2] https://docs.python.org/3/library/functions.html#input

Change-Id: Ie1c25b3fa2f3a255b78426c20e47c968cd7198ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3306613
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Christian Flach <cmfcmf@chromium.org>
 4 years ago
recipe-roller 5deb9c9a5d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829095859467187441

recipe_engine:
aebd6ccd5a
  aebd6cc (bryner@google.com)
      Update to new cffi wheel.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I32a0b29de79ae3563377a425a8ba46b197c9fb53
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309675
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller ad7c145263 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829097116635688641

recipe_engine:
6612e07002
  6612e07 (chanli@chromium.org)
      [buildbucket] Add infra to DEFAULT_FIELDS

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic553fa686f6a867f7319d628d42f83d91eaa539a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309664
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller 663c5e4f69 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829104662854196817

recipe_engine:
df92157f2c~..346c0ea55f67794598b8e5b264411c05ed565918
  df92157 (vadimsh@chromium.org)
      Add a simple `nodejs` recipe module.
  346c0ea (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e4c95e4e4cdc to 05791e01bd94

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8475dc305397a07373470d5f66248174b2ff9d0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309521
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller 554765c35d Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829105923369331681

recipe_engine:
6ea35fceeb
  6ea35fc (iannucci@chromium.org)
      Recipe 'run' command has a weirdo concept of how working directory

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9fc6896cf0780906617754142c0fe38686781de9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3309261
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Anthony Polito 8676aa925e Give better error message when proc fails to execute. 
Change-Id: I9dcbaa6dd287f0a5c2a749cfdf4607bddbf04734
BUG: 1274851
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307919
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>
 4 years ago
Garrett Beaty 320a1caf81 Add a method to the git API for running git number. 
Change-Id: Ieac13aac86df1c3e759f5aa66015ee6a3ac5c826
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307495
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Auto-Submit: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 4 years ago
Josip Sokcevic 804165b445 Revert "Use ort strategy when applying patch" 
This reverts commit d8c84597ce.

Reason for revert: breaks skiabuildbot, crbug.com/1273642

Original change's description:
> Use ort strategy when applying patch
>
> ort is faster and fixes bugs in recursive strategy.
>
> Bug: 1260085
> Change-Id: Ib8523d45da5cb0beea957b6ab706101d55bdc1f8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3276506
> Commit-Queue: Anthony Polito <apolito@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@google.com>
> Reviewed-by: Anthony Polito <apolito@google.com>

Bug: 1260085
Bug: 1273642
Change-Id: Iece472547549363733fd2fa8fe5240d39df744a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307500
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 4 years ago
recipe-roller 512ca5c38e Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829187715444793217

recipe_engine:
6405fa87ee
  6405fa8 (gbeaty@chromium.org)
      Don't report coverage when using the --py3-only flag.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0e548465b03d54ab24523938f304d74dc5ce2fee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307499
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller 0b037419f5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829188966380336977

recipe_engine:
4d492867cf
  4d49286 (iannucci@chromium.org)
      Fix ResourceWaiter to not accidentally sort by gevent.Channel

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3ef516874efee21a099f3d37e42324e2c801668d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3307497
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Garrett Beaty 2e486c0d9d Replace can_fail_build with raise_on_failure. 
The step API now supports the same functionality that can_fail_build
provides, so standardize on that argument rather than maintaining a
duplicate mechanism.

Bug: 1274644
Change-Id: Idcc3c0dacbab8d2d786b27ec277713063da6d334
Recipe-Manual-Change: build_limited
Recipe-Manual-Change: infra
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3301439
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
 4 years ago
Garrett Beaty 51d99b2f3a Fix the use of raw_io output placeholders. 
In order to enforce that the test data provided for placeholders is of
the appropriate type (text vs binary), existing mismatches must be
resolved. This will prevent type mismatch issues from occurring when
switching builders to use python3.

Bug: 1273548
Change-Id: I83da25432b67853992d7771aba558fd38520a24e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3300310
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
 4 years ago
recipe-roller 02f4003fdb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829229854762889089

recipe_engine:
ba4a4b2d4f
  ba4a4b2 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 83708e8181ac to 7422359d33c6

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6a5dffb0ecdd5648f53f62d38f96cefece6f874f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3305986
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller d91735a9ab Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829238675179401809

recipe_engine:
6d57d876da
  6d57d87 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 660e637467d1 to 0f5c78ebfa5f

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iee91c2171db77513d7895dac8e5e3a8434953e6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3305977
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Fumitoshi Ukai 2ffa1bde79 Roll out goma client VERSION=239 
Bug: b/206705242
Change-Id: I8c9c02b978559bf3b26a9ebdbb4aa31eace97c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3300807
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
 4 years ago
Brian Ryner afb82b2cfe Update to new cffi wheel. 
This removes the libffi.so.6 dependency on Linux.

Bug: 1247674
Change-Id: I271bc6525ffbe8bd413e730b23365e1bc52aa16f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3299731
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
 4 years ago
recipe-roller 646c3cd4d6 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829714939111375777

recipe_engine:
a8f2ad5eff
  a8f2ad5 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 8316a4907135 to 3f6049a5711c

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibe4b0d8610503e34ff4aeb09e05148be4c699fa9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3299768
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
recipe-roller b23a88a7c7 Roll recipe dependencies (nontrivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8829745138191541841

Please review the expectation changes, and LGTM+CQ.

recipe_engine:
206cd301ad
  206cd30 (gbeaty@chromium.org)
      Remove the log from write_raw.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=dpranke@google.com

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ifb9fe37d3d17fdb9b13ddab317c3357bf4e014b1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3298693
Auto-Submit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
 4 years ago
Josip Sokcevic a29f589a15 Make fix_encoding_test py3 compatible 
And run it in presubmit checks

R=gavinmak@google.com

Change-Id: If2a8848f6ce85c466f45d9bf0f4fca6b4d75312f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3296677
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 4 years ago
Josip Sokcevic b6c1ed40d5 Make presubmit_unittest py3 compatible 
And run it in presubmit checks

R=apolito@google.com

Change-Id: I1521fe4dd9fd5fe391459a00a91f03399b15b36a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292211
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
 4 years ago
recipe-roller cfb30ff2a3 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8830172328172143009

recipe_engine:
0dc8afb3a9
  0dc8afb (iannucci@chromium.org)
      [cipd] Move ensure_tool to non-cacheable directory

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9a53009ab6f8d0a0378b5346f5bca750fe42de7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292358
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Josip Sokcevic 6635baff5b Make CannedChecksUnittest py3 compatible 
R=apolito@google.com

Change-Id: I24610ca05536b4ac6eed2c0a33ef411650b46dd0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292089
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 4 years ago
recipe-roller 90da0e1518 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8830174212818503905

recipe_engine:
cb62e2ac49
  cb62e2a (vadimsh@chromium.org)
      Add a simple `golang` recipe module.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0bfa5517c292fc1a5d055dc13f67e69c73989974
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3292355
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Josip Sokcevic 11c32b5f69 Run py3 compatible unit tests with py3 
R=apolito@google.com

Change-Id: Id5e4f99ccb9d284ac09c2c4dd0fa57e59cb54f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3291894
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
 4 years ago
Anthony Polito af6bc7c015 add vpython3 to tests that run under vpython3 
Change-Id: I51aece95bed6d32faf6f3f93591a7bdf459b3edc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3291901
Auto-Submit: Anthony Polito <apolito@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
 4 years ago
recipe-roller 57bf1fc016 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8830193087644129041

recipe_engine:
03702dfe10
  03702df (iannucci@chromium.org)
      [engine] Make step names internally coerce to `str`.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I865c486d47b13b4f9eed37600bda67a273a73a5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3291896
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Yiwei Zhang c40274f5d8 roll lucicfg to v1.30.4 
To pickup:
  * https://crrev.com/c/3290046
  * https://crrev.com/c/3290193

R=vadimsh

Change-Id: I72ac9a25100a89d201929c1727cf23df1a7206df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3290283
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Reviewed-by: Dirk Pranke <dpranke@google.com>
 4 years ago
Alex Gough 1c7dec337d [windows_sdk] Use correct path within cipd package 
Previous CL[0] had the paths inside the SDK wrong so did not
correctly find the SetEnv.x64.json files in recent cipd packaged
SDKs. The 'win_sdk' portion was not necessary.

Downloading the cipd packages and verifies the old and new paths:

gci . -File -Recurse | Where-Object {$_.Name -match 'SetEnv.x64.json'}

CPID-----------------\
C:\src\dt\tmp\new-sdk\ Windows Kits\10\bin\SetEnv.x64.json
C:\src\dt\tmp\old-sdk\ win_sdk\bin\SetEnv.x64.json

[0] https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3283800

R=iannucci@chromium.org

Bug: 1250098
Change-Id: I579fd288824ca9014176b7b1c221affd966fb953
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3290913
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 4 years ago
Yuanjun Huang 176a9e8764 [cipd] Update bb tool 
bb batch cli retries on sub-request level.
Change logs:
  infra/infra:
    3c772505..0e7a6d8b
  luci-go
    da9044a7..ab1a8c041d

Bug:1269620
Change-Id: I8905a808b40da92fe9f34453f1bc48ecbdadba1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3286664
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Yuanjun Huang <yuanjunh@google.com>
 4 years ago
Gavin Mak d8c84597ce Use ort strategy when applying patch 
ort is faster and fixes bugs in recursive strategy.

Bug: 1260085
Change-Id: Ib8523d45da5cb0beea957b6ab706101d55bdc1f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3276506
Commit-Queue: Anthony Polito <apolito@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Anthony Polito <apolito@google.com>
 4 years ago
recipe-roller 64cb3ee4cd Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8830333743599813745

recipe_engine:
0f2cbbeaa0
  0f2cbbe (zhaoyangli@chromium.org)
      Add get sub invocation api to ResultDB recipe API

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ida7cc9996466fb490e4b8f570319adb9304c8ea9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3288873
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 4 years ago
Robert Iannucci 41ed8341a5 [windows_sdk] Fix json finder arguments. 
R=bryner

Bug: 1250098
Recipe-Nontrivial-Roll: build
Recipe-Nontrivial-Roll: build_limited
Recipe-Nontrivial-Roll: infra
Change-Id: If19660a8ae9f1c3f4946b9367e150d2bf9b097a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3288863
Reviewed-by: Brian Ryner <bryner@google.com>
Commit-Queue: Brian Ryner <bryner@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
 4 years ago