Michael Anthony Knyszek
							
						 
						
							 
							
							
							
								
							
								9957a266a0 
								
							
								 
							
						 
						
							
							
								
								Update CQ proto to latest version  
							
							 
							
							... 
							
							
							
							Bug:
Change-Id: Iefa3a7bd449dfbe29450597d4ead73626c5315b1
Reviewed-on: https://chromium-review.googlesource.com/636167 
Commit-Queue: Michael Knyszek <mknyszek@google.com>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Aaron Gable
							
						 
						
							 
							
							
							
								
							
								0213723929 
								
							
								 
							
						 
						
							
							
								
								Rietveld upload.py: send remote url instead of root hash  
							
							 
							
							... 
							
							
							
							Using the remote url is much more useful than the hash of the
first commit in the repo, since we can use it to track down
repos, teams, and people still using Rietveld for review.
Bug: 600469
Change-Id: I067594794ba77692c11daf63b5f5844d36209a08
Reviewed-on: https://chromium-review.googlesource.com/556301 
Reviewed-by: Andrew Bonventre <andybons@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org> 
							
						 
						
							8 years ago  
						
					 
				
					
						
							
							
								 
								Paweł Hajdan, Jr
							
						 
						
							 
							
							
							
								
							
								beec006697 
								
							
								 
							
						 
						
							
							
								
								gclient validate: add schema checking  
							
							 
							
							... 
							
							
							
							Bug: 570091
Change-Id: I1297f817f2e3d791c22b256de40f12c0c23dceb5
Reviewed-on: https://chromium-review.googlesource.com/500807 
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Aaron Gable
							
						 
						
							 
							
							
							
								
							
								edfd7cd8da 
								
							
								 
							
						 
						
							
							
								
								Workaround Python Issue 26083 in upload.py  
							
							 
							
							... 
							
							
							
							This issue is fixed in Python 2.7.12, but we don't guarantee
that we use that version everywhere. The root issue is that,
on certain platforms (e.g. Mac), the exception indicating that
the underlying command (e.g. 'hg') was not found is too large,
and loading the pickle representing the exception fails.
This CL catches this specific exception and treats it identically
to the OS properly raising a 'command not found' code.
BUG=699173
Change-Id: I0483ab0d1d0b6a3dfcfd26f2d9644817b5b5284f
Reviewed-on: https://chromium-review.googlesource.com/455537 
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Andrii Shyshkalov
							
						 
						
							 
							
							
							
								
							
								e1fe1ff075 
								
							
								 
							
						 
						
							
							
								
								Update CQ proto files to 07b713a88.  
							
							 
							
							... 
							
							
							
							This includes gerrit_cq_ability verifier.
TBR=sergiyb@chromium.org,rmistry@chromium.org
BUG=
Change-Id: Ifdb09bb33dd6a6fc7fdcb592e6bc4a2f8ac474ad
Reviewed-on: https://chromium-review.googlesource.com/444767 
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Andrii Shyshkalov
							
						 
						
							 
							
							
							
								
							
								dd013e2b68 
								
							
								 
							
						 
						
							
							
								
								Update CQ config protobuf.  
							
							 
							
							... 
							
							
							
							R=machenbach@chromium.org 
BUG=644915
Change-Id: Id0035e8b286c0f5b4c0c41aec7458965b9bd1a39
Reviewed-on: https://chromium-review.googlesource.com/421514 
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Mike Stipicevic
							
						 
						
							 
							
							
							
								
							
								a719d3dcf0 
								
							
								 
							
						 
						
							
							
								
								Retry up to three times on upload timeout.  
							
							 
							
							... 
							
							
							
							BUG=668526
Change-Id: Id49f1c1394a72880410eb06ba7356307fff7e8c5
Reviewed-on: https://chromium-review.googlesource.com/414496 
Commit-Queue: Mike Stipicevic <stip@chromium.org>
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Sergiy Byelozyorov
							
						 
						
							 
							
							
							
								
							
								1f14230d05 
								
							
								 
							
						 
						
							
							
								
								Bump timeout to upload files to Rietveld  
							
							 
							
							... 
							
							
							
							BUG=668526
Change-Id: I8aa762e8836ddc4838baaca803de17f3ffcb1ad2
Reviewed-on: https://chromium-review.googlesource.com/414908 
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								scottmg
							
						 
						
							 
							
							
							
								
							
								ae09f5fa13 
								
							
								 
							
						 
						
							
							
								
								Default to not using --find-copies-harder  
							
							 
							
							... 
							
							
							
							It's too ridiculously slow on Windows and Mac, and there's very little benefit to finding files that were "copied" from an historical file (as
opposed to one that's in the current patch).
BUG=544889
Review-Url: https://codereview.chromium.org/2488823002  
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								Aaron Gable
							
						 
						
							 
							
							
							
								
							
								6ff1fc0e01 
								
							
								 
							
						 
						
							
							
								
								Automatically map urls to their raw appengine forms  
							
							 
							
							... 
							
							
							
							BUG=657216
R=dnj@chromium.org 
Review URL: https://codereview.chromium.org/2431893002  . 
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								hinoka
							
						 
						
							 
							
							
							
								
							
								8ea74908a6 
								
							
								 
							
						 
						
							
							
								
								depot_tools: Remove third_party/gsutil  
							
							 
							
							... 
							
							
							
							A quick "git grep gsutil" reveals that this is no longer being used, and all
references to gsutil are pointed to gsutil.py.
BUG=
Review-Url: https://codereview.chromium.org/2280023003  
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								agable
							
						 
						
							 
							
							
							
								
							
								f14eaff814 
								
							
								 
							
						 
						
							
							
								
								Remove --base_url from git cl and upload.py  
							
							 
							
							... 
							
							
							
							R=tandrii@chromium.org 
BUG=638750
Review-Url: https://codereview.chromium.org/2271873003  
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								nodir
							
						 
						
							 
							
							
							
								
							
								ca166003fb 
								
							
								 
							
						 
						
							
							
								
								upload.py: honor explicit empty title  
							
							 
							
							... 
							
							
							
							R=pauljensen@chromium.org 
BUG=
TEST=PatchSet 3 of this CL
Review-Url: https://codereview.chromium.org/2096123003  
							
						 
						
							9 years ago  
						
					 
				
					
						
							
							
								 
								vapier
							
						 
						
							 
							
							
							
								
							
								9f343717f1 
								
							
								 
							
						 
						
							
							
								
								handle configparser rename in python3  
							
							 
							
							... 
							
							
							
							The ConfigParser module was renamed to configparser, so update the
two modules using it to try both (and default to the new name).
Review-Url: https://codereview.chromium.org/2076653002  
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								mgiuca
							
						 
						
							 
							
							
							
								
							
								1dfe43ca1a 
								
							
								 
							
						 
						
							
							
								
								Simplify octal constants in Python code (e.g. 0o0700 -> 0o700).  
							
							 
							
							... 
							
							
							
							Review-Url: https://codereview.chromium.org/2075923003  
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								vapier
							
						 
						
							 
							
							
							
								
							
								2cc483c1d2 
								
							
								 
							
						 
						
							
							
								
								git cl upload: stop using deprecated except syntax  
							
							 
							
							... 
							
							
							
							The newer form works with python2 and python3.
Review-Url: https://codereview.chromium.org/2076643002  
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								vapier
							
						 
						
							 
							
							
							
								
							
								c094376847 
								
							
								 
							
						 
						
							
							
								
								git cl upload: convert to print_function  
							
							 
							
							... 
							
							
							
							This makes the code work both in python2 and python3.
Review-Url: https://codereview.chromium.org/2078553002  
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								vapier
							
						 
						
							 
							
							
							
								
							
								8057ac8802 
								
							
								 
							
						 
						
							
							
								
								use py3 compatible octal constants  
							
							 
							
							... 
							
							
							
							Review-Url: https://codereview.chromium.org/2076613002  
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								vapier
							
						 
						
							 
							
							
							
								
							
								45c2edf73c 
								
							
								 
							
						 
						
							
							
								
								httplib2: update to 0.9.2 release  
							
							 
							
							... 
							
							
							
							This is in preparation for adding py3 support.
Review-Url: https://codereview.chromium.org/2073823002  
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								nodir
							
						 
						
							 
							
							
							
								
							
								7aafc3f4ad 
								
							
								 
							
						 
						
							
							
								
								git cl upload: commit subject is default patchset title  
							
							 
							
							... 
							
							
							
							git cl upload asks the user to provide a patchset title.
If the user makes a commit per patchset, the subject of the commit may
be exactly what patchset title should be.
R=dnj@chromium.org, vadimsh@chromium.org 
BUG=582419
Review-Url: https://codereview.chromium.org/1868313002  
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								tandrii@chromium.org
							
						 
						
							 
							
							
							
								
							
								f04a6e6c14 
								
							
								 
							
						 
						
							
							
								
								git cl upload: print patchset when uploading to Rietvled.  
							
							 
							
							... 
							
							
							
							R=andybons@chromium.org,phajdan@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1772293003 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@299174 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								tandrii@chromium.org
							
						 
						
							 
							
							
							
								
							
								a1afbb986d 
								
							
								 
							
						 
						
							
							
								
								Roll cq_client.  
							
							 
							
							... 
							
							
							
							From infra_internal, revisions 6f979a..cd0150f.
TBR=sergiyb@chromium.org,machenbach@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1697053003 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298789 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								bratell@opera.com
							
						 
						
							 
							
							
							
								
							
								c53b8cbf72 
								
							
								 
							
						 
						
							
							
								
								Remove unused print_output argument from upload.py  
							
							 
							
							... 
							
							
							
							R=dpranke@chromium.org,tandrii@chromium.org
BUG=
Review URL: https://codereview.chromium.org/1545913002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298097 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								bratell@opera.com
							
						 
						
							 
							
							
							
								
							
								3a1707d767 
								
							
								 
							
						 
						
							
							
								
								Fix git cl upload deadlock.  
							
							 
							
							... 
							
							
							
							If the stderr buffer used in git diff became full
before stdout was completely consumed, git cl upload
would deadlock.
This also sets GIT_PAGER to be perfectly sure no pager
is triggered by the git commands run. I haven't
seen that as a problem but it's a reasonable (and
common) precaution.
BUG=558726
Review URL: https://codereview.chromium.org/1544813002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298090 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								20b08f266b 
								
							
								 
							
						 
						
							
							
								
								Update cq_client in depot_tools form CQ repo  
							
							 
							
							... 
							
							
							
							R=tandrii@chromium.org 
BUG=564557
Review URL: https://codereview.chromium.org/1534813002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298053 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								akuegel@chromium.org
							
						 
						
							 
							
							
							
								
							
								da93188cef 
								
							
								 
							
						 
						
							
							
								
								Remove akuegel@ from OWNERS.  
							
							 
							
							... 
							
							
							
							BUG=
TBR=sergiyb@chromium.org 
Review URL: https://codereview.chromium.org/1533853002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@298052 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								machenbach@chromium.org
							
						 
						
							 
							
							
							
								
							
								c1bb56e730 
								
							
								 
							
						 
						
							
							
								
								Roll CQ client changes 7d916d5..f59ed9f  
							
							 
							
							... 
							
							
							
							BUG=chromium:561530
Review URL: https://codereview.chromium.org/1490473004 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297753 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								tandrii@chromium.org
							
						 
						
							 
							
							
							
								
							
								ad6451a79e 
								
							
								 
							
						 
						
							
							
								
								Roll CQ client changes f5de663..7d916d5  
							
							 
							
							... 
							
							
							
							R=sergiyb@chromium.org 
BUG=
Review URL: https://codereview.chromium.org/1479983002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297729 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								6a43185c75 
								
							
								 
							
						 
						
							
							
								
								Updated cq_client  
							
							 
							
							... 
							
							
							
							R=akuegel@chromium.org 
BUG=562427
Review URL: https://codereview.chromium.org/1475033006 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297726 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								150aa7b955 
								
							
								 
							
						 
						
							
							
								
								Re-land: Removed virtualenv from depot_tools  
							
							 
							
							... 
							
							
							
							Original CL: https://codereview.chromium.org/1437483002/ .
R=dnj@google.com, tandrii@chromium.org, dnj@chromium.org, pgervais@chromium.org 
BUG=542922, 503067
Review URL: https://codereview.chromium.org/1407953011  .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297494 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								dnj@google.com
							
						 
						
							 
							
							
							
								
							
								16ab651b2d 
								
							
								 
							
						 
						
							
							
								
								Revert of Removed virtualenv from depot_tools (patchset  #1  id:1 of  https://codereview.chromium.org/1437483002/  )  
							
							 
							
							... 
							
							
							
							Reason for revert:
This CL over-aggressively removed the Windows bootstrap code used by /gclient.bat, which in turn downloads/installs the Windows toolchain, including Python. Labs can no longer provision Windows bots because of this.
update_depot_tools.bat did more than initialize the virtualenv. It also downloaded and installed Python, Git, and Subversion on Windows systems.
I'm reverting to restore the toolchain so we can create new Windows bots.
Original issue's description:
> Removed virtualenv from depot_tools
>
> This effectively reverts http://crrev.com/1195423002  and
> http://crrev.com/1205873002 .
>
> R=pgervais@chromium.org, tandrii@chromium.org 
> TBR=pgervais@chromium.org   # i wanna get my Fixit credit today :-)
> BUG=542922,503067
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=297491 
TBR=pgervais@chromium.org,tandrii@chromium.org,sergiyb@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=542922,503067
Review URL: https://codereview.chromium.org/1431173002  .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297493 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								9ca2fc13f9 
								
							
								 
							
						 
						
							
							
								
								Removed virtualenv from depot_tools  
							
							 
							
							... 
							
							
							
							This effectively reverts http://crrev.com/1195423002  and
http://crrev.com/1205873002 .
R=pgervais@chromium.org, tandrii@chromium.org 
TBR=pgervais@chromium.org   # i wanna get my Fixit credit today :-)
BUG=542922,503067
Review URL: https://codereview.chromium.org/1437483002  .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297491 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								7083f3cee5 
								
							
								 
							
						 
						
							
							
								
								Update CQ client lib  
							
							 
							
							... 
							
							
							
							R=akuegel@chromium.org 
Review URL: https://codereview.chromium.org/1412393002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@297201 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								stip@chromium.org
							
						 
						
							 
							
							
							
								
							
								798a9e3ecd 
								
							
								 
							
						 
						
							
							
								
								Revert of Temporary fix for codereview cert issue. (patchset  #3  id:2 of  https://codereview.chromium.org/1376333002/  )  
							
							 
							
							... 
							
							
							
							Reason for revert:
Outage is now over
Original issue's description:
> Temporary fix for codereview cert issue.
> 
> BUG=537763
> R=stip@chromium.org 
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296959 
TBR=tandrii@google.com,tandrii@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=537763
Review URL: https://codereview.chromium.org/1374223004 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296964 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								tandrii@chromium.org
							
						 
						
							 
							
							
							
								
							
								c4e1b91bce 
								
							
								 
							
						 
						
							
							
								
								Temporary fix for codereview cert issue.  
							
							 
							
							... 
							
							
							
							BUG=537763
R=stip@chromium.org 
Review URL: https://codereview.chromium.org/1376333002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296959 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								290e86a998 
								
							
								 
							
						 
						
							
							
								
								Updated cq_client  
							
							 
							
							... 
							
							
							
							R=pgervais@chromium.org, rmistry@chromium.org 
Review URL: https://codereview.chromium.org/1309393004 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296530 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								petermayo@chromium.org
							
						 
						
							 
							
							
							
								
							
								fed8b4e9c1 
								
							
								 
							
						 
						
							
							
								
								Update fancy_urllib to work with python-2.7.10  
							
							 
							
							... 
							
							
							
							This issue is cloned from https://codereview.chromium.org/1273083004/  for andreyu
BUG=chromium:517460
R=vapier@chromium.org 
Review URL: https://codereview.chromium.org/1281273002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296285 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								iannucci@chromium.org
							
						 
						
							 
							
							
							
								
							
								d61a4950b2 
								
							
								 
							
						 
						
							
							
								
								Changes to improve multiprocessing PRESUBMIT support in Windows  
							
							 
							
							... 
							
							
							
							* make RunTest's multiprocessing.Pool in the constructor of InputApi
    to avoid getting tripped up by chdir manipulation.
  * Don't do the split cyclic-import check when the invoker of the
    Pylint presubmit checks explicitly sends cyclic import check
    parameters via extra_args
  * fix pseudobug where ownership of the files variable was unclear,
    and pass all arguments on stdin (instead of mix of CLI + stdin).
  * fix bug in pylint which caused it to manipulate sys.path before
    spawning its subprocesses, which caused multiprocessing to fail
    on windows.
    * Note: This may carry a slight semantic change. Before, pylint would
      add all .py files' directories to sys.path while checking any of
      them. Now in parallel mode, pylint will only add the path of the
      single file to sys.path. This behavior actually mirrors Python's
      own behavior, so the check should be more-correct than before (and
      should cut down on pylint import scanning time with very large
      sys.path's).
    * If someone encounters an issue with this, please note that the
      GetPylint check also includes an extra_paths_list which is
      expressly for this purpose.
R=dpranke@chromium.org, kbr@chromium.org, maruel@chromium.org 
BUG=501012
Review URL: https://codereview.chromium.org/1208743002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295908 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							10 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								f3751949de 
								
							
								 
							
						 
						
							
							
								
								Use virtualenv to run commit_queue script  
							
							 
							
							... 
							
							
							
							R=pgervais@chromium.org 
BUG=503067
Review URL: https://codereview.chromium.org/1195423002 .
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295843 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								1d630b0c72 
								
							
								 
							
						 
						
							
							
								
								Update cq_client and add validate command to commit_queue binary  
							
							 
							
							... 
							
							
							
							R=akuegel@chromium.org, pgervais@chromium.org 
BUG=472612, 503068
Review URL: https://codereview.chromium.org/1200863002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295818 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								rmistry@google.com
							
						 
						
							 
							
							
							
								
							
								d91b7e3ccb 
								
							
								 
							
						 
						
							
							
								
								Find, upload and apply patchset dependencies.  
							
							 
							
							... 
							
							
							
							Here is an explanation of the changes in each module:
* git_cl.py -
IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency.
* upload.py -
Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/  lands).
* rietveld.py -
Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/  lands).
* apply_issue.py -
If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]).
apply_issue will then loop over the list applying each dependency.
Note: The apply_issue.py diff looks much worse than it is. Please see my comment in
https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 
Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/ ) and the following CLs created in my test Rietveld instance:
* https://skia-codereview-staging.appspot.com/931002   ('Branch1 CL')
* https://skia-codereview-staging.appspot.com/5001001  ('Branch2 CL')
* https://skia-codereview-staging.appspot.com/9881001  ('Branch3 CL')
* https://skia-codereview-staging.appspot.com/3951001  ('Branch3.1 CL')
Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs.
Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw 
BUG=502255
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 
Review URL: https://codereview.chromium.org/1149653002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295799 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								rmistry@google.com
							
						 
						
							 
							
							
							
								
							
								1c28dab9ee 
								
							
								 
							
						 
						
							
							
								
								Revert of [depot_tools] Find, upload and apply patchset dependencies (patchset  #17  id:360001 of  https://codereview.chromium.org/1149653002/ )  
							
							 
							
							... 
							
							
							
							Reason for revert:
Ran into a crash during the bot_update step here:
https://uberchromegw.corp.google.com/i/internal.infra.try/builders/infra-internal-presubmit/builds/62 
Original issue's description:
> Find, upload and apply patchset dependencies.
> 
> Here is an explanation of the changes in each module:
> 
> * git_cl.py -
> IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency.
> 
> * upload.py -
> Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/  lands).
> 
> * rietveld.py -
> Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/  lands).
> 
> * apply_issue.py -
> If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]).
> apply_issue will then loop over the list applying each dependency.
> Note: The apply_issue.py diff looks much worse than it is. Please see my comment in
> https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 
> 
> 
> Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/ ) and the following CLs created in my test Rietveld instance:
> * https://skia-codereview-staging.appspot.com/931002   ('Branch1 CL')
> * https://skia-codereview-staging.appspot.com/5001001  ('Branch2 CL')
> * https://skia-codereview-staging.appspot.com/9881001  ('Branch3 CL')
> * https://skia-codereview-staging.appspot.com/3951001  ('Branch3.1 CL')
> Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs.
> 
> 
> Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw 
> 
> BUG=502255
> 
> Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295778 
TBR=agable@chromium.org,jrobbins@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=502255
Review URL: https://codereview.chromium.org/1200773003 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295782 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								rmistry@google.com
							
						 
						
							 
							
							
							
								
							
								c2b9bd03e9 
								
							
								 
							
						 
						
							
							
								
								Find, upload and apply patchset dependencies.  
							
							 
							
							... 
							
							
							
							Here is an explanation of the changes in each module:
* git_cl.py -
IF a local branch is being tracked AND a CL has been uploaded there THEN use the CL's issue number and latest patchset as a dependency.
* upload.py -
Uploads the patchset dependency, if it exists, to Rietveld (Rietveld will be able to parse this when https://codereview.chromium.org/1155513002/  lands).
* rietveld.py -
Adds utility methods to get patchset dependencies from the new Rietveld endpoint (the endpoint will exist when https://codereview.chromium.org/1155513002/  lands).
* apply_issue.py -
If CL3 depends on CL2 which in turn depends on CL1 then apply_issue will gather a list of all issues and patchsets to apply (Eg: [CL1:PS1, CL2:PS1, CL3:PS2]).
apply_issue will then loop over the list applying each dependency.
Note: The apply_issue.py diff looks much worse than it is. Please see my comment in
https://codereview.chromium.org/1149653002/diff/260001/apply_issue.py#oldcode169 
Tested end-to-end using a test Git repository (https://skia.googlesource.com/skiabot-test/ ) and the following CLs created in my test Rietveld instance:
* https://skia-codereview-staging.appspot.com/931002   ('Branch1 CL')
* https://skia-codereview-staging.appspot.com/5001001  ('Branch2 CL')
* https://skia-codereview-staging.appspot.com/9881001  ('Branch3 CL')
* https://skia-codereview-staging.appspot.com/3951001  ('Branch3.1 CL')
Opt into the new UI and observe the new 'Depends on Patchset' and 'Dependent Patchsets' sections in the above CLs.
Design doc is here: https://docs.google.com/document/d/1KZGFKZpOPvco81sYVRCzwlnjGctup71RAzY0MSb0ntc/edit#heading=h.6r6lt4tsvssw 
BUG=502255
Review URL: https://codereview.chromium.org/1149653002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295778 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								442811154b 
								
							
								 
							
						 
						
							
							
								
								Added CQ team as OWNERS for CQ-related stuff in depot_tools  
							
							 
							
							... 
							
							
							
							TBR=pgervais@chromium.org 
R=akuegel@chromium.org, tandrii@chromium.org, phajdan.jr@chromium.org 
Review URL: https://codereview.chromium.org/1183363002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295718 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								sheyang@chromium.org
							
						 
						
							 
							
							
							
								
							
								dc3a1c1083 
								
							
								 
							
						 
						
							
							
								
								Updated cq_client library with signcla verifier  
							
							 
							
							... 
							
							
							
							BUG=457428
Review URL: https://codereview.chromium.org/1177953005 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295680 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								67ac65cf1c 
								
							
								 
							
						 
						
							
							
								
								Renamed google.protobuf to protobuf26  
							
							 
							
							... 
							
							
							
							R=pgervais@chromium.org 
Review URL: https://codereview.chromium.org/1162993005 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295512 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								3ee55885bf 
								
							
								 
							
						 
						
							
							
								
								Updated cq_client library  
							
							 
							
							... 
							
							
							
							This introduces changes from https://chromereviews.googleplex.com/206957013/ .
R=akuegel@chromium.org 
TBR=pgervais@chromium.org 
BUG=471767
Review URL: https://codereview.chromium.org/1156373013 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295506 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								0b5a74a547 
								
							
								 
							
						 
						
							
							
								
								Insert third_party in to the beginning of PATH  
							
							 
							
							... 
							
							
							
							This allows to avoid conflicts with libraries in users' PATH
R=pgervais@chromium.org, tandrii@chromium.org 
Review URL: https://codereview.chromium.org/1161803004 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295497 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								sergiyb@chromium.org
							
						 
						
							 
							
							
							
								
							
								dc1283197c 
								
							
								 
							
						 
						
							
							
								
								Added tools to retrieve CQ builders from a CQ config  
							
							 
							
							... 
							
							
							
							R=pgervais@chromium.org 
Review URL: https://codereview.chromium.org/1153333003 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@295461 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago  
						
					 
				
					
						
							
							
								 
								sheyang@chromium.org
							
						 
						
							 
							
							
							
								
							
								002ffa0e3e 
								
							
								 
							
						 
						
							
							
								
								Remove apiclient package  
							
							 
							
							... 
							
							
							
							BUG=
Review URL: https://codereview.chromium.org/1091163002 
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@294877 0039d316-1c4b-4281-b951-d872f2087c98 
							
						 
						
							11 years ago