Commit Graph

7301 Commits (02ffb6f47a212714e68e34028d6bc23235f43f3c)
 

Author SHA1 Message Date
recipe-roller 99044852de Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/8d23e817d0aa858ca3032a6576a3903caf90e4bf (yiwzhang@google.com)
    Update protos from luci-go

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8425cb61417821d36789bb34ce1608279dc4a7bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2219822
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller b41a5cec3d Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/b52da73829e2147d8473eb84ed9b76b02dce09d0 (olivernewman@google.com)
    Reland "[swarming] Use ensure_tool() to install swarming"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2949de76a69a747948e412f24c68a94b4f9c3cbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2223241
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Robert Iannucci b19e1213cf [led] Update to latest version.
This should resolve issues with kitchen tasks complaining about
'impossible' errors.

R=yiwzhang@google.com

Bug: 1015181
Change-Id: Idf8abea7b8585173b6609514a47c81ae00dc1935
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2223101
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
5 years ago
Nodir Turakulov d5be5daff9 Roll prpc and rdb tools to the latest version
R=vadimsh@chromium.org

Change-Id: I8a0df0566e174e9d688daf8ba3ed4172c90a2af3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2220784
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
5 years ago
recipe-roller 721a721d08 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/58f654b6ca5f282aa70a5ec0a1510e9a6c318ff5 (yiwzhang@google.com)
    [luciexe] support output flag with differnt encoding based on extension

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I86e8ac2007e710af32e20c2d3535f047d1be60f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2219300
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Ryan Harrison 399b81d274 Add standalone tint gclient config
BUG=tint:1

Change-Id: Ie24a17c0d52ade62a4f2eb02d513f33011615113
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2219573
Auto-Submit: Ryan Harrison <rharrison@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
5 years ago
recipe-roller 93a9381c76 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/04d01abeecc5d7641e6b0c6a233a985559812602 (iannucci@chromium.org)
    [luciexe] Strip properties of `unicode` types.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I42bec6d8fc5748048a09216a9f3f71536842852a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2220856
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 7d311f5946 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/199d97fdb42377d9011045c594f3bd132e237522 (iannucci@chromium.org)
    [luciexe] Log uncaught exceptions in luciexe/cmd.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5839c12f59a0f8297757bc610635b84b1c72a33d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2220870
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller e4c9e6c19c Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/8819155845e1c94e00eae1b243aee0e79816d642 (tikuta@chromium.org)
    isolated: remove support for blacklist

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2f610459cbf62daac90d45c52c4ae29a7c58934c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2220869
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Robert Iannucci b8de90f2cb [led] Update to latest version.
Contains multiple improvements related to bbagent.

R=gbeaty@chromium.org, yiwzhang@google.com

Bug: 1015181, 1087651
Change-Id: I1ee63fe2e3f0d2a717725f3c01e6159af635dae4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2220867
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
5 years ago
recipe-roller 090475cde4 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/cd3a9f0d8c372d765cc5f7641b9601a1d96b3e8a (nodir@chromium.org)
    [resultdb] Add test_id_prefix and base_variant

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I15971c568bd2bb894c575c8e6f1cdde3e4243c0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2219574
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Robert Iannucci 4504fd580a Remove infra_paths module.
We no longer need it to bridge path differences between buildbot and
LUCI, and it shouldn't be in use downstream now either.

R=machenbach@chromium.org, martiniss@chromium.org, tandrii@chromium.org, yiwzhang@google.com

Bug: 1015181
Change-Id: Iaba2100653ae9f06799d1d510bef993f7f710dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2220171
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
5 years ago
Aaron Gable 6e7ddb698b Remove agable from depot_tools OWNERS and TODOs
Change-Id: I0667af4562208a111ab3673f3fca6aab655f5f26
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2218962
Auto-Submit: Aaron Gable <agable@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
Commit-Queue: Anthony Polito <apolito@google.com>
5 years ago
Ng Zhi An cdaf0be1f4 Add git completion helper to cl upload
This is similar in spirit to the helper flags in git subcommands, e.g.
try `git branch --git-completion-helper`. It provides a list of long
flags that the subcommands support, without repeating it manually in the
completion script. Note that this special flag is not returned in help,
so there is no noise.

To see the result, source the script, then `git cl upload --<TAB>`.

Change-Id: I82e280ceac5178b0e5fa52611b9a4125e6943337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2209926
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
5 years ago
Robert Iannucci 0c7d654c74 [bb] Update bb tool to contain latest protos.
R=nodir@chromium.org,  vadimsh@chromium.org, yiwzhang@google.com

Bug: 1015181,1086729
Change-Id: I94e1dffa334a60818c50ff09e155276147fa99a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216807
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
5 years ago
recipe-roller 24f3a385a3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/b2839ad3882c5f1412afbd31f72c45355e404932 (olivernewman@google.com)
    [cipd] URL-encode version in tool path

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I93b4896cf62236b82c73e67eed60978169af9b41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216796
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller b9f2cc0b8e Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/923fb4bfa6f6930bac2ba3f03162ce8c59e0eb93 (olivernewman@google.com)
    Revert "[swarming] Use ensure_tool() to install swarming"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I6fdb6bc6fe11155d0f33e3d2e72337391b7683db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216791
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Robert Iannucci f203902ee8 [lucicfg] Update to 1.14.3.
This correctly generates 'use_bbagent' in luci.recipe().

R=nodir@chromium.org, vadimsh@chromium.org, yiwzhang@google.com

Bug: 1015181
Change-Id: I7a0b0086a98600fd7429434ab244d82b58efa2d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216540
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
5 years ago
recipe-roller 1fc333a7d7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/567bbd0e945b1144e2343441deac92a661a17f9d (yiwzhang@google.com)
    [proto_module] Remove unused DEPS

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia55b38048e9e1cca05c967289c65a114bac09f9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216579
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Vadim Shtayura 0ec48260a2 [luci-auth] Update to the latest version.
Has support for generating tokens through LUCI Token Server.
Has somewhat nicer UX around `luci-auth context` usage.

R=iannucci@chromium.org
BUG=1082960

Change-Id: I2a77649b7ebbc5c99af4435afa929022a0e93ddb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216533
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
5 years ago
Vincent Scheib 2be61a1df4 Document the parameter {heading} avilable to --output-format-heading.
R=jsbell@chromium.org

Change-Id: Ia0db8fe7494306147e0e80f49e229f50b8603f09
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2214243
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
5 years ago
Andreas Papacharalampous 603989e2c0 add clarification for Python 3
Bug: None
Change-Id: Ie9cfc90b1dd4b241238e5f0a4c995979f7a0fbdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2213175
Auto-Submit: Andreas Papacharalampous <andreas@apap04.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
recipe-roller ea71aeab0b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/bf5c53d04c84487f31275133294f5a57145fecf4 (olivernewman@google.com)
    [swarming] Use ensure_tool() to install swarming
  https://crrev.com/9ddf1e1c6ae354ee17de8abd99dc37acdf4dbe60 (olivernewman@google.com)
    [isolated] Use ensure_tool() to install isolated

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2a56b974f6d840e5c846a43881211c82ca3c956b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2216058
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Richard He 42033b2c6a Fix gclient-new-workdir when source repo is shallow clone
When source repo is a 'shallow clone', `.git/shallow` is not linked to
the new workdir. Which makes running git command fails in new workdir.

Change-Id: I81d38b7b2cccc482711dcc1dd02ea06fbd01a56d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211635
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Richard He <linyhe@microsoft.com>
5 years ago
recipe-roller 74f67e29f7 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/4af7811ff97185909adb1a058be892162eaeca92 (olivernewman@google.com)
    [cipd] Add helper method for ensuring a CIPD tool

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I646a55a45f3c53b81ebddadebc28ddb50405e5cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2213182
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller db1a7975aa Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/db16f4a77fed59430dec426ff459339638a5bebd (iannucci@chromium.org)
    [comprehensive_ui] Use python instead of echo for windows compat.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1713e654fa76c4ce80569324a6902928863eb278
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2212954
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Edward Lesmes 942c97d626 update_depot_tools: Pull changes first before updating tools on Win.
Update git checkout before updating the tools.
If the scripts to update the tools are broken in the current revision,
this will allow us to get a new, hopefully working, revision instead of
leaving us stuck on a broken one.

We already do this for Linux.

Change-Id: I31856ebbd659d5360ad705dc39e5856b4140a19f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208625
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
Owen Rodley c9eb1c3712 Update lucicfg version.
Change-Id: Id0913dd89874a234b956bcba8905c5684b3892be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211111
Auto-Submit: Owen Rodley <orodley@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
5 years ago
Josip Sokcevic 14a83aec56 Reland "Use OS level locking in git_cache.py"
This is a reland of d3affaa624

Original change's description:
> Use OS level locking in git_cache.py
> 
> Without OS level locking it's possible to leave "lock" files on disk
> which will prevent next run to acquire those locks. This can easily
> happen if SIGKIL is issued.
> 
> R=apolito@google.com, ehmaldonado@chromium.org
> 
> Bug: 1049610
> Change-Id: Id87aa1376b9ea5ff0c2d14f3603636493ed1dd5b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2189333
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

Bug: 1049610
Change-Id: I58e65a10f7c779e0de1121ba7167c694996e390c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211189
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
Josip Sokcevic 8f6bfe301f Revert "Use OS level locking in git_cache.py"
This reverts commit d3affaa624.

Reason for revert: no attribute ignore_lock

Original change's description:
> Use OS level locking in git_cache.py
> 
> Without OS level locking it's possible to leave "lock" files on disk
> which will prevent next run to acquire those locks. This can easily
> happen if SIGKIL is issued.
> 
> R=​apolito@google.com, ehmaldonado@chromium.org
> 
> Bug: 1049610
> Change-Id: Id87aa1376b9ea5ff0c2d14f3603636493ed1dd5b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2189333
> Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Josip Sokcevic <sokcevic@google.com>

TBR=iannucci@chromium.org,ehmaldonado@chromium.org,apolito@google.com,infra-scoped@luci-project-accounts.iam.gserviceaccount.com,sokcevic@google.com

Change-Id: Iecc963e0a99d7f59f3f8801e529839346f9fbaf3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1049610
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2211186
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
Ilya Sherman 7aed4bb802 Fix `git cl format` for metrics XML files on Windows
* Call `os.path.normpath()` prior to comparing file paths
* Run Python files with `vpython`
* Pass `shell=True` for Windows commands, so that the PATH variable is
  defined: https://stackoverflow.com/a/32799942
  * While here, clean up similar call sites to drop an unnecessary cast.

Fixed: 1081763
Change-Id: I8096b3ad14a4675036a579fab537af1d94f12725
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2203422
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Ilya Sherman <isherman@chromium.org>
5 years ago
Ilya Sherman b67e60cd33 Add git cl format support for "structured" metrics
This matches the support for the other metrics subdirectories.

R=ehmaldonado@chromium.org

Bug: none
Change-Id: Ibf84e1d1b33e38843b8a11ff3299d4c0c3aa5eb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2173743
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Ilya Sherman <isherman@chromium.org>
5 years ago
Josip Sokcevic d3affaa624 Use OS level locking in git_cache.py
Without OS level locking it's possible to leave "lock" files on disk
which will prevent next run to acquire those locks. This can easily
happen if SIGKIL is issued.

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1049610
Change-Id: Id87aa1376b9ea5ff0c2d14f3603636493ed1dd5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2189333
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
5 years ago
recipe-roller 008b71ab13 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/33d170546318d569bda45360dde56b4bde7784cf (yiwzhang@google.com)
    Reland "[engine] export `LOGDOG_NAMESPACE` env var when running a step"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3f3eb84d60274d3c70e64ad25f7f0ec19f6372c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2210842
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller a0139c0aa3 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/6e7cf734a384f0d1daef9c1404474e70fd75798f (olivernewman@google.com)
    [swarming] Update swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I99bca58c2f32e9064e7d8fb43eb7864230d0d015
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2209918
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller f56c82ff22 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/69ea67ccefa38df2b05a9320879eebba9d3bd676 (yiwzhang@google.com)
    Revert "[engine] export `LOGDOG_NAMESPACE` env var when running a step"

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia5875585b29c811875985fdc9148267c683d100c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2209916
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller d8c6146c0b Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/0655aa3e1de7c0167302fb582a13f7cafd4866e7 (iannucci@chromium.org)
    Update go.chromium.org/luci protobufs.
  https://crrev.com/9ed63c7585afba169c36ef08ada467e210fcec3c (yiwzhang@google.com)
    [engine] export `LOGDOG_NAMESPACE` env var when running a step

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I00b981af1ab7f51cac3ad7eb644023d59a293c54
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2209664
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Ng Zhi An 4cfa04ff98 Fix extra spaces in git cl completion
The commands come from the output of git cl -h, which then goes through
an sed filter, matching on the ANSI escape sequence for green and reset.
This ends up having extra spaces, since the output aligns the
subcommands based on the longest subcommand. For shorter commands like
archive, it becomes "archive   ". So, tweak the sed regex to only
capture the part without the whitespaces.

Change-Id: I80a84f142520478547895f85def68331575fdd72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2209582
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
5 years ago
Ng Zhi An 620c56e90e Fix git cl completion
__git_cl_all_commands is a variable, so it should use the variable
parameter, ${}, not a command substitution $().

Change-Id: I81fc2c73afd85cc1f737af00fbc294d933145e22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2205456
Reviewed-by: Andrii Shyshkalov <tandrii@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
Edward Lesmes 002f97b35a Abort fetch, gclient, gsutil.py when update_depot_tools fails on Windows
We should fail when we fail to update depot_tools instead of continuing
the execution silently. Otherwise, developers might get stuck on a bad
depot_tools revision without knowing.

Change-Id: I0431a24a28a77aca8c66352939a0252c458b3e9d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208616
Reviewed-by: Josip Sokcevic <sokcevic@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
Ye Kuang 5a7be3da21 Roll out new goma client binary VERSION=200
ccc8255ac0

Bug: b/156546740
Change-Id: If754346ec49c7314b13160ea682c630e0e5ccd21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208512
Commit-Queue: Ye Kuang <yekuang@google.com>
Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com>
Auto-Submit: Ye Kuang <yekuang@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@google.com>
5 years ago
recipe-roller e67e41aa89 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/c032fdbdb5e726dbb2842c212a6ec237126fda56 (lamontjones@chromium.org)
    cq: correct property name.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I24d67cbe6b65d95f69eef08321102c9a9ec9c9a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2208209
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller c4fb197419 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/935b52680cfbf06efe126de0f68980a51472bfcd (yiwzhang@google.com)
    [engine] Support merge step in Stream Engine
  https://crrev.com/9612029d01ef2c99345f6b53dd15ece8bc75400e (yiwzhang@google.com)
    [luciexe] set default log level to info

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I43a2232ac8f1df0e29ece052f8e0edaa672bcb59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2204903
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 728fc62772 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/2209e8c4c0d99b6682a1c747015ba95a962bb088 (iannucci@chromium.org)
    Fix luciexe mode when stdout is populated from user space.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5e1c2a464ba1e69a4f5bafc35e0e9e89aedd938c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2204919
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
recipe-roller 5e0a4a6b80 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/270b341c5f36f1cdfa73ab7f190f961a1c8f7565 (olivernewman@google.com)
    [swarming] Update swarming client version

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ibc7e76407946ad6f3f9496fdd5c1b9827f640236
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2203271
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Robert Brandt beb877fe49 depot_tools: bugfix for py3 syntax and bytes/str changes
Also update copywrite header to conform to expectations.

BUG=chromium:1082354
TEST=locally, can upload commit with this fix

Change-Id: I5527cf9cc58fbab94f777b82008a422a3190f539
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2199884
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
5 years ago
recipe-roller 176bf64148 Roll recipe dependencies (trivial).
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (recipe_engine) into this repository.

recipe_engine:
  https://crrev.com/093ad4d4c27bcecdb3b80d36b4615692cde14524 (iannucci@chromium.org)
    [luciexe] Synthesize deprecated properties to ease transition.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.

TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3a4349b13ab05d5c31b8439104acdf2e78c4c704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2202664
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
5 years ago
Derek Morris 053213d049 Add a pan-project presubmit check for commits in tree
It's possible to add commit objects to the tree, and this can cause
some confusion for git's tools - if this happens to overlap with an
actual folder or a gclient-imported repo, the tree will be dirty.

This change finds this issue by scanning the tree and looking for a
commit object there.

Bug: 869594
Change-Id: Ia1f1fb22ab8f7ac1eed7b32dedad5c1296b1d67b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1842637
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Derek Morris <demorri@microsoft.com>
5 years ago
Simon Que 30ef5cb437 Update cipd_manifest for Goma client 80180e1e
R=tikuta@chromium.org, ukai@chromium.org, yekuang@google.com, yyanagisawa@chromium.org

Bug: b/155444722
Change-Id: Idb8c4a08a8094a5ec923d4ba0157d1142d9271b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2198271
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
5 years ago
Josip Sokcevic 8280ae5e0a Delete dirty bot_update workspace
File marker '.dirty_bot_checkout' indicates that bot_update checkout has
started. Such marker is removed on successful checkout.

If such marker is present before creation, it means previous run wasn't
successful and may have left workspace in a bad state. In that case,
delete working directory and continue with a clean checkout.

R=apolito@google.com, ehmaldonado@chromium.org

Bug: 1074260
Change-Id: Ic089eedc26f7c269d5342fae366899571d8f8d41
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2186273
Commit-Queue: Josip Sokcevic <sokcevic@google.com>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Anthony Polito <apolito@google.com>
5 years ago