aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
9,353 Commits
6 Branches
0 Tags
190 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from '0074158bf6'
${ noResults }
Commit Graph

9353 Commits (0074158bf6b73459ee93faffaa7853ca7ba931db)
 

Author SHA1 Message Date
Peter Kasting 0074158bf6 Fix various lint false positives. 
* C++11: Expressions related to type_traits templates. Cherry-pick of
  internal cl/477737746.
* C++20: requires-expressions. Cherry pick of internal cl/450768176.
* C++20: `co_return *p;`. Unique to Chromium (cpplint_chromium.py).

Bug: 1284275
Change-Id: I06ede7b708dfe71308f669a2d6c37d00ded6c086
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4226465
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
 2 years ago
Aravind Vasudevan f15baeae48 Revert "Warn users when .boto might be outdated" 
This reverts commit e2f35370f5.

Reason for revert: Potentially breaks https://source.chromium.org/chromium/chromium/src/+/main:build/fuchsia/gcs_download.py;l=34 

Original change's description:
> Warn users when .boto might be outdated
>
> Fixed: 1414152
> Change-Id: I887de64a72777c92413ee921099dd762361f6c5c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4251897
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> Reviewed-by: Traian Captan <tcaptan@chromium.org>

Change-Id: Idd403b3054643b437ee165b8af2e775dc7e1abb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4262468
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2 years ago
Joanna Wang 6b98cdcbc1 Check for detached HEAD state. 
Bug: 1416683
Change-Id: I538715d05170662001ac7193a86dbd2e7f50e3f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4258505
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
 2 years ago
Chan Li 78db513359 [depot_tools] Roll led 
To release https://crrev.com/8a2853232613a9b6ad94dfcb3ea911a41861b42b

Change-Id: I0781f63aed104691c992f81b735fe760bc02bf93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4256627
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 2 years ago
Aravind Vasudevan e2f35370f5 Warn users when .boto might be outdated 
Fixed: 1414152
Change-Id: I887de64a72777c92413ee921099dd762361f6c5c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4251897
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Traian Captan <tcaptan@chromium.org>
 2 years ago
Aravind Vasudevan 9ae55e5d77 Cleanup GSUTIL_ENABLE_LUCI_AUTH flag 
This change cleans up GSUTIL_ENABLE_LUCI_AUTH flag from gsutil. This is the final change to transition to luci-auth.

Fixed: 1359383
Change-Id: I1b4ac4bf95a887ebec92f71df343e855829846a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4197458
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2 years ago
recipe-roller e8ca7709cb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789153922331963633

recipe_engine:
086386d9ca
  086386d (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e2d67b2cb935 to d120042f61f6

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I2e8b1d99a2e40d6287cb76917d00970be744a244
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4249563
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller ce1ef9afdf Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789248290143892817

recipe_engine:
4b7bc24b24~..29c7df628b1b7ea7510b91ca80eebf66953727b5
  4b7bc24 (machenbach@chromium.org)
      [led] Retain fluency with inject_input_recipes
  73273ae (olivernewman@google.com)
      [test] Avoid creating empty expectation file dirs
  e12221e (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from fca00f1dc785 to 7fdf5527267e
  9529a65 (iannucci@chromium.org)
      [warnings] Fix error on py3 where str is not comparable to None.
  0caaa20 (iannucci@chromium.org)
      Fix typo in warn/escape.py
  29c7df6 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 7fdf5527267e to a4b0cf91f9d6

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic047e7b1b204e0c3a0ec2179dfd45ecb8c8d03b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4246317
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Robert Iannucci b2429ece99 [recipes] Mark repo as py3 only. 
This will allow autoroller to continue to roll into this repo.

Since there are no recipes (only modules) in this repo, this will have
no effect on any production builders.

R=ajp@google.com

Bug: 941669
Change-Id: I3e1847d6782ac4dfad4a5bdbb01388e8dd3ccebf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4241140
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 2 years ago
Ben Segall c4efd8a7aa Set path based reproxy flags in autoninja to sandbox developer builds 
This is being added as per go/chromium-reclient-dev-cfg-op#heading=h.kt0ffeuv1ll4

Bug: b/264405266
Change-Id: I69c6ae2343a206516cb3425300741ede46628ece
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4189202
Commit-Queue: Ben Segall <bentekkie@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
 2 years ago
Yiwei Zhang e636a25853 split the config validation request into smaller requests 
R=iannucci, yuanjunh

Bug: b/268065448
Change-Id: I6d700c39bdea8438815e3bf5a462038b05619a9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4240362
Reviewed-by: Gavin Mak <gavinmak@google.com>
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Auto-Submit: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
recipe-roller 10369890bb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789588660140111505

recipe_engine:
d82cf3c7fd
  d82cf3c (godofredoc@google.com)
      Use python3 instead of python in file module.

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5491d13acfe9fda047037813690bdf66cc3d16f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4237879
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller ea8c51d18b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789599357096474433

recipe_engine:
343085eec3
  343085e (mohrr@google.com)
      cq: Add NEW_PATCHSET_RUN constant

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I78be761d524afd490c2787279986ffba618f9130
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4237547
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 023ee12319 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789609422789286209

recipe_engine:
95a79f0a5d
  95a79f0 (ddoman@chromium.org)
      [recipes-py] remove no longer owners

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I5bd8de9ba7c98d244a00e6c92b24ad239e543fe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4237535
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Camilo Jacomet d8fb7c9667 [auth][oob-deprecation]: Update CIPD entries for LUCI Auth. 
Fixed issue where token to paste was refreshing fast and made it difficult to copy in terminal emulators such as Alacritty and Konsole.

Bug:1411481, 1406354
Change-Id: I260c18c4aca873530d7ead55ab8826b01edffd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4231602
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
 2 years ago
chrome-bot cd2395991f Add crossbench to the gclient config 
Bug:1410350
Change-Id: Iaf9fa01a92ed50c70224d480c3ee1b4acaf71aeb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4234360
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Ashwin Verleker <ashwinpv@google.com>
 2 years ago
recipe-roller 7bad7fdbe9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789705043284449409

recipe_engine:
4f7d370e33
  4f7d370 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 49c144dcbda8 to fc9d7a3dff50

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ic03af3d11c3212177830cbdcf50f8cc90cfcf5e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4232881
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Riley Wong 7d6a777cdb Updating lucicfg to version 1.38.0 -> 1.38.1 
This is a minor patch that will fix the error that arises from having no config file when running lucicfg valdate.

Bug:1412186
Change-Id: Ie7432354d382fa88b45d1668e6d6476d2530898c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4226560
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
Auto-Submit: Riley Wong <rgw@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
 2 years ago
recipe-roller 2ec2918216 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789757900418032529

recipe_engine:
985a9d1c5a
  985a9d1 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e2742d350e80 to a8b84fba102d

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I30e8763cf9aaf4d01ce0f4817891f15e343e56d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4229752
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 9d4c379aeb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789778033777796577

recipe_engine:
81745250cc
  8174525 (chanli@chromium.org)
      [recipe-py] led: support trigger real build

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib25a0131a02ed945a379e057981a9c19610c593f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4228362
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 7f8d4b9893 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789793762973974753

recipe_engine:
4387134d2f
  4387134 (bpastene@chromium.org)
      Switch internal recipes.py callsites to py3 in recipe autoroller

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iefec1f5f42045866981e7f9a0214bfbcda0083b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4227417
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Joanna Wang 6215dd0365 stacked-changes: Skip empty branches. 
Changes:
- _UploadAllPrecheck() returns a list of cls to upload that skips any empty commits in the stack.
- If the current branch is empty, we throw an error.
- UploadAllSquashed() now computes the parent to use for the squashed and cherry-pick flow.
  - for cherry-pick it uses the gerrit_squash_hash of the next cl in `cls`. This means it could be the gerrit_squash_hash of the direct ancestor OR the closest non-empty ancestor branch.
  - for multiple squashed commits, the first parent passed in is either:
     - the closest ancestor with a gerrit_squash_hash OR the common ancestor shared with the root of the tree.
- PrepareSquashedCommit() and PrepareCherryPick() now both require a parent passed in.

Bug:1411878, b/265929888
Change-Id: I7dba289defb40ed0464eabdb7e90810353ef155f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4220412
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
recipe-roller 2c90793139 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789867372352400609

recipe_engine:
5960b43515
  5960b43 (juahurta@google.com)
      recipe_engine: add option to skip step presention when using fi...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie5ffa1cfc2958e0870db02fc4dc5f82354a23b65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4226466
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 8e50f83d28 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8789884988438340625

recipe_engine:
6473859b07
  6473859 (zbikowski@google.com)
      Skip placeholder for get_file in url recipe module

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I09ab9e0e65e2e23c0ef70f951a7179725a1d8c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4225674
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Aravind Vasudevan ef2d011ad3 Do not add line break to the end of stdout/stderr 
gsutil.py adds a line break at the end of stdout/stderr when luci-auth is used. This change fixes it.

R=sokcevic, jojwang

Bug: 1412249, 1359383
Change-Id: Ieb200db94d9ed9149e17df93c33802a7433a8d5d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4221262
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2 years ago
Aravind Vasudevan 91ea91249f Remove OOB deprecation log from gsutil 
This change removes OOB deprecation log from gsutil. This is no longer necessary and it hinders with tools that use gsutil.py.

R=sokcevic, jojwang

Bug: 1412249, 1359383
Change-Id: If47239520a15d24658314bd44570babf99831e36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4221926
Auto-Submit: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Aravind Vasudevan a02b4bf030 Fix gerrit new-password URL 
This change fixes gerrit new-password URL from <host>-review.googlesource.com/new-password to <host>.googlesource.com/new-password.

Fixed: 1412557
Change-Id: I0c73e890fa9db5e2172d9a88cbc50703675e9f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4219808
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
 2 years ago
Junji Watanabe 963e01c76c Remove ninja entries from cipd_manifest.txt 
CIPD Ninja is installed by DEPS instead.

Bug: 1340825
Change-Id: I69106fe9b06154bac7db9278e905efb99e90974c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4220972
Reviewed-by: Philipp Wollermann <philwo@google.com>
Commit-Queue: Philipp Wollermann <philwo@google.com>
Auto-Submit: Junji Watanabe <jwata@google.com>
Commit-Queue: Junji Watanabe <jwata@google.com>
 2 years ago
Joanna Wang 79499cf439 Update env_vars metrics name. 
Bug: b/265929888
Change-Id: Iaf2fd1d509f4390d26c8f4f74f863bbe3551600c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4219773
Reviewed-by: Gavin Mak <gavinmak@google.com>
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
Loic Sharma e3fe027009 [Windows] Ignore extra spaces in ninja args 
The `ninja.py` script fails for this invocation:

```
ninja -C C:\Code\f\engine\src\out\host_debug_unopt\
 flutter_windows_unittests.exe
```

However, this works as expected:

```
ninja.exe -C C:\Code\f\engine\src\out\host_debug_unopt\
 flutter_windows_unittests.exe
```

Notice how there are extra spaces between the DIR and target. This bug breaks the Flutter engine's build integration with Visual Studio after `ninja.exe` was removed from depot_tools.

Here is an example MSBuild target that runs into this issue:

```xml
  <Target Name="Build">
    <Exec Command="call ninja -C $(OutDir)  flutter_windows_unittests.exe" />
  </Target>
```

Change-Id: Ib0022bc48151de438ac209fd07e0183872538ac6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215121
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Loïc Sharma <loicsharma@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
 2 years ago
Joanna Wang 5ed21de943 Change env_variables to repeated metric. 
Bug: b/265929888
Change-Id: I7787e053ca0785801817e4916d9b25fa2ff0e8d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4219772
Auto-Submit: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
 2 years ago
recipe-roller 3d293077f4 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790251781580695681

recipe_engine:
030e1286cc
  030e128 (yiwzhang@google.com)
      write summary markdown to expectation on build success and intr...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I26599e3816e488ddfb45b7d3f6bb9e372dfbcffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4218660
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Richard Wang 15d51f9304 Update Goma client 
Bug: b/266522285
Change-Id: I231af930254959f33da90540c8107d4c1b8a7b74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4216156
Commit-Queue: Richard Wang <richardwa@google.com>
Reviewed-by: Fumitoshi Ukai <ukai@google.com>
 2 years ago
recipe-roller e33d80c935 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790314695148063617

recipe_engine:
d57dd757d9
  d57dd75 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from f2c7e8383362 to 46eca1e3a280

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib812511316536d02ec1e34255dc7b1090d4ac9ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215083
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Camilo Jacomet 8361a9b75d [auth][oob-deprecation]: Update CIPD entries for LUCI Auth. 
Bug:1406354,1411203
Change-Id: I0fac4d16a28945005bfa00af0bcf0a2144a2809f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215079
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Camilo Jacomet <cjacomet@google.com>
 2 years ago
Riley Wong c40715e2d2 Revert "Updating Lucicfg to Version 1.38.0" 
This reverts commit 6e096da546.

Reason for revert: Failure in lucicfg validate causing presubmit to fail

Original change's description:
> Updating Lucicfg to Version 1.38.0
>
> Version updates lucicfg fmt/validate/lint to add conditional formatting rules based off path.
>
> Change-Id: I0870c142210f95e75356ef2cc9d94f4e265f8c80
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215131
> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
> Commit-Queue: Riley Wong <rgw@google.com>

Change-Id: I80031587b78f61a58f984d8695316328958bc147
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215612
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Auto-Submit: Riley Wong <rgw@google.com>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2 years ago
Leina Sun d41df98b29 [Pinpoint] Surface CLI priority flag to depot_tools 
Bug: chromium:1411458
Change-Id: Ife781433e2f1bf8d37990e6bc2e0108c980f9ea1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215115
Auto-Submit: Leina Sun <sunxiaodi@google.com>
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Vadim Shtayura <vadimsh@chromium.org>
 2 years ago
Riley Wong 6e096da546 Updating Lucicfg to Version 1.38.0 
Version updates lucicfg fmt/validate/lint to add conditional formatting rules based off path.

Change-Id: I0870c142210f95e75356ef2cc9d94f4e265f8c80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4215131
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Riley Wong <rgw@google.com>
 2 years ago
Joanna Wang 92d7df88aa Add way to track env variables. 
Bug:b/265929888
Change-Id: Ibf24e9aae7bff1d9af36c15fc7f9bdad9dbba526
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4209320
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Shelley Vohr 106754b269 Account for managed solution in src when finding ninja 
At present when looking for ninja, main only searches in two locations, gclient root and src. The Electron project lists Chromium’s src as a dependency in its DEPS file, so Ninja won’t be in the primary solution’s path (as it’s a transitive dependency, not a direct dependency of Chromium). This change adapts existing logic to account for that case.

Change-Id: I35aea29135d5968722a308bfb6dbb8a727550b42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4203207
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Joanna Wang <jojwang@chromium.org>
 2 years ago
recipe-roller 3d072ab6fb Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790412842174380129

recipe_engine:
8d334f01d4
  8d334f0 (dhanyaganesh@chromium.org)
      luci_analysis: Instead of hardcoded 'chromium' project, make it...

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Icdbebf1c455f8b1ff67e97b87d7c0b2b2de38e4d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4209167
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Joanna Wang c4ac30261d Revert auto-cc behavior back to original and fix comments. 
Bug: 1411521, b/265929888
Change-Id: I2d5908f4fb54ad11914d061539c4677e8320c163
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4205471
Reviewed-by: Gavin Mak <gavinmak@google.com>
Commit-Queue: Joanna Wang <jojwang@chromium.org>
 2 years ago
recipe-roller 94b0eb1bb5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790492114932751121

recipe_engine:
895ffd7769
  895ffd7 (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from e9c576da44c4 to c41d94e38272

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: I1d659d5d446b57341bbdb918d40b43ef103b9432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4204922
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
recipe-roller 77f3ca4b16 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls
recipe changes from upstream projects (recipe_engine) into this repository.

The build that created this CL was
https://ci.chromium.org/b/8790504697511252929

recipe_engine:
410efdc8d6
  410efdc (chromium-autoroll@skia-public.iam.gserviceaccount.com)
      Roll CAS Client from 66bc2247690a to dbdde7146475

Please check the following references for more information:
- autoroller, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#autoroller
- rollback, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/workflow.md#rollback
- cross-repo dependencies, https://chromium.googlesource.com/infra/luci/recipes-py/+/main/doc/cross_repo.md

Use https://goo.gl/noib3a to file a bug.

R=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Ignore-Freeze: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ia49f4e0deaa69476207053c5525b51279829c085
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4204918
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 2 years ago
Chan Li ed5ad736b6 [depot_tools] Roll lucicfg 
To release https://crrev.com/c/4163498

Bug: 1114804
Change-Id: Id93232e0197b9aa4682a649e7d64442db9af37f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4204928
Reviewed-by: Yuanjun Huang <yuanjunh@google.com>
Commit-Queue: Chan Li <chanli@chromium.org>
 2 years ago
Josip Sokcevic fe5a0b1289 Use default number of cores for gclient jobs 
Instead of always setting jobs to 1 for ARM (which includes Mac), use
number of cores. Some old boards have not worked well with parallel
sync, but I don't have historical context was going on. My assumption is
that those boards were single-core.

See: https://codereview.chromium.org/10116033

R=aravindvasudev@google.com

Bug: 1410757
Change-Id: I0b7e3363375ba719c73d4d7141e6cab34bf7d32f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4198732
Reviewed-by: Dirk Pranke <dpranke@google.com>
Reviewed-by: Aravind Vasudevan <aravindvasudev@google.com>
Commit-Queue: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Aravind Vasudevan effdecd9ab Reland "Enable luci-auth by default" 
This reland includes fix for crbug.com/1410703. It fallbacks to normal gsutil call when luci-auth is not logged in.

This is a reland of commit a7b20b34f8

Original change's description:
> Enable luci-auth by default
>
> This change enables luci-auth by default for gsutil.py, replacing OOB authentication flow.
>
> Bug: 1359383
> Change-Id: I1a93edc0d04e03c13921359205f252b9e1ed7594
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4193195
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>

Bug: 1359383
Change-Id: I9acfa8a578de8e106346b83aae509f9ffe1146e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4199427
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>
 2 years ago
Junji Watanabe 9d77ca716f [recipe] Remove depot_tools.{ninja_path, autoninja_path} recipe APIs 
I have replaced all the references, and there should be no references to these APIs anymore.

A PSA has been sent already.
http://g/chromium-dev-internal/n2IL0Mbh0E8

Bug: 1340825
Change-Id: Ife882f4427f8841cacb9a70a99dbd6a90c741da2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4194896
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Junji Watanabe 8f41177abf Remove legacy ninja binaries 
PSA has already been sent to internal/external devs.
Internal: http://g/chromium-dev-internal/n2IL0Mbh0E8
External: https://groups.google.com/a/chromium.org/g/chromium-dev/c/027jM6DLkIk

Bug: 1340825
Change-Id: I9f3b4b2cb20147fd48ba379b257c7280ba9c53f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4194897
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Gavin Mak <gavinmak@google.com>
 2 years ago
Aravind Vasudevan b7d8efd8be Revert "Enable luci-auth by default" 
This reverts commit a7b20b34f8.

Reason for revert: http://go/crb/1410670

Original change's description:
> Enable luci-auth by default
>
> This change enables luci-auth by default for gsutil.py, replacing OOB authentication flow.
>
> Bug: 1359383
> Change-Id: I1a93edc0d04e03c13921359205f252b9e1ed7594
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4193195
> Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
> Reviewed-by: Josip Sokcevic <sokcevic@chromium.org>

Bug: 1359383
Change-Id: I490cdc8a20e3ef0e87bd75eafd507698856b9374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4199424
Commit-Queue: Aravind Vasudevan <aravindvasudev@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2 years ago