Fumitoshi Ukai
a7571b1596
Reland "Reland "Use bundled python to run gn""
...
This reverts commit 6678906cf8
.
Reason for revert:
run gn.py instead of gn on PATH in presubmit check.
Bug: 414312048
Original change's description:
> Revert "Reland "Use bundled python to run gn""
>
> This reverts commit 49fcbee29e
.
>
> Reason for revert: This broke a presubmit check in devtools-frontend https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715987965894722097/overview
>
> Bug: 414312048
> Original change's description:
> > Reland "Use bundled python to run gn"
> >
> > This reverts commit a3cdfed6c4
.
> >
> > Reason for revert:
> > https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed
> >
> > Original change's description:
> > > Revert "Use bundled python to run gn"
> > >
> > > This reverts commit fa8fc854e1
.
> > >
> > > Reason for revert: Most likely culprit for consistent failure
> > > to generate orderfiles (see crbug.com/414312048).
> > >
> > > Bug: 414312048
> > >
> > > Original change's description:
> > > > Use bundled python to run gn
> > > >
> > > > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > > > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > >
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> > > Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> > > Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> >
> > Bug: 414312048
> > Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Reviewed-by: Junji Watanabe <jwata@google.com>
>
> Bug: 414312048
> Change-Id: Iadb3bd20af737c1e7404bf8e95c333f1dbd62942
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508888
> Commit-Queue: Garrett Beaty <gbeaty@google.com>
> Reviewed-by: Garrett Beaty <gbeaty@google.com>
> Owners-Override: Garrett Beaty <gbeaty@google.com>
> Auto-Submit: Liviu Rau <liviurau@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: 414312048
Change-Id: I86d611b234bd5b2e91b184c7610c18cfe79f9816
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6515221
Reviewed-by: Junji Watanabe <jwata@google.com>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Gavin Mak <gavinmak@google.com>
Reviewed-by: Gavin Mak <gavinmak@google.com>
2 months ago
Liviu Rau
6678906cf8
Revert "Reland "Use bundled python to run gn""
...
This reverts commit 49fcbee29e
.
Reason for revert: This broke a presubmit check in devtools-frontend https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8715987965894722097/overview
Bug: 414312048
Original change's description:
> Reland "Use bundled python to run gn"
>
> This reverts commit a3cdfed6c4
.
>
> Reason for revert:
> https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed
>
> Original change's description:
> > Revert "Use bundled python to run gn"
> >
> > This reverts commit fa8fc854e1
.
> >
> > Reason for revert: Most likley culprit for consistent failure
> > to generate orderfiles (see crbug.com/414312048).
> >
> > Bug: 414312048
> >
> > Original change's description:
> > > Use bundled python to run gn
> > >
> > > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > > Reviewed-by: Junji Watanabe <jwata@google.com>
> > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> >
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> > Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> > Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
>
> Bug: 414312048
> Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Junji Watanabe <jwata@google.com>
Bug: 414312048
Change-Id: Iadb3bd20af737c1e7404bf8e95c333f1dbd62942
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6508888
Commit-Queue: Garrett Beaty <gbeaty@google.com>
Reviewed-by: Garrett Beaty <gbeaty@google.com>
Owners-Override: Garrett Beaty <gbeaty@google.com>
Auto-Submit: Liviu Rau <liviurau@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
2 months ago
Fumitoshi Ukai
49fcbee29e
Reland "Use bundled python to run gn"
...
This reverts commit a3cdfed6c4
.
Reason for revert:
https://chromium-review.googlesource.com/c/chromium/src/+/6498495 landed
Original change's description:
> Revert "Use bundled python to run gn"
>
> This reverts commit fa8fc854e1
.
>
> Reason for revert: Most likley culprit for consistent failure
> to generate orderfiles (see crbug.com/414312048).
>
> Bug: 414312048
>
> Original change's description:
> > Use bundled python to run gn
> >
> > Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> > Reviewed-by: Junji Watanabe <jwata@google.com>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> > Commit-Queue: Fumitoshi Ukai <ukai@google.com>
>
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
> Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
> Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bug: 414312048
Change-Id: Id04cfe67ed994b91d794e51ba329f411de5d2d36
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6504176
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Junji Watanabe <jwata@google.com>
3 months ago
Friedrich Hauser
a3cdfed6c4
Revert "Use bundled python to run gn"
...
This reverts commit fa8fc854e1
.
Reason for revert: Most likley culprit for consistent failure
to generate orderfiles (see crbug.com/414312048).
Bug: 414312048
Original change's description:
> Use bundled python to run gn
>
> Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
> Reviewed-by: Junji Watanabe <jwata@google.com>
> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> Auto-Submit: Fumitoshi Ukai <ukai@google.com>
> Commit-Queue: Fumitoshi Ukai <ukai@google.com>
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Change-Id: Id5e5f7cec91927aae144026aa16b169689881fb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6494846
Owners-Override: Friedrich Hauser <friedrichh@chromium.org>
Auto-Submit: Friedrich Hauser <friedrichh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
3 months ago
Fumitoshi Ukai
fa8fc854e1
Use bundled python to run gn
...
Change-Id: If01a7dae1aca72c93c87c1db27d2d37432094852
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6490515
Reviewed-by: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Fumitoshi Ukai <ukai@google.com>
Commit-Queue: Fumitoshi Ukai <ukai@google.com>
3 months ago
Jamie Madill
67574d7a19
gn: Call gn.bat in msysgit on Windows.
...
Since 'python3' might not exist in Windows, this fixes the 'gn'
script for msysgit users.
Recipe-Manual-Change: infra
Bug: None
Change-Id: Ic5ed76963a7cf1819008470079256a6fd572fb0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3103446
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Auto-Submit: Jamie Madill <jmadill@chromium.org>
4 years ago
Mirko Bonadei
ea4e399c4d
Switch gn wrapper scripts to invoke python3.
...
Bug: 941669
Change-Id: I515459793f2a406a959c361f9884b183e21ebdf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2825439
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
4 years ago
brettw@chromium.org
a738935a12
Add executable and line ending properties for GN.
...
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/69693002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@234321 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago
brettw@chromium.org
67bb861400
Add a wrapper script for GN to depot_tools
...
This automatically searches the path for a source root (or takes one from the
command line), and then executes the current platform's GN binary inside that
source tree.
This will allow the user to have a "gn" command on their path, and allow our
scripts to run GN without having to bake-in the logic for finding the correct
platform's GN binary.
Review URL: https://codereview.chromium.org/66013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@233983 0039d316-1c4b-4281-b951-d872f2087c98
12 years ago