aiden
/
depot_tools
mirror of https://chromium.googlesource.com/chromium/tools/depot_tools
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
6,184 Commits
6 Branches
0 Tags
182 MiB
main
chrome/4147
chrome/3987
chrome/3865
chrome/3904
infra/config
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'chrome/3865'
${ noResults }
Commit Graph

6184 Commits (chrome/3865)
 

Author SHA1 Message Date
Michael Moss 57ed3aedae Run git_cl commands as a python step. 
Otherwise this fails on Windows because git_cl.py "is not a valid Win32
application".

R=​gbeaty@google.com, iannucci@google.com

Bug: 726111
Change-Id: I4b9fea6b5271241e14407aeab175ce73d1ee8349

Change-Id: I4b9fea6b5271241e14407aeab175ce73d1ee8349
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1835598
Commit-Queue: Michael Moss <mmoss@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
(cherry picked from commit 6b4c2a88f3)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1846782
Reviewed-by: Michael Moss <mmoss@chromium.org>
 5 years ago
recipe-roller e3614ad6f5 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/11077013dc5ac1cf8fa7971965046b0e67c0dd5f [swarming] Make TaskResult.output_dir a Path (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I22223285a1ca55b61bac72a811170b23981eced4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1719956
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Edward Lesmes 365720e237 Revert "depot_tools: Move six to depot_tools' .vpython" 
This reverts commit 3a98df0bdd.

Reason for revert:
Can't roll into skia and build_internal

Original change's description:
> depot_tools: Move six to depot_tools' .vpython
> 
> Bug: 984182
> Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
> Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
> Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Reviewed-by: Michael Moss <mmoss@chromium.org>

TBR=iannucci@chromium.org,mmoss@chromium.org,tandrii@chromium.org,ehmaldonado@chromium.org

Change-Id: I51e502e6f7633a6f26898f1ecbcd86ccf9c7c123
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 984182
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1718996
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lemur 3a98df0bdd depot_tools: Move six to depot_tools' .vpython 
Bug: 984182
Change-Id: I34a242c8607624beb0f06a27c563e413dec99790
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717492
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
 6 years ago
Quinten Yearsley d242ed7a0e [git-cl] Proofread docstrings for consistency 
Change-Id: I5195762d493e3c00d1656004fb2e800524ee9637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1710950
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Auto-Submit: Quinten Yearsley <qyearsley@chromium.org>
 6 years ago
Edward Lemur 34cc05018d depot_tools: Update pymox to a Python 3 compatible version. 
Bug: 984182
Change-Id: Ib28cec16883bb5269453c27c74d8124fbfba8920
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1717248
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Quinten Yearsley c420221f1d [git-cl] Proofread error messages for consistency 
Change-Id: I6a4bbd300e8343671c9d595844de2c6ab24a00d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1710941
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lemur 4a8e453fbd bot_update: Disable metrics collection for bots, since it's not supported. 
Change-Id: Iee0b783d725f15fbe3ab3d41ce2303a2ab1807af
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1713218
Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lemur 73065b2067 depot_tools: Make some changes to make metrics collection compatible with Python 3. 
Bug: 984182
Change-Id: I55e9e83d01d5a86464cc234c083e4212f0ba4a1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1713217
Auto-Submit: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Robert Iannucci 004da782dd Remove WATCHLISTS. 
I was the only one left :)

TBR=ehmaldonado@chromium.org

Change-Id: I66893b6de9231e09ef3a10cf0b02c8836d1ad012
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1713221
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
Edward Lemur ee7b9dda90 gclient: Make some changes to make gclient compatible with Python 3. 
Bug: 984182
Change-Id: Ia85f9bdb88b343776540556921890bc3ea73f2ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1710957
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Quinten Yearsley 0a0fbf143a [git-cl] Remove apparently effect-less import 
Change-Id: Ief9948f5331945359696de8e158af021a6ade7ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1709804
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
 6 years ago
recipe-roller 5e67857cb3 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/bf2840613e4e2be9581a36c7f4e4a0cf14695578 Remove final jsonResult reference (martiniss@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id64a7623e57aecf2beb34ae00ba9d41d273c28ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1710953
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Edward Lemur f4e0cc69ee depot_tools: Remove rietvelt code. 
Bug: 984182
Change-Id: I0ad2f612f681644b78353195e451e43da936ac9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1709640
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
recipe-roller 6ab53d93e9 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/da55db0ed58e23a8a3ee76fd3f1d4aa95a9db0c8 [commands/test] Use "." instead of checkmark for success, even with emoji. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Iee2884132938cfb759d59d27d7da03821364d095
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1708153
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Edward Lemur 9217ff8b2c depot_tools: Make metrics Python 3 compatible. 
Bug: 984182
Change-Id: I2b7e4be6131558019d461e09d062b52085f330ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1702855
Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Edward Lemur 966ad1914b depot_tools: Restore third_party/upload.py 
This is a partial revert of
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1702495

It is used by my_activity.py (via rietveld)

Bug: 984745, 984182
Change-Id: Ic9a3e59a2ffb4b500666f9ad2ee076c8bb81a3d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1703390
Reviewed-by: Andy Perelson <ajp@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
recipe-roller 282a1f2f77 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/44c14e31274e6d1c84cad9bc0df608fbdf03e575 Clean up the read hack, which is now immortalized forever. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id7a259823a505aff80827472dbd22dc778570371
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1704657
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Debrian Figueroa 0fb33b26eb Updated presubmit error message format. 
Changed all headers in message to be the size of header 4 tags.

Made sure there is always a new line after code tag(```).

Change-Id: I772941a8bbf0634c9496ec648533110997e23cde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1702293
Commit-Queue: Debrian Figueroa <debrian@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
Raul Tambre 65c2b1e1d1 fix_encoding: Do unicode type checks only on Python 2 
The unicode type doesn't exist in Python 3, because everything's Unicode.

This would resulted in the following error on Python 3:
<Unicode console <stderr>>.write: NameError("name 'unicode' is not defined")

Bug: 942522
Change-Id: I3e90d078df64abcec2c79aa69881deea40ff7d01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701401
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Auto-Submit: Raul Tambre <raul@tambre.ee>
 6 years ago
Raul Tambre 43271f94de fetch: Decode gclient output if returning stdout 
In Python 3 the output of a subprocess is bytes, so they need to be decoded to be used as a string.

This previously caused the following error if there was an existing checkout during a fetch:
Traceback (most recent call last):
  File "C:\Google\depot_tools\\fetch.py", line 318, in <module>
    sys.exit(main())
  File "C:\Google\depot_tools\\fetch.py", line 313, in main
    return run(options, spec, root)
  File "C:\Google\depot_tools\\fetch.py", line 299, in run
    if not options.force and checkout.exists():
  File "C:\Google\depot_tools\\fetch.py", line 98, in exists
    return (os.path.exists(os.path.join(gclient_root, b'.gclient')) or
  File "C:\Program Files\Python38\lib\ntpath.py", line 109, in join
    genericpath._check_arg_types('join', path, *paths)
  File "C:\Program Files\Python38\lib\genericpath.py", line 151, in _check_arg_types
    raise TypeError("Can't mix strings and bytes in path components") from None
TypeError: Can't mix strings and bytes in path components

Bug: 939847
Change-Id: Ibf5b4923268595ba439586d688894f92696ecbb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701403
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Raul Tambre <raul@tambre.ee>
 6 years ago
Raul Tambre 70eba7d2d1 setup_color: Don't fill created string buffer with nulls 
This causes an error since Python 3.5 due to a regression (https://bugs.python.org/issue32745):
Traceback (most recent call last):
  File "C:\Google\depot_tools\metrics.py", line 267, in print_notice_and_exit
    yield
  File "C:\Google\depot_tools\gclient.py", line 3153, in <module>
    sys.exit(main(sys.argv[1:]))
  File "C:\Google\depot_tools\gclient.py", line 3136, in main
    setup_color.init()
  File "C:\Google\depot_tools\setup_color.py", line 70, in init
    buf = ctypes.create_string_buffer('\0', 1024)
  File "C:\Program Files\Python38\lib\ctypes\__init__.py", line 63, in create_string_buffer
    raise TypeError(init)
TypeError: <Unicode console <stderr>>.write: ArgumentError("argument 2: <class 'ValueError'>: embedded null character")

Simply not filling the buffer with NULLs doesn't change the behaviour.

Bug: 942522
Change-Id: I1feb81555e995597b0b70f4aee9151fea755510c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701402
Auto-Submit: Raul Tambre <raul@tambre.ee>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
Andrii Shyshkalov 71f0da3e93 git-cl: add --preserve-tryjobs option for upload command. 
CQ will soon start canceling tryjobs it triggered on no-longer-latest
patchsets if these tryjobs won't be re-used. New option can be used by
developers who upload new patchsets but actually care for prior
CQ-triggered tryjobs to complete.

This footer is effectively sticky, unless someone removes it by hand later.
We need to have the footer one way or another to tell the CQ what to do
(and provide a visible audit trail).

We may revisit the stickiness later based on accumulated usage data s.t.
the following uploads remove the footer unless the flag is passed.

Bug: 909895
Test: git cl upload --preserve-tryjobs
Change-Id: Ibbc6e917504c31eab8ab85296b3ecafd3add46df
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701506
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Andrii Shyshkalov 0e889b7298 git-cl: rebrand "Commit-Queue" as "CQ". 
Change-Id: If61260b1f4951d3c881fff46a0bde2dac47d593b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1701503
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org>
 6 years ago
Edward Lemur 2c92208d3d depot_tools: Remove unused third_party libraries. 
Remove:
- third_party/boto
- third_party/fancy_urllib
- third_party/protobuf26
- third_party/simplejson
- third_party/upload.py

Change-Id: I08488325f15ca04876fcff611eb766979299806b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1702495
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
Debrian Figueroa d3af69947e Add failure status on timeouts 
Change-Id: I6f7b0791172f9f4e7af278f8acb3f1ca986789d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1700390
Commit-Queue: Debrian Figueroa <debrian@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
Erik Staab 10e07dd38b [depot_tools] Add new tryjob failure types TEST_TIMEOUT and TEST_EXPIRED. 
Bug: 850653
Change-Id: I3bbf0c423076fd42d5fb8f5cae193ffa8b1d63a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1699030
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
 6 years ago
recipe-roller a8ecea5293 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9f38694b68d88bf0bbc102aa614f42f21f13b71c Add named cache support to the swarming recipe module. (jbudorick@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ib931ef657b6d5eead355f0ff0ee79eee14903298
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1700151
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Debrian Figueroa 587f1feeee Fix Presubmit Infra Failure tests 
Change-Id: Ie807735f22e76ce0e2ee18c2ed8b149c342fa7ee
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1700149
Commit-Queue: Debrian Figueroa <debrian@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
recipe-roller cb59c3177b Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b9ad522afc7ff805c27a781d405b33e35f542dab [swarming] Fix task stdout/stderr link (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I986c987f52c7c71d9e1c512db6279fce0d5a8cdc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1699050
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Eli Ribble 78dec0421b Show nice error on failure to enumerage input files. 
Without this we get an ugly stack trace. This is way more
friendly.

Bug: 983006

Change-Id: I5ba871ad71ad43bb48d91697e96473afbfe399a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1697221
Auto-Submit: Eli Ribble <eliribble@chromium.org>
Commit-Queue: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
recipe-roller 08a3d8e2a0 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/c311cdcc9e6de9c2decaa69ce54f9a5fbe00fa16 [isolated] Roll client (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I3d7bdf3727a0e0632856ed5edac8f62e643f9808
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1696705
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 3a0c3c21e8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/ce9672b4fa31f12efc35008478675193aa98a433 [swarming] Update presentation (joshuaseaton@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I4b45a1d223446b34b180b53450cedb6aad85e103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1696464
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Vadim Shtayura 3768f8421f [lucicfg] Update to the latest version. 
Picks up various CrOS protos, no changes to lucicfg itself.

R=tandrii@chromium.org, maruel@chromium.org

Change-Id: If9edc69f628909ca46a8c38a80f824aca4911fc8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1696235
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>
 6 years ago
recipe-roller d3f699407f Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/b077e6d7b5e202070b28b0e7e1be95396c423eec [fetch] Actually fetch from the provided ref. (iannucci@chromium.org)
  https://crrev.com/4cf2107dcc2dd67bb3e84154700ee5023eea02b3 [fetch] Fix docstring typos/inaccuracy. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Ie6195aad787bc1f04891b53b22f98d7f26a4c5e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1695864
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Debrian Figueroa 986505f489 Updated error message format 
Added headers and code tags

Made sure that when limiting message size, at least part of the message
is seen.

Change-Id: I404e2f7e86907f701332a62fe46334ff437cca03
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1690741
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Debrian Figueroa <debrian@google.com>
 6 years ago
Jesse McKenna 3b07526aec Update autoninja's psutil from v5.2.2 to v5.6.2 
This incorporates a fix to psutil's calculation of
the number of processors on Windows systems with
more than 64 cores.

Windows systems with more than 64 logical
processors divide the processors into groups, with
most applications using only one group, i.e. a
portion of the actual processing power available.
Prior to v5.4.4, psutil only counted the number of
processors in the first processor group. This
resulted in only partial utilization of high-
processing-power systems.

For example, on the 72-core P920, this change has
the following effect:

Before:
> autoninja -C out\nogoma chrome
"c:\src\depot_tools\ninja.exe" -C out\nogoma base -j 38

After:
> autoninja -C out\nogoma chrome
"c:\src\depot_tools\ninja.exe" -C out\nogoma base -j 74

Using this new version of psutil doubles the
number of processors used for building Chrome on
the P920 (when not using goma).

A similar bug exists in ninja.exe, so using
autoninja will be particularly important after
this fix for users of the P920 and other systems
with >64 cores. More fixes will be needed
elsewhere for similar bugs - see crbug.com/980967
for general progress.

Bug: 980270
Change-Id: I8de61a72cf95acf28ef1bcef1b0057b7b1225832
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1686081
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
 6 years ago
recipe-roller 55dad64f46 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/acbc4da8bc664d35bab3ba890bab1c01646d1aba [recipe_engine] Speculatively add retries on EINVAL to os.read on OS X. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I0b8c475716b18267c461c50fcd1ac3c337ab42a0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1690738
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 92afaf53fd Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9dac536b55887262b4ce846f3db7a7f596542e5e [platform] Return intel or arm for platform.arch based on actual platform.machine(). (ihuh@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8446450e2dcaf04992d7537054905f6dd46349c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1688650
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 2aa3ab5390 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/e2f09162f4902d4ce8cc02cbb54e1deec1511e7d [buildbucket] Add exe_cipd_version param (nodir@google.com)
  https://crrev.com/f4bcf2e22201416987c332e970156f4730de3cf1 [swarming] Expose swarming task result output_dir (olivernewman@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I39d642319d9d3bc2c61b7ca586912b53299edc60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1688589
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller ff4f6bccd8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/6e5f0481e76309308a2cd155504b619915a1b529 [recipe_engine] Add more debug info to os.read shim on OS X. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I9ff824c1ff9fad58f92d10f66cd23da67298e1e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1688122
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller ffd96e6df0 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2e24f9a6923e685d7068cdef1e6c54c9cf24babf [recipe_engine] Add debug os.read method on darwin. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8ee89ba89937c2c22ac24c847536b6561e4c1d1d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1686499
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
John Budorick f21ffb4f98 Copy presubmit logic up into the presubmit recipe module. 
Bug: 925774
Change-Id: I27e8670578095db71384d77cdb3d606bfdcf1077
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1684760
Commit-Queue: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
 6 years ago
Mohamed Heikal dc37feb99d Make it clear in the help message that my_activity.py dates are mm/dd/yy 
my_activity.py prints out a help message when required, which has some
example ways to use my_activity.py. However the dates used are ambiguous
in terms of the date format used/required. This CL changes the example
to make it clearer that it is mm/dd/yy.

Change-Id: Id054739201e5c83528902b1f38d1c27c7bbc788b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1682498
Auto-Submit: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
 6 years ago
Debrian Figueroa 6095d40061 Make sure PresubmitResult can be converted to a json. 
R=martiniss@google.com

Change-Id: Ida198bd834e39cc76d483a88a894f8e39d346976
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1681082
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Debrian Figueroa <debrian@google.com>
 6 years ago
recipe-roller 788d9e0de8 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/9fc4304dd3a91f553108a76aa90c70c27891601a [lint] Add textwrap to module whitelist. (iannucci@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: If2591c2e718a2a7f950de1cba8580617eafe640c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1679549
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 1ff9ce92d1 Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/030aa06ad86265996ac798450272c98c48d9dbbf Safely check _finalized in _AttributeRaiser.__setattr__. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: Id87580d4be6a570c04f2b899039304e60795205e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1678851
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
Yang Guo 6e269a0bab Extend git-cl-owners to show all owners for a file 
Change-Id: Ie1109c3da9c687a9543c0cfb91f8660c29fb36c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1664391
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
 6 years ago
recipe-roller d9ae33420a Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/2ac91e7351b226f7d5ec133d8f7a6820ce40f5c1 [isolated] Implement -blacklist support (athom@google.com)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I8253f3c35ad9dd7d5a242c35674b676ca1086319
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1678060
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago
recipe-roller 667fa910da Roll recipe dependencies (trivial). 
This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).


More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug.
recipe_engine:
  https://crrev.com/42f7ab36378d1351a4192d61227fa83048558f19 Safely check _finalized in StepData.__setattr__. (gbeaty@chromium.org)


TBR=iannucci@chromium.org

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Change-Id: I585bd2da3163d04a6fde4c3b2c48f6facde05a7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1677602
Reviewed-by: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Recipe Roller <recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com>
 6 years ago